eolivelli opened a new pull request #66:
URL: https://github.com/apache/openjpa/pull/66
This is a draft PR.
I am trying to run all of the integration tests against HerdDB.
HerdDBDictionary enables aggressive use of delimiters, in order to not have
problems with the the long list of re
rmannibucau commented on pull request #65:
URL: https://github.com/apache/openjpa/pull/65#issuecomment-658559477
@struberg agree on A, B is true but likely slower than this exclusion list
(even if not sexy it is faster than a hashset in most cases and consumes way
less constant mem ;)), C
rmannibucau commented on a change in pull request #65:
URL: https://github.com/apache/openjpa/pull/65#discussion_r454804045
##
File path:
openjpa-kernel/src/main/java/org/apache/openjpa/enhance/PCClassFileTransformer.java
##
@@ -118,17 +120,44 @@ public PCClassFileTransformer(
struberg commented on pull request #65:
URL: https://github.com/apache/openjpa/pull/65#issuecomment-658421421
I still wonder if this whole `_transforming` boolean is a bit gone wrong?
A.) it is set in a different method than cleared! For no apparent reason.
This is not per se wrong,
dazey3 commented on a change in pull request #65:
URL: https://github.com/apache/openjpa/pull/65#discussion_r454610970
##
File path:
openjpa-kernel/src/main/java/org/apache/openjpa/enhance/PCClassFileTransformer.java
##
@@ -118,17 +120,44 @@ public PCClassFileTransformer(MetaD
dazey3 commented on a change in pull request #65:
URL: https://github.com/apache/openjpa/pull/65#discussion_r454610970
##
File path:
openjpa-kernel/src/main/java/org/apache/openjpa/enhance/PCClassFileTransformer.java
##
@@ -118,17 +120,44 @@ public PCClassFileTransformer(MetaD
dazey3 commented on a change in pull request #65:
URL: https://github.com/apache/openjpa/pull/65#discussion_r454610970
##
File path:
openjpa-kernel/src/main/java/org/apache/openjpa/enhance/PCClassFileTransformer.java
##
@@ -118,17 +120,44 @@ public PCClassFileTransformer(MetaD
dazey3 commented on a change in pull request #65:
URL: https://github.com/apache/openjpa/pull/65#discussion_r454610970
##
File path:
openjpa-kernel/src/main/java/org/apache/openjpa/enhance/PCClassFileTransformer.java
##
@@ -118,17 +120,44 @@ public PCClassFileTransformer(MetaD
struberg commented on a change in pull request #65:
URL: https://github.com/apache/openjpa/pull/65#discussion_r454594620
##
File path:
openjpa-kernel/src/main/java/org/apache/openjpa/enhance/PCClassFileTransformer.java
##
@@ -118,17 +120,44 @@ public PCClassFileTransformer(Met
rmannibucau edited a comment on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-658359342
@jgrassel not with 3.1.2 (:() but with a patched 3.1.3-SNAPSHOT (still
trying to find a good solution we both agree on before merging/pushing). Just
meant I can reproduc
rmannibucau commented on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-658359342
@jgrassel not with 3.1.2 (:() but with a patched 3.1.3-SNAPSHOT (still
trying to find a good solution we both agree on before merging/pushing)
jgrassel edited a comment on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-658357931
Ok, glad to hear that it worked with 3.1.2 (the patch that is)!
This is an automated message from the Apache
jgrassel commented on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-658357931
Ok, glad to hear that it worked with 3.1.2!
This is an automated message from the Apache Git Service.
To respond to
rmannibucau commented on pull request #65:
URL: https://github.com/apache/openjpa/pull/65#issuecomment-658353355
@jgrassel yes it violates but it is important to have it when startup time
is needed otherwise you basically potentially load all your app twice for
nothing (or load it all in m
jgrassel commented on pull request #65:
URL: https://github.com/apache/openjpa/pull/65#issuecomment-658350601
@rmannibucau That optimization sounds like a violation of the
PersistenceUnitInfo contract:
```
/**
* Return a new instance of a ClassLoader that the provider may
* use
rmannibucau commented on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-658349573
@jgrassel thanks a lot, I was able to test it on 3.1.2 too and also checked
the proposed patch in my PR fixes that issue.
--
jgrassel commented on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-658340904
I was able to reproduce the enhancement failure issue with OpenJPA 3.1.0
this way on Open Liberty.
This is an auto
jgrassel commented on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-658339925
Here's a version of the test bucket that will run with the jpa-2.2 complaint
version of OpenJPA
You'll need to edit the pom.xml file at the project root, and put in the
ful
rmannibucau commented on pull request #65:
URL: https://github.com/apache/openjpa/pull/65#issuecomment-658338171
@jgrassel The threadlocal - as the boolean today - just skips the
transformer, so it means that if a class must be enhanced and is loaded while
another is enhanced then it is sk
jgrassel commented on pull request #65:
URL: https://github.com/apache/openjpa/pull/65#issuecomment-658326420
Yeah, I noticed that commons was excluded after taking a second look through
the change set, my comment update wasn't fast enough. =). I'm not sure I'm
clear on why the ThreadLocal
rmannibucau commented on pull request #65:
URL: https://github.com/apache/openjpa/pull/65#issuecomment-658324978
@jgrassel commons is excluded and the jdk as well, just to skip reading the
bytecode (which is more costly than this exclusion list if you benchmark both
options so overall the
rmannibucau edited a comment on pull request #65:
URL: https://github.com/apache/openjpa/pull/65#issuecomment-658324978
@jgrassel commons is excluded and the jdk as well, just to skip reading the
bytecode (which is more costly than this exclusion list if you benchmark both
options so overa
jgrassel edited a comment on pull request #65:
URL: https://github.com/apache/openjpa/pull/65#issuecomment-658319959
I've already stated I'm not a fan of the exclusion list, for something
that's going to be called once for every class that has to be checked to be
enhanced, let alone be enh
jgrassel edited a comment on pull request #65:
URL: https://github.com/apache/openjpa/pull/65#issuecomment-658319959
I've already stated I'm not a fan of the exclusion list, for something
that's going to be called once for every class that has to be checked to be
enhanced, let alone be enh
jgrassel commented on pull request #65:
URL: https://github.com/apache/openjpa/pull/65#issuecomment-658319959
I've already stated I'm not a fan of the exclusion list, for something
that's going to be called once for every class that has to be checked to be
enhanced, let alone be enhanced,
rmannibucau commented on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-658318212
Created https://github.com/apache/openjpa/pull/65 as a proposed fix on
master if you want to give it a try.
rmannibucau opened a new pull request #65:
URL: https://github.com/apache/openjpa/pull/65
Follow up PR of https://github.com/apache/openjpa/pull/64
Goal is to let people test this proposed fix to ensure we didn't miss
anything in the analyzis.
--
[
https://issues.apache.org/jira/browse/OPENJPA-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17157536#comment-17157536
]
ASF subversion and git services commented on OPENJPA-2817:
--
Co
rmannibucau edited a comment on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-658034247
@struberg point is that the classloader does it and the transformer is
called under that lock already
@jgrassel will test your sample but today I'm off but I will come
rmannibucau edited a comment on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-658034247
@struberg point is that the classloader does it and the transformer is
called under that lock already
@jgrassel will test your sample but today I'm off but I will come
rmannibucau commented on pull request #64:
URL: https://github.com/apache/openjpa/pull/64#issuecomment-658034247
@struberg point is that the classloader does it and the transformer is
called under that lock already
@jgrassel will test your sample but today I'm off but I will come back to
31 matches
Mail list logo
