mawiesne commented on code in PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#discussion_r1091554145
##
.gitattributes:
##
@@ -0,0 +1,48 @@
+# Handle line endings automatically for files detected as text
+# and leave all files detected as binary untouched.
+* text
mawiesne merged PR #80:
URL: https://github.com/apache/opennlp-sandbox/pull/80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@opennlp.a
mawiesne commented on code in PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#discussion_r1091495783
##
.github/workflows/maven.yml:
##
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See t
jzonthemtn opened a new pull request, #494:
URL: https://github.com/apache/opennlp/pull/494
See https://issues.apache.org/jira/browse/OPENNLP-1459. The need for this
was due to the fix in https://issues.apache.org/jira/browse/OPENNLP-1332.
--
This is an automated message from the Apache G
rzo1 commented on code in PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#discussion_r1091031684
##
.github/workflows/maven.yml:
##
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the N
rzo1 commented on code in PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#discussion_r1091031684
##
.github/workflows/maven.yml:
##
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the N
rzo1 commented on code in PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#discussion_r1091027976
##
.gitattributes:
##
@@ -0,0 +1,48 @@
+# Handle line endings automatically for files detected as text
+# and leave all files detected as binary untouched.
+* text=aut
rzo1 opened a new pull request, #80:
URL: https://github.com/apache/opennlp-sandbox/pull/80
as the title says.
Normalize line endings according to `.gitattributes`.
Merge target: **introduce-parent-pom-for-opennlp-sandbox**
--
This is an automated message from the Apache Gi
Richard, yes, it is possible that the values in the tests should be
updated, and in this case that looks likely.
The affecting change is this:
https://github.com/apache/opennlp/pull/442/files
Both tests pass when that change is reverted. It looks to me the merged
change is correct, and I think up
mawiesne commented on PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#issuecomment-1408992799
> Added a few comments, but feel free to ignore them and address/discuss
later if you prefer. Great work! 👏
Thx @kinow. I addressed most of them. Hints on the file naming issue
mawiesne commented on code in PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#discussion_r1090901403
##
pom.xml:
##
@@ -0,0 +1,473 @@
+
+
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://m
mawiesne commented on code in PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#discussion_r1090894768
##
.github/PULL_REQUEST_TEMPLATE.md:
##
@@ -0,0 +1,27 @@
+Thank you for contributing to Apache OpenNLP.
+
+In order to streamline the review of the contribution we
mawiesne commented on code in PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#discussion_r1090893174
##
.github/PULL_REQUEST_TEMPLATE.md:
##
@@ -0,0 +1,27 @@
+Thank you for contributing to Apache OpenNLP.
+
+In order to streamline the review of the contribution we
mawiesne commented on code in PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#discussion_r1090890375
##
.gitattributes:
##
@@ -0,0 +1,48 @@
+# Handle line endings automatically for files detected as text
+# and leave all files detected as binary untouched.
+* text
mawiesne commented on code in PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#discussion_r1090889186
##
pom.xml:
##
@@ -0,0 +1,473 @@
+
+
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://m
mawiesne commented on code in PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#discussion_r109068
##
mahout-addon/pom.xml:
##
@@ -21,15 +21,12 @@
http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation=
mawiesne commented on code in PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#discussion_r1090887604
##
.github/PULL_REQUEST_TEMPLATE.md:
##
@@ -0,0 +1,27 @@
+Thank you for contributing to Apache OpenNLP.
+
+In order to streamline the review of the contribution we
mawiesne commented on code in PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#discussion_r1090886169
##
.github/CONTRIBUTING.md:
##
@@ -0,0 +1,11 @@
+# How to contribute to Apache OpenNLP
+
+Thank you for your intention to contribute to the Apache OpenNLP project.
kinow commented on code in PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#discussion_r1090875982
##
.github/PULL_REQUEST_TEMPLATE.md:
##
@@ -0,0 +1,27 @@
+Thank you for contributing to Apache OpenNLP.
+
+In order to streamline the review of the contribution we as
mawiesne commented on PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#issuecomment-1408967188
> Windows is broken due to weird file names but I am +1 for the PR (shows
the problems)
Hints on how to rename and fix it: welcome.
--
This is an automated message from the
Hi Jeff,
Regarding ArvoresDeitadasEval.evalPortugueseChunkerQn(...): Higher
cross validation accuracy is a good thing, no? ;-) But it would be
interesting to know, why it is (a bit) better than before.
Regarding SourceForgeModelEval.evalChunkerModel(...):
Maybe just do a git bisect session? We h
Good catch, Bruno. I wrote the NOTICE file date up as
https://issues.apache.org/jira/browse/OPENNLP-1458.
I also noticed that the jira-report Maven plugin is throwing an NPE during
the release build. This might explain why our list of Jira issues was empty
in the release notes last time. The stack
22 matches
Mail list logo
