On Tue, Sep 02, 2014 at 07:20:30PM -0700, Pravin Shelar wrote:
> On Tue, Sep 2, 2014 at 6:55 PM, Jesse Gross wrote:
> > On Mon, Sep 1, 2014 at 1:10 AM, Simon Horman
> > wrote:
> >> On Thu, Aug 28, 2014 at 10:12:49AM +0900, Simon Horman wrote:
> >>> On Wed, Aug 27, 2014 at 03:03:53PM -0500, Jesse
On Sat, Aug 23, 2014 at 10:09:13AM -0700, John Fastabend wrote:
>On 08/23/2014 07:51 AM, Thomas Graf wrote:
>>On 08/23/14 at 11:24am, Jiri Pirko wrote:
>>>Sat, Aug 23, 2014 at 12:53:34AM CEST, sfel...@cumulusnetworks.com wrote:
On Aug 22, 2014, at 12:39 PM, John Fastabend
wrote:
[sn
Hi Jiri,
sorry for coming a little late to the party.
I'm very happy to see work in this area.
On Thu, Aug 21, 2014 at 06:19:03PM +0200, Jiri Pirko wrote:
> Benefit from the possibility to work with flows in switch devices and
> use the swdev api to offload flow datapath.
>
> Signed-off-by: Jiri
Thu, Sep 04, 2014 at 11:03:46AM CEST, simon.hor...@netronome.com wrote:
>On Sat, Aug 23, 2014 at 10:09:13AM -0700, John Fastabend wrote:
>>On 08/23/2014 07:51 AM, Thomas Graf wrote:
>>>On 08/23/14 at 11:24am, Jiri Pirko wrote:
Sat, Aug 23, 2014 at 12:53:34AM CEST, sfel...@cumulusnetworks.com wr
On Thu, Sep 04, 2014 at 11:09:26AM +0200, Jiri Pirko wrote:
> Thu, Sep 04, 2014 at 11:03:46AM CEST, simon.hor...@netronome.com wrote:
> >On Sat, Aug 23, 2014 at 10:09:13AM -0700, John Fastabend wrote:
> >>On 08/23/2014 07:51 AM, Thomas Graf wrote:
> >>>On 08/23/14 at 11:24am, Jiri Pirko wrote:
> >>
Thu, Sep 04, 2014 at 11:04:49AM CEST, simon.hor...@netronome.com wrote:
>Hi Jiri,
>
>sorry for coming a little late to the party.
>I'm very happy to see work in this area.
>
>On Thu, Aug 21, 2014 at 06:19:03PM +0200, Jiri Pirko wrote:
>> Benefit from the possibility to work with flows in switch dev
Thu, Sep 04, 2014 at 11:23:35AM CEST, simon.hor...@netronome.com wrote:
>On Thu, Sep 04, 2014 at 11:09:26AM +0200, Jiri Pirko wrote:
>> Thu, Sep 04, 2014 at 11:03:46AM CEST, simon.hor...@netronome.com wrote:
>> >On Sat, Aug 23, 2014 at 10:09:13AM -0700, John Fastabend wrote:
>> >>On 08/23/2014 07:5
On Thu, Sep 04, 2014 at 11:24:58AM +0200, Jiri Pirko wrote:
> Thu, Sep 04, 2014 at 11:04:49AM CEST, simon.hor...@netronome.com wrote:
> >Hi Jiri,
> >
> >sorry for coming a little late to the party.
> >I'm very happy to see work in this area.
> >
> >On Thu, Aug 21, 2014 at 06:19:03PM +0200, Jiri Pir
Wed, Sep 03, 2014 at 05:20:25PM CEST, john.fastab...@gmail.com wrote:
>On 09/03/2014 02:24 AM, Jiri Pirko wrote:
>>After this, flow related structures can be used in other code.
>>
>>Signed-off-by: Jiri Pirko
>>---
>
>Hi Jiri,
>
>As I indicated before I'm looking into integrating this with some
>h
Wed, Sep 03, 2014 at 08:42:18PM CEST, pshe...@nicira.com wrote:
>On Wed, Sep 3, 2014 at 8:20 AM, John Fastabend
>wrote:
>> On 09/03/2014 02:24 AM, Jiri Pirko wrote:
>>>
>>> After this, flow related structures can be used in other code.
>>>
>>> Signed-off-by: Jiri Pirko
>>> ---
>>
>>
>> Hi Jiri,
Wed, Sep 03, 2014 at 08:41:39PM CEST, pshe...@nicira.com wrote:
>On Wed, Sep 3, 2014 at 2:24 AM, Jiri Pirko wrote:
>> After this, flow related structures can be used in other code.
>>
>> Signed-off-by: Jiri Pirko
>> ---
>> include/net/sw_flow.h | 99 ++
>
Thu, Sep 04, 2014 at 01:20:58AM CEST, f.faine...@gmail.com wrote:
>On 09/03/2014 02:24 AM, Jiri Pirko wrote:
>> Signed-off-by: Jiri Pirko
>> ---
>> include/linux/netdevice.h | 3 ++-
>> include/net/dsa.h | 1 +
>> net/dsa/Kconfig | 2 +-
>> net/dsa/dsa.c | 3 +++
Wed, Sep 03, 2014 at 05:46:23PM CEST, john.fastab...@gmail.com wrote:
>On 09/03/2014 02:24 AM, Jiri Pirko wrote:
>>The goal of this is to provide a possibility to suport various switch
>>chips. Drivers should implement relevant ndos to do so. Now there is a
>>couple of ndos defines:
>>- for getting
Wed, Sep 03, 2014 at 06:37:08PM CEST, john.fastab...@gmail.com wrote:
>On 09/03/2014 02:24 AM, Jiri Pirko wrote:
>>Benefit from the possibility to work with flows in switch devices and
>>use the swdev api to offload flow datapath.
>>
>>Signed-off-by: Jiri Pirko
>>---
>> net/openvswitch/Makefile
Hi,
Can you pls point me to a direction where I can set the mtu size on ovs bridge ?
Thanks,
Bhavin Shah
.:|:.:|:. sh...@cisco.com
Systems Engineer
AT&T Account Team
732 429-4080 mobile
732 635-4271 office
welcome to the human network
___
dev mailing
On Thu, Sep 4, 2014 at 6:45 AM, Bhavin Shah (shahb) wrote:
> Hi,
> Can you pls point me to a direction where I can set the mtu size on ovs
> bridge ?
ifconfig br1 mtu 9000
>
> Thanks,
> Bhavin Shah
>
> .:|:.:|:. sh...@cisco.com
> Systems Engineer
> AT&T Account Team
> 732 429-4080 mobile
> 732
You might want to add
[diff]
renames = copies
to your .gitconfig or .git/config, so that this is the default.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Wed, Aug 20, 2014 at 09:00:47PM -0700, Ben Pfaff wrote:
> Commit 79fe0f4611b60 (meta-flow: Add 64-bit registers.) added support for
> the OpenFlow 1.5 (draft) standardized registers, but neglected to cause
> them to be serialized when Open vSwitch composes flow matches. This meant
> that they w
On Thu, Aug 21, 2014 at 10:45:14AM -0700, Ben Pfaff wrote:
> OpenFlow 1.2 and later have "experimenter errors". The OVS implementation
> was buggy in a few ways. First, a bug in extract-ofp-errors prevented
> OF1.2+ experimenter errors from being properly decoded. Second,
> OF1.2+ experimenter e
Small nits below, otherwise looks good to me (even though I’m not versed in
MSVC),
Signed-off-by: Jarno Rajahalme
On Sep 3, 2014, at 1:08 PM, Gurucharan Shetty wrote:
> Before this change (i.e., with pthread locks for atomics on Windows),
> the benchmark for cmap and hmap was as follows:
>
>
Thanks for the quick response Guru.
Follow up question is how to set it on the TAP interfaces that are
dynamically defined.
Thanks,
Bhavin Shah
.:|:.:|:. sh...@cisco.com
Systems Engineer
AT&T Account Team
732 429-4080 mobile
732 635-4271 office
welcome to the human network
On 9/4/1
On Thu, Sep 04, 2014 at 08:42:44AM -0700, Jarno Rajahalme wrote:
> Small nits below, otherwise looks good to me (even though I?m not versed in
> MSVC),
>
> Signed-off-by: Jarno Rajahalme
>
> On Sep 3, 2014, at 1:08 PM, Gurucharan Shetty wrote:
> >
> > +/* 64 bit writes are atomic on i586 if 64
[Moving to ovs-discuss]
On Thu, Sep 4, 2014 at 8:44 AM, Bhavin Shah (shahb) wrote:
> Thanks for the quick response Guru.
>
> Follow up question is how to set it on the TAP interfaces that are
> dynamically defined.
The one that creates the tap interface needs to have that ability. If
the questio
On Wed, Sep 03, 2014 at 04:32:55PM -0700, Ankur Sharma wrote:
> In this change we have created a new directory named Netlink
> inside datapath-windows/ovsext/. This directory will be used to
> keep all the netlink related files.
>
> The reason we have created new directory is that for 'put' relate
Looks good to me,
Acked-by: Jarno Rajahalme
On Aug 20, 2014, at 9:00 PM, Ben Pfaff wrote:
> Commit 79fe0f4611b60 (meta-flow: Add 64-bit registers.) added support for
> the OpenFlow 1.5 (draft) standardized registers, but neglected to cause
> them to be serialized when Open vSwitch composes flo
On Wed, Sep 03, 2014 at 04:33:05PM -0700, Ankur Sharma wrote:
> In this change we have introduced buffer mgmt apis which will be
> used while creating netlink messages. The basic functionality provided
> by apis is on similar lines to ofpbuf in userspace with an exception
> that it will not do run
On Wed, Sep 03, 2014 at 04:33:24PM -0700, Ankur Sharma wrote:
> Signed-off-by: Ankur Sharma
> Tested-by: Ankur Sharma
> Reported-at: https://github.com/openvswitch/ovs-issues/issues/37
> Acked-by: Eitan Eliahu
> Acked-by: Alin Gabriel Serdean
Applied, thanks!
__
On Wed, Sep 03, 2014 at 04:33:15PM -0700, Ankur Sharma wrote:
> Added a new macro for calculating the number of bytes required
> for padding. Fixed a minor typo.
>
> Signed-off-by: Ankur Sharma
> Tested-by: Ankur Sharma
> Reported-at: https://github.com/openvswitch/ovs-issues/issues/37
> Acked-b
On Wed, Sep 03, 2014 at 04:33:32PM -0700, Ankur Sharma wrote:
> In this change we have added the APIs for putting
> netlink headers, attributes in a buffer.
>
> The buffer is managed through NetlinkBuf.[c|h].
>
> Signed-off-by: Ankur Sharma
> Tested-by: Ankur Sharma
> Reported-at: https://githu
> However, you should probably keep the version in your patch if you
> know that the alignment check can be computed at compile-time and/or
> there is some documentation that MSVC will not align 64-bit units on
> at 4-byte alignment.
https://urldefense.proofpoint.com/v1/url?u=http://msdn.micros
On Sep 4, 2014, at 2:04 AM, Simon Horman wrote:
>
>
> [snip]
>
> In relation to ports and datapaths it seems to me that the API that
> has been developed accommodates a model where a port may belong to a
> switch device; that this topology is fixed before any API calls are made
> and that all
On Wed, Sep 03, 2014 at 04:33:40PM -0700, Ankur Sharma wrote:
> Signed-off-by: Ankur Sharma
> Tested-by: Ankur Sharma
> Reported-at: https://github.com/openvswitch/ovs-issues/issues/37
> Acked-by: Eitan Eliahu
> Acked-by: Alin Gabriel Serdean
Applied, thanks!
__
On Wed, Sep 03, 2014 at 04:38:43PM -0700, Ankur Sharma wrote:
> In this change we have introduced buffer mgmt apis which will be
> used while creating netlink messages. The basic functionality provided
> by apis is on similar lines to ofpbuf in userspace with an exception
> that it will not do run
Acked-by: Jarno Rajahalme
On Aug 21, 2014, at 10:45 AM, Ben Pfaff wrote:
> OpenFlow 1.2 and later have "experimenter errors". The OVS implementation
> was buggy in a few ways. First, a bug in extract-ofp-errors prevented
> OF1.2+ experimenter errors from being properly decoded. Second,
> OF1
Acked-by: Jarno Rajahalme
On Aug 21, 2014, at 10:45 AM, Ben Pfaff wrote:
> From: Jean Tourrilhes
>
> Signed-off-by: Jean Tourrilhes
> [b...@nicira.com removed the definitions of these errors in OF1.1 and OF1.2]
> Signed-off-by: Ben Pfaff
> ---
> lib/ofp-errors.h | 12 ++--
> 1 file
On Thu, Sep 4, 2014 at 8:42 AM, Jarno Rajahalme wrote:
> Small nits below, otherwise looks good to me (even though I’m not versed in
> MSVC),
>
> Signed-off-by: Jarno Rajahalme
>
> On Sep 3, 2014, at 1:08 PM, Gurucharan Shetty wrote:
>> +
>> +/* 64 bit writes are atomic on i586 if 64 bit align
Thanks! Applied to master.
On Thu, Sep 04, 2014 at 09:18:45AM -0700, Jarno Rajahalme wrote:
> Looks good to me,
>
> Acked-by: Jarno Rajahalme
>
> On Aug 20, 2014, at 9:00 PM, Ben Pfaff wrote:
>
> > Commit 79fe0f4611b60 (meta-flow: Add 64-bit registers.) added support for
> > the OpenFlow 1.5
Thanks for the reviews. I applied these patches to master.
On Thu, Sep 04, 2014 at 09:51:41AM -0700, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
>
> On Aug 21, 2014, at 10:45 AM, Ben Pfaff wrote:
>
> > From: Jean Tourrilhes
> >
> > Signed-off-by: Jean Tourrilhes
> > [b...@nicira.com
I applied all four of these patches to master. Thank you!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, Aug 29, 2014 at 03:47:21PM -0700, Ankur Sharma wrote:
> Please attribute this change to Nithin Raju
I took care of that for this series, but the right way to do that is
to keep the patch author as Nithin and then let git send-email add a
From: line at the beginning. Please see CONTRIBUTI
Many of the ovs_numa_*() functions abort the program when the
input cpu socket or core id is invalid. This commit relaxes
the input check and makes these functions return OVS_*_UNSPEC
when the check fails.
Signed-off-by: Alex Wang
---
lib/ovs-numa.c | 77 --
Signed-off-by: Alex Wang
---
lib/ovs-numa.c | 18 ++
lib/ovs-numa.h |7 +++
2 files changed, 25 insertions(+)
diff --git a/lib/ovs-numa.c b/lib/ovs-numa.c
index 545b075..2de2aa2 100644
--- a/lib/ovs-numa.c
+++ b/lib/ovs-numa.c
@@ -168,6 +168,24 @@ ovs_numa_get_n_cores(v
ovs-vtep is an emulator and it works only on one
physical switch. This switch name is stored in the variable
'ps_name' and then passed around. An upcoming commit requires
access to this variable at more places and it is easier if this
variable is global.
Signed-off-by: Gurucharan Shetty
---
vtep
Before destroying a logical switch, cleanup any left over local
mac information in Ucast_Macs_Local or Mcast_Macs_Local table.
We need to do this to atleast cleanup the 'unknown-dst' information
added in the Mcast_Macs_Local table while creating the Logical_Switch
class in setup_ls().
Signed-off-b
The VTEP emulator creates one OVS bridge for every logical switch and then
programs flow in it based on learned local macs and controller programmed
remote macs.
Multiple logical switches can have multiple OVS tunnels to the
same remote machine (with different tunnel ids). But VTEP schema expects
string.split() function splits a quoted string if there is a whitespace
inside the quote.
ex: The following code snippet will output ['printing', '"No', 'Diagnostic"']
args = 'printing "No Diagnostic"'
print args.split()
The above is a problem if we run the following command through vtep_ctl().
vt
This is needed to create, get, set records in the Tunnel table.
(We need to add the Tunnel table's 'local' and 'remote' columns
that point to the Physical_Locator record to cache because vtep-ctl
commands like 'add-ucast-local' will try to add an entry in
Physical_Locator table based on the conten
Reported-by: Ziyou Wang
Signed-off-by: Gurucharan Shetty
---
AUTHORS |1 +
vtep/README.ovs-vtep |1 +
2 files changed, 2 insertions(+)
diff --git a/AUTHORS b/AUTHORS
index d25d888..5c02b10 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -295,6 +295,7 @@ Voravit T. vora..
Future patches will change the recirc action implementation to not
using recursion. The stack depth detection is no longer necessary.
Signed-off-by: Andy Zhou
Acked-by: Pravin B Shelar
---
datapath/actions.c | 63 -
datapath/datapath.c | 6 +
Since kernel stack is limited in size, it is not wise to using
recursive function with large stack frames.
This patch provides an alternative implementation of recirc action
without using recursion.
A per CPU fixed sized, 'deferred action FIFO', is used to store either
recirc or sample actions en
Add a short description of the module and its assumption.
Signed-off-by: Alex Wang
---
lib/ovs-numa.c | 12
1 file changed, 12 insertions(+)
diff --git a/lib/ovs-numa.c b/lib/ovs-numa.c
index 2de2aa2..ad44d95 100644
--- a/lib/ovs-numa.c
+++ b/lib/ovs-numa.c
@@ -36,6 +36,18 @@
On Thu, Sep 4, 2014 at 1:26 PM, Alex Wang wrote:
> Add a short description of the module and its assumption.
>
> Signed-off-by: Alex Wang
> ---
> lib/ovs-numa.c | 12
> 1 file changed, 12 insertions(+)
>
> diff --git a/lib/ovs-numa.c b/lib/ovs-numa.c
> index 2de2aa2..ad44d95 10064
Thx for the clarification, I'll replace the 'socket' with 'numa' and repost
the series.
On Thu, Sep 4, 2014 at 1:32 PM, Pravin Shelar wrote:
> On Thu, Sep 4, 2014 at 1:26 PM, Alex Wang wrote:
> > Add a short description of the module and its assumption.
> >
> > Signed-off-by: Alex Wang
> > --
On Thu, Sep 4, 2014 at 5:33 AM, Jiri Pirko wrote:
> Wed, Sep 03, 2014 at 08:41:39PM CEST, pshe...@nicira.com wrote:
>>On Wed, Sep 3, 2014 at 2:24 AM, Jiri Pirko wrote:
>>> After this, flow related structures can be used in other code.
>>>
>>> Signed-off-by: Jiri Pirko
>>> ---
>>> include/net/sw
'numa' and 'socket' are currently used interchangeably in ovs-numa.
But they are not always equivalent as some platform can have multiple
sockets on a numa node. To avoid confusion, this commit renames all
the 'cpu_socket' to 'numa_node'.
Signed-off-by: Alex Wang
---
lib/ovs-numa.c | 138 +
Many of the ovs_numa_*() functions abort the program when the
input cpu socket or core id is invalid. This commit relaxes
the input check and makes these functions return OVS_*_UNSPEC
when the check fails.
Signed-off-by: Alex Wang
---
lib/ovs-numa.c | 77 --
Add a short description of the module and its assumption.
Signed-off-by: Alex Wang
---
lib/ovs-numa.c | 12
1 file changed, 12 insertions(+)
diff --git a/lib/ovs-numa.c b/lib/ovs-numa.c
index 4698967..c909d5a 100644
--- a/lib/ovs-numa.c
+++ b/lib/ovs-numa.c
@@ -36,6 +36,18 @@
Signed-off-by: Alex Wang
---
lib/ovs-numa.c | 17 +
lib/ovs-numa.h |7 +++
2 files changed, 24 insertions(+)
diff --git a/lib/ovs-numa.c b/lib/ovs-numa.c
index bcdea3b..4698967 100644
--- a/lib/ovs-numa.c
+++ b/lib/ovs-numa.c
@@ -168,6 +168,23 @@ ovs_numa_get_n_cores(vo
The /FS option allows serial access to PDB file creation letting
parallel builds succeed with mingw32-make (with some tricks). The
'make' that comes with MSYS has a bug that causes hangs with
parallel builds which supposedly has been fixed in the upcoming
1.0.19 release.
Signed-off-by: Gurucharan
MSVC has a '-O2' compiler optimization flag which makes code run
fast and is the recommended option for released code. For e.g.,
running "./tests/ovstest.exe test-cmap benchmark 100 3 1"
shows a 3x improvement for some cmap micro-benchmarks.
In the Visual Studio world, there is a concept of "r
>
> Yes, that what I was getting at.
>
I took a slightly different approach and sent a v2. Have a look. I
mainly targeted at the "release" vs "debug" build that I keep hearing
often. I do not know all the differences between the two. But I think
the v2 is a good start.
>>
>> >
>> > Saurabh
_
Looks good to me.
Acked-by: Ankur Sharma
Regards,
Ankur
From: dev on behalf of Eitan Eliahu
Sent: Thursday, September 4, 2014 3:18 AM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH] Windows NetLink Socket - Support for asynchronous
event notifi
>We keep an outstanding, out of band, I/O request in the driver at all
>time.
>Once an event generated the driver queues the event message, completes the
>pending I/O and unblocks the calling thread through setting the event in
>the
>overlapped structure n the NL socket. The thread will read all
>The /FS option allows serial access to PDB file creation letting
>parallel builds succeed with mingw32-make (with some tricks). The
>'make' that comes with MSYS has a bug that causes hangs with
>parallel builds which supposedly has been fixed in the upcoming
>1.0.19 release.
>
>Signed-off-by: Gur
>
>diff --git a/m4/openvswitch.m4 b/m4/openvswitch.m4
>index e918f25..2044e6b 100644
>--- a/m4/openvswitch.m4
>+++ b/m4/openvswitch.m4
>@@ -86,6 +86,14 @@ AC_DEFUN([OVS_CHECK_WIN32],
> AC_MSG_ERROR([pthread directory not specified])
> ]
> )
>+ AC_ARG_WITH([debug],
>+
On Thu, Sep 4, 2014 at 5:16 PM, Saurabh Shah wrote:
>>
>>diff --git a/m4/openvswitch.m4 b/m4/openvswitch.m4
>>index e918f25..2044e6b 100644
>>--- a/m4/openvswitch.m4
>>+++ b/m4/openvswitch.m4
>>@@ -86,6 +86,14 @@ AC_DEFUN([OVS_CHECK_WIN32],
>> AC_MSG_ERROR([pthread directory not specif
From: lawrancejing
In file net/openvswitch/vport.h, line#35 and line#37 are the same,
the patch will remove one to make code more clean.
Signed-off-by: lawrancejing
---
--- net/openvswitch/vport.h.orig 2014-08-22 02:45:36.474929300 +0800
+++ net/openvswitch/vport.h 2014-08-22 02:46:15.0419292
On Thu, Sep 04, 2014 at 02:48:37PM +0200, Jiri Pirko wrote:
> Wed, Sep 03, 2014 at 06:37:08PM CEST, john.fastab...@gmail.com wrote:
> >On 09/03/2014 02:24 AM, Jiri Pirko wrote:
> >>Benefit from the possibility to work with flows in switch devices and
> >>use the swdev api to offload flow datapath.
On Thu, Sep 04, 2014 at 09:30:45AM -0700, Scott Feldman wrote:
>
> On Sep 4, 2014, at 2:04 AM, Simon Horman wrote:
>
> >
> >
> > [snip]
> >
> > In relation to ports and datapaths it seems to me that the API that
> > has been developed accommodates a model where a port may belong to a
> > swit
I'm not sure even why the device name is hard coded while it appears in the
interface header file.
Thanks Saurabh.
Eitan
-Original Message-
From: Saurabh Shah
Sent: Thursday, September 04, 2014 4:50 PM
To: Eitan Eliahu; dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH] Windows NetLink S
On 2014-09-04 14:47, Jiri Pirko wrote:
> Thu, Sep 04, 2014 at 01:20:58AM CEST, f.faine...@gmail.com wrote:
>>On 09/03/2014 02:24 AM, Jiri Pirko wrote:
>>> Signed-off-by: Jiri Pirko
>>> ---
>>> include/linux/netdevice.h | 3 ++-
>>> include/net/dsa.h | 1 +
>>> net/dsa/Kconfig
Fri, Sep 05, 2014 at 06:43:23AM CEST, n...@openwrt.org wrote:
>On 2014-09-04 14:47, Jiri Pirko wrote:
>> Thu, Sep 04, 2014 at 01:20:58AM CEST, f.faine...@gmail.com wrote:
>>>On 09/03/2014 02:24 AM, Jiri Pirko wrote:
Signed-off-by: Jiri Pirko
---
include/linux/netdevice.h | 3 ++-
>
Hi Eitan,
#else
sock->fd = socket(AF_NETLINK, SOCK_RAW, protocol);
if (sock->fd < 0) {
+int last_error = GetLastError();
The above breaks linux build. You could leave last_error outside and use it
wherever appropriate.
#define OVS_DEVICE_NAME_NT L"\\Device\\OpenvSwitchDev
73 matches
Mail list logo
