Re: [ovs-dev] [PATCH 16/19] ovs-ofctl: Add 'bundle' command and unit testing.

Thanks Jarno! On May 14, 2015 at 2:11:50 PM, Jarno Rajahalme (jrajaha...@nicira.com(mailto:jrajaha...@nicira.com)) wrote: > The new ovs-ofctl 'bundle' command accepts files similar to > 'add-flows', but each line can optionally start with 'add', 'modify', > 'delete', 'modify_strict', or 'delete

Re: [ovs-dev] [RFC PATCH kernel 00/10] IPv6 tunneling support for the kernel datapath

On Thu, May 14, 2015 at 11:10 AM, Jiri Benc wrote: > This patchset is against the current net-next. I'm intentionally not sending > it to netdev yet, I'd like to gather feedback on design decisions first, > especially on the ovs part in the second patchset. > > This patchset adds support for tunne

[ovs-dev] I'm excited for you to join us

SP Casino has a deposit tripling 200% Bonus for you when you sign up and make your first deposit. Not only that but with over 450 HD-quality casino games, you’ll be entertained for hours on end. Look out for weekly and monthly offers in your email inbox to enhance your chances of winning. If yo

Re: [ovs-dev] [PATCH] ovs-ofctl: replace-flows and diff-flows support for multiple tables

Hi Ben, Thanks for your comments, and for making time to review the patch. On Thu, May 7, 2015 at 12:31 PM, Ben Pfaff wrote: > On Sun, May 03, 2015 at 05:35:43PM -0700, shashank.shanb...@gmail.com > wrote: > > From: Shashank Shanbhag > > > > Fix replace-flows and diff-flows to modify/diff flow

Re: [ovs-dev] Resubmit behaviour

On Thu, May 14, 2015 at 04:39:46PM -0700, Joe Stringer wrote: > If we define the following flow table: > > table=0 in_port=1,actions=resubmit:0 > table=0 in_port=0,actions=goto_table:1 > table=1 in_port=0 actions=2 > ... > (default drop) > > Is the resubmit using port 0 supposed to apply to only

[ovs-dev] Resubmit behaviour

I'm trying to figure out what the proper semantics are supposed to be for resubmit with in_ports, which is being used in some of the OpenStack neutron firewalling flows. If we define the following flow table: table=0 in_port=1,actions=resubmit:0 table=0 in_port=0,actions=goto_table:1 table=1 in_p

Re: [ovs-dev] STP and Open vSwitch: hosts versus networks

> On May 4, 2015, at 5:41 PM, Ben Pfaff wrote: > > Recently we've had a number of reports on this mailing list that, when a > new port appears on an Open vSwitch switch, STP triggers a topology > change and start dropping packets for several seconds. After thinking > about this for a while, I t

Re: [ovs-dev] I'm just waiting for you to join

Make three times as much cash when you sign up with SP Casino and grab your 200% Welcome Bonus. Along with your Welcome Bonus, there are also over 450 unique, classic casino games for you to indulge in. We’ll send you regular promotions to help you boost your balance and your gameplay. Our promo

[ovs-dev] [PATCH 14/19] ofproto: Split delete_flow*().

Signed-off-by: Jarno Rajahalme --- ofproto/ofproto.c | 79 +++-- 1 file changed, 65 insertions(+), 14 deletions(-) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index a0404a6..03b6551 100644 --- a/ofproto/ofproto.c +++ b/ofproto/ofproto.c @@

Re: [ovs-dev] [PATCH 11/19] ofproto: Refactor modify_flows__().

> On May 14, 2015, at 2:01 PM, Jarno Rajahalme wrote: > > +#if 0 > +/* Get the buffered packet, if any. */ > +if (fm->buffer_id != UINT32_MAX && req) { > +error = ofconn_pktbuf_retrieve(req->ofconn, fm->buffer_id, > + &packet, &in_port); > +

[ovs-dev] [PATCH 18/19] ofproto: Infra for table versioning.

Signed-off-by: Jarno Rajahalme --- ofproto/ofproto-dpif-xlate.c | 17 - ofproto/ofproto-dpif.c | 43 +- ofproto/ofproto-dpif.h |5 - ofproto/ofproto-provider.h |6 ++ ofproto/ofproto.c|5

[ovs-dev] [PATCH 07/19] bundles: Manage bundles in connmgr.

This will make implementing commit in ofproto.c easier. Signed-off-by: Jarno Rajahalme --- ofproto/bundles.c | 116 ++--- ofproto/bundles.h | 19 - ofproto/connmgr.c | 51 +-- ofproto/connmgr.h |6 ++- 4 files c

[ovs-dev] [PATCH 01/19] ofproto: Eliminate use of unset error code.

Signed-off-by: Jarno Rajahalme --- ofproto/ofproto.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index 927521b..67feee6 100644 --- a/ofproto/ofproto.c +++ b/ofproto/ofproto.c @@ -4372,8 +4372,7 @@ add_flow(struct ofproto *ofproto,

[ovs-dev] [PATCH 19/19] Use classifier versioning.

Each rule is now added or deleted in a specific tables version. Flow tables are versioned with a monotonically increasing 64-bit integer, where positive values are valid version numbers. Rule modifications are implemented as an insertion of a new rule and a deletion of the old rule, both taking p

[ovs-dev] [PATCH 13/19] ofproto: Split modify_flows().

Signed-off-by: Jarno Rajahalme --- ofproto/ofproto.c | 114 - 1 file changed, 78 insertions(+), 36 deletions(-) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index 4ccd2bd..a0404a6 100644 --- a/ofproto/ofproto.c +++ b/ofproto/ofproto.c @@

[ovs-dev] [PATCH 05/19] classifier: Support duplicate rules.

OpenFlow 1.4 bundles are easier to implement when it is possible to mark a rule as 'to_be_removed' and then insert a new, identical rule with the same priority. All but one out of the identical rules must be marked as 'to_be_removed', and the one rule that is not 'to_be_removed' must have been ins

[ovs-dev] [PATCH 12/19] ofproto: Split add_flow().

Split add_flow() to add_flow_begin() which does all the error checking, and add_flow_finish() which can not fail. Since we still want to send an error response for an unknown 'buffer_id', send_buffered_packet() now send the error response itself. Signed-off-by: Jarno Rajahalme --- ofproto/ofpro

[ovs-dev] [PATCH 11/19] ofproto: Refactor modify_flows__().

Signed-off-by: Jarno Rajahalme --- ofproto/ofproto.c | 328 - 1 file changed, 198 insertions(+), 130 deletions(-) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index cc106e6..db07610 100644 --- a/ofproto/ofproto.c +++ b/ofproto/ofproto.c

[ovs-dev] [PATCH 16/19] ovs-ofctl: Add 'bundle' command and unit testing.

The new ovs-ofctl 'bundle' command accepts files similar to 'add-flows', but each line can optionally start with 'add', 'modify', 'delete', 'modify_strict', or 'delete_strict' keyword, so that arbitrary flow table modifications may be specified in a single file. The modifications in the file are ex

[ovs-dev] [PATCH 08/19] ofproto: Factor out ofproto_rule_insert__().

Pairs well with ofproto_rule_remove__(). Signed-off-by: Jarno Rajahalme --- ofproto/ofproto.c | 29 + 1 file changed, 21 insertions(+), 8 deletions(-) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index ffdc17d..9d35d5b 100644 --- a/ofproto/ofproto.c +++ b/ofp

[ovs-dev] [PATCH 17/19] classifier: Support table versioning

This patch allows classifier rules to become visible and invisible in specific versions. A 'version' is defined as a positive monotonically increasing integer, which never wraps around. When versioning is not used, the 'version' parameter should be passed as 'CLS_NO_VERSION'. This feature enable

[ovs-dev] [PATCH 15/19] ofproto: Add support for reverting flow mods, and bundle commit.

Signed-off-by: Jarno Rajahalme --- ofproto/bundles.c | 40 - ofproto/bundles.h | 21 +++-- ofproto/ofproto.c | 235 +++-- tests/ofproto.at | 66 +++ 4 files changed, 293 insertions(+), 69 deletions(-) diff --git a/ofprot

[ovs-dev] [PATCH 06/19] bundles: Validate bundled messages.

OpenFlow bundle messages should be decoded and validated at the time they are added to the bundle. This commit does this for flow mod and port mod messages. Signed-off-by: Jarno Rajahalme --- lib/ofp-print.c |4 ++-- lib/ofp-util.c| 10 +++--- lib/ofp-util.h|7 +-- o

[ovs-dev] [PATCH 10/19] ofproto: Use enum ofperr for 'error'.

Signed-off-by: Jarno Rajahalme --- ofproto/ofproto.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index e689979..cc106e6 100644 --- a/ofproto/ofproto.c +++ b/ofproto/ofproto.c @@ -3866,7 +3866,7 @@ collect_rules_strict(st

[ovs-dev] [PATCH 09/19] ofproto: Factor out ofproto_rule_create().

Makes add_flow() easier to read and understand. Signed-off-by: Jarno Rajahalme --- ofproto/ofproto.c | 96 - 1 file changed, 59 insertions(+), 37 deletions(-) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index 9d35d5b..e689979 100644 -

[ovs-dev] [PATCH 04/19] classifier: Add support for invisible flows.

This makes it possible to tentatively add flows to the classifier without the datapath seeing them. Signed-off-by: Jarno Rajahalme --- lib/classifier-private.h |3 +- lib/classifier.c | 68 +- lib/classifier.h |1 + ofproto/of

[ovs-dev] [PATCH 03/19] ofp-util: Fix xid in ofputil_encode_bundle_add().

Bundle add must use the same xid as the embedded message. Signed-off-by: Jarno Rajahalme --- lib/ofp-util.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/ofp-util.c b/lib/ofp-util.c index 6366919..e62c584 100644 --- a/lib/ofp-util.c +++ b/lib/ofp-util.c @@ -8900,7

[ovs-dev] [PATCH 00/19] Support OF bundles for flow mods.

This series completes the implementation of OpenFlow 1.4 bundles for flow mods. Port mods are not yet supported. OpenFlow 1.4 specifies support for 'bundles' which allow arbitrary collections of flow table modifications to be executed as a single transaction. Supporting this in OVS requres major

[ovs-dev] [PATCH 02/19] ofp-parse: Remove unused F_OUT_PORT field flag.

Signed-off-by: Jarno Rajahalme --- lib/ofp-parse.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/ofp-parse.c b/lib/ofp-parse.c index 856044d..126980c 100644 --- a/lib/ofp-parse.c +++ b/lib/ofp-parse.c @@ -245,7 +245,6 @@ parse_ofp_str__(struct ofputil_flow_mod

Re: [ovs-dev] OVN OpenStack integration status

On 05/14/2015 03:57 PM, Gurucharan Shetty wrote: > For the problem in hand, I sent out I think is a fix yesterday. > https://www.mail-archive.com/dev@openvswitch.org/msg46000.html Thanks! I'll work on testing that now. I just finished a writeup about an environment where I was running a single V

Re: [ovs-dev] OVN OpenStack integration status

For the problem in hand, I sent out I think is a fix yesterday. https://www.mail-archive.com/dev@openvswitch.org/msg46000.html On Wed, May 13, 2015 at 11:17 AM, Russell Bryant wrote: > On 05/13/2015 01:28 PM, Gurucharan Shetty wrote: >> On Wed, May 13, 2015 at 10:19 AM, Russell Bryant wrote: >>>

[ovs-dev] Enjoy top-class gaming with me

You can qualify for a 200% Welcome Bonus at SP Casino when you sign up today. Not only that but with over 450 HD-quality casino games, you’ll be entertained for hours on end. Every week we’ll also send you regular offers to elevate your gaming and your account balance. Also, if you have a sugge

[ovs-dev] [RFC PATCH 13/13] Increase FLOW_WC_SEQ

The flow structure was changed, increase the sequence number. All the asserts either do not apply or have been resolved by previous patches in this set. Signed-off-by: Jiri Benc --- lib/flow.c | 12 ++-- lib/flow.h | 4 ++-- lib/match.c

[ovs-dev] [RFC PATCH 11/13] tunneling: ignore route cache for ipv6 tunnels

There's no route cache for ipv6, thus we cannot consult it when checking for status change. It means we currently don't know the status of the outgoing interface, this may be fixed later. Signed-off-by: Jiri Benc --- lib/netdev-vport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[ovs-dev] [RFC PATCH 06/13] tunneling: extend flow_tnl with ipv6 addresses

Note that because there's been no prerequisite on the outer protocol, we cannot add it now. Instead, treat the ipv4 and ipv6 dst fields in the way that either both are null, or at most one of them is non-null. Signed-off-by: Jiri Benc --- lib/dpif.c | 6 -- lib/flow.c | 19 +

[ovs-dev] [RFC PATCH 12/13] meta-flow: add ipv6 tunnel NXM/OXM fields

This is currently not standardized anywhere. Until it is, those fields are not settable by openflow. Signed-off-by: Jiri Benc --- lib/meta-flow.c | 42 ++ lib/meta-flow.h | 35 +++ lib/nx-match.c | 4 3 files changed,

[ovs-dev] [RFC PATCH 09/13] tunneling: ofproto-dpif: prevent IPv6 loops

Store the original IP address similarly to IPv4. Change the is_tunnel boolean to the outer protocol; null protocol indicates no tunnel. Signed-off-by: Jiri Benc --- ofproto/ofproto-dpif-xlate.c | 27 +-- ofproto/ofproto-dpif-xlate.h | 2 +- ofproto/ofproto-dpif.c

[ovs-dev] [RFC PATCH 05/13] lib: add format_in6_addr and scan_in6_addr

Add in6_addr counterparts to the existing format and scan functions. Otherwise we'd need to recast all the time. Signed-off-by: Jiri Benc --- lib/odp-util.c | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/lib/odp-util.c b/lib/odp-util.c index 962

[ovs-dev] [RFC PATCH 02/13] lib: add ipv6 helper functions for tnl_config

These functions will be used by the next patch. Signed-off-by: Jiri Benc --- lib/packets.h | 9 + lib/smap.c| 11 +++ lib/smap.h| 1 + lib/socket-util.c | 9 + lib/socket-util.h | 1 + 5 files changed, 31 insertions(+) diff --git a/lib/packets.h b

[ovs-dev] [RFC PATCH kernel 10/10] openvswitch: add IPv6 support for vxlan

Signed-off-by: Jiri Benc --- net/openvswitch/vport-vxlan.c | 133 +++--- 1 file changed, 99 insertions(+), 34 deletions(-) diff --git a/net/openvswitch/vport-vxlan.c b/net/openvswitch/vport-vxlan.c index 5808a9344b59..5fc9510345ba 100644 --- a/net/openvswitch/

[ovs-dev] [RFC PATCH kernel 01/10] openvswitch: fix CHECKSUM_PARTIAL with tunnels

When the packet ovs gets from a NIC driver is CHECKSUM_PARTIAL and it goes through decapsulation, csum_start may point before the skb->data after the decapsulation. This triggers a BUG_ON in skb_checksum_help. As we don't need to calculate the checksum for the header that was already stripped, jus

[ovs-dev] [RFC PATCH 04/13] netlink: helper functions for ipv6 address in netlink attrs

Signed-off-by: Jiri Benc --- lib/netlink.c | 18 ++ lib/netlink.h | 3 +++ 2 files changed, 21 insertions(+) diff --git a/lib/netlink.c b/lib/netlink.c index 09723b24da1b..fbf62bdd93d1 100644 --- a/lib/netlink.c +++ b/lib/netlink.c @@ -308,6 +308,15 @@ nl_msg_put_be64(struct ofp

[ovs-dev] [RFC PATCH 10/13] tunneling: add ipv6 tunnel endpoints to flow_metadata

Signed-off-by: Jiri Benc --- lib/flow.c | 2 ++ lib/flow.h | 2 ++ lib/ofp-print.c | 10 ++ lib/ofp-util.c | 8 4 files changed, 22 insertions(+) diff --git a/lib/flow.c b/lib/flow.c index 752cf5f15c50..c1202bd6ce7c 100644 --- a/lib/flow.c +++ b/lib/flow.c @@ -769,

[ovs-dev] [RFC PATCH 03/13] tunneling: add ipv6 fields to netdev_tunnel_config

Allow configuration of ipv6 tunnel endpoints. Signed-off-by: Jiri Benc --- lib/dpif-netlink.c | 6 +++- lib/netdev-vport.c | 88 -- lib/netdev.h | 3 ++ 3 files changed, 74 insertions(+), 23 deletions(-) diff --git a/lib/dpif-netlink.c

[ovs-dev] [RFC PATCH kernel 06/10] openvswitch: IPv6 support for ovs_flow_tun_info_init

Allow ovs_tunnel_info to be initialized also from an IPv6 header. Signed-off-by: Jiri Benc --- net/openvswitch/flow.h | 50 ++ net/openvswitch/vport-geneve.c | 2 +- net/openvswitch/vport-gre.c| 2 +- net/openvswitch/vport-vxlan.c | 2 +- n

[ovs-dev] [RFC PATCH 08/13] tunneling: extend tnl_match with ipv6

Also add a new 'protocol' field that holds the outer protocol. Signed-off-by: Jiri Benc --- ofproto/tunnel.c | 66 +--- 1 file changed, 53 insertions(+), 13 deletions(-) diff --git a/ofproto/tunnel.c b/ofproto/tunnel.c index ccef40a59668..116b

[ovs-dev] [RFC PATCH 07/13] ds: implement ds_put_in6_addr

This will be used at various places, there's no sense in open coding the conversion everywhere. Signed-off-by: Jiri Benc --- lib/dynamic-string.c | 9 + lib/dynamic-string.h | 2 ++ 2 files changed, 11 insertions(+) diff --git a/lib/dynamic-string.c b/lib/dynamic-string.c index 914af64c

[ovs-dev] [PATCH RFC 00/13] IPv6 tunneling

This patchset adds support for tunneling over IPv6. This is only implemented for the kernel datapath (and obviously depends on the kernel RFC set I posted). Setting up the tunnel over IPv6 is very intuitive to users: in the vport options, just specify IPv6 address in remote_ip/local_ip instead of

[ovs-dev] [RFC PATCH 01/13] datapath: add ipv6 tunnel definitions

This adds the needed constants from the kernel patch set posted earlier. Signed-off-by: Jiri Benc --- datapath/linux/compat/include/linux/openvswitch.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/datapath/linux/compat/include/linux/openvswitch.h b/datapath/linux/compat/include/linux/

[ovs-dev] [RFC PATCH kernel 09/10] vxlan: export vxlan6_xmit_skb

Signed-off-by: Jiri Benc --- drivers/net/vxlan.c | 13 +++-- include/net/vxlan.h | 7 +++ 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 48341ae49012..97549b8ee705 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxla

[ovs-dev] [RFC PATCH kernel 08/10] ip6_tunnel: do not update stats if no netdev given

Other users of IPv6 tunneling (e.g. openvswitch) may not have a net_device that represents the tunnel. Signed-off-by: Jiri Benc --- include/net/ip6_tunnel.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/net/ip6_tunnel.h b/include/net/ip6_tunnel.h index b8529aa1d

[ovs-dev] [RFC PATCH kernel 07/10] openvswitch: IPv6 support for ovs_tunnel_get_egress_info

Return -EAFNOSUPPORT if the provided tunnel key has a different address family than the tunnel. Such configuration is invalid but we have no way to check this when the flow is configured (unless we want to interpret actions and lookup the destination vports), thus we have to check at run time. Sig

[ovs-dev] [RFC PATCH kernel 05/10] openvswitch: tunnel: use tos and ttl also for ipv6

Rename the ipv4_tos and ipv4_ttl fields to just 'tos' and 'ttl', as they'll be used with IPv6 tunnels, too. Signed-off-by: Jiri Benc --- net/openvswitch/flow.h | 8 net/openvswitch/flow_netlink.c | 10 +- net/openvswitch/vport-geneve.c | 4 ++-- net/openvswitch/vport-g

[ovs-dev] [RFC PATCH kernel 04/10] openvswitch: IPv6 type of tunnel vports

Allow tunnel vports to be configured as tunnels over IPv6 by using OVS_TUNNEL_ATTR_OVER_IPV6 option. For now, reject such tunnels. The support to individual tunnel types will be added by subsequent patches. Signed-off-by: Jiri Benc --- include/uapi/linux/openvswitch.h | 1 + net/openvswitch/vpor

[ovs-dev] [RFC PATCH kernel 02/10] openvswitch: remove custom alignment

The custom alignment of struct ovs_key_ipv4_tunnel was originally introduced by commit 1139e241ec436 ("openvswitch: Compact sw_flow_key."). At that time, the size of the structure was not a multiply of 64bit. This is not the case anymore with addition of more fields. As this alignment is error pron

[ovs-dev] [RFC PATCH kernel 03/10] openvswitch: IPv6 tunnel flows

Allow user space to configure tunnel flows with IPv6 addresses. For now, let all tunnel vports refuse such addresses. Signed-off-by: Jiri Benc --- include/uapi/linux/openvswitch.h | 2 + net/openvswitch/flow.h | 17 --- net/openvswitch/flow_netlink.c | 96 +++

[ovs-dev] [RFC PATCH kernel 00/10] IPv6 tunneling support for the kernel datapath

This patchset is against the current net-next. I'm intentionally not sending it to netdev yet, I'd like to gather feedback on design decisions first, especially on the ovs part in the second patchset. This patchset adds support for tunneling over IPv6 to the kernel datapath. In the last patch, it

Re: [ovs-dev] [PATCH 5/5] datapath-windows: Multiple NBLs support for VXLAN packets

> On Apr 24, 2015, at 3:03 AM, Sorin Vinturis > wrote: > > Added support for handling multiple NBLs with only one NB when > encapsulating VXLAN packets. > > Signed-off-by: Sorin Vinturis hi Sorin, Was this patch necessary? Here’s my reasoning for the question. If a NBL contains an NB that c

Re: [ovs-dev] [PATCH 3/5] datapath-windows: Multiple NBLs support for ingress data path

hi Sorin, I looked at this patch. I had a few comments. > +static NTSTATUS > +OvsCreateNewNBLsFromMultipleNBs(POVS_SWITCH_CONTEXT switchContext, > +PNET_BUFFER_LIST *curNbl, > +PNET_BUFFER_LIST *nextNbl) > +{ > +NTSTATUS status =

Re: [ovs-dev] [PATCH net-next V7 2/2] openvswitch: 802.1ad: Flow handling, actions, and vlan parsing

On Tue, May 12, 2015 at 5:06 PM, Thomas F Herbert wrote: > Add support for 802.1ad including the ability to push and pop double > tagged vlans. > > Signed-off-by: Thomas F Herbert > --- ... ... > diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c > index c691b1a..062e180