Re: [ovs-dev] [PATCH] datapath: Revert "datapath: Constify netlink structs."

2015-08-04 Thread Joe Stringer
On 4 August 2015 at 18:07, Pravin B Shelar wrote: > This reverts commit 2023bdcfc44c149a8e3b38dcde8f04f2ec3f8501. > This commit is causing segfaults when genl compat code is in use. > > Compat code update genl_multicast_group and genl_family type objects. > Therefore these can not be const. > > Si

Re: [ovs-dev] Adding a new file to ovs-master

2015-08-04 Thread ravali.burra
Hi Russell & Thomas, When I am adding the new header file in bridge.c file depending on the order of the header file I am seeing different errors i.e. if I place the header file in the end of header file section i.e. before the declaration of VLOG module declaration then I am facing the issue

Re: [ovs-dev] [PATCH] dpif-netdev: Translate Geneve options per-flow, not per-packet.

2015-08-04 Thread Jesse Gross
On Tuesday, August 4, 2015, Traynor, Kevin wrote: > > > -Original Message- > > From: dev [mailto:dev-boun...@openvswitch.org ] On Behalf > Of Jesse Gross > > Sent: Thursday, July 30, 2015 4:10 AM > > To: dev@openvswitch.org > > Subject: [ovs-dev] [PATCH 2/2] dpif-netdev: Translate Geneve

[ovs-dev] [PATCH] datapath: Revert "datapath: Constify netlink structs."

2015-08-04 Thread Pravin B Shelar
This reverts commit 2023bdcfc44c149a8e3b38dcde8f04f2ec3f8501. This commit is causing segfaults when genl compat code is in use. Compat code update genl_multicast_group and genl_family type objects. Therefore these can not be const. Signed-off-by: Pravin B Shelar --- datapath/datapath.c | 25 +

Re: [ovs-dev] [PATCH 2/2] dpif-netdev: Translate Geneve options per-flow, not per-packet.

2015-08-04 Thread Traynor, Kevin
> -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Jesse Gross > Sent: Thursday, July 30, 2015 4:10 AM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH 2/2] dpif-netdev: Translate Geneve options per- > flow, not per-packet. > > The kernel implementatio

Re: [ovs-dev] [PATCH net-next v2] openvswitch: Make 100 percents packets sampled when sampling rate is 1.

2015-08-04 Thread Pravin Shelar
On Mon, Aug 3, 2015 at 9:07 PM, Wenyu Zhang wrote: > When sampling rate is 1, the sampling probability is UINT32_MAX. The packet > should be sampled even the prandom_u32() generate the number of UINT32_MAX. > And none packet need be sampled when the probability is 0. > > Signed-off-by: Wenyu Zhang

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Retry tx/rx queue setup until we don't get any failure.

2015-08-04 Thread Ethan Jackson
Sure let's do that. If you write an INSTALL.DPDK note, and post it here. I'll incorporate it into the patch and merge. Thanks for your patience. Ethan On Tue, Aug 4, 2015 at 4:48 AM, Stokes, Ian wrote: > This issue currently affects Fortville cards on systems with a logical core > count grea

Re: [ovs-dev] [PATCH v3] dpif-netdev: fix race for queues between pmd threads

2015-08-04 Thread Ethan Jackson
Hey, Really sorry this has taken so long to merge. I dropped the ball. It's in now. Ethan On Tue, Aug 4, 2015 at 5:26 AM, Ilya Maximets wrote: > Will anyone plan to apply this patch? > > Best regards, Ilya Maximets. > > On 28.07.2015 23:48, Flavio Leitner wrote: >> On Tue, Jul 28, 2015 at 09:

Re: [ovs-dev] [PATCH 1/3] tests: Expand kernel sanity tests.

2015-08-04 Thread Daniele Di Proietto
On 04/08/2015 02:38, "Joe Stringer" wrote: >On 30 July 2015 at 11:21, Daniele Di Proietto >wrote: >> Acked-by: Daniele Di Proietto >> >> On 30/07/2015 00:52, "Joe Stringer" wrote: >> >>>The initial sanity test only checked IPv4 without IP fragments. This >>>patch >>>adds additional tests usi

[ovs-dev] [PATCH 1/3] tests: Rename kmod-traffic.at to traffic.at.

2015-08-04 Thread Daniele Di Proietto
The file will be part of two different testsuites: one for the kernel datapath and another for the userspace datapath. No functional change in this commit. Signed-off-by: Daniele Di Proietto --- tests/automake.mk | 2 +- tests/kmod-testsuite.at | 2 +- tests/kmod-traffic.at | 107 --

[ovs-dev] [PATCH 3/3] tests: Add userspace-testsuite.

2015-08-04 Thread Daniele Di Proietto
The new userspace-testsuite, which can be launched via `make check-userspace`, reuses the kmod tests on the userspace datapath. The userspace datapath is already tested by the main testsuite (and that's not going to change), but having also the userspace-testsuite has the following advantages: *

[ovs-dev] [PATCH 2/3] kmod-macros: Move some code to traffic-common-macros.

2015-08-04 Thread Daniele Di Proietto
These macros will also be used by userspace datapath testing in following commits. No functional change in this commit. Signed-off-by: Daniele Di Proietto --- tests/automake.mk | 1 + tests/kmod-macros.at | 54 -- tests/kmod-testsui

[ovs-dev] [PATCH 0/3] Vagrant userspace testsuite

2015-08-04 Thread Daniele Di Proietto
This series adds a new testsuite for the userspace datapath that runs the already written kmod-sanity tests. The reason for this are explained in the 3rd commit message. The first two commits just move some code (without modifing it), while the 3rd introduces the new infrastructure. The testsuit

Re: [ovs-dev] Adding a new file to ovs-master

2015-08-04 Thread Thomas F Herbert
On 8/4/15 10:50 AM, Russell Bryant wrote: On 08/04/2015 08:37 AM, ravali.bu...@wipro.com wrote: Hi Team, I have added the new file to ovs-master for MSTP but while compiling I am unable include the new header file in the file. I have added the reference for the new files in lib/automake.mk eve

Re: [ovs-dev] [PATCH 1/2] datapath-windows: Process tunnel filter requests iteratively

2015-08-04 Thread Sorin Vinturis
Nithin, please see my answers to your questions on my previous reply on this thread. -Original Message- From: Nithin Raju [mailto:nit...@vmware.com] Sent: Tuesday, 4 August, 2015 16:39 To: Sorin Vinturis Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH 1/2] datapath-windows: Process

Re: [ovs-dev] Adding a new file to ovs-master

2015-08-04 Thread Russell Bryant
On 08/04/2015 08:37 AM, ravali.bu...@wipro.com wrote: > Hi Team, > > I have added the new file to ovs-master for MSTP but while compiling > I am unable include the new header file in the file. > > I have added the reference for the new files in lib/automake.mk even > then I am able to see error l

Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when handling flows

2015-08-04 Thread Sorin Vinturis
This patch is already committed on both master and 2.4 branch. -Original Message- From: Nithin Raju [mailto:nit...@vmware.com] Sent: Tuesday, 4 August, 2015 16:39 To: Sorin Vinturis Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when handling flows >

Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

2015-08-04 Thread Sorin Vinturis
Nithin, The code snippet that you paste is from the first version of this patch, which is no longer current. There is a v2 version of this patch, [PATCH v2] datapath-windows: Solved BSOD when adding OVS ports: http://openvswitch.org/pipermail/dev/2015-July/057089.html, which adds the ndisHandl

Re: [ovs-dev] [PATCH 1/2] datapath-windows: Process tunnel filter requests iteratively

2015-08-04 Thread Nithin Raju
> On Aug 4, 2015, at 3:29 AM, Sorin Vinturis > wrote: > > Nithin, > > There is a v2 version of this patch series. Still, I will address your > comments inline. > Thanks Sorin. I’ll wait for the v3. ___ dev mailing list dev@openvswitch.org http://o

Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when handling flows

2015-08-04 Thread Nithin Raju
> On Aug 3, 2015, at 8:26 AM, Nithin Raju wrote: > >> On Jul 1, 2015, at 10:28 AM, Sorin Vinturis >> wrote: >> >> OvsPrepareFlow() returns an error only when the new flow allocation >> fails. In this case HandleFlowPut() should return error without trying >> to free the flow, thus avoiding the

Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

2015-08-04 Thread Nithin Raju
> On Aug 4, 2015, at 1:45 AM, Sorin Vinturis > wrote: > > Nithin, that check (if (nbl->SourceHandle == context->ovsPool.ndisHandle) ..) > at L564 was added by my patch. Please see here: > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openvswitch_ovs_commit_d50b88bf830c401636

Re: [ovs-dev] [ovn-controller-vtep V4 1/6] ovn-sb: Remove the "Gateway" table from the ovn-sb schema.

2015-08-04 Thread Russell Bryant
On 08/03/2015 09:06 PM, Alex Wang wrote: > Hey Russell, > > With your add type/option change and Ben's tunnel-key work in, it is time > to rebase my ovn-controller-vtep series~~ > > So, now, I think I'd like to adopt your earlier suggestion, which > requires users > to specify this when creating

[ovs-dev] Adding a new file to ovs-master

2015-08-04 Thread ravali.burra
Hi Team, I have added the new file to ovs-master for MSTP but while compiling I am unable include the new header file in the file. I have added the reference for the new files in lib/automake.mk even then I am able to see error like expected ';', identifier or '(' before 'struct' . Can you pl

Re: [ovs-dev] [PATCH v3] dpif-netdev: fix race for queues between pmd threads

2015-08-04 Thread Ilya Maximets
Will anyone plan to apply this patch? Best regards, Ilya Maximets. On 28.07.2015 23:48, Flavio Leitner wrote: > On Tue, Jul 28, 2015 at 09:55:52AM +0300, Ilya Maximets wrote: >> Currently pmd threads select queues in pmd_load_queues() according to >> get_n_pmd_threads_on_numa(). This behavior lea

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Retry tx/rx queue setup until we don't get any failure.

2015-08-04 Thread Stokes, Ian
This issue currently affects Fortville cards on systems with a logical core count greater than 64. Just to call out however that the number of cores setup by default to forward traffic to a NIC using OVS with DPDK will be the total number of cores detected on the system. This is the default beh

Re: [ovs-dev] [Patch v1 0/3]Implementation of OpenFlow 1.4 Vacancy Events

2015-08-04 Thread Saloni Jain
Hi Ben, Thanks. I will rebase and repost my patches on Aug. 18, 2015. Thanks and Regards, Saloni Jain Tata Consultancy Services Mailto: saloni.j...@tcs.com Website: http://www.tcs.com Experience certainty. IT Services Business Solutions Consulting __

Re: [ovs-dev] [PATCH] datapath-windows: Enable failure after restarting extension

2015-08-04 Thread Sorin Vinturis
Nithin, please see my answers inline. Thanks! -Original Message- From: Nithin Raju [mailto:nit...@vmware.com] Sent: Monday, 3 August, 2015 20:22 To: Sorin Vinturis Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] datapath-windows: Enable failure after restarting extension > On Jul

Re: [ovs-dev] [PATCH 2/2] datapath-windows: Support for IRP cancelling mechanism

2015-08-04 Thread Sorin Vinturis
Nithin, thanks for reviewing this patch. There is a v2 version of this patch though. Please see my answers inline. -Original Message- From: Nithin Raju [mailto:nit...@vmware.com] Sent: Monday, 3 August, 2015 19:56 To: Sorin Vinturis Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH 2

Re: [ovs-dev] [PATCH 1/2] datapath-windows: Process tunnel filter requests iteratively

2015-08-04 Thread Sorin Vinturis
Nithin, There is a v2 version of this patch series. Still, I will address your comments inline. Thanks, Sorin -Original Message- From: Nithin Raju [mailto:nit...@vmware.com] Sent: Monday, 3 August, 2015 19:19 To: Sorin Vinturis Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH 1/2]

Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when handling flows

2015-08-04 Thread Sorin Vinturis
Nithin, Thanks for your comment. I agree with what you said. This patch removes a wrong call to FreeFlow() function. Do you see any issue with this patch? -Sorin -Original Message- From: Nithin Raju [mailto:nit...@vmware.com] Sent: Monday, 3 August, 2015 18:27 To: Sorin Vinturis Cc: de

Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

2015-08-04 Thread Sorin Vinturis
Nithin, that check (if (nbl->SourceHandle == context->ovsPool.ndisHandle) ..) at L564 was added by my patch. Please see here: https://github.com/openvswitch/ovs/commit/d50b88bf830c401636085ecd5048e929c80fd4d2 -Sorin -Original Message- From: Nithin Raju [mailto:nit...@vmware.com] Sent