Re: [ovs-dev] [PATCH] ofp-util: Add "check_overlap" and "reset_counts" to stateful flags.

2015-11-24 Thread Simon Horman
On Wed, Nov 25, 2015 at 04:22:28PM +0900, Simon Horman wrote: > On Tue, Sep 29, 2015 at 11:50:40AM -0700, Ben Pfaff wrote: > > The OpenFlow specification implies that every flag is part of the flow > > state, even though that isn't really meaningful for OFPFF_CHECK_OVERLAP > > or OFPFF_RESET_COUNTS

[ovs-dev] (no subject)

2015-11-24 Thread Vanessa Roman
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [rhel --user 4/7] utilities: add --user option to ovs-ctl

2015-11-24 Thread Andy Zhou
On Tue, Nov 24, 2015 at 3:25 PM, Ben Pfaff wrote: > On Thu, Nov 19, 2015 at 12:58:39PM -0800, Andy Zhou wrote: > > Allow ovs-ctl to take --user=USER option. When this option is specified > > 'USER' will be parsed in the format of 'user:group" and be set into > > shell variables $OVS_USER and $OVS

Re: [ovs-dev] [PATCH] ofp-util: Add "check_overlap" and "reset_counts" to stateful flags.

2015-11-24 Thread Simon Horman
On Tue, Sep 29, 2015 at 11:50:40AM -0700, Ben Pfaff wrote: > The OpenFlow specification implies that every flag is part of the flow > state, even though that isn't really meaningful for OFPFF_CHECK_OVERLAP > or OFPFF_RESET_COUNTS. This commit adds them to the flow state (reported > in flow stats r

Re: [ovs-dev] [PATCH repost 1/3] tests: Run OVS_WAIT_WHILE, OVS_WAIT_UNTIL in main shell environment.

2015-11-24 Thread Simon Horman
Hi Ben, On Tue, Sep 29, 2015 at 11:17:13AM -0700, Ben Pfaff wrote: > AT_CHECK runs its commands in a subshell. That means that (among other > effects), any variable assignments within its commands will disappear after > the commands' completion. That doesn't matter for any of the existing > user

Re: [ovs-dev] [PATCH 2/2] ofproto: Correctly reject duplicate bucket ID for OFPGC_INSERT_BUCKET.

2015-11-24 Thread Simon Horman
On Thu, Sep 10, 2015 at 01:18:55PM -0700, Ben Pfaff wrote: > Otherwise duplicate bucket IDs cause linked list loops and other nastiness > because the ofputil_bucket_find() in the OFPG15_BUCKET_LAST case later in > copy_buckets_for_insert_bucket() will find the new bucket instead of the > old one an

Re: [ovs-dev] [PATCH 03/12] flow: Introduce parse_dl_type().

2015-11-24 Thread Ben Pfaff
On Sun, Nov 15, 2015 at 10:21:14PM -0800, Daniele Di Proietto wrote: > The function simply returns the ethernet type of the packet (after > eventually discarding the VLAN tag). It will be used by a following > commit. > > Signed-off-by: Daniele Di Proietto Acked-by: Ben Pfaff _

Re: [ovs-dev] [PATCH 01/12] packets: Define ICMP types.

2015-11-24 Thread Ben Pfaff
On Sun, Nov 15, 2015 at 10:21:12PM -0800, Daniele Di Proietto wrote: > Linux and FreeBSD have different names for these constants. Windows > doesn't define them. It is simpler to redefine them from scratch for > OVS. > > These definitions will be used by a future commit. > > Signed-off-by: Dani

Re: [ovs-dev] [RFC] make: Add 'lint-docs' target

2015-11-24 Thread Ben Pfaff
On Fri, Nov 13, 2015 at 02:18:40AM +, Stephen Finucane wrote: > This provides a quick, easy way to use the 'mdl' executable provided > in markdowlinter to validate documentation. > > This change does not resolve any of the issues this linter raises - > these will need to be done in a follow up

Re: [ovs-dev] [PATCH] datapath-windows: Support for OVS_KEY_ATTR_SCTP attribute

2015-11-24 Thread Ben Pfaff
On Wed, Nov 18, 2015 at 09:18:21PM +, Sairam Venugopal wrote: > Thanks for the patch. > > Acked-by: Sairam Venugopal Applied to master, thanks Sorin and Sairam! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH V14 1/4] Flow and action changes for 802.1AD

2015-11-24 Thread Ben Pfaff
On Mon, Nov 09, 2015 at 08:30:19PM -0800, Thomas F Herbert wrote: > > > On 11/9/15 12:58 PM, Ben Pfaff wrote: > >On Fri, Oct 02, 2015 at 05:31:58PM -0400, Thomas F Herbert wrote: > >>From: "Thomas F. Herbert" > >> > >>ToDo: The flow structure needs to be updated to hold both the inner and > >>o

Re: [ovs-dev] [PATCHv2 6/6] ofproto: Validate ct actions support.

2015-11-24 Thread Ben Pfaff
On Wed, Nov 11, 2015 at 02:25:20PM -0800, Jarno Rajahalme wrote: > LGTM, > > However, I would urge Ben to offer his opinion to this design, I don't object to the checking, but I think it can be done in the existing ->rule_construct(). ___ dev mailing li

Re: [ovs-dev] [PATCHv2 5/6] ofproto-provider: Add action validation.

2015-11-24 Thread Ben Pfaff
On Wed, Nov 11, 2015 at 11:39:53AM -0800, Joe Stringer wrote: > Add an ofproto-level function to allow implementations to reject > specific action types based on internal implementation details. The > first user will be the next patch, which checks for datapath (kernel) > support for various aspect

Re: [ovs-dev] What should be the behavior of ovsdb_idl_add_table()?

2015-11-24 Thread Ben Pfaff
On Tue, Nov 24, 2015 at 05:08:38PM +, Aymerich, Edward wrote: > I was under the impression that ovsdb_idl_add_table() should replicate and > monitor all columns of the given table, so I don't > have to add each column individually. That's not what it does. It only makes the IDL track the row

Re: [ovs-dev] [PATCH 2/6 v2] datapath-windows: cleanup InitHvVportCommon()

2015-11-24 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju > Trimis: Wednesday, November 18, 2015 6:14 PM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH 2/6 v2] datapath-windows: cleanup > InitHvVportCommon() > > Th

Re: [ovs-dev] [PATCH 4/6 v2] datapath-windows: nuke port # argument in IP helper

2015-11-24 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju > Trimis: Wednesday, November 18, 2015 6:14 PM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH 4/6 v2] datapath-windows: nuke port # argument > in IP helper >

Re: [ovs-dev] [PATCH 5/6 v2] datapath-windows: cleanup AssignNicNameSpecial()

2015-11-24 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju > Trimis: Wednesday, November 18, 2015 6:14 PM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH 5/6 v2] datapath-windows: cleanup > AssignNicNameSpecial() > >

Re: [ovs-dev] [PATCH 6/6 v2] datapath-windows: Fix HvUpdateNic() to handle name changes

2015-11-24 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju > Trimis: Wednesday, November 18, 2015 6:14 PM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH 6/6 v2] datapath-windows: Fix HvUpdateNic() to > handle name ch

Re: [ovs-dev] [PATCH 1/6 v2] datapath-windows: refactor port enumeration code

2015-11-24 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju > Trimis: Wednesday, November 18, 2015 6:14 PM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH 1/6 v2] datapath-windows: refactor port > enumeration code > >

Re: [ovs-dev] [PATCH 3/6 v2] datapath-windows: cleanup events code

2015-11-24 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju > Trimis: Wednesday, November 18, 2015 6:14 PM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH 3/6 v2] datapath-windows: cleanup events code > > Turns out th

Re: [ovs-dev] [PATCH V2] bugfix of ovsdb-client connecting error when updating ca_crt.pem file many times

2015-11-24 Thread Ben Pfaff
On Mon, Nov 09, 2015 at 02:37:40AM +, Liuyongqiang (A) wrote: > From 84cba1149085a9c61fe622fc649db0e058355334 Mon Sep 17 00:00:00 2001 > From: YongQiangLiu > Date: Mon, 9 Nov 2015 09:49:47 +0800 > Subject: [PATCH] this patch fixed the bug of ovsdb-client connecting failed > when user update c

[ovs-dev] Cannot connect to vhost-user socket created on Openvswitch with DPDK

2015-11-24 Thread Ryan Yang
Hello All, I am trying to connect to vhost-user socket created on openvswitch with DPDK but kept receiving following error: error: internal error: process exited while connecting to monitor: 2015-11-25T19:19:02.192794Z qemu-kvm: -chardev socket,id=charnet2,path=/usr/local/var/run/openvswitch/vhos

Re: [ovs-dev] Questions about lrouter patch ports in ovn-nb schema

2015-11-24 Thread Ben Pfaff
On Sat, Nov 07, 2015 at 10:22:03PM -0800, Han Zhou wrote: > I noticed that the "mac" field of Logical_Router_Port must be set the same > as mac address in "addresses" field of the peer patch port in Logical_Port > table. At least this is what has been verified in my test setup and also in > ovn.at

[ovs-dev] (no subject)

2015-11-24 Thread dev-bounces
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v4] datapath: Add support for lwtunnel

2015-11-24 Thread Jesse Gross
On Tue, Nov 24, 2015 at 2:40 PM, Joe Stringer wrote: > On 23 November 2015 at 21:30, Pravin B Shelar wrote: >> Following patch adds support for lwtunnel to OVS datapath. >> With this change OVS datapath detect lwtunnel support and >> make use of new APIs if available. On older kernel where the >>

Re: [ovs-dev] [PATCH v3 1/2] ofproto: Allow xlate_actions() to fail.

2015-11-24 Thread Joe Stringer
On 24 November 2015 at 13:41, Jarno Rajahalme wrote: > Sometimes xlate_actions() fails due to too deep recursion, too many > MPLS labels, or missing recirculation context. Make xlate_actions() > clear out the produced odp actions in these cases to make it easy for > the caller to install a drop f

Re: [ovs-dev] [PATCH v2 2/2] ovs-ofctl: Support multiple tables in replace-flows and diff-flows.

2015-11-24 Thread Ben Pfaff
On Tue, Nov 24, 2015 at 10:21:41AM -0800, Jarno Rajahalme wrote: > > > On Nov 24, 2015, at 10:15 AM, Jarno Rajahalme wrote: > > > > > >> On Nov 24, 2015, at 9:40 AM, Jarno Rajahalme wrote: > >> > >> > >>> On Nov 24, 2015, at 9:25 AM, Ben Pfaff wrote: > >>> > >>> On Thu, Nov 19, 2015 at 01:

Re: [ovs-dev] [PATCH v2 2/2] ovs-ofctl: Support multiple tables in replace-flows and diff-flows.

2015-11-24 Thread Ben Pfaff
On Tue, Nov 24, 2015 at 10:15:57AM -0800, Jarno Rajahalme wrote: > > > On Nov 24, 2015, at 9:40 AM, Jarno Rajahalme wrote: > > > > > >> On Nov 24, 2015, at 9:25 AM, Ben Pfaff wrote: > >> However, for practically forever, OVS has had special extensions to > >> allow control over the table in wh

Re: [ovs-dev] [PATCH v2 2/2] ovs-ofctl: Support multiple tables in replace-flows and diff-flows.

2015-11-24 Thread Ben Pfaff
On Tue, Nov 24, 2015 at 09:40:20AM -0800, Jarno Rajahalme wrote: > > > On Nov 24, 2015, at 9:25 AM, Ben Pfaff wrote: > > > > On Thu, Nov 19, 2015 at 01:33:18PM -0800, Jarno Rajahalme wrote: > >> Currently ovs-ofctl replace-flows and diff-flows commands only support > >> flows in table 0. Extend

Re: [ovs-dev] [rhel --user 6/7] ovs-lib: add directory_check()

2015-11-24 Thread Andy Zhou
On Tue, Nov 24, 2015 at 3:34 PM, Ben Pfaff wrote: > On Thu, Nov 19, 2015 at 12:58:41PM -0800, Andy Zhou wrote: > > Rafactor common directory existence check and ownership check into > > a common function. Move daemon's default directory to $RUNDIR, since > > the process may not able to write core

Re: [ovs-dev] [PATCH] datapath/vport: Remove an invalid comment

2015-11-24 Thread Thadeu Lima de Souza Cascardo
On Tue, Nov 24, 2015 at 03:28:35PM -0500, Aaron Conole wrote: > Commit 3544358aa596 ("datapath: Improve kernel hash table") removed the > failure condition of ovs_vport_del by switching away from a custom > hashtable which allocated a new bucket, to an hlist with flexible-array > buckets. The funct

Re: [ovs-dev] [PATCH v2 2/8] ofproto: Enable in-place modification for recirc actions.

2015-11-24 Thread Ben Pfaff
On Tue, Nov 24, 2015 at 02:25:47PM -0800, Jarno Rajahalme wrote: > > > On Nov 24, 2015, at 1:53 PM, Ben Pfaff wrote: > > > > On Tue, Nov 24, 2015 at 01:10:35PM -0800, Jarno Rajahalme wrote: > >> > >>> On Nov 24, 2015, at 10:27 AM, Ben Pfaff wrote: > >>> > >>> On Fri, Nov 06, 2015 at 04:10:49P

Re: [ovs-dev] [PATCH V2] ovn: use name instead of uuid as key of logical router ports

2015-11-24 Thread Han Zhou
On Tue, Nov 24, 2015 at 9:50 AM, Ben Pfaff wrote: > On Sat, Nov 07, 2015 at 10:16:32PM -0800, Han Zhou wrote: >> Before this patch, logical switch ports were using name as key but >> logical router ports using uuid, which confuses user when trouble- >> shooting, and names of patch ports unreadable

Re: [ovs-dev] [PATCH v2] ovn: support ARP response for known IPs

2015-11-24 Thread Han Zhou
On Tue, Nov 24, 2015 at 9:54 AM, Ben Pfaff wrote: > On Thu, Nov 19, 2015 at 02:08:50PM -0800, Han Zhou wrote: >> For lswitch ports with known IPs, ARP is responded directly from >> local ovn-controller to avoid flooding. >> >> Signed-off-by: Han Zhou >> --- >> >> Notes: >> v1->v2: remove the

[ovs-dev] [PATCH v3] ovn: use name instead of uuid as key of logical router ports

2015-11-24 Thread Han Zhou
Before this patch, logical switch ports were using name as key but logical router ports using uuid, which confuses user when trouble- shooting, and names of patch ports unreadable. This patch unifies it by using "name" field also for logical router ports. Signed-off-by: Han Zhou --- Notes: v

Re: [ovs-dev] [rhel --user 7/7] rhel: run daemons as the ovs user

2015-11-24 Thread Ben Pfaff
On Thu, Nov 19, 2015 at 12:58:42PM -0800, Andy Zhou wrote: > Make RHEL systemd distributions start OVS and OVN daemons under user > ovs. The 'ovs' user and group will be created at the openvswitch RPM > installtion time. > > Signed-off-by: Andy Zhou I guess this hasn't attracted a review from a

Re: [ovs-dev] [rhel --user 6/7] ovs-lib: add directory_check()

2015-11-24 Thread Ben Pfaff
On Thu, Nov 19, 2015 at 12:58:41PM -0800, Andy Zhou wrote: > Rafactor common directory existence check and ownership check into > a common function. Move daemon's default directory to $RUNDIR, since > the process may not able to write core file to "/" anymore after the > user change. > > Signed-of

Re: [ovs-dev] [rhel --user 5/7] ovn: add --user option to ovn-ctl.

2015-11-24 Thread Ben Pfaff
On Thu, Nov 19, 2015 at 12:58:40PM -0800, Andy Zhou wrote: > ovs-ctl now takes --user option to start OVS daemons under the user > specified. This is a similar change in OVN to launch OVN daemons > under the specified user. > > Signed-off-by: Andy Zhou In two places in the documentation, I think

Re: [ovs-dev] [rhel --user 2/7] rhel: remove tabs from spec file

2015-11-24 Thread Ben Pfaff
On Thu, Nov 19, 2015 at 12:58:37PM -0800, Andy Zhou wrote: > From: Andy Zhou Might want to update the author of each commit. (You can use "git commit --amend --author='...'" or just "git citool"). > Change tabs in to spaces. No content change. > > Signed-off-by: Andy Zhou Acked-by: Ben Pfaff

Re: [ovs-dev] [rhel --user 1/7] ovs-ctl: Remove hard coded root user and group

2015-11-24 Thread Ben Pfaff
On Thu, Nov 19, 2015 at 12:58:36PM -0800, Andy Zhou wrote: > From: Andy Zhou > > Replace hard coded root user and group with OVS_USER and OVS_GROUP. > > Signed-off-by: Andy Zhou > Acked-by: Ansis Atteka > Acked-by: Ben Pfaff Acked-by: Ben Pfaff __

Re: [ovs-dev] [rhel --user 4/7] utilities: add --user option to ovs-ctl

2015-11-24 Thread Ben Pfaff
On Thu, Nov 19, 2015 at 12:58:39PM -0800, Andy Zhou wrote: > Allow ovs-ctl to take --user=USER option. When this option is specified > 'USER' will be parsed in the format of 'user:group" and be set into > shell variables $OVS_USER and $OVS_GROUP, which will be used > by shell functions, such as sta

Re: [ovs-dev] [rhel --user 3/7] utilities: fix ovsdb file ownership

2015-11-24 Thread Ben Pfaff
On Tue, Nov 24, 2015 at 03:02:08PM -0800, Andy Zhou wrote: > On Tue, Nov 24, 2015 at 2:19 PM, Ben Pfaff wrote: > > > On Thu, Nov 19, 2015 at 12:58:38PM -0800, Andy Zhou wrote: > > > Change ovsdb file ownership to match "$OVS_USER":"$OVS_GROUP" when > > > we either create it for the first time, or

Re: [ovs-dev] [rhel --user 3/7] utilities: fix ovsdb file ownership

2015-11-24 Thread Andy Zhou
On Tue, Nov 24, 2015 at 2:19 PM, Ben Pfaff wrote: > On Thu, Nov 19, 2015 at 12:58:38PM -0800, Andy Zhou wrote: > > Change ovsdb file ownership to match "$OVS_USER":"$OVS_GROUP" when > > we either create it for the first time, or upgrade it. > > > > Signed-off-by: Andy Zhou > > --- > > utilities

Re: [ovs-dev] [PATCH 20/23] system-traffic: Remove netcat from ICMP test.

2015-11-24 Thread Joe Stringer
On 24 November 2015 at 10:39, Daniele Di Proietto wrote: > Acked-by: Daniele Di Proietto Thanks for the review, I'll push this patch soon. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 22/23] system-traffic: Add internal port conntrack tests.

2015-11-24 Thread Joe Stringer
On 24 November 2015 at 10:49, Daniele Di Proietto wrote: > Small comments inline. Otherwise: > > Acked-by: Daniele Di Proietto > > Thanks for the test > > On 07/11/2015 12:00, "Joe Stringer" wrote: > >>Add an additional test that ensures that when receiving packets from >>internal ports that res

Re: [ovs-dev] [PATCH v4] datapath: Add support for lwtunnel

2015-11-24 Thread Joe Stringer
On 23 November 2015 at 21:30, Pravin B Shelar wrote: > Following patch adds support for lwtunnel to OVS datapath. > With this change OVS datapath detect lwtunnel support and > make use of new APIs if available. On older kernel where the > support is not there the backported tunnel modules are used

Re: [ovs-dev] [PATCH v2 2/8] ofproto: Enable in-place modification for recirc actions.

2015-11-24 Thread Jarno Rajahalme
> On Nov 24, 2015, at 1:53 PM, Ben Pfaff wrote: > > On Tue, Nov 24, 2015 at 01:10:35PM -0800, Jarno Rajahalme wrote: >> >>> On Nov 24, 2015, at 10:27 AM, Ben Pfaff wrote: >>> >>> On Fri, Nov 06, 2015 at 04:10:49PM -0800, Jarno Rajahalme wrote: When modifying an existing datapath flow wit

Re: [ovs-dev] [rhel --user 3/7] utilities: fix ovsdb file ownership

2015-11-24 Thread Ben Pfaff
On Thu, Nov 19, 2015 at 12:58:38PM -0800, Andy Zhou wrote: > Change ovsdb file ownership to match "$OVS_USER":"$OVS_GROUP" when > we either create it for the first time, or upgrade it. > > Signed-off-by: Andy Zhou > --- > utilities/ovs-lib.in | 4 > 1 file changed, 4 insertions(+) > > diff

[ovs-dev] [monitor2 v2 8/9] lib: add monitor2 support in ovsdb-idl.

2015-11-24 Thread Andy Zhou
From: Andy Zhou Add support for monitor2. When idl starts to run, monitor2 will be attempted first. In case the server is an older version that does not recognize monitor2. IDL will then fall back to use "monitor" method. Signed-off-by: Andy Zhou --- v1->v2: * extra check in error case:

[ovs-dev] [monitor2 v2 7/9] ovsdb-client: support monitor2

2015-11-24 Thread Andy Zhou
From: Andy Zhou Add monitor2 option to ovsdb-client. See ovsdb-client(1) manpage patch for details. Signed-off-by: Andy Zhou Acked-by: Ben Pfaff --- v1->v2: * style fixes --- ovsdb/monitor.h | 1 + ovsdb/ovsdb-client.1.in | 29 +++--- ovsdb/ovsdb-client.c| 148

[ovs-dev] [monitor2 v2 9/9] ovsdb: test ovs-vswitchd for backward compatibility

2015-11-24 Thread Andy Zhou
From: Andy Zhou Add test to make sure ovs-vswitchd fall back to use the "monitor" method when connecting to an older ovsdb-server that does not support "monitor2". For testing backward compatibility, add an ovs-appctl command: "ovsdb-server/disable-monitor2". This command will restart all curren

[ovs-dev] [monitor2 v2 6/9] ovsdb: enable jasonrpc-server to service monitor2 request

2015-11-24 Thread Andy Zhou
From: Andy Zhou ovsdb-server now accepts the new "monitor2" request. The next patch will switch IDL to use monitor2 by default. Signed-off-by: Andy Zhou Acked-by: Ben Pfaff --- v1->v2: update NEWS --- NEWS | 2 ++ ovsdb/jsonrpc-server.c | 39 ++

[ovs-dev] [monitor2 v2 4/9] lib: add diff and apply diff APIs for ovsdb_datum

2015-11-24 Thread Andy Zhou
From: Andy Zhou When an OVSDB column change its value, it is more efficient to only send what has changed, rather than sending the entire new copy. This is analogous to software programmer send patches rather than the entire source file. For columns store a single element, the "diff" datum is th

[ovs-dev] [monitor2 v2 5/9] ovsdb: generate update2 notification for a monitor2 session

2015-11-24 Thread Andy Zhou
From: Andy Zhou Add functions that can generate "update2" notification for a "monitor2" session. "monitor2" and "update2" are RFC 7047 extensions described by ovsdb-server(1) manpage. See the manpage changes for more details. Signed-off-by: Andy Zhou --- v1->v2: * remove ovsdb_monitor_compose_

[ovs-dev] [monitor2 v2 3/9] ovsdb-date.at: convert tabs into spaces

2015-11-24 Thread Andy Zhou
From: Andy Zhou No content change. Signed-off-by: Andy Zhou Acked-by: Ben Pfaff --- tests/ovsdb-data.at | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/tests/ovsdb-data.at b/tests/ovsdb-data.at index f44d6d4..ed8cb0e 100644 --- a/tests/ovsdb-da

[ovs-dev] [monitor2 v2 2/9] lib: avoid set size check when generating diff datum from json

2015-11-24 Thread Andy Zhou
From: Andy Zhou Added ovsdb_transient_datum_from_json() to avoid size check for the diff datum that is transient in nature. Suppose a datum contains set, and the max number of elements is 2. If we are changing from set that contains [A, B], to a set contains [C, D], the diff datum will contains 4

[ovs-dev] [monitor2 v2 1/9] ovsdb: refactor, add ovsdb_monitor_max_columns()

2015-11-24 Thread Andy Zhou
From: Andy Zhou This function will have multiple callers in later patches. Signed-off-by: Andy Zhou Acked-by: Ben Pfaff --- ovsdb/monitor.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/ovsdb/monitor.c b/ovsdb/monitor.c index 7805c60..daf69c

Re: [ovs-dev] [PATCH] vtep/vtep.xml - formatting

2015-11-24 Thread Bruce Davie
Looks fine to me. Acked-by: Bruce Davie > On Nov 20, 2015, at 2:09 PM, Ariel Tubaltsev wrote: > > We continue to review HW VTEP schema > This patch contains only cosmetical changes, to separate it from > semantical changes > > Signed-off-by: Ariel Tubaltsev > --- > vtep/vtep.xml | 22 ++

Re: [ovs-dev] [PATCH v2 2/8] ofproto: Enable in-place modification for recirc actions.

2015-11-24 Thread Ben Pfaff
On Tue, Nov 24, 2015 at 01:10:35PM -0800, Jarno Rajahalme wrote: > > > On Nov 24, 2015, at 10:27 AM, Ben Pfaff wrote: > > > > On Fri, Nov 06, 2015 at 04:10:49PM -0800, Jarno Rajahalme wrote: > >> When modifying an existing datapath flow with recirculation actions, > >> the references to old (if

Re: [ovs-dev] [PATCH v2 8/8] conntrack action: Add support for NAT.

2015-11-24 Thread Ben Pfaff
On Fri, Nov 06, 2015 at 04:10:55PM -0800, Jarno Rajahalme wrote: > Extend OVS conntrack interface to cover NAT. New nested nat action > may be included with a CT action. A bare nat action only mangles > existing connections. If a nat action with src or dst range attribute > is included, new (non

[ovs-dev] [PATCH v3] ovn: support ARP response for known IPs

2015-11-24 Thread Han Zhou
For lswitch ports with known IPs, ARP is responded directly from local ovn-controller to avoid flooding. Signed-off-by: Han Zhou --- Notes: v1->v2: remove the extra arg of xasprintf() v2->v3: update ovn-northd.8.xml to describe the new flows ovn/northd/ovn-northd.8.xml | 18 +++

[ovs-dev] [PATCH v3 1/2] ofproto: Allow xlate_actions() to fail.

2015-11-24 Thread Jarno Rajahalme
Sometimes xlate_actions() fails due to too deep recursion, too many MPLS labels, or missing recirculation context. Make xlate_actions() clear out the produced odp actions in these cases to make it easy for the caller to install a drop flow (instead or installing a flow with partially translated ac

[ovs-dev] [PATCH v3 2/2] ofproto: Enable in-place modification for recirc actions.

2015-11-24 Thread Jarno Rajahalme
When modifying an existing datapath flow with recirculation actions, the references to old (if any) recirculation actions need to be freed, and references to new recirculation actions need to be stored. Signed-off-by: Jarno Rajahalme Acked-by: Joe Stringer --- ofproto/ofproto-dpif-rid.h| 63

Re: [ovs-dev] [PATCH v2 1/8] ofproto: Allow xlate_actions() to fail.

2015-11-24 Thread Jarno Rajahalme
I’ll post a new version of this and the related next patch separately in a minute, Jarno > On Nov 24, 2015, at 11:26 AM, Jarno Rajahalme wrote: > > >> On Nov 24, 2015, at 10:17 AM, Ben Pfaff wrote: >> >> On Fri, Nov 06, 2015 at 04:10:48PM -0800, Jarno Rajahalme wrote: >>> Sometimes xlate_

Re: [ovs-dev] [PATCH v2 4/8] system-tests: Use '--bundle'

2015-11-24 Thread Jarno Rajahalme
> On Nov 24, 2015, at 10:33 AM, Ben Pfaff wrote: > > On Fri, Nov 06, 2015 at 04:10:51PM -0800, Jarno Rajahalme wrote: >> Use OpenFlow bundles for setting up flow tables. This has the benefit >> that when debugging test failures, no packet gets processed by >> partially set-up flow table, which

Re: [ovs-dev] [PATCH v2 3/8] system-tests: Make bridge creation more consistent.

2015-11-24 Thread Jarno Rajahalme
> On Nov 24, 2015, at 10:32 AM, Ben Pfaff wrote: > > On Fri, Nov 06, 2015 at 04:10:50PM -0800, Jarno Rajahalme wrote: >> Create all bridges with the same set of supported OpenFlow protocols >> and fail-safe-mode secure, so that each test explicitly specifies flow >> handling. >> >> Signed-off-b

Re: [ovs-dev] [PATCH v3] ovn: support ARP response for known IPs

2015-11-24 Thread Han Zhou
Sorry, please ignore this one because the v3 change was missing by format-patch. On Tue, Nov 24, 2015 at 1:23 PM, Han Zhou wrote: > For lswitch ports with known IPs, ARP is responded directly from > local ovn-controller to avoid flooding. > > Signed-off-by: Han Zhou > --- > > Notes: > v1->v2

[ovs-dev] [PATCH v3] ovn: support ARP response for known IPs

2015-11-24 Thread Han Zhou
For lswitch ports with known IPs, ARP is responded directly from local ovn-controller to avoid flooding. Signed-off-by: Han Zhou --- Notes: v1->v2: remove the extra arg of xasprintf() v2->v3: update ovn-northd.8.xml to describe the new flows ovn/northd/ovn-northd.c | 38 +++

Re: [ovs-dev] [PATCH v2 2/8] ofproto: Enable in-place modification for recirc actions.

2015-11-24 Thread Jarno Rajahalme
> On Nov 24, 2015, at 10:27 AM, Ben Pfaff wrote: > > On Fri, Nov 06, 2015 at 04:10:49PM -0800, Jarno Rajahalme wrote: >> When modifying an existing datapath flow with recirculation actions, >> the references to old (if any) recirculation actions need to be freed, >> and references to new recircu

[ovs-dev] [PATCH] datapath/vport: Remove an invalid comment

2015-11-24 Thread Aaron Conole
Commit 3544358aa596 ("datapath: Improve kernel hash table") removed the failure condition of ovs_vport_del by switching away from a custom hashtable which allocated a new bucket, to an hlist with flexible-array buckets. The function stopped returning failure code at that point, so remove the mislea

[ovs-dev] [PATCH] Vagrantfile: Update to Fedora 22 base box

2015-11-24 Thread Mark D. Gray
Fedora 20 base box is no longer available at chef/fedora20. Signed-off-by: Mark D. Gray --- Vagrantfile | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Vagrantfile b/Vagrantfile index e8c104d..102a17d 100644 --- a/Vagrantfile +++ b/Vagrantfile @@ -6,11 +6,11 @@ V

Re: [ovs-dev] [PATCH v2 1/8] ofproto: Allow xlate_actions() to fail.

2015-11-24 Thread Jarno Rajahalme
> On Nov 24, 2015, at 10:17 AM, Ben Pfaff wrote: > > On Fri, Nov 06, 2015 at 04:10:48PM -0800, Jarno Rajahalme wrote: >> Sometimes xlate_actions() fails due to too deep recursion, too many >> MPLS labels, or missing recirculation context. Make xlate_actions() >> fail in these circumstances, so

Re: [ovs-dev] [PATCH 22/23] system-traffic: Add internal port conntrack tests.

2015-11-24 Thread Daniele Di Proietto
Small comments inline. Otherwise: Acked-by: Daniele Di Proietto Thanks for the test On 07/11/2015 12:00, "Joe Stringer" wrote: >Add an additional test that ensures that when receiving packets from >internal ports that reside in a foreign namespace, the conntrack >information is not populated

Re: [ovs-dev] [PATCH v2 7/8] packets: Reorder CS_* flags to remove gap.

2015-11-24 Thread Ben Pfaff
On Fri, Nov 06, 2015 at 04:10:54PM -0800, Jarno Rajahalme wrote: > This changes the conntrack state flags used in the OpenFlow interface > to match the ones we currently use in the datapath. While these do > not need to be synced, it is nice to get rid of the gap. > > This should be merged before

Re: [ovs-dev] many patches of mine need review

2015-11-24 Thread Zoltan Kiss
On 24/11/15 17:06, Ben Pfaff wrote: On Tue, Nov 24, 2015 at 10:51:28AM +, Zoltan Kiss wrote: I've also have a question unanswered, but only for two weeks: http://openvswitch.org/pipermail/dev/2015-November/062039.html Probably you are the best person to answer it, I should have added you

Re: [ovs-dev] [PATCH 20/23] system-traffic: Remove netcat from ICMP test.

2015-11-24 Thread Daniele Di Proietto
Acked-by: Daniele Di Proietto On 07/11/2015 11:59, "Joe Stringer" wrote: >Netcat is different on each platform I tried (Debian, Ubuntu, RHEL), >so rather than handling version differences it's better to just do the >same test with some hardcoded packets. > >Signed-off-by: Joe Stringer >--- > t

Re: [ovs-dev] [PATCH v2 6/8] system-tests: Workaround for pyftpdlib bug handling IPv6 addresses.

2015-11-24 Thread Ben Pfaff
On Fri, Nov 06, 2015 at 04:10:53PM -0800, Jarno Rajahalme wrote: > Hack around a bug in pyftpdlib that rejects EPRT connection due to > mismatching textual representation of the IPv6 address when the > address is not in the normalized format. This happens when the > control connection is mangled b

Re: [ovs-dev] [PATCH v2 5/8] system-tests: Add IPv6 FTP system test.

2015-11-24 Thread Ben Pfaff
On Fri, Nov 06, 2015 at 04:10:52PM -0800, Jarno Rajahalme wrote: > Signed-off-by: Jarno Rajahalme I'll let someone who knows this part of the system better review this. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2 4/8] system-tests: Use '--bundle'

2015-11-24 Thread Ben Pfaff
On Fri, Nov 06, 2015 at 04:10:51PM -0800, Jarno Rajahalme wrote: > Use OpenFlow bundles for setting up flow tables. This has the benefit > that when debugging test failures, no packet gets processed by > partially set-up flow table, which may seem confusing. > > Signed-off-by: Jarno Rajahalme P

Re: [ovs-dev] [PATCH v2 3/8] system-tests: Make bridge creation more consistent.

2015-11-24 Thread Ben Pfaff
On Fri, Nov 06, 2015 at 04:10:50PM -0800, Jarno Rajahalme wrote: > Create all bridges with the same set of supported OpenFlow protocols > and fail-safe-mode secure, so that each test explicitly specifies flow > handling. > > Signed-off-by: Jarno Rajahalme This looks good to me but I'm no expert

Re: [ovs-dev] [PATCH v2 2/8] ofproto: Enable in-place modification for recirc actions.

2015-11-24 Thread Ben Pfaff
On Fri, Nov 06, 2015 at 04:10:49PM -0800, Jarno Rajahalme wrote: > When modifying an existing datapath flow with recirculation actions, > the references to old (if any) recirculation actions need to be freed, > and references to new recirculation actions need to be stored. > > Signed-off-by: Jarno

Re: [ovs-dev] [PATCH v2 00/11] Conntrack debugging appctl/dpctl

2015-11-24 Thread Joe Stringer
On 24 November 2015 at 10:20, Daniele Di Proietto wrote: > > On 24/11/2015 10:01, "Ben Pfaff" wrote: > >>On Thu, Nov 05, 2015 at 07:12:31PM -0800, Daniele Di Proietto wrote: >>> The goal of this series is to introduce two dpctl command to interact >>> with the Linux kernel connection tracker. Th

Re: [ovs-dev] [PATCH v2 2/2] ovs-ofctl: Support multiple tables in replace-flows and diff-flows.

2015-11-24 Thread Jarno Rajahalme
> On Nov 24, 2015, at 10:15 AM, Jarno Rajahalme wrote: > > >> On Nov 24, 2015, at 9:40 AM, Jarno Rajahalme wrote: >> >> >>> On Nov 24, 2015, at 9:25 AM, Ben Pfaff wrote: >>> >>> On Thu, Nov 19, 2015 at 01:33:18PM -0800, Jarno Rajahalme wrote: Currently ovs-ofctl replace-flows and diff

Re: [ovs-dev] [PATCH v2 00/11] Conntrack debugging appctl/dpctl

2015-11-24 Thread Daniele Di Proietto
On 24/11/2015 10:01, "Ben Pfaff" wrote: >On Thu, Nov 05, 2015 at 07:12:31PM -0800, Daniele Di Proietto wrote: >> The goal of this series is to introduce two dpctl command to interact >> with the Linux kernel connection tracker. The same infrastructure >> will be used by the userspace connection

Re: [ovs-dev] [PATCH v2 1/8] ofproto: Allow xlate_actions() to fail.

2015-11-24 Thread Ben Pfaff
On Fri, Nov 06, 2015 at 04:10:48PM -0800, Jarno Rajahalme wrote: > Sometimes xlate_actions() fails due to too deep recursion, too many > MPLS labels, or missing recirculation context. Make xlate_actions() > fail in these circumstances, so that we can install a drop flow > instead of a flow with pa

Re: [ovs-dev] [PATCH v2 2/2] ovs-ofctl: Support multiple tables in replace-flows and diff-flows.

2015-11-24 Thread Jarno Rajahalme
> On Nov 24, 2015, at 9:40 AM, Jarno Rajahalme wrote: > > >> On Nov 24, 2015, at 9:25 AM, Ben Pfaff wrote: >> >> On Thu, Nov 19, 2015 at 01:33:18PM -0800, Jarno Rajahalme wrote: >>> Currently ovs-ofctl replace-flows and diff-flows commands only support >>> flows in table 0. Extend this to co

Re: [ovs-dev] [PATCH v2 1/2] openflow: Remove OFPG11_*

2015-11-24 Thread Jarno Rajahalme
> On Nov 24, 2015, at 9:15 AM, Ben Pfaff wrote: > > On Thu, Nov 19, 2015 at 01:33:17PM -0800, Jarno Rajahalme wrote: >> Protocol-independent symbols OFPG_* were already defined in >> openflow-common.h, so remove the protocol version dependent symbols. >> >> Found by inspection. >> >> Signed-of

Re: [ovs-dev] [PATCH v2 00/11] Conntrack debugging appctl/dpctl

2015-11-24 Thread Ben Pfaff
On Thu, Nov 05, 2015 at 07:12:31PM -0800, Daniele Di Proietto wrote: > The goal of this series is to introduce two dpctl command to interact > with the Linux kernel connection tracker. The same infrastructure > will be used by the userspace connection tracker. > > First, it defines some structure

Re: [ovs-dev] [PATCH v2] ovn: support ARP response for known IPs

2015-11-24 Thread Ben Pfaff
On Thu, Nov 19, 2015 at 02:08:50PM -0800, Han Zhou wrote: > For lswitch ports with known IPs, ARP is responded directly from > local ovn-controller to avoid flooding. > > Signed-off-by: Han Zhou > --- > > Notes: > v1->v2: remove the extra arg of xasprintf() This seems reasonable but it shou

Re: [ovs-dev] [PATCH V2] ovn: use name instead of uuid as key of logical router ports

2015-11-24 Thread Ben Pfaff
On Sat, Nov 07, 2015 at 10:16:32PM -0800, Han Zhou wrote: > Before this patch, logical switch ports were using name as key but > logical router ports using uuid, which confuses user when trouble- > shooting, and names of patch ports unreadable. This patch unifies > it by using "name" field also for

Re: [ovs-dev] [PATCH v2 2/2] ovs-ofctl: Support multiple tables in replace-flows and diff-flows.

2015-11-24 Thread Jarno Rajahalme
> On Nov 24, 2015, at 9:25 AM, Ben Pfaff wrote: > > On Thu, Nov 19, 2015 at 01:33:18PM -0800, Jarno Rajahalme wrote: >> Currently ovs-ofctl replace-flows and diff-flows commands only support >> flows in table 0. Extend this to cover all possible tables. >> >> Signed-off-by: Jarno Rajahalme >

Re: [ovs-dev] [PATCH v2 2/2] ovs-ofctl: Support multiple tables in replace-flows and diff-flows.

2015-11-24 Thread Ben Pfaff
On Thu, Nov 19, 2015 at 01:33:18PM -0800, Jarno Rajahalme wrote: > Currently ovs-ofctl replace-flows and diff-flows commands only support > flows in table 0. Extend this to cover all possible tables. > > Signed-off-by: Jarno Rajahalme There's one oddity that may deserve consideration. It depen

Re: [ovs-dev] [PATCH v2 1/2] openflow: Remove OFPG11_*

2015-11-24 Thread Ben Pfaff
On Thu, Nov 19, 2015 at 01:33:17PM -0800, Jarno Rajahalme wrote: > Protocol-independent symbols OFPG_* were already defined in > openflow-common.h, so remove the protocol version dependent symbols. > > Found by inspection. > > Signed-off-by: Jarno Rajahalme Acked-by: Ben Pfaff

[ovs-dev] What should be the behavior of ovsdb_idl_add_table()?

2015-11-24 Thread Aymerich, Edward
I was under the impression that ovsdb_idl_add_table() should replicate and monitor all columns of the given table, so I don't have to add each column individually. But this is not working for me. Let's say that I have a table called 'Test', and this table has columns 'colA', 'colB' and 'colC'.

Re: [ovs-dev] many patches of mine need review

2015-11-24 Thread Ben Pfaff
On Tue, Nov 24, 2015 at 10:51:28AM +, Zoltan Kiss wrote: > I've also have a question unanswered, but only for two weeks: > > http://openvswitch.org/pipermail/dev/2015-November/062039.html > > Probably you are the best person to answer it, I should have added you Cc. I responded now, although

Re: [ovs-dev] PORTING.md: dpif's and wildcarding

2015-11-24 Thread Ben Pfaff
On Tue, Nov 10, 2015 at 04:29:47PM +, Zoltan Kiss wrote: > This documentation talks a great deal about porting strategies, and it > mentions that "Only an ofproto provider can take full advantage of hardware > with built-in support for wildcards" > I wonder if it's still true, as dpif providers

Re: [ovs-dev] Decoding packet_out message

2015-11-24 Thread Ben Pfaff
On Tue, Nov 24, 2015 at 02:30:13PM +0100, Alvaro Morales Vicente wrote: > I can get all the fields, except for the actions, with the po variable > (struct ofputil_packet_out) like po.packet_len, po.in_port… I have also > tried with ofpacts variable (struct ofpbuf) which creates a buffer to store >

[ovs-dev] Decoding packet_out message

2015-11-24 Thread Alvaro Morales Vicente
Hi All, I am really new in OVS. I have problems decoding an ofp_packet_out message that my virtual switch receives. Specifically, the packet_out message received from the controller is (I get this information from wireshark): -Header -Version: 0x01 -Type: Packet Out (CSM) (13) -L

[ovs-dev] [PATCH v5 3/3] Implement OFPT_TABLE_STATUS Message.

2015-11-24 Thread saloni . jain12
From: Saloni Jain On change in a table state, the controller needs to be informed with the OFPT_TABLE_STATUS message. The message is sent with reason OFPTR_VACANCY_DOWN or OFPTR_VACANCY_UP in case of change in remaining space eventually crossing any one of the threshold. Signed-off-by: Saloni Ja

[ovs-dev] [PATCH v5 2/3] Implement Vacancy Events for OFPMP_TABLE_DESC.

2015-11-24 Thread saloni . jain12
From: Saloni Jain This patch adds support for vacancy events in table-desc. ovs-ofctl -O OpenFlow14 dump-tables-desc -This command is enhanced to display the Vacancy Event configuration of the tables on a , which is set using the mod-table command. Signed-off-by: Saloni Jain Co-authored-by:

  1   2   >