[ovs-dev] Delivery reports about your e-mail

2016-01-05 Thread Returned mail
Dear user of openvswitch.org, We have detected that your account has been used to send a huge amount of spam during the last week. We suspect that your computer had been infected by a recent virus and now runs a trojaned proxy server. We recommend that you follow the instructions in the attachm

[ovs-dev] Delivery reports about your e-mail

2016-01-05 Thread Bounced mail
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] World largest meds reseller

2016-01-05 Thread Spencer
96 You get strength and passion! p{margin:10px 0;padding:0;} table{border-collapse:collapse;} h1,h2,h3,h4,h5,h6{display:block;margin:0;padding:0;} img,a img{border:0;height:auto;outline:none;text-decoration:none;} body,#bodyTable,#bodyCell{height:100%;margin:0;padding:0;width:100%;

Re: [ovs-dev] memory leak in recirc_state?

2016-01-05 Thread Ben Pfaff
Thanks. That was my experience also. I applied this to master and branch-2.5. I think that branch-2.4 has the same bug but the backport is not trivial and I do not know whether it is worthwhile. On Tue, Jan 05, 2016 at 05:22:24PM -0800, William Tu wrote: > Hi Ben, > > The patch works OK. It pa

Re: [ovs-dev] memory leak in recirc_state?

2016-01-05 Thread William Tu
Hi Ben, The patch works OK. It passes "make check" and "make check-valgrind" without reporting memory leaks. Thank you William On Tue, Jan 5, 2016 at 5:02 PM, William Tu wrote: > Hi Ben, > > Sure, I will test this fix. > > Regards, > William > > On Tue, Jan 5, 2016 at 4:55 PM, Ben Pfaff wrote

Re: [ovs-dev] [PATCH v3 1/1] python: Restrict line length to 79 chars.

2016-01-05 Thread Russell Bryant
On 01/05/2016 07:35 PM, Ben Pfaff wrote: > On Tue, Jan 05, 2016 at 06:27:19PM -0500, Russell Bryant wrote: >> Resolve pep8 error: >> >> E501 line too long (80 > 79 characters) >> >> Signed-off-by: Russell Bryant > > Acked-by: Ben Pfaff > Thanks, I pushed this to master. -- Russell Bryant _

Re: [ovs-dev] memory leak in recirc_state?

2016-01-05 Thread William Tu
Hi Ben, Sure, I will test this fix. Regards, William On Tue, Jan 5, 2016 at 4:55 PM, Ben Pfaff wrote: > Thanks. Would you mind testing this proposed fix? > http://openvswitch.org/pipermail/dev/2016-January/064070.html > > On Tue, Jan 05, 2016 at 11:32:48AM -0800, William Tu wrote: > >

Re: [ovs-dev] memory leak in recirc_state?

2016-01-05 Thread Ben Pfaff
Thanks. Would you mind testing this proposed fix? http://openvswitch.org/pipermail/dev/2016-January/064070.html On Tue, Jan 05, 2016 at 11:32:48AM -0800, William Tu wrote: > Hi Ben, > > These two tests generate the leak: > mpls_xlate > 381: MPLS xlate action > ofproto-dpif > 852:

[ovs-dev] [PATCH] ofproto-dpif-rid: Fix memory leak in recirc_state.

2016-01-05 Thread Ben Pfaff
recirc_state_clone() copies the stack and actions and nothing ever freed them. CC: Jarno Rajahalme CC: Andy Zhou Reported-by: William Tu Reported-at: http://openvswitch.org/pipermail/dev/2016-January/064040.html Signed-off-by: Ben Pfaff --- ofproto/ofproto-dpif-rid.c | 20 ++--

Re: [ovs-dev] [PATCH v3 1/1] python: Restrict line length to 79 chars.

2016-01-05 Thread Ben Pfaff
On Tue, Jan 05, 2016 at 06:27:19PM -0500, Russell Bryant wrote: > Resolve pep8 error: > > E501 line too long (80 > 79 characters) > > Signed-off-by: Russell Bryant Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/

[ovs-dev] [PATCH] ofproto-dpif-upcall: Avoid double-delete of ukeys.

2016-01-05 Thread Ben Pfaff
revalidate_sweep__() has two cases where it calls ukey_delete() to remove a ukey from the umap via cmap_remove(). The first case is a direct call to ukey_delete(), when !flow_exists. The second case is an indirect call via push_ukey_ops(), when result != UKEY_KEEP. If both of these conditions ar

[ovs-dev] [PATCH v3 1/1] python: Restrict line length to 79 chars.

2016-01-05 Thread Russell Bryant
Resolve pep8 error: E501 line too long (80 > 79 characters) Signed-off-by: Russell Bryant --- Makefile.am | 3 +-- python/build/nroff.py | 15 ++- python/ovs/db/idl.py | 6

[ovs-dev] [PATCH v3 0/1] Python style fixes and flake8 integration.

2016-01-05 Thread Russell Bryant
These patches originated in my Python 3 patch series, but seemed like a reasonable set to split out before revisiting a v2 of the Python 3 series. These patches integrate running of the 'flake8' tool into the build process. They resolve several Python style issues, and a few real bugs. v1->v2: -

Re: [ovs-dev] [PATCH 06/11] python: Restrict line length to 79 chars.

2016-01-05 Thread Russell Bryant
On Tuesday, January 5, 2016, Ben Pfaff wrote: > On Tue, Jan 05, 2016 at 02:58:59PM -0500, Russell Bryant wrote: > > Resolve pep8 error: > > > > E501 line too long (80 > 79 characters) > > > > Signed-off-by: Russell Bryant > > > I expected this to no longer update dirs.py and to effectively igno

Re: [ovs-dev] [PATCH v2 12/12] python: Resolve some indentation warnings.

2016-01-05 Thread Ben Pfaff
On Tue, Jan 05, 2016 at 02:59:05PM -0500, Russell Bryant wrote: > This patch resolves the following warnings from flake8: > > E111 indentation is not a multiple of four > E112 expected an indented block > E113 unexpected indentation > > It's critical to have correct indentation in Python code,

Re: [ovs-dev] [PATCH v2 06/12] python: Restrict line length to 79 chars.

2016-01-05 Thread Ben Pfaff
On Tue, Jan 05, 2016 at 02:58:59PM -0500, Russell Bryant wrote: > Resolve pep8 error: > > E501 line too long (80 > 79 characters) > > Signed-off-by: Russell Bryant I expected this to no longer update dirs.py and to effectively ignore the error in it by not checking dirs.py at all but only dir

Re: [ovs-dev] [PATCH v2 11/12] python: Add missing Apache License headers.

2016-01-05 Thread Ben Pfaff
On Tue, Jan 05, 2016 at 02:59:04PM -0500, Russell Bryant wrote: > Signed-off-by: Russell Bryant Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH monitor_cond 00/12] Implement conditional monitoring

2016-01-05 Thread Andy Zhou
On Tue, Jan 5, 2016 at 5:13 AM, Liran Schour wrote: > This patch series implements conditional monitoring by introducing an OVSDB > RFC extension with 2 new JSON-RPC methods: "monitor_cond" and > "monitor_cond_change". Specification of this extension is defined in the > ovsdb-server (1) man page.

[ovs-dev] [PATCH 2/3] rstp: fix memory leak reported by valgrind

2016-01-05 Thread William Tu
test case: 1650 RSTP Single bridge, call stacks hmap_insert_at (hmap.h:235) rstp_port_set_port_number__ (rstp.c:744) rstp_add_port (rstp.c:1164) new_bridge (test-rstp.c:123) test_rstp_main (test-rstp.c:514) ovstest_wrapper_test_rstp_main__ (test-rstp.c:714) ovs_cmdl_run_

[ovs-dev] [PATCH 3/3] ofproto: fix memory leak reported by valgrind

2016-01-05 Thread William Tu
Test case 757: ofproto - table description (OpenFlow 1.4) Call stacks: parse_ofp_table_vacancy (ofp-parse.c:896) parse_ofp_table_mod (ofp-parse.c:978) ofctl_mod_table (ovs-ofctl.c:2011) ovs_cmdl_run_command (command-line.c:121) main (ovs-ofctl.c:135) Reason: return without freei

[ovs-dev] [PATCH 1/3] ovs-ofctl: fix memory leak reported by valgrind

2016-01-05 Thread William Tu
Reported by 348: ovs-ofctl parse-flows (skb_priority) Reason: return without freeing memory Signed-off-by: William Tu Signed-off-by: Daniele Di Proietto Co-authored-by: Daniele Di Proietto --- lib/ofp-parse.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/ofp-parse

Re: [ovs-dev] [PATCH v2] CONTRIBUTING: Add example Submitted-at header.

2016-01-05 Thread Russell Bryant
On 01/05/2016 11:35 AM, Ben Pfaff wrote: > On Tue, Jan 05, 2016 at 09:39:43AM -0500, Russell Bryant wrote: >> Document a Submitted-at header to be used for GitHub pull request URLs, >> or any other case where a patch was submitted somewhere other than the >> OVS dev mailing list. >> >> Signed-off-b

[ovs-dev] [PATCH v2 07/12] python: Fix several pep8 whitespace errors.

2016-01-05 Thread Russell Bryant
Fix the following pep8 errors: E201 whitespace after '(' E203 whitespace before ',' E222 multiple spaces after operator E225 missing whitespace around operator E226 missing whitespace around arithmetic operator E231 missing whitespace after ':' E241 multiple spaces after ':' E251 u

[ovs-dev] [PATCH v2 09/12] python: Remove unnecessary semicolons and slashes.

2016-01-05 Thread Russell Bryant
Resolve the following flake8 errors: E703 statement ends with a semicolon E502 the backslash is redundant between brackets Also document the reamining flake8 errors that are still ignored. Signed-off-by: Russell Bryant Acked-by: Ben Pfaff --- Makefile.am

[ovs-dev] [PATCH v2 11/12] python: Add missing Apache License headers.

2016-01-05 Thread Russell Bryant
Signed-off-by: Russell Bryant --- python/ovs/dirs.py | 12 python/ovs/dirs.py.template | 12 python/ovstest/tests.py | 12 3 files changed, 36 insertions(+) diff --git a/python/ovs/dirs.py b/python/ovs/dirs.py index a805f0a..c67aecb 100644 ---

[ovs-dev] [PATCH v2 10/12] python: Inherit from object.

2016-01-05 Thread Russell Bryant
class Vlog now inherits from "object". This is a "new style" Python class, which isn't new at all at this point. This was introduced back in Python 2.2, and some Python 2 code won't work as expected without it. Signed-off-by: Russell Bryant Acked-by: Ben Pfaff --- python/ovs/vlog.py | 2 +- 1

[ovs-dev] [PATCH v2 12/12] python: Resolve some indentation warnings.

2016-01-05 Thread Russell Bryant
This patch resolves the following warnings from flake8: E111 indentation is not a multiple of four E112 expected an indented block E113 unexpected indentation It's critical to have correct indentation in Python code, so it seemed worth enabling these warnings. Signed-off-by: Russell Bryant -

[ovs-dev] [PATCH v2 08/12] python: Resolve a deprecation warning.

2016-01-05 Thread Russell Bryant
Resolve the following deprecation warning. This deprecation warning advises to use an alternative syntax which is also compatible with Python 3, where has_key() was removed. W601 .has_key() is deprecated, use 'in' Also fix this related error: E713 test for membership should be 'not in' Sig

[ovs-dev] [PATCH v2 06/12] python: Restrict line length to 79 chars.

2016-01-05 Thread Russell Bryant
Resolve pep8 error: E501 line too long (80 > 79 characters) Signed-off-by: Russell Bryant --- Makefile.am | 2 +- python/build/nroff.py | 15 ++- python/ovs/db/idl.py | 6 +

[ovs-dev] [PATCH v2 05/12] python: Resolve pep8 comparison errors.

2016-01-05 Thread Russell Bryant
Resolve pep8 errors: E711 comparison to None should be 'if cond is None:' The reason comparing against None with "is None" is preferred over "== None" is because a class can define its own equality operator and produce bizarre unexpected behavior. Using "is None" has a very explicit meaning th

[ovs-dev] [PATCH v2 04/12] python: Resolve pep8 blank line errors.

2016-01-05 Thread Russell Bryant
Resolve pep8 errors E302 and E303: E302 expected 2 blank lines, found 1 E303 too many blank lines (3) Signed-off-by: Russell Bryant Acked-by: Ben Pfaff --- Makefile.am | 2 +- ofproto/ipfix-gen-entities| 3 +++ python/

[ovs-dev] [PATCH v2 01/12] python: Run flake8 at build time.

2016-01-05 Thread Russell Bryant
If flake8 is installed, run it at build time. Similar to most Makefile targets, run it once and then only run again if the files change. flake8 is set to ignore all error and warning types that currently occur. Future patches will remove items from the ignore list as they are resolved. Signed-of

[ovs-dev] [PATCH v2 00/12] Python style fixes and flake8 integration.

2016-01-05 Thread Russell Bryant
These patches originated in my Python 3 patch series, but seemed like a reasonable set to split out before revisiting a v2 of the Python 3 series. These patches integrate running of the 'flake8' tool into the build process. They resolve several Python style issues, and a few real bugs. v1->v2: -

[ovs-dev] [PATCH v2 03/12] python: Fix invalid varable/function references.

2016-01-05 Thread Russell Bryant
This code referred to "rows" where it meant to refer to "fetched_rows". The patch resolves flake8 error: F821 undefined name 'rows' python/build/nroff.py used a function fatal() that was not defined, which raised the same type of error. Signed-off-by: Russell Bryant Acked-by: Ben Pfaff ---

[ovs-dev] [PATCH v2 02/12] python: Remove unused imports and variables.

2016-01-05 Thread Russell Bryant
This resolves the following flake8 error types: F841 local variable 'e' is assigned to but never used F401 'exceptions' imported but unused Signed-off-by: Russell Bryant Acked-by: Ben Pfaff --- Makefile.am | 2 +- debian/ovs-monitor-ipsec

Re: [ovs-dev] [PATCH 11/11] python: Add missing Apache License headers.

2016-01-05 Thread Russell Bryant
On 01/04/2016 07:45 PM, Ben Pfaff wrote: > On Tue, Dec 22, 2015 at 12:17:33PM -0500, Russell Bryant wrote: >> Signed-off-by: Russell Bryant > > Probably should add this to python/ovs/dirs.py.template instead of the > non-template version. > Thanks. I added this to the template version. I also

Re: [ovs-dev] [PATCH] ofp-util: Avoid use-after-free error in ofputil_append_meter_config()

2016-01-05 Thread Andy Zhou
Thanks! On Mon, Jan 4, 2016 at 5:14 PM, Ben Pfaff wrote: > On Mon, Jan 04, 2016 at 05:06:04PM -0800, Ben Pfaff wrote: > > On Wed, Dec 23, 2015 at 01:37:23PM -0800, Andy Zhou wrote: > > > On Wed, Dec 23, 2015 at 9:26 AM, Ben Pfaff wrote: > > > > > > > On Fri, Dec 18, 2015 at 02:51:43PM -0800, An

Re: [ovs-dev] [PATCH] openvswitch-switch.init: Redirect error to /dev/null.

2016-01-05 Thread Guru Shetty
On 5 January 2016 at 11:28, Ben Pfaff wrote: > On Tue, Jan 05, 2016 at 10:18:41AM -0800, Gurucharan Shetty wrote: > > The latest Open vSwitch kernel module from Upstream linux does not > > list "version". During debian package installation, we would see > > a non-harmful error in the log. This pa

Re: [ovs-dev] memory leak in recirc_state?

2016-01-05 Thread William Tu
Hi Ben, These two tests generate the leak: mpls_xlate 381: MPLS xlate action ofproto-dpif 852: ofproto-dpif - MPLS handling ==65139==by 0x4E1C83: xmemdup (util.c:134) ==65139==by 0x431044: recirc_state_clone (ofproto-dpif-rid.c:221) ==65139==by 0x431044: recirc_alloc_id__ (ofp

Re: [ovs-dev] [PATCH] openvswitch-switch.init: Redirect error to /dev/null.

2016-01-05 Thread Ben Pfaff
On Tue, Jan 05, 2016 at 10:18:41AM -0800, Gurucharan Shetty wrote: > The latest Open vSwitch kernel module from Upstream linux does not > list "version". During debian package installation, we would see > a non-harmful error in the log. This patch suppresses it. > > Signed-off-by: Gurucharan Shett

Re: [ovs-dev] [PATCH] openvswitch-switch.init: Redirect error to /dev/null.

2016-01-05 Thread Ben Pfaff
On Tue, Jan 05, 2016 at 10:18:41AM -0800, Gurucharan Shetty wrote: > The latest Open vSwitch kernel module from Upstream linux does not > list "version". During debian package installation, we would see > a non-harmful error in the log. This patch suppresses it. > > Signed-off-by: Gurucharan Shett

Re: [ovs-dev] memory leak in recirc_state?

2016-01-05 Thread Ben Pfaff
I think that recirc_run needs to be modified so that On Tue, Jan 05, 2016 at 06:40:23PM +, ChengChun Tu wrote: > Hi Ben, > > Yes, Valgrind testcase 381 reports leak and generates the call stack below: > I tried to debug it for a while but not able to understand it. Thanks, what's the name

Re: [ovs-dev] [PATCH 02/11] python: Remove unused imports and variables.

2016-01-05 Thread Ben Pfaff
On Tue, Jan 05, 2016 at 01:30:39PM -0500, Russell Bryant wrote: > On 01/04/2016 07:26 PM, Ben Pfaff wrote: > > On Tue, Dec 22, 2015 at 12:17:24PM -0500, Russell Bryant wrote: > >> This resolves the following flake8 error types: > >> > >> F841 local variable 'e' is assigned to but never used > >>

Re: [ovs-dev] [PATCH 06/11] python: Restrict line length to 79 chars.

2016-01-05 Thread Russell Bryant
On 01/04/2016 07:33 PM, Ben Pfaff wrote: > On Tue, Dec 22, 2015 at 12:17:28PM -0500, Russell Bryant wrote: >> Resolve pep8 error: >> >> E501 line too long (80 > 79 characters) >> >> Signed-off-by: Russell Bryant > > This modifies python/ovs/dirs.py, but that's generated by > dirs.py.template (y

[ovs-dev] [PATCH] utilities/ovs-vsctl.c: honor 'help' as ovs-ofctl and dpctl

2016-01-05 Thread Aaron Conole
Currently, ovs-ofctl and ovs-dpctl allow a 'help' keyword, in addition to -h and --help. However, ovs-vsctl does not honor the same 'help' keyword. This change adds a 'help' which redirects to usage(), bringing ovs-vsctl in line with ovs-ofctl and ovs-dpctl. Signed-off-by: Aaron Conole --- utili

Re: [ovs-dev] memory leak in recirc_state?

2016-01-05 Thread ChengChun Tu
Hi Ben, Yes, Valgrind testcase 381 reports leak and generates the call stack below: I tried to debug it for a while but not able to understand it. fun:malloc fun:xmalloc fun:ofpbuf_new fun:ofpbuf_new_with_headroom fun:ofpbuf_clone_data_with_headroom fun:ofpbuf_clone_with_headroom fun:rec

Re: [ovs-dev] [PATCH 02/11] python: Remove unused imports and variables.

2016-01-05 Thread Russell Bryant
On 01/04/2016 07:26 PM, Ben Pfaff wrote: > On Tue, Dec 22, 2015 at 12:17:24PM -0500, Russell Bryant wrote: >> This resolves the following flake8 error types: >> >> F841 local variable 'e' is assigned to but never used >> F401 'exceptions' imported but unused >> >> Signed-off-by: Russell Bryant

[ovs-dev] [PATCH] openvswitch-switch.init: Redirect error to /dev/null.

2016-01-05 Thread Gurucharan Shetty
The latest Open vSwitch kernel module from Upstream linux does not list "version". During debian package installation, we would see a non-harmful error in the log. This patch suppresses it. Signed-off-by: Gurucharan Shetty --- debian/openvswitch-switch.init | 13 + 1 file changed,

Re: [ovs-dev] [PATCH] debian: Move ovs-lib to openvswitch-common.

2016-01-05 Thread Guru Shetty
On 5 January 2016 at 09:39, Ben Pfaff wrote: > On Tue, Jan 05, 2016 at 09:10:35AM -0800, Gurucharan Shetty wrote: > > ovs-lib is used by both ovs-ctl and ovn-ctl. So it > > is useful to move it to openvswitch-common > > > > Signed-off-by: Gurucharan Shetty > > Acked-by: Ben Pfaff > Applied. th

[ovs-dev] memory leak in recirc_state?

2016-01-05 Thread Ben Pfaff
Looking at the recirculation code in ofproto-dpif-rid.c, I see code to copy the stack and the actions from one recirc_state to another in recirc_state_clone(), but I can't find any code that ever frees them. recirc_run(), for example, just does a plain (postponed) "free" of the recirc_id_node (whic

Re: [ovs-dev] OVS/OVN: Interface with NAT

2016-01-05 Thread Guru Shetty
Amitabha, I am looking at integrating NAT with OVN. I have a use case of Kubernetes. But the modeling should also work with OpenStack. So I would like to know a little bit about your plans around OpenStack + NAT with OVN. So if you are around, ping me at "shettyg" (openvswitch or openstack-neutron

Re: [ovs-dev] [PATCH] debian: Move ovs-lib to openvswitch-common.

2016-01-05 Thread Ben Pfaff
On Tue, Jan 05, 2016 at 09:10:35AM -0800, Gurucharan Shetty wrote: > ovs-lib is used by both ovs-ctl and ovn-ctl. So it > is useful to move it to openvswitch-common > > Signed-off-by: Gurucharan Shetty Acked-by: Ben Pfaff ___ dev mailing list dev@open

Re: [ovs-dev] [PATCH v2 2/5] debian: Add a package for OVN common components.

2016-01-05 Thread Guru Shetty
> > > > I still think we'll want to get rid of the dependency on > openvswitch-switch, but we can do that later. > > Acked-by: Ben Pfaff > Thanks. I pushed the series. I sent a patch which atleast removes openswitch-switch dependency from ovn-common ___

[ovs-dev] [PATCH] debian: Move ovs-lib to openvswitch-common.

2016-01-05 Thread Gurucharan Shetty
ovs-lib is used by both ovs-ctl and ovn-ctl. So it is useful to move it to openvswitch-common Signed-off-by: Gurucharan Shetty --- debian/control|3 +-- debian/openvswitch-common.install |1 + debian/openvswitch-switch.install |1 - 3 files changed, 2 insertions(+

Re: [ovs-dev] [PATCH v2 4/5] debian: Add a package for OVN central components.

2016-01-05 Thread Ben Pfaff
On Wed, Dec 16, 2015 at 02:47:10PM -0800, Gurucharan Shetty wrote: > Signed-off-by: Gurucharan Shetty Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2 5/5] debian: Add a package for OVN docker drivers.

2016-01-05 Thread Ben Pfaff
On Wed, Dec 16, 2015 at 02:47:11PM -0800, Gurucharan Shetty wrote: > Signed-off-by: Gurucharan Shetty > --- > v1-v2: change the name from openvswitch-ovn-docker to ovn-docker Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswit

Re: [ovs-dev] [PATCH v2 3/5] debian: Add a package for host components.

2016-01-05 Thread Ben Pfaff
On Wed, Dec 16, 2015 at 02:47:09PM -0800, Gurucharan Shetty wrote: > Signed-off-by: Gurucharan Shetty > --- > v1-v2: > change the name of package from openvswitch-ovn-controller to ovn-host Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org h

Re: [ovs-dev] [PATCH v2 2/5] debian: Add a package for OVN common components.

2016-01-05 Thread Ben Pfaff
On Wed, Dec 16, 2015 at 02:47:08PM -0800, Gurucharan Shetty wrote: > Signed-off-by: Gurucharan Shetty > --- > v1-v2: > change name of the package from openvswitch-ovn-common to ovn-common I still think we'll want to get rid of the dependency on openvswitch-switch, but we can do that later. Acked

Re: [ovs-dev] [PATCH 01/11] python: Run flake8 at build time.

2016-01-05 Thread Ben Pfaff
On Tue, Jan 05, 2016 at 11:23:24AM -0500, Russell Bryant wrote: > On 01/04/2016 07:23 PM, Ben Pfaff wrote: > > On Tue, Dec 22, 2015 at 12:17:23PM -0500, Russell Bryant wrote: > >> If flake8 is installed, run it at build time. Similar to most Makefile > >> targets, run it once and then only run aga

Re: [ovs-dev] [PATCH] ofp-util: Rearrange ofputil_append_meter_config() to be clearer.

2016-01-05 Thread Ben Pfaff
Thanks, applied to master. On Mon, Jan 04, 2016 at 05:18:21PM -0800, Justin Pettit wrote: > Acked-by: Justin Pettit > > --Justin > > > > On Jan 4, 2016, at 5:14 PM, Ben Pfaff wrote: > > > > The code is easier to reason about with all of the assignments to the > > members of 'reply' in one pl

Re: [ovs-dev] [PATCH v2] CONTRIBUTING: Add example Submitted-at header.

2016-01-05 Thread Ben Pfaff
On Tue, Jan 05, 2016 at 09:39:43AM -0500, Russell Bryant wrote: > Document a Submitted-at header to be used for GitHub pull request URLs, > or any other case where a patch was submitted somewhere other than the > OVS dev mailing list. > > Signed-off-by: Russell Bryant Acked-by: Ben Pfaff __

Re: [ovs-dev] [PATCH 01/11] python: Run flake8 at build time.

2016-01-05 Thread Russell Bryant
On 01/04/2016 07:23 PM, Ben Pfaff wrote: > On Tue, Dec 22, 2015 at 12:17:23PM -0500, Russell Bryant wrote: >> If flake8 is installed, run it at build time. Similar to most Makefile >> targets, run it once and then only run again if the files change. >> >> flake8 is set to ignore all error and warn

[ovs-dev] [PATCH v2] CONTRIBUTING: Add example Submitted-at header.

2016-01-05 Thread Russell Bryant
Document a Submitted-at header to be used for GitHub pull request URLs, or any other case where a patch was submitted somewhere other than the OVS dev mailing list. Signed-off-by: Russell Bryant --- CONTRIBUTING.md | 8 1 file changed, 8 insertions(+) diff --git a/CONTRIBUTING.md b/CON

Re: [ovs-dev] [PATCH] CONTRIBUTING: Add example GitHub-PR header.

2016-01-05 Thread Russell Bryant
On 01/04/2016 07:15 PM, Ben Pfaff wrote: > On Mon, Jan 04, 2016 at 04:04:18PM -0500, Russell Bryant wrote: >> I have used a GitHub-PR header to refer to the GitHub pull request where >> a patch originated in a couple of cases. This results in the commit >> getting automatically linked back to the

[ovs-dev] [PATCH 3/3] ovn: Qos options for VMI updated in ovn-nb.xml

2016-01-05 Thread bschanmu
Signed-off-by: Babu Shanmugam --- ovn/ovn-nb.xml | 17 + 1 file changed, 17 insertions(+) diff --git a/ovn/ovn-nb.xml b/ovn/ovn-nb.xml index ef34c9b..e0e9df6 100644 --- a/ovn/ovn-nb.xml +++ b/ovn/ovn-nb.xml @@ -182,6 +182,23 @@ Required. A logical switch name connecte

[ovs-dev] [PATCH 1/3] ovn: ovn-controller changes for qos settings

2016-01-05 Thread bschanmu
The qos settings are managed using the 'options' fields in the "Port_Binding" table. Signed-off-by: Babu Shanmugam --- ovn/controller/binding.c| 116 +++- ovn/controller/ovn-controller.c | 4 ++ 2 files changed, 118 insertions(+), 2 deletions(-) dif

[ovs-dev] [PATCH 2/3] ovn: Qos options for VMI updated in ovn-sb.xml

2016-01-05 Thread bschanmu
Signed-off-by: Babu Shanmugam --- ovn/ovn-sb.xml | 17 + 1 file changed, 17 insertions(+) diff --git a/ovn/ovn-sb.xml b/ovn/ovn-sb.xml index e674f3a..1ea35d5 100644 --- a/ovn/ovn-sb.xml +++ b/ovn/ovn-sb.xml @@ -1300,6 +1300,23 @@ tcp.flags = RST; + + +

[ovs-dev] [PATCH 0/3] QOS support in OVN

2016-01-05 Thread bschanmu
This patch series enables QOS support in OVN. Only two parameters (policing_rate and policing_burst) are enabled through this patch series. Babu Shanmugam (3): ovn: ovn-controller changes for qos settings ovn: Qos options for VMI updated in ovn-sb.xml ovn: Qos options for VMI updated in ovn-

[ovs-dev] [PATCH 0/3] QOS support in OVN

2016-01-05 Thread bschanmu
This patch series enables QOS support in OVN. Only two parameters (policing_rate and policing_burst) are enabled through this patch series. Babu Shanmugam (3): ovn: ovn-controller changes for qos settings ovn: Qos options for VMI updated in ovn-sb.xml ovn: Qos options for VMI updated in ovn-

[ovs-dev] [PATCH monitor_cond 02/12] ovsdb: add conditions utilities to support monitor_cond

2016-01-05 Thread Liran Schour
now is a 3-element json array or a boolean value, see ovsdb-server(1) man page. This functions will be used for conditional monitoring sessions. Signed-off-by: Liran Schour --- ovsdb/condition.c| 287 --- ovsdb/condition.h| 28 -

[ovs-dev] [PATCH monitor_cond 03/12] ovsdb: generate update notifications for monitor_cond session

2016-01-05 Thread Liran Schour
Hold session's conditions in ovsdb_monitor_session_conditon. Pass it to ovsdb_monitor for generating "update2" notifications. Add functions that can generate "update2" notification for a "monitor_cond" session. json_cache for will be enabled only for session's with empty condition. "monitor_cond" a

[ovs-dev] [PATCH monitor_cond 12/12] tests: add testing for idl conditional monitoring

2016-01-05 Thread Liran Schour
Testsing ovsdb-idl with condition change by "monitor_cond_change" method. Signed-off-by: Liran Schour --- tests/ovsdb-idl.at | 74 + tests/test-ovsdb.c | 52 - tests/test-ovsdb.py | 24 + 3

[ovs-dev] [PATCH monitor_cond 05/12] lib: replace monitor2 with monitor_cond

2016-01-05 Thread Liran Schour
Replace monitor2 with monitor_cond with empty condition. Signed-off-by: Liran Schour --- lib/ovsdb-idl.c| 28 ++-- ovsdb/jsonrpc-server.c | 14 +++--- ovsdb/jsonrpc-server.h | 2 +- ovsdb/ovsdb-client.c | 27 ++- ovsdb/ovsdb-serv

[ovs-dev] [PATCH monitor_cond 10/12] lib: add condition change to idl session

2016-01-05 Thread Liran Schour
Implement function for changing condition in an idl session. Signed-off-by: Liran Schour --- lib/ovsdb-idl-provider.h | 33 lib/ovsdb-idl.c | 393 ++- lib/ovsdb-idl.h | 13 ++ 3 files changed, 438 insertions(+), 1 deletion(-)

[ovs-dev] [PATCH monitor_cond 08/12] lib: add to ovsdb-idl monitor_id

2016-01-05 Thread Liran Schour
That will be used later to issue "monitor_cond_change" commands. Signed-off-by: Liran Schour --- lib/ovsdb-idl.c | 19 ++- lib/ovsdb-idl.h | 1 + 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c index f288e92..aed62a5 100644 --- a

[ovs-dev] [PATCH monitor_cond 07/12] ovsdb: enable jsonrpc-server to service "monitor_cond_change" request

2016-01-05 Thread Liran Schour
ovsdb-server now accepts "monitor_cond_change" request. On condition change we record all rows of table in a new changes list - OVSDB_MONITOR_ALL that are being indexed by the transaction-id at the moment of record. JSON cache is being used only for empty condition monitor sessions. Sees ovsdb-serv

[ovs-dev] [PATCH monitor_cond 11/12] python: move Python idl to work with monitor_cond

2016-01-05 Thread Liran Schour
Python idl works now with "monitor_cond" method. Add test for backward compatibility with old "monitor" method. Signed-off-by: Liran Schour --- python/ovs/db/data.py | 12 python/ovs/db/idl.py | 161 +++--- tests/ovsdb-idl.at| 97 ++

[ovs-dev] [PATCH monitor_cond 04/12] ovsdb-client: support monitor-cond

2016-01-05 Thread Liran Schour
Add monitor_cond method to ovsdb-client. Add unit tests. See ovsdb-client(1) man page for details. Signed-off-by: Liran Schour --- NEWS| 3 +- ovsdb/ovsdb-client.1.in | 37 +- ovsdb/ovsdb-client.c| 74 ++-- tests/ovsdb-monitor.at | 178 +++

[ovs-dev] [PATCH monitor_cond 06/12] ovsdb: add API for changing monitor session's conditions

2016-01-05 Thread Liran Schour
That will be used to by jsonrpc-server for monitor_cond_change method See ovsdb-server (1) man page. Signed-off-by: Liran Schour --- ovsdb/monitor.c | 52 +++- ovsdb/monitor.h | 7 +++ 2 files changed, 58 insertions(+), 1 deletion(-) diff --g

[ovs-dev] [PATCH monitor_cond 01/12] ovsdb: create column index mapping between ovsdb row to monitor row

2016-01-05 Thread Liran Schour
Indexing is different between ovsdb_row to ovsdb_monitor_row. To be able to evaluate conditions on ovsdb_monitor_row we need this mapping. signed-off-by: Liran Schour --- ovsdb/monitor.c | 17 + 1 file changed, 17 insertions(+) diff --git a/ovsdb/monitor.c b/ovsdb/monitor.c inde

[ovs-dev] [PATCH monitor_cond 09/12] ovsdb: look for monitor id on all jsonrpc monitor sessions

2016-01-05 Thread Liran Schour
That will be used later to issue "monitor_cond_change" command. Signed-off-by: Liran Schour --- ovsdb/jsonrpc-server.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/ovsdb/jsonrpc-server.c b/ovsdb/jsonrpc-server.c index ecaf379..2b7b4d1 100644 --- a/ovsdb/

[ovs-dev] [PATCH monitor_cond 00/12] Implement conditional monitoring

2016-01-05 Thread Liran Schour
This patch series implements conditional monitoring by introducing an OVSDB RFC extension with 2 new JSON-RPC methods: "monitor_cond" and "monitor_cond_change". Specification of this extension is defined in the ovsdb-server (1) man page. Monitor2 is now merged into monitor_cond. A monitor_cond sess

[ovs-dev] [PATCH v8] Implement OFPT_TABLE_STATUS Message.

2016-01-05 Thread saloni . jain12
From: Saloni Jain On change in a table state, the controller needs to be informed with the OFPT_TABLE_STATUS message. The message is sent with reason OFPTR_VACANCY_DOWN or OFPTR_VACANCY_UP in case of change in remaining space eventually crossing any one of the threshold. Signed-off-by: Saloni Ja

Re: [ovs-dev] [ovs-discuss] monitor2 support in python idl

2016-01-05 Thread Numan Siddique
On 01/05/2016 12:49 PM, Liran Schour wrote: >> From: Numan Siddique >> >> +dev list >> >> >> On 01/05/2016 01:11 AM, Russell Bryant wrote: >>> On 01/04/2016 10:29 AM, Numan Siddique wrote: Hi, I have started working on supporting the monitor2 support in python > idl. Please le

[ovs-dev] Delivery reports about your e-mail

2016-01-05 Thread The Post Office
Dear user dev@openvswitch.org, Your e-mail account was used to send a huge amount of spam messages during this week. We suspect that your computer had been infected and now contains a hidden proxy server. We recommend you to follow instruction in order to keep your computer safe. Have a nice d