Re: [ovs-dev] [PATCH monitor_cond V2 03/12] ovsdb: generate update notifications for monitor_cond session

On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > Hold session's conditions in ovsdb_monitor_session_conditon. Pass it > to ovsdb_monitor for generating "update2" notifications. > Add functions that can generate "update2" notification for a > "monitor_cond" session. >

[ovs-dev] [PATCH] netdev-dpdk: Add vhost-user multiqueue support

Most of the network cards today supports multiple receive and transmit queues (MQ). The core idea is that on packet reception, a NIC can send different packets to different queues to distribute processing among CPUs running in parallel. The packet distribution is based on a result of a filter

[ovs-dev] Returned mail: see transcript for details

Dear user of openvswitch.org, Your account was used to send a huge amount of spam messages during the last week. Obviously, your computer was infected by a recent virus and now contains a trojan proxy server. Please follow the instructions in order to keep your computer safe. Have a nice day,

Re: [ovs-dev] [PATCH monitor_cond V2 01/12] ovsdb: create column index mapping between ovsdb row to monitor row

Andy Zhou wrote on 21/01/2016 09:20:52 AM: > > Please also see my comments for the next patch. > > On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > Indexing is different between ovsdb_row to ovsdb_monitor_row. To be > able to evaluate conditions on

Re: [ovs-dev] [PATCH monitor_cond V2 02/12] ovsdb: add conditions utilities to support monitor_cond

Andy Zhou wrote on 21/01/2016 11:27:42 AM: > On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > now is a 3-element json array or a boolean value, see > ovsdb-server(1) man page. This functions will be used for > conditional monitoring sessions. > >

Re: [ovs-dev] [PATCH v2 1/2] ovn-nbctl: Help catch lport-set-addresses mistakes.

On 01/20/2016 05:43 PM, Ben Pfaff wrote: > On Wed, Jan 20, 2016 at 05:33:16PM -0500, Russell Bryant wrote: >> While debugging a broken OVN environment yesterday, the problem turned >> out to be invalid entries in the logical port addresses column. In >> particular, the following command had been

[ovs-dev] [PATCH RFC v3] dpif-netdev: Allow different numbers of rx queues for different ports.

Currently, all of the PMD netdevs can only have the same number of rx queues, which is specified in other_config:n-dpdk-rxqs. Fix that by introducing of new option for PMD interfaces: 'n_rxq', which specifies the maximum number of rx queues to be created for this interface. Example:

Re: [ovs-dev] [PATCH monitor_cond V2 02/12] ovsdb: add conditions utilities to support monitor_cond

On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > now is a 3-element json array or a boolean value, see > ovsdb-server(1) man page. This functions will be used for > conditional monitoring sessions. > > Signed-off-by: Liran Schour > --- >

Re: [ovs-dev] [PATCH] datapath-windows: Refactor sofware offloads and mss

Acked-by: Sorin Vinturis -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean Sent: Thursday, 21 January, 2016 04:17 To: dev@openvswitch.org Subject: [ovs-dev] [PATCH] datapath-windows: Refactor sofware offloads and

[ovs-dev] Returned mail: Data format error

The original message was received at Sun, 1 Jan 2006 01:59:37 +0530 from [197.144.121.169] - The following addresses had permanent fatal errors - dev@openvswitch.org - Transcript of session follows - ... while talking to openvswitch.org.: 550 5.1.2 ... Host

Re: [ovs-dev] [OVS-DPDK] Unable to successfully add IN port to datapath, failed to add port1 as port: Unknown error -19

> -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of beerappa s m > Sent: Wednesday, January 20, 2016 10:37 AM > To: 许志峰 > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [OVS-DPDK] Unable to successfully add IN port to > datapath, failed to add port1 as

Re: [ovs-dev] [PATCH RFC v2] dpif-netdev: Allow different numbers of rx queues for different ports.

Good point. I have multiple customer who are running OVS plus DPDK2.0 and they are waiting on OVS 2.5 to integrate DPDK 2.2 for Jumbo Frame support. If they don’t have it soon they have mentioned moving to Snabb vswitch or other options like Nuage VRS or Contrails vRouter... Eric

Re: [ovs-dev] [PATCH RFC v2] dpif-netdev: Allow different numbers of rx queues for different ports.

Thank you very much for review. New version posted. Best regards, Ilya Maximets. On 21.01.2016 02:26, Daniele Di Proietto wrote: > Hi Ilya, > > Thanks for the patch. I like the general approach and the implementation. > Couple of things: > > * This change should definitely be mentioned in

Re: [ovs-dev] [PATCH v6 0/4] Convert DPDK configuration from command line to DB based

Aaron Conole writes: > Currently, configuration of DPDK parameters is done via the command line > through a --dpdk **OPTIONS** -- command line argument. This has a number of > challenges, including: > * It must be the first option passed to ovs-vswitchd > * It breaks from the

Re: [ovs-dev] [PATCH v2 1/2] ovn-nbctl: Help catch lport-set-addresses mistakes.

On Thu, Jan 21, 2016 at 09:11:19AM -0500, Russell Bryant wrote: > On 01/20/2016 05:43 PM, Ben Pfaff wrote: > > On Wed, Jan 20, 2016 at 05:33:16PM -0500, Russell Bryant wrote: > >> While debugging a broken OVN environment yesterday, the problem turned > >> out to be invalid entries in the logical

Re: [ovs-dev] [PATCH v2 3/3] ovn: Fix localnet ports on the same chassis.

On Wed, Jan 20, 2016 at 10:40:56PM -0800, Han Zhou wrote: > On Wed, Jan 20, 2016 at 3:22 PM, Ben Pfaff wrote: > > > > On Wed, Jan 20, 2016 at 11:31:08AM -0500, Russell Bryant wrote: > > > Multiple logical ports on the same chassis that were connected to the > > > same physical

Re: [ovs-dev] [PATCH] netdev-dpdk: Add vhost-user multiqueue support

Sorry, please drop this patch since it is based on DPDK-2.2.0 and master currently requires DPDK-2.1.0. -- fbl On Thu, 21 Jan 2016 11:27:24 -0200 Flavio Leitner wrote: > Most of the network cards today supports multiple receive > and transmit queues (MQ). The core idea is

Re: [ovs-dev] [PATCH 40/41] ofproto-dpif-xlate: Put recirc_state, not recirc_id_node, in xlate_in.

I think I'd be more comfortable letting you figure that out, if that's OK, and just stick to the compromise we have here for the moment. On Wed, Jan 20, 2016 at 05:46:31PM -0800, Jarno Rajahalme wrote: > I did not look at the details yet, but basically the reference would be > released if gotten

Re: [ovs-dev] [PATCH v2 3/3] ovn: Fix localnet ports on the same chassis.

On 01/21/2016 11:04 AM, Ben Pfaff wrote: > The desired behavior for 'tag == 0' is to add two flows: > > * One that matches on a priority-tagged VLAN header and strips it. > > * One that matches on no VLAN header at all. > > I'm pretty sure that the existing code has this behavior

Re: [ovs-dev] [PATCH] ofp-util: Make decoding switch features harder to misuse (and fix leak).

We pull off the features to get at the port descriptors that follow them (which we pull in port_iterator_next()). On Thu, Jan 21, 2016 at 08:19:26AM -0800, William Tu wrote: > Hi Ben, > > in port_iterator_fetch_features, why do we need to decode/pull the feature > but later on never use it at

Re: [ovs-dev] [PATCH v2 1/3] ovn-controller: Update check for parent port.

On 01/20/2016 06:19 PM, Ben Pfaff wrote: > On Wed, Jan 20, 2016 at 11:31:06AM -0500, Russell Bryant wrote: >> There were a couple of checks that checked for a parent port as the >> field being non-NULL. We should treat an empty string the same as NULL >> for this field. >> >> Signed-off-by:

[ovs-dev] [PATCH v3] ovs-bugtool: Create OVN plugin and add output.

Three extra files will be generated when running ovs-bugtool - ovn-nbctl-show.out - ovn-sbctl-lflow-list.out - ovn-sbctl-show.out V3: - fix Copyright year to 2016 - remove extra blanks v2: - Start a new ovn/utilities/bugtool directory. - Add new ovn scripts and plugin, ovn.xml. - Apply

Re: [ovs-dev] [PATCH v3] ipv6 tunneling: Fix for performance drop introduced by ipv6 tunnel support.

On Tue, Jan 19, 2016 at 05:23:58PM +, Sugesh Chandran wrote: > Adding a new field called dl_type in flow tunnel structure to verify the > validity > of tunnel metadata. This field avoids the need of resetting and validating the > entire ipv4/ipv6 tunnel destination address which caused a

[ovs-dev] [PATCH] ovs-benchmark: fix return value of do_poll

A positive number is returned when do_poll successes. Signed-off-by: William Tu --- utilities/ovs-benchmark.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/utilities/ovs-benchmark.c b/utilities/ovs-benchmark.c index cfff413..ee593ff 100644

Re: [ovs-dev] will ovn support dynamic routing protocol

I'm having trouble understanding what's going on. The diagram you show, and the text below, talks about static routing. Where does dynamic routing come in? On Thu, Jan 21, 2016 at 12:46:24PM +0800, Shi Xin Ruan wrote: > Hi Ben, > > > Let me give example by neutron router because I am not very

Re: [ovs-dev] [PATCH] datapath: compat: Add NULL check for tun-dst.

On Wed, Jan 20, 2016 at 9:43 PM, Joe Stringer wrote: > On 20 January 2016 at 21:17, Pravin B Shelar wrote: >> tun-dst could be NULL in case of incorrect action list >> where set tunnel action is missing but packet is sent >> to tunnel vport. >> >> Signed-off-by:

[ovs-dev] [PATCH v2] travis: Install six Python library.

The travis-ci build is broken because the Python six library is not installed. Signed-off-by: Russell Bryant --- v1->v2: - use pip install --user option - disable pip version check - successfully tested on travis-ci this time .travis/prepare.sh | 1 + 1 file changed, 1

[ovs-dev] [PATCH] system-traffic: use appropriate nc options for installed version

The "conntrack - ICMP related with NAT" test case currently fails on systems using the nmap version of nc because this version does not support the -q command-line option. Fix this by detecting when the nmap version is in use and using the corresponding "--send-only" command-line option:

Re: [ovs-dev] [PATCH v8] Implement OFPT_TABLE_STATUS Message.

On Thu, Jan 14, 2016 at 05:56:02PM +0530, Saloni Jain wrote: > As per the Openflow Specification-1.4, Section: 7.4.3.1 Modify Flow Table > Message, Page:73,74: > > "When the remaining space in the flow table increases to more than > vacancy_up, and if vacancy up events are enabled, a vacancy up

Re: [ovs-dev] [PATCH] ofp-util: Make decoding switch features harder to misuse (and fix leak).

Hi Ben, in port_iterator_fetch_features, why do we need to decode/pull the feature but later on never use it at all? Thanks William @@ -865,8 +864,7 @@ port_iterator_fetch_features(struct port_iterator *pi) > } > > struct ofputil_switch_features features; > -enum ofperr error =

[ovs-dev] [PATCH v3] ovs-bugtool: Create OVN plugin and add output.

Create a new ovn/utilities/bugtool directory, add ovn.xml to bugtool plugins, and add ovn-nbctl show, ovn-sbctl show, and ovn-sbctl lflow-list. Signed-off-by: William Tu --- ovn/utilities/automake.mk | 2 ++ ovn/utilities/bugtool/automake.mk

Re: [ovs-dev] [PATCH v2] travis: Install six Python library.

On 21 January 2016 at 11:41, Russell Bryant wrote: > The travis-ci build is broken because the Python six library is not > installed. > > Signed-off-by: Russell Bryant Thanks, this fixes it for me. Acked-by: Joe Stringer

Re: [ovs-dev] [PATCH 1/8] netdev-vport: Factor-out tunnel Push-pop code into separate module.

On Sun, Jan 10, 2016 at 11:18 PM, Pravin B Shelar wrote: > new file mode 100644 > index 000..755b6c1 > --- /dev/null > +++ b/lib/netdev-vport-private.h [...] > +struct vport_class { > +const char *dpif_port; > +struct netdev_class netdev_class; > +}; Is this used

[ovs-dev] [RFC] ovn-controller: Only process lflows for local datapaths.

Previously, ovn-controller translated logical flows into OpenFlow flows for *every* logical datapath. This patch makes it so we skip doing so for the egress pipeline if the datapath is a logical switch with no logical ports bound locally. In that case, the flows have no effect. This was the

Re: [ovs-dev] [PATCH v2 3/3] ovn: Fix localnet ports on the same chassis.

On 01/20/2016 06:22 PM, Ben Pfaff wrote: > The new logic here in physical_run() looks wrong to me. I think that it > strips a vlan if it didn't match on one. > > if (tag) { > match_set_dl_vlan(, htons(tag)); > } else if (!strcmp(binding->type, "localnet"))

Re: [ovs-dev] [PATCH v2] travis: Install six Python library.

On 01/21/2016 03:35 PM, Joe Stringer wrote: > On 21 January 2016 at 11:41, Russell Bryant wrote: >> The travis-ci build is broken because the Python six library is not >> installed. >> >> Signed-off-by: Russell Bryant > > Thanks, this fixes it for me. > >

Re: [ovs-dev] [PATCH 40/41] ofproto-dpif-xlate: Put recirc_state, not recirc_id_node, in xlate_in.

Thanks. I applied this to master. On Thu, Jan 21, 2016 at 01:09:29PM -0800, Jarno Rajahalme wrote: > Sounds like a plan, > > Jarno > > > On Jan 21, 2016, at 8:42 AM, Ben Pfaff wrote: > > > > I think I'd be more comfortable letting you figure that out, if that's > > OK, and

Re: [ovs-dev] [PATCH 41/41] [RFC] Implement "closures".

On Wed, Jan 20, 2016 at 05:39:46PM -0800, Jarno Rajahalme wrote: > Not a full review, but see some comments below, > > And sorry for not snipping, but I felt like not cutting any context > when commenting an RFC patch. Sure. Thanks for reviewing it at all; I wasn't expecting this much feedback

Re: [ovs-dev] [PATCH v6 0/4] Convert DPDK configuration from command line to DB based

On Thu, Jan 21, 2016 at 09:59:22AM -0500, Aaron Conole wrote: > Aaron Conole writes: > > Currently, configuration of DPDK parameters is done via the command line > > through a --dpdk **OPTIONS** -- command line argument. This has a number of > > challenges, including: > > * It

Re: [ovs-dev] [PATCH 3/8] timeval: Factor out cycles_counter().

On Sun, Jan 10, 2016 at 11:18 PM, Pravin B Shelar wrote: > Used by STT tunnel. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross In general, I think it would be good to expand the commit messages in this series. Once this is

Re: [ovs-dev] [PATCH 5/8] netdev-vport: Make class init configurable.

On Sun, Jan 10, 2016 at 11:18 PM, Pravin B Shelar wrote: > Used by STT. > > Signed-off-by: Pravin B Shelar This looks fine but I wonder if it is better to do any necessary initialization at the time of the first port creation. The STT data structures are

Re: [ovs-dev] [PATCH 6/8] dp-packet: Add private data

On Sun, Jan 10, 2016 at 11:18 PM, Pravin B Shelar wrote: > This scratchpad can be used by any layer to keep private data. > STT will use it for TCP reassembly state. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross

Re: [ovs-dev] [PATCH] system-traffic: use appropriate nc options for installed version

> On Jan 21, 2016, at 1:19 PM, Joe Stringer wrote: > > On 21 January 2016 at 11:57, Lance Richardson wrote: >> The "conntrack - ICMP related with NAT" test case currently fails >> on systems using the nmap version of nc because this version >> does not

Re: [ovs-dev] [PATCH 2/8] tunnel: Add IP ECN related functions.

On Thu, Jan 21, 2016 at 1:50 PM, pravin shelar wrote: > On Thu, Jan 21, 2016 at 1:29 PM, Jesse Gross wrote: >> What about checking to see if the packet is originally ECT or even IP? >> It doesn't inherently have to be done in this function but skipping >> ahead

Re: [ovs-dev] [PATCH 4/8] netdev: Return number of packet from netdev_pop_header()

On Sun, Jan 10, 2016 at 11:18 PM, Pravin B Shelar wrote: > diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c > index c746cc2..215e9b6 100644 > --- a/lib/dpif-netdev.c > +++ b/lib/dpif-netdev.c > @@ -3529,8 +3528,12 @@ dp_execute_cb(void *aux_, struct dp_packet **packets, >

Re: [ovs-dev] [PATCH] system-traffic: use appropriate nc options for installed version

- Original Message - > > > On Jan 21, 2016, at 1:19 PM, Joe Stringer wrote: > > > > On 21 January 2016 at 11:57, Lance Richardson wrote: > >> The "conntrack - ICMP related with NAT" test case currently fails > >> on systems using the nmap version of

Re: [ovs-dev] [PATCHv2 branch2-4] rhel: provide our own SELinux custom policy package

On 01/20/2016 05:59 PM, Ansis Atteka wrote: > CentOS, RHEL and Fedora distributions ship with their own Open vSwitch > SELinux policy that is too strict and prevents Open vSwitch to work > normally out of the box. > > As a solution, this patch introduces a new package which will "loosen" > up

[ovs-dev] [PATCH] gitignore: Ignore flake8-check.

This is generated at build time and should not be part of the repo. Fixes: 115d8719dbfda (python: Run flake8 at build time.) Signed-off-by: Ben Pfaff --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 71bb21b..97af69a 100644 ---

Re: [ovs-dev] [PATCH 1/8] netdev-vport: Factor-out tunnel Push-pop code into separate module.

On Thu, Jan 21, 2016 at 12:56 PM, Jesse Gross wrote: > On Sun, Jan 10, 2016 at 11:18 PM, Pravin B Shelar wrote: >> new file mode 100644 >> index 000..755b6c1 >> --- /dev/null >> +++ b/lib/netdev-vport-private.h > [...] >> +struct vport_class { >> +

Re: [ovs-dev] [PATCH 1/8] netdev-vport: Factor-out tunnel Push-pop code into separate module.

On Thu, Jan 21, 2016 at 1:45 PM, pravin shelar wrote: > On Thu, Jan 21, 2016 at 12:56 PM, Jesse Gross wrote: >> On Sun, Jan 10, 2016 at 11:18 PM, Pravin B Shelar wrote: >>> new file mode 100644 >>> index 000..755b6c1 >>> --- /dev/null

Re: [ovs-dev] [PATCH 40/41] ofproto-dpif-xlate: Put recirc_state, not recirc_id_node, in xlate_in.

Sounds like a plan, Jarno > On Jan 21, 2016, at 8:42 AM, Ben Pfaff wrote: > > I think I'd be more comfortable letting you figure that out, if that's > OK, and just stick to the compromise we have here for the moment. > > On Wed, Jan 20, 2016 at 05:46:31PM -0800, Jarno

[ovs-dev] [PATCH v3 2/2] ovn: Fix localnet ports on the same chassis.

Multiple logical ports on the same chassis that were connected to the same physical network via localnet ports were not able to send packets to each other. This was because ovn-controller created a single patch port between br-int and the physical network access bridge and used it for all

[ovs-dev] [PATCH v3 1/2] ovn-controller: Move local_datapaths calculation.

Before this patch, physical.c build up the set of local datapaths for its own use. I'd like to use it in another module in a later patch, so pull it out of physical. It's now populated by the bindings module, since that seems like a more appropriate place to do it, and it's also done much

Re: [ovs-dev] [PATCH] system-traffic: use appropriate nc options for installed version

On 21 January 2016 at 11:57, Lance Richardson wrote: > The "conntrack - ICMP related with NAT" test case currently fails > on systems using the nmap version of nc because this version > does not support the -q command-line option. > > Fix this by detecting when the nmap

Re: [ovs-dev] [PATCH 2/8] tunnel: Add IP ECN related functions.

On Sun, Jan 10, 2016 at 11:18 PM, Pravin B Shelar wrote: > diff --git a/lib/packets.c b/lib/packets.c > index d82341d..a910f50 100644 > --- a/lib/packets.c > +++ b/lib/packets.c > +void > +IP_ECN_set_ce(struct dp_packet *pkt, bool is_ipv6) > +{ > +if (is_ipv6) { > +

Re: [ovs-dev] [PATCH monitor_cond V2 02/12] ovsdb: add conditions utilities to support monitor_cond

On Thu, Jan 21, 2016 at 4:41 AM, Liran Schour wrote: > Andy Zhou wrote on 21/01/2016 11:27:42 AM: > > On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour > wrote: > > > now is a 3-element json array or a boolean value, see > > ovsdb-server(1)

[ovs-dev] Be comfident ask for the salary you deserve with a Degree

EL0R'S, MASTER'S & DOCT0RATE DEGREES Add Bache1or's, Master's or Doctorate Degrees to your resume in just a few weeks and open avenues to promotion and better jobs! At your Own Pace! At your Own Schedule! At your Own Convenience! No Examination! No Study! No Class! Regardless of your age,

Re: [ovs-dev] [PATCH 2/8] tunnel: Add IP ECN related functions.

On Thu, Jan 21, 2016 at 1:29 PM, Jesse Gross wrote: > On Sun, Jan 10, 2016 at 11:18 PM, Pravin B Shelar wrote: >> diff --git a/lib/packets.c b/lib/packets.c >> index d82341d..a910f50 100644 >> --- a/lib/packets.c >> +++ b/lib/packets.c >> +void >>

Re: [ovs-dev] [PATCH v2 3/3] ovn: Fix localnet ports on the same chassis.

On Thu, Jan 21, 2016 at 03:30:50PM -0500, Russell Bryant wrote: > On 01/20/2016 06:22 PM, Ben Pfaff wrote: > > The new logic here in physical_run() looks wrong to me. I think that it > > strips a vlan if it didn't match on one. > > > > if (tag) { > >

Re: [ovs-dev] [PATCH monitor_cond V2 08/12] lib: add to ovsdb-idl monitor_id

On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > That will be used later to issue "monitor_cond_change" commands. > this commit message is not very helpful. > > Signed-off-by: Liran Schour > --- > lib/ovsdb-idl.c | 19 ++- >

Re: [ovs-dev] [PATCH v2 3/5] python: Convert dict iterators.

On 01/20/2016 06:26 PM, Ben Pfaff wrote: > Acked-by: Ben Pfaff Thanks, I pushed this patch to master. There's also a trivial patch #5 without a review, but I can also just include it as the first patch on the next series. -- Russell Bryant

Re: [ovs-dev] [PATCH] gitignore: Ignore flake8-check.

Thanks, applied to master. On Thu, Jan 21, 2016 at 07:22:00PM -0500, Russell Bryant wrote: > Acked-by: Russell Bryant > > On Thursday, January 21, 2016, Ben Pfaff wrote: > > > This is generated at build time and should not be part of the repo. > > > > Fixes:

Re: [ovs-dev] [PATCH monitor_cond V2 09/12] ovsdb: look for monitor id on all jsonrpc monitor sessions

On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > That will be used later to issue "monitor_cond_change" command. > > This commit message is the same as the last patch. I don't think it explains the reason for this patch. > Signed-off-by: Liran Schour

Re: [ovs-dev] [PATCH monitor_cond V2 11/12] python: move Python idl to work with monitor_cond

I am not much of a python person. Hope some one more knowledgable with python can review this. On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > Python idl works now with "monitor_cond" method. Add test > for backward compatibility with old "monitor" method. > >

Re: [ovs-dev] [PATCH monitor_cond V2 07/12] ovsdb: enable jsonrpc-server to service "monitor_cond_update" request

On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > ovsdb-server now accepts "monitor_cond_update" request. On conditions > update > we record all rows of table in a new changes list - OVSDB_MONITOR_ALL that > are > being indexed by the transaction-id at the moment of

Re: [ovs-dev] [PATCH RFC v3] dpif-netdev: Allow different numbers of rx queues for different ports.

On Thu, 21 Jan 2016 17:15:18 +0300 Ilya Maximets wrote: > Currently, all of the PMD netdevs can only have the same number of > rx queues, which is specified in other_config:n-dpdk-rxqs. > > Fix that by introducing of new option for PMD interfaces: 'n_rxq', > which

Re: [ovs-dev] [PATCH monitor_cond V2 10/12] lib: add monitor_cond_update to idl session

On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > Implement function for changing condition in an idl session. > > Signed-off-by: Liran Schour > Tabs are used in this file. > --- > lib/ovsdb-idl-provider.h | 33 > lib/ovsdb-idl.c |

Re: [ovs-dev] [PATCH] system-traffic: use appropriate nc options for installed version

On 21 January 2016 at 13:53, Lance Richardson wrote: > - Original Message - >> >> > On Jan 21, 2016, at 1:19 PM, Joe Stringer wrote: >> > >> > On 21 January 2016 at 11:57, Lance Richardson wrote: >> >> The "conntrack - ICMP related

Re: [ovs-dev] [PATCH monitor_cond V2 04/12] ovsdb-client: support monitor-cond

On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > Add monitor_cond method to ovsdb-client. Add unit tests. > See ovsdb-client(1) man page for details. > > Signed-off-by: Liran Schour > --- > NEWS| 3 +- > ovsdb/ovsdb-client.1.in

Re: [ovs-dev] [PATCH monitor_cond V2 06/12] ovsdb: add API for changing monitor session's conditions

On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > That will be used to by jsonrpc-server for monitor_cond_change > method See ovsdb-server (1) man page. > > Signed-off-by: Liran Schour > --- > ovsdb/monitor.c | 52

Re: [ovs-dev] [PATCH monitor_cond V2 11/12] python: move Python idl to work with monitor_cond

On 01/21/2016 10:58 PM, Andy Zhou wrote: > I am not much of a python person. Hope some one more knowledgable with > python can review this. I'm happy to do Python reviews. I'll have to catch up on how this feature works first so I probably won't have a proper review until next week. -- Russell

Re: [ovs-dev] [PATCH] gitignore: Ignore flake8-check.

Acked-by: Russell Bryant On Thursday, January 21, 2016, Ben Pfaff wrote: > This is generated at build time and should not be part of the repo. > > Fixes: 115d8719dbfda (python: Run flake8 at build time.) > Signed-off-by: Ben Pfaff > >

Re: [ovs-dev] [PATCH monitor_cond V2 05/12] lib: replace monitor2 with monitor_cond

I think this patch should be folded into the last one. On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > Replace monitor2 with monitor_cond with empty condition. > > Signed-off-by: Liran Schour > --- > lib/ovsdb-idl.c| 28

[ovs-dev] [PATCH v6 5/4] NEWS: Announce the DPDK EAL configuration change

Previous commits have converted dpdk EAL initialization from requiring a ``--dpdk ... --`` command line arguments to using the Open vSwitch database. This change announces that as significant NEWS. Signed-off-by: Aaron Conole --- NEWS | 4 1 file changed, 4

Re: [ovs-dev] [PATCH 1/8] netdev-vport: Factor-out tunnel Push-pop code into separate module.

On Thu, Jan 21, 2016 at 1:59 PM, Jesse Gross wrote: > On Thu, Jan 21, 2016 at 1:45 PM, pravin shelar wrote: >> On Thu, Jan 21, 2016 at 12:56 PM, Jesse Gross wrote: >>> On Sun, Jan 10, 2016 at 11:18 PM, Pravin B Shelar

Re: [ovs-dev] [PATCH 4/8] netdev: Return number of packet from netdev_pop_header()

On Thu, Jan 21, 2016 at 3:41 PM, Jesse Gross wrote: > On Sun, Jan 10, 2016 at 11:18 PM, Pravin B Shelar wrote: >> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c >> index c746cc2..215e9b6 100644 >> --- a/lib/dpif-netdev.c >> +++ b/lib/dpif-netdev.c >> @@

Re: [ovs-dev] [PATCH monitor_cond V2 11/12] python: move Python idl to work with monitor_cond

On Thu, Jan 21, 2016 at 8:04 PM, Russell Bryant wrote: > On 01/21/2016 10:58 PM, Andy Zhou wrote: > > I am not much of a python person. Hope some one more knowledgable with > > python can review this. > > I'm happy to do Python reviews. I'll have to catch up on how this >

Re: [ovs-dev] [PATCH RFC v3] dpif-netdev: Allow different numbers of rx queues for different ports.

On 22.01.2016 06:10, Flavio Leitner wrote: > My concern is that this can create some interesting issues like > having a port with N queues for RX/TX, but only one operating with > many streams because the receiving NIC is single queue. > > It also can create an unbalanced workload since you can

Re: [ovs-dev] [PATCH 5/8] netdev-vport: Make class init configurable.

On Thu, Jan 21, 2016 at 3:48 PM, Jesse Gross wrote: > On Sun, Jan 10, 2016 at 11:18 PM, Pravin B Shelar wrote: >> Used by STT. >> >> Signed-off-by: Pravin B Shelar > > This looks fine but I wonder if it is better to do any necessary >

Re: [ovs-dev] [PATCH v2 3/5] python: Convert dict iterators.

On Thu, Jan 21, 2016 at 11:01:42PM -0500, Russell Bryant wrote: > There's also a trivial patch #5 without a review, but I can also just > include it as the first patch on the next series. I read it and I thought I reviewed it. Let me try again. ___ dev

Re: [ovs-dev] [PATCH v2 5/5] python: Remove old style classes.

On Tue, Jan 12, 2016 at 02:45:49PM -0500, Russell Bryant wrote: > Python 3 removed support for "old-style classes". Classes should always > inherit from object to get consistent behavior between Python 2 and 3. > > Enable a flake8 warning to help prevent regressions in the future. > >

[ovs-dev] [PATCH] travis: Install six Python library.

The travis-ci build is broken because the Python six library is not installed. Signed-off-by: Russell Bryant --- .travis/prepare.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis/prepare.sh b/.travis/prepare.sh index cfc1b17..385849a 100755 --- a/.travis/prepare.sh