[ovs-dev] [PATCH v2 2/2] system-traffic: use appropriate nc options for installed version

2016-01-22 Thread Lance Richardson
Test cases using netcat ("ICMP related" and "ICMP related with NAT") currently fail on systems using the nmap version of nc because this version does not support the -q command-line option. Fix this by detecting which version of netcat is is in use and using the "--send-only" command-line option

[ovs-dev] Hitless resynchronisation of forwarding state

2016-01-22 Thread Zoltán Balogh
Dear OVS community, We have a proposal to add an extension to OVS which makes resynchronization of forwarding state between switch and controller simpler and faster. Jan Scheurich is a colleague of mine has prepared a google document describing the problem statement and giving a high-level

Re: [ovs-dev] [PATCH 7/8] tnl-ports: Handle STT ports.

2016-01-22 Thread pravin shelar
On Fri, Jan 22, 2016 at 11:51 AM, Jesse Gross wrote: > On Sun, Jan 10, 2016 at 11:18 PM, Pravin B Shelar wrote: >> diff --git a/lib/tnl-ports.c b/lib/tnl-ports.c >> index e7f2066..13d114d 100644 >> --- a/lib/tnl-ports.c >> +++ b/lib/tnl-ports.c >> @@ -95,24

[ovs-dev] [PATCH 1/1] ovsdb: fix typo in libovsdb's pkg-config

2016-01-22 Thread Ansari, Shad
Fix typo in the library name of pkg-config of libovsdb. Reported-by: Javier Albornz Signed-off-by: Shad Ansari --- ovsdb/libovsdb.pc.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovsdb/libovsdb.pc.in b/ovsdb/libovsdb.pc.in

[ovs-dev] [PATCH v2] test-ovsdb: fix memory leak reported by valgrind.

2016-01-22 Thread William Tu
Testcase 1311, 1312: Boolean-distinct queries on scalars, reports leak below: xmalloc (util.c:112) do_query_distinct (test-ovsdb.c:1208) ovs_cmdl_run_command (command-line.c:121) main (test-ovsdb.c:72) Signed-off-by: William Tu --- tests/test-ovsdb.c | 2 ++

Re: [ovs-dev] [PATCH 7/8] tnl-ports: Handle STT ports.

2016-01-22 Thread Jesse Gross
On Sun, Jan 10, 2016 at 11:18 PM, Pravin B Shelar wrote: > diff --git a/lib/tnl-ports.c b/lib/tnl-ports.c > index e7f2066..13d114d 100644 > --- a/lib/tnl-ports.c > +++ b/lib/tnl-ports.c > @@ -95,24 +96,28 @@ tnl_port_init_flow(struct flow *flow, struct eth_addr mac, > -if

Re: [ovs-dev] [PATCH 4/8] netdev: Return number of packet from netdev_pop_header()

2016-01-22 Thread Jesse Gross
On Thu, Jan 21, 2016 at 11:05 PM, pravin shelar wrote: > On Thu, Jan 21, 2016 at 3:41 PM, Jesse Gross wrote: >> On Sun, Jan 10, 2016 at 11:18 PM, Pravin B Shelar wrote: >>> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c >>> index

[ovs-dev] [PATCH] flake8: Fix use of --select and --ignore.

2016-01-22 Thread Russell Bryant
The flake8 command evolved over a series of patches and now includes the use of both --select and --ignore. Unfortunately, this wasn't doing what I thought. The use of --select completely overrides what --ignore does, meaning that we were only currently enforcing a small number of warnings

Re: [ovs-dev] [PATCH monitor_cond V2 05/12] lib: replace monitor2 with monitor_cond

2016-01-22 Thread Liran Schour
Andy Zhou wrote on 22/01/2016 03:34:49 AM: > > I think this patch should be folded into the last one. > Will do that. > On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > Replace monitor2 with monitor_cond with empty condition. > > Signed-off-by:

Re: [ovs-dev] [PATCH monitor_cond V2 11/12] python: move Python idl to work with monitor_cond

2016-01-22 Thread Liran Schour
Andy Zhou wrote on 22/01/2016 06:42:01 AM: > On Thu, Jan 21, 2016 at 8:04 PM, Russell Bryant wrote: > On 01/21/2016 10:58 PM, Andy Zhou wrote: > > I am not much of a python person. Hope some one more knowledgable with > > python can review this. > > I'm happy to

[ovs-dev] Message could not be delivered

2016-01-22 Thread Automatic Email Delivery Software
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH monitor_cond V2 08/12] lib: add to ovsdb-idl monitor_id

2016-01-22 Thread Liran Schour
Andy Zhou wrote on 22/01/2016 05:27:56 AM: > On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > That will be used later to issue "monitor_cond_change" commands. > > this commit message is not very helpful. > Will add a more comprehensive commit

Re: [ovs-dev] [PATCH monitor_cond V2 03/12] ovsdb: generate update notifications for monitor_cond session

2016-01-22 Thread Liran Schour
Andy Zhou wrote on 21/01/2016 02:03:51 PM: > On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > Hold session's conditions in ovsdb_monitor_session_conditon. Pass it > to ovsdb_monitor for generating "update2" notifications. > Add functions that can

Re: [ovs-dev] [PATCH v8] Implement OFPT_TABLE_STATUS Message.

2016-01-22 Thread Saloni Jain
Thanks. I have updated this in version v9. Thanks and Regards, Saloni Jain Tata Consultancy Services Mailto: saloni.j...@tcs.com Website: http://www.tcs.com Experience certainty. IT Services Business Solutions

Re: [ovs-dev] [PATCH monitor_cond V2 09/12] ovsdb: look for monitor id on all jsonrpc monitor sessions

2016-01-22 Thread Liran Schour
Andy Zhou wrote on 22/01/2016 05:33:49 AM: > On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > That will be used later to issue "monitor_cond_change" command. > This commit message is the same as the last patch. I don't think it > explains the reason

Re: [ovs-dev] [PATCH monitor_cond V2 06/12] ovsdb: add API for changing monitor session's conditions

2016-01-22 Thread Liran Schour
Andy Zhou wrote on 22/01/2016 04:09:47 AM: > On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > That will be used to by jsonrpc-server for monitor_cond_change > method See ovsdb-server (1) man page. > > Signed-off-by: Liran Schour >

Re: [ovs-dev] [PATCH monitor_cond V2 07/12] ovsdb: enable jsonrpc-server to service "monitor_cond_update" request

2016-01-22 Thread Liran Schour
Andy Zhou wrote on 22/01/2016 04:43:26 AM: > On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > ovsdb-server now accepts "monitor_cond_update" request. On conditions update > we record all rows of table in a new changes list - OVSDB_MONITOR_ALL that are

Re: [ovs-dev] [PATCH monitor_cond V2 10/12] lib: add monitor_cond_update to idl session

2016-01-22 Thread Liran Schour
Andy Zhou wrote on 22/01/2016 05:55:45 AM: > On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > Implement function for changing condition in an idl session. > > Signed-off-by: Liran Schour > > Tabs are used in this file. > Will

Re: [ovs-dev] [PATCH monitor_cond V2 02/12] ovsdb: add conditions utilities to support monitor_cond

2016-01-22 Thread Andy Zhou
On Fri, Jan 22, 2016 at 12:24 AM, Liran Schour wrote: > Andy Zhou wrote on 21/01/2016 11:32:54 PM: > > > On Thu, Jan 21, 2016 at 4:41 AM, Liran Schour wrote: > > Andy Zhou wrote on 21/01/2016 11:27:42 AM: > > > On Sat, Jan

Re: [ovs-dev] [PATCH monitor_cond V2 06/12] ovsdb: add API for changing monitor session's conditions

2016-01-22 Thread Andy Zhou
On Fri, Jan 22, 2016 at 1:41 AM, Liran Schour wrote: > Andy Zhou wrote on 22/01/2016 04:09:47 AM: > > > On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour > wrote: > > That will be used to by jsonrpc-server for monitor_cond_change > > method See

Re: [ovs-dev] [PATCH monitor_cond V2 08/12] lib: add to ovsdb-idl monitor_id

2016-01-22 Thread Andy Zhou
On Fri, Jan 22, 2016 at 1:59 AM, Liran Schour wrote: > Andy Zhou wrote on 22/01/2016 05:27:56 AM: > > > On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour > wrote: > > That will be used later to issue "monitor_cond_change" commands. > > > > this

[ovs-dev] cmap: discovering a cuckoo path

2016-01-22 Thread William Tu
Hi, I'm reading through the lib/cmap.c and I wonder if we need an extra lock at cmap_insert_bfs(). When cmap_insert_bfs() found a path and started to move all elements backward, it goes through the for loop below and calls cmap_set_bucket() one-by-one, and eventually place the new_node. However,

Re: [ovs-dev] cmap: discovering a cuckoo path

2016-01-22 Thread Ben Pfaff
On Fri, Jan 22, 2016 at 03:12:08PM -0800, William Tu wrote: > I'm reading through the lib/cmap.c and I wonder if we need an extra lock at > cmap_insert_bfs(). > > When cmap_insert_bfs() found a path and started to move all elements > backward, it goes through the for loop below and calls

Re: [ovs-dev] [PATCH monitor_cond V2 02/12] ovsdb: add conditions utilities to support monitor_cond

2016-01-22 Thread Liran Schour
Andy Zhou wrote on 21/01/2016 11:32:54 PM: > On Thu, Jan 21, 2016 at 4:41 AM, Liran Schour wrote: > Andy Zhou wrote on 21/01/2016 11:27:42 AM: > > On Sat, Jan 16, 2016 at 12:16 AM, Liran Schour wrote: > > > now is a

[ovs-dev] [PATCH v1] vtep: make vtep-ctl support L3 tables.

2016-01-22 Thread Wenyu Zhang
Add supporting for tables necessary for L3 usage: Logical_Router Arp_Sources_Local Arp_Sources_Remote Signed-off-by: Wenyu Zhang Acked-by: Shuangmin Zhang --- vtep/vtep-ctl.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git

[ovs-dev] [PATCH v9] Implement OFPT_TABLE_STATUS Message.

2016-01-22 Thread saloni . jain12
From: Saloni Jain On change in a table state, the controller needs to be informed with the OFPT_TABLE_STATUS message. The message is sent with reason OFPTR_VACANCY_DOWN or OFPTR_VACANCY_UP in case of change in remaining space eventually crossing any one of the threshold.

[ovs-dev] Mail System Error - Returned Mail

2016-01-22 Thread jodha
Message could not be delivered ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] Software vtep gw

2016-01-22 Thread Na Zhu
Dear, I need to do some experiment about ovn "vtep" schema, does anyone know software TOR which supports "vtep" schema? BR Juno ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] ofproto-dpif-xlate: Fix recirculation for resubmit to current table.

2016-01-22 Thread Ben Pfaff
When recirculation defers actions for processing later, it decides based on the actions being saved whether it needs to record the table and cookie from which they originated. Until now, it was thought that this was only important for actions that send packets to the controller (because those

[ovs-dev] Be competitave, get a Degree

2016-01-22 Thread Eve Booth
BECAUSE YOU DESERVE IT! Is your lack of a degree holding you back from career advancement? Are you having difficulty finding employment in your field of interest because you don’t have the paper to back it up – even though you are qualified? If you are looking for a fast and effective

Re: [ovs-dev] Software vtep gw

2016-01-22 Thread Na Zhu
That is what i want, thank you very much. 2016-01-22 23:41 GMT+08:00 Guru Shetty : > > https://github.com/openvswitch/ovs/blob/master/vtep/README.ovs-vtep.md > > On 22 January 2016 at 05:06, Na Zhu wrote: > >> Dear, >> >> I need to do some experiment about

Re: [ovs-dev] [PATCH v2 5/5] python: Remove old style classes.

2016-01-22 Thread Russell Bryant
On 01/22/2016 12:03 AM, Ben Pfaff wrote: > On Tue, Jan 12, 2016 at 02:45:49PM -0500, Russell Bryant wrote: >> Python 3 removed support for "old-style classes". Classes should always >> inherit from object to get consistent behavior between Python 2 and 3. >> >> Enable a flake8 warning to help

[ovs-dev] Right your own ticket with the Degree you diserve!

2016-01-22 Thread Sam Denny
Get a Degree in 5 weeks with our program! ~ Our program will let ANYONE with professional experience gain a Degree: ~ Doctorate ~ Bachelors ~ Masters Just think about it... Follow YOUR Dreams! Live a wonderful life by earning or upgrading your degree. This is a good chance to make a right move

Re: [ovs-dev] [PATCH] test-ovsdb: fix memory leak reported by valgrind.

2016-01-22 Thread Ben Pfaff
On Fri, Jan 22, 2016 at 08:29:27AM -0800, William Tu wrote: > Testcase 1311, 1312: Boolean-distinct queries on scalars, reports leak > below: > xmalloc (util.c:112) > do_query_distinct (test-ovsdb.c:1208) > ovs_cmdl_run_command (command-line.c:121) > main (test-ovsdb.c:72) > >

Re: [ovs-dev] [PATCH] test-ovsdb: fix memory leak reported by valgrind.

2016-01-22 Thread William Tu
I think so, too. However, valgrind does not report any leak related to 'classes'. So I don't have much confidence. On Fri, Jan 22, 2016 at 8:39 AM, Ben Pfaff wrote: > On Fri, Jan 22, 2016 at 08:29:27AM -0800, William Tu wrote: > > Testcase 1311, 1312: Boolean-distinct queries on

[ovs-dev] [PATCH] test-ovsdb: fix memory leak reported by valgrind.

2016-01-22 Thread William Tu
Testcase 1311, 1312: Boolean-distinct queries on scalars, reports leak below: xmalloc (util.c:112) do_query_distinct (test-ovsdb.c:1208) ovs_cmdl_run_command (command-line.c:121) main (test-ovsdb.c:72) Signed-off-by: William Tu --- tests/test-ovsdb.c | 1 + 1

[ovs-dev] [PATCH v2 0/2] system-traffic: use appropriate nc options for installed version

2016-01-22 Thread Lance Richardson
Test cases using netcat ("ICMP related" and "ICMP related with NAT") currently fail on systems using the nmap version of nc because this version does not support the -q command-line option. Fix this by detecting which version of netcat is is in use and using the "--send-only" command-line

[ovs-dev] ovn-northd: Logical_Port.port_addresses format

2016-01-22 Thread Numan Siddique
Hi All, I am working on the port security feature in ovn and implementing as per the port security proposal defined here [1]. If a logical port has one mac and multiple IP addresses (both ipv4 and ipv6), as per this proposal, Logical_Port.port_security will be defined as

[ovs-dev] [PATCH v2 1/2] Revert "system-traffic: Remove netcat from ICMP test."

2016-01-22 Thread Lance Richardson
Revert previous workaround for netcat portability issue. This reverts commit dc55e9465511dee6c12dbf0edb4ce2d9af57cb15. Signed-off-by: Lance Richardson --- tests/system-traffic.at | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git

Re: [ovs-dev] Software vtep gw

2016-01-22 Thread Guru Shetty
https://github.com/openvswitch/ovs/blob/master/vtep/README.ovs-vtep.md On 22 January 2016 at 05:06, Na Zhu wrote: > Dear, > > I need to do some experiment about ovn "vtep" schema, does anyone know > software TOR which supports "vtep" schema? > > > > BR > Juno >

Re: [ovs-dev] [PATCH] netdev-dpdk: Add vhost-user multiqueue support

2016-01-22 Thread Traynor, Kevin
> -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Flavio Leitner > Sent: Thursday, January 21, 2016 1:27 PM > To: dev@openvswitch.org > Cc: Flavio Leitner > Subject: [ovs-dev] [PATCH] netdev-dpdk: Add vhost-user multiqueue support > > Most of the network

Re: [ovs-dev] Hitless resynchronisation of forwarding state

2016-01-22 Thread Ben Pfaff
On Fri, Jan 22, 2016 at 03:32:21PM +, Zoltán Balogh wrote: > We have a proposal to add an extension to OVS which makes > resynchronization of forwarding state between switch and controller > simpler and faster. There are already multiple ways that one can atomically replace the contents of

Re: [ovs-dev] [PATCH] test-ovsdb: fix memory leak reported by valgrind.

2016-01-22 Thread Ben Pfaff
I'd go ahead and free it. If we're wrong, valgrind will tell us about the invalid free. On Fri, Jan 22, 2016 at 08:45:28AM -0800, William Tu wrote: > I think so, too. > However, valgrind does not report any leak related to 'classes'. So I don't > have much confidence. > > On Fri, Jan 22, 2016

Re: [ovs-dev] [PATCH] test-ovsdb: fix memory leak reported by valgrind.

2016-01-22 Thread William Tu
thanks, I will resubmit the patch. On Fri, Jan 22, 2016 at 9:31 AM, Ben Pfaff wrote: > I'd go ahead and free it. If we're wrong, valgrind will tell us about > the invalid free. > > On Fri, Jan 22, 2016 at 08:45:28AM -0800, William Tu wrote: > > I think so, too. > > However,

Re: [ovs-dev] ovn-northd: Logical_Port.port_addresses format

2016-01-22 Thread Han Zhou
On Fri, Jan 22, 2016 at 7:06 AM, Numan Siddique wrote: > > Hi All, > > I am working on the port security feature in ovn and implementing as per the port security proposal defined here [1]. > > If a logical port has one mac and multiple IP addresses (both ipv4 and ipv6), as

[ovs-dev] [PATCH 06/11] python: Drop use of sys.maxint.

2016-01-22 Thread Russell Bryant
sys.maxint does not exist in Python 3, as an int does not have a max value anymore (except as limited by implementation details and system resources). sys.maxsize works as a reasonable substitute as it's the same as sys.maxint. The Python 3.0 release notes have this to say: The sys.maxint

[ovs-dev] [PATCH 11/11] python: Deal with str and byte differences.

2016-01-22 Thread Russell Bryant
Python 3 has separate types for strings and bytes. Python 2 used the same type for both. We need to convert strings to bytes before writing them out to a socket. We also need to convert data read from the socket to a string. Signed-off-by: Russell Bryant ---

[ovs-dev] [PATCH 02/11] python: Drop unicode type.

2016-01-22 Thread Russell Bryant
Python 2 had str and unicode. Python 3 only has str, which is always a unicode string. Drop use of unicode with the help of six.text_type (unicode in py2 and str in py3) and six.string_types ([str, unicode] in py2 and [str] in py3). Signed-off-by: Russell Bryant ---

[ovs-dev] [PATCH 09/11] python: Don't compare None and int.

2016-01-22 Thread Russell Bryant
Comparing None to an integer worked in Python 2, but fails in Python 3. Signed-off-by: Russell Bryant --- python/ovs/reconnect.py | 2 +- tests/test-reconnect.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/python/ovs/reconnect.py

[ovs-dev] [PATCH 07/11] python: Use six.unichr().

2016-01-22 Thread Russell Bryant
six.unichr() is equivalent to unichr() in Python 2 and chr() in Python 3. Signed-off-by: Russell Bryant --- python/ovs/json.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/ovs/json.py b/python/ovs/json.py index a59a0c2..db74397 100644 ---

[ovs-dev] [PATCH 05/11] python: Don't use StringIO directly.

2016-01-22 Thread Russell Bryant
StringIO.StringIO in Python 2 became io.StringIO in Python 3. Use six.StringIO which is an alias for the two cases. Signed-off-by: Russell Bryant --- python/ovs/json.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/python/ovs/json.py

[ovs-dev] [PATCH 01/11] python: Drop usage of long type.

2016-01-22 Thread Russell Bryant
Python 2 has both long and int types. Python 3 only has int, which behaves like long. In the case of needing a set of integer types, we can use six.integer_types which includes int and long for Python 2 and just int for Python 3. We can convert all cases of long(value) to int(value), because as

[ovs-dev] [PATCH 03/11] python: Drop use of types.StringTypes.

2016-01-22 Thread Russell Bryant
types.StringTypes does not exist in Python 3. We can use six.string_types, instead. Signed-off-by: Russell Bryant --- python/ovs/unixctl/__init__.py | 4 +++- python/ovs/unixctl/client.py | 5 +++-- python/ovs/unixctl/server.py | 3 +-- 3 files changed, 7 insertions(+), 5

[ovs-dev] [PATCH 08/11] python: Remove reamining direct type comparisons.

2016-01-22 Thread Russell Bryant
I've hit several bugs in this Python 3 work where the fix was some code needed to be converted to use isinstance(). This has been primarily around deadling with the changes to unicode handling. Go ahead and convert the rest of the direct type comparisons to use isinstance(), as it could avoid a

[ovs-dev] [PATCH 04/11] python: Drop use of types.FunctionType.

2016-01-22 Thread Russell Bryant
This code asserted that the callback argument was of type types.FunctionType. It's more pythonic to just check that the argument is callable, and not specifically that it's a function. There are other ways to implement a callback than types.FunctionType. Signed-off-by: Russell Bryant

[ovs-dev] [PATCH 10/11] python: Fix object comparisons in Python 3.

2016-01-22 Thread Russell Bryant
Python 3 no longer supports __cmp__. Instead, we have to implement the "rich comparison" operators. We implement __eq__ and __lt__ and use functools.total_ordering to implement the rest. In one case, no __cmp__ method was provided and instead relied on the default behavior provided in Python 2.

[ovs-dev] [PATCH 00/11] Python 3, continued ...

2016-01-22 Thread Russell Bryant
This is another series of Python 3 compatibility fixes. All tests continue to pass with Python 2 with these changes applied. There will be one more patch series after this one which primarily refactors the test suite to run Python tests with both Python 2 and 3. Russell Bryant (11): python:

Re: [ovs-dev] [PATCH v2 1/2] dpif-netdev: Rework of rx queue management.

2016-01-22 Thread Daniele Di Proietto
Hi Ilya, Thank you very much for the patch. I definitely like that the queue assignment is performed by the main thread: not only is less bug-prone, but the logic will be more easily customizable. I absolutely welcome the changes to do_add_port and do_del_port to keep the queues to the