Re: [ovs-dev] [PATCH V6] Add Passive TCP connection to IDL.

2016-02-26 Thread Ben Pfaff
On Wed, Feb 24, 2016 at 08:39:02AM +, Ofer Ben-Yacov wrote: > The current implementation IDL is: > 1. connects to the OVSDB > 2. get the schema and > 3. disconnect > 4. connect again to work with the OVSDB server. I don't understand--where do you see that behavior? I can't spot it anywhere.

Re: [ovs-dev] [RFC] OVN: Support Static Route

2016-02-26 Thread Ben Pfaff
This message is formed as if it were a patch, but no patch was included. Was there supposed to be a patch? ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 3/3] testsuite: Add delay after ovs-vswitchd killing.

2016-02-26 Thread Ben Pfaff
On Fri, Feb 26, 2016 at 02:53:35PM -0800, Joe Stringer wrote: > On 26 February 2016 at 03:57, Ilya Maximets wrote: > > Fixes failure of test due to not yet fully destroyed ports from > > previous test if ovs-vswitchd was killed. > > > > Example: > > > >

Re: [ovs-dev] [PATCH 1/3] system-traffic.at: Skip tests if namespaces or veths aren't supported.

2016-02-26 Thread Ben Pfaff
On Fri, Feb 26, 2016 at 02:57:39PM +0300, Ilya Maximets wrote: > This prevents failure of test scenarios 'make check-kernel' > and 'make check-system-userspace' if creation of veth pairs or > network namespaces is not supported by kernel (or module isn't loaded). > > Signed-off-by: Ilya Maximets

Re: [ovs-dev] [PATCH 2/3] testsuite: Add timeout to add_of_br() command.

2016-02-26 Thread Ben Pfaff
On Fri, Feb 26, 2016 at 02:57:40PM +0300, Ilya Maximets wrote: > Fixes hang of testsuite on ovs-vswitchd failure. > > Signed-off-by: Ilya Maximets Applied, thanks. ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] [PATCH] Clean code in netlink-socket

2016-02-26 Thread Ben Pfaff
On Fri, Feb 26, 2016 at 02:10:12PM +, Alin Serdean wrote: > Found by inspection. > > Signed-off-by: Alin Gabriel Serdean Applied to master, thanks. ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] [PATCH] ovn: Suppport ct_mark/ct_label in lflow matches.

2016-02-26 Thread Ben Pfaff
On Thu, Feb 25, 2016 at 11:01:19PM -0500, Russell Bryant wrote: > From: Russell Bryant > > Add support for matching on ct_mark and ct_label in OVN logical flows. > > Signed-off-by: Russell Bryant Acked-by: Ben Pfaff

Re: [ovs-dev] [PATCH] ofp: Add support for bundles extension in OpenFlow 1.3.

2016-02-26 Thread Ben Pfaff
On Thu, Feb 25, 2016 at 01:20:17PM -0800, Jarno Rajahalme wrote: > ONF Extension 230 adds support for OpenFlow 1.4 bundles to OpenFlow > 1.3. Supporting this allows OpenFlow 1.3 controllers to start using > bundles. Also the ovs-ofctl '--bundle' option can now be used with > OpenFlow 1.3. > >

Re: [ovs-dev] [PATCH] odp-util: Use FLOW_MAX_MPLS_LABELS when parsing MPLS ODP keys.

2016-02-26 Thread Ben Pfaff
On Thu, Feb 25, 2016 at 01:20:16PM -0800, Jarno Rajahalme wrote: > Even though the number of supported MPLS labels may vary between a > datapath and the OVS userspace, it is better to use the > FLOW_MAX_MPLS_LABELS than a hard-coded '3' as the maximum number of > labels to scan. > > Requested-by:

Re: [ovs-dev] [PATCH 2/2] ovsdb-server: Refactoring and clean up remote status reporting.

2016-02-26 Thread Ben Pfaff
On Wed, Feb 24, 2016 at 01:27:34PM -0800, Andy Zhou wrote: > When reporting remote status, A listening remote will randomly > pick a session and report its session status. This does not seem > to make much sense. It is probably better to leave those fields > untouched. > > Update

Re: [ovs-dev] [PATCH 1/2] ovsdb: fix a typo in ovs-vswitchd.conf.db(5).

2016-02-26 Thread Ben Pfaff
On Wed, Feb 24, 2016 at 01:27:33PM -0800, Andy Zhou wrote: > Signed-off-by: Andy Zhou Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v7 1/2] ovn: Avoid ARP responder for packets from localnet port

2016-02-26 Thread Ben Pfaff
On Thu, Feb 25, 2016 at 08:49:45PM -0800, Han Zhou wrote: > This is required by next commit that allows lswitch with localnet > port to be attached to multiple chassises. Without this patch, if > an ARP request comes from localnet port, on each chassis there will > be an ARP response, which is not

Re: [ovs-dev] fedora: include ovs-save file in the rpm package

2016-02-26 Thread Ansis Atteka
On 23 February 2016 at 13:15, Ben Pfaff wrote: > On Sat, Feb 13, 2016 at 01:56:01PM -0800, Ansis Atteka wrote: > > Otherwise, "ovs-ctl force-reload-kmod ..." command fails with: > > > > Detected internal interfaces: br-int p1[ OK ] > > Saving flows

Re: [ovs-dev] [PATCH] ofp-parse: Remove unneeded #include.

2016-02-26 Thread Ben Pfaff
On Fri, Feb 26, 2016 at 03:32:07PM -0800, Justin Pettit wrote: > > > On Feb 26, 2016, at 2:42 PM, Ben Pfaff wrote: > > > > Signed-off-by: Ben Pfaff > > Acked-by: Justin Pettit Thanks, applied to master.

Re: [ovs-dev] [PATCH] ofp-parse: Remove unneeded #include.

2016-02-26 Thread Justin Pettit
> On Feb 26, 2016, at 2:42 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 0/9] RFC: rework code base for third-party linking

2016-02-26 Thread Ben Pfaff
On Fri, Feb 26, 2016 at 03:16:07PM -0800, Ben Warren wrote: > > On Feb 26, 2016, at 2:32 PM, Ben Pfaff wrote: > > > > On Mon, Feb 22, 2016 at 03:46:50PM -0800, b...@skyportsystems.com wrote: > >> From: Ben Warren > >> > >> This patch set is a first stab

Re: [ovs-dev] [PATCH 0/9] RFC: rework code base for third-party linking

2016-02-26 Thread Ben Warren
Hi Ben, > On Feb 26, 2016, at 2:32 PM, Ben Pfaff wrote: > > On Mon, Feb 22, 2016 at 03:46:50PM -0800, b...@skyportsystems.com wrote: >> From: Ben Warren >> >> This patch set is a first stab at making a 'dev' distribution for OpenVswitch >> The goal is to

Re: [ovs-dev] [PATCH v2 1/2] datapath: Drop support for kernel older than 3.10

2016-02-26 Thread pravin shelar
On Thu, Feb 25, 2016 at 2:20 PM, Jesse Gross wrote: > On Tue, Feb 23, 2016 at 9:01 PM, Pravin B Shelar wrote: >> diff --git a/FAQ.md b/FAQ.md >> index 8bd7ab9..8e0a775 100644 >> --- a/FAQ.md >> +++ b/FAQ.md >> @@ -157,6 +157,7 @@ A: The following table lists

Re: [ovs-dev] [PATCH 3/3] testsuite: Add delay after ovs-vswitchd killing.

2016-02-26 Thread Joe Stringer
On 26 February 2016 at 03:57, Ilya Maximets wrote: > Fixes failure of test due to not yet fully destroyed ports from > previous test if ovs-vswitchd was killed. > > Example: > > netdev_linux|WARN|br0: creating tap device failed: Device or resource busy > bridge|WARN|could

Re: [ovs-dev] Implementation of Packet-Out in Bundles

2016-02-26 Thread Ben Pfaff
Tests like the ones in ofproto.at, which test functionality, are more important than the ones in ofp-print.at, which test message decoding and printing, but it's best to have both. On Fri, Feb 26, 2016 at 09:57:48PM +, André Mantas wrote: > Ok, makes sense. So I should focus on making similar

Re: [ovs-dev] Query regarding the implementation of Packet Type aware pipeline [EXT-112]

2016-02-26 Thread Ben Pfaff
On Fri, Feb 26, 2016 at 02:29:28PM -0800, Jean Tourrilhes wrote: > On Fri, Feb 26, 2016 at 12:38:05PM -0800, Ben Pfaff wrote: > > > > I had to look up EXT-427 to find out what we're talking about. EXT-427 > > extends OFPT_PACKET_OUT in OF1.5 to allow the controller to specify the > > values of

[ovs-dev] [PATCH] ofp-parse: Remove unneeded #include.

2016-02-26 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/ofp-parse.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/ofp-parse.h b/lib/ofp-parse.h index a1c147b..e1ebee7 100644 --- a/lib/ofp-parse.h +++ b/lib/ofp-parse.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2010, 2011, 2012,

Re: [ovs-dev] [PATCH] thread: Keep openvswitch/thread.h #includes more contained within include/.

2016-02-26 Thread Ben Pfaff
On Fri, Feb 26, 2016 at 02:26:47PM -0800, Justin Pettit wrote: > > > On Feb 26, 2016, at 2:25 PM, Ben Pfaff wrote: > > > > It's better if the "include" directory is self-contained to the extent > > possible. > > > > Signed-off-by: Ben Pfaff > > Acked-by: Justin

Re: [ovs-dev] [PATCH] rhel: provide our own SELinux custom policy package

2016-02-26 Thread Ansis Atteka
On 22 February 2016 at 20:18, Flavio Leitner wrote: > On Mon, 15 Feb 2016 17:40:25 -0800 > Ansis Atteka wrote: > > > From: Ansis Atteka > > > > CentOS, RHEL and Fedora distributions ship with their own Open vSwitch > > SELinux

Re: [ovs-dev] [PATCH 0/9] RFC: rework code base for third-party linking

2016-02-26 Thread Ben Pfaff
On Mon, Feb 22, 2016 at 03:46:50PM -0800, b...@skyportsystems.com wrote: > From: Ben Warren > > This patch set is a first stab at making a 'dev' distribution for OpenVswitch > The goal is to provide shared libraries and header files so that third party > applications can

Re: [ovs-dev] Query regarding the implementation of Packet Type aware pipeline [EXT-112]

2016-02-26 Thread Jean Tourrilhes
On Fri, Feb 26, 2016 at 12:38:05PM -0800, Ben Pfaff wrote: > > I had to look up EXT-427 to find out what we're talking about. EXT-427 > extends OFPT_PACKET_OUT in OF1.5 to allow the controller to specify the > values of arbitrary metadata fields. Yes, this would be valuable and > I'd be happy

Re: [ovs-dev] [PATCH] thread: Keep openvswitch/thread.h #includes more contained within include/.

2016-02-26 Thread Justin Pettit
> On Feb 26, 2016, at 2:25 PM, Ben Pfaff wrote: > > It's better if the "include" directory is self-contained to the extent > possible. > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin

[ovs-dev] [PATCH] thread: Keep openvswitch/thread.h #includes more contained within include/.

2016-02-26 Thread Ben Pfaff
It's better if the "include" directory is self-contained to the extent possible. Signed-off-by: Ben Pfaff --- include/openvswitch/thread.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/openvswitch/thread.h b/include/openvswitch/thread.h index

Re: [ovs-dev] Implementation of Packet-Out in Bundles

2016-02-26 Thread André Mantas
Ok, makes sense. So I should focus on making similar tests to the ones in ofproto.at? Or these are also important? Thanks. Ben Pfaff escreveu no dia sexta, 26/02/2016 às 20:35: > On Fri, Feb 26, 2016 at 08:07:32PM +, André Mantas wrote: > > I've seen some examples in

Re: [ovs-dev] [PATCH v7 1/2] ovn: Avoid ARP responder for packets from localnet port

2016-02-26 Thread Russell Bryant
On Fri, Feb 26, 2016 at 12:06 PM, Han Zhou wrote: > > > On Fri, Feb 26, 2016 at 7:59 AM, Russell Bryant wrote: > > > > > > > > On Thu, Feb 25, 2016 at 11:26 PM, Han Zhou wrote: > >> > >> This is required by next commit that allows lswitch

Re: [ovs-dev] [PATCH 0/9] RFC: rework code base for third-party linking

2016-02-26 Thread Ben Pfaff
On Mon, Feb 22, 2016 at 03:46:50PM -0800, b...@skyportsystems.com wrote: > - There may not seem to be much rhyme or reason as to the ordering of #include > directives in source files. My OCD pushes me towards always using a > particular > pattern, usually alphabetic with files in directories

Re: [ovs-dev] [Partial-Update-Map-Columns 0/7] Add Initial code for Partia-map-columns funtionality

2016-02-26 Thread Ben Pfaff
On Mon, Feb 22, 2016 at 07:58:16PM +, Lutz, Arnoldo wrote: > In the current implementation, every time an element of either a map or > set column has to be modified, the entire content of the column is > sent to the server to be updated. This is not a major problem if the > information

Re: [ovs-dev] [PATCH 4/7] Add and correct functionality of Partial Update Map Columns

2016-02-26 Thread Ben Pfaff
On Fri, Feb 26, 2016 at 01:06:59PM -0800, Ben Pfaff wrote: > On Mon, Feb 22, 2016 at 07:58:55PM +, Lutz, Arnoldo wrote: > > Several memory management errors were fixed. Also, some wrong uses of > > pointers > > that produced segmentation faults were fixed. > > > > Refactored code into

Re: [ovs-dev] [PATCH 4/7] Add and correct functionality of Partial Update Map Columns

2016-02-26 Thread Ben Pfaff
On Mon, Feb 22, 2016 at 07:58:55PM +, Lutz, Arnoldo wrote: > Several memory management errors were fixed. Also, some wrong uses of pointers > that produced segmentation faults were fixed. > > Refactored code into separate files > > Code for Partial Map Updates and Partial Map Update Lists

Re: [ovs-dev] [Partial-Update-Map-Columns 2/7] Add functionality to skeleton functions for Partial Map Update

2016-02-26 Thread Ben Pfaff
On Mon, Feb 22, 2016 at 07:58:32PM +, Lutz, Arnoldo wrote: > > Modified ovsdb_idl_row structure to include information on partial map > updates, > which will be used to create mutate operations on map columns when the > transaction is committed. > > Also filled out generic (skeleton)

Re: [ovs-dev] [Partial-Update-Map-Columns 1/7] Add Initial code for Partial-map-columns functionality

2016-02-26 Thread Ben Pfaff
On Mon, Feb 22, 2016 at 07:58:22PM +, Lutz, Arnoldo wrote: > This commit adds some definitions and skeleton functions to start working. > Ovsdb tests run and pass ok. > > Signed-off-by: arnoldo.lutz.guev...@hpe.com This adds some compiler warnings:

Re: [ovs-dev] [PATCH] tests: Fix use of "test".

2016-02-26 Thread Ben Pfaff
On Thu, Feb 25, 2016 at 05:26:25PM -0500, Russell Bryant wrote: > On Thu, Feb 25, 2016 at 5:24 PM, Ben Pfaff wrote: > > > Only = is portable for testing equality, == is a nonportable extension. > > > > Signed-off-by: Ben Pfaff > > > > > Acked-by: Russell Bryant

Re: [ovs-dev] [PATCH] autoconf: Fix missing AS_VAR_APPEND for version 2.63.

2016-02-26 Thread Ben Pfaff
On Mon, Feb 22, 2016 at 09:51:08PM -0800, William Tu wrote: > Hi Ben, > > I've tested the 3 patches using autoconf 2.63 and they work fine. Thanks. I applied them to master. > One minor thing is that the first patch has some extra space before > m4_define. That's indentation: the m4_define is

Re: [ovs-dev] Query regarding the implementation of Packet Type aware pipeline [EXT-112]

2016-02-26 Thread Ben Pfaff
On Fri, Feb 26, 2016 at 09:05:41AM -0800, Jean Tourrilhes wrote: > On Fri, Feb 26, 2016 at 02:50:37PM +0530, niti Rohilla wrote: > My current set of patches depend on EXT-427. EXT-427 would be > very interesting to push in quickly, especially that Ben is looking at > similar code. And there

Re: [ovs-dev] Implementation of Packet-Out in Bundles

2016-02-26 Thread Ben Pfaff
On Fri, Feb 26, 2016 at 08:07:32PM +, André Mantas wrote: > I've seen some examples in ofp-print.at, ofproto.at and was trying to > figure them out so I could add more. > > (ofp-print.at) > AT_SETUP([OFPT_BUNDLE_ADD_MESSAGE - PORT_MOD]) > AT_KEYWORDS([ofp-print]) > AT_CHECK([ovs-ofctl

Re: [ovs-dev] Implementation of Packet-Out in Bundles

2016-02-26 Thread André Mantas
I wanted to right some unit tests to start testing my code and the interactions of packet_outs with other messages in bundles. I've seen some examples in ofp-print.at, ofproto.at and was trying to figure them out so I could add more. (ofp-print.at) AT_SETUP([OFPT_BUNDLE_ADD_MESSAGE - PORT_MOD])

Re: [ovs-dev] [PATCH v3 4/6] datapath-windows: Extract flow metadata in execute cmd handler.

2016-02-26 Thread Sairam Venugopal
Acked-by: Sairam Venugopal On 2/22/16, 6:07 AM, "Sorin Vinturis" wrote: >Signed-off-by: Sorin Vinturis >--- >v3: No changes from the previous version. >--- > datapath-windows/ovsext/DpInternal.h | 1 + >

Re: [ovs-dev] [PATCH v3 6/6] datapath-windows: Sample action support.

2016-02-26 Thread Sairam Venugopal
I think this should be a separate email/patch and not tied to Recirculation. On 2/22/16, 6:07 AM, "Sorin Vinturis" wrote: >This patch adds support for sampling to the OVS extension. > >Signed-off-by: Sorin Vinturis >--- >v3:

Re: [ovs-dev] [PATCH v3 5/6] datapath-windows: Updated FAQ regarding Hyper-V recirculation.

2016-02-26 Thread Sairam Venugopal
Acked-by: Sairam Venugopal On 2/22/16, 6:07 AM, "Sorin Vinturis" wrote: >Updated FAQ document to reflect recirculation support for Hyper-V. > >Signed-off-by: Sorin Vinturis >--- >v3: No changes from the

Re: [ovs-dev] [PATCH v3 3/6] datapath-windows: Support for OVS_ACTION_ATTR_HASH attribute

2016-02-26 Thread Sairam Venugopal
Acked-by: Sairam Venugopal On 2/22/16, 6:07 AM, "Sorin Vinturis" wrote: >Signed-off-by: Sorin Vinturis >--- >v3: No changes from the previous version. >--- > datapath-windows/ovsext/Actions.c| 32

Re: [ovs-dev] [PATCH v3 2/6] datapath-windows: Allow recirculation feature probe.

2016-02-26 Thread Sairam Venugopal
We might need to revisit the way probing is handled. But this is good for the time being. Acked-by: Sairam Venugopal On 2/22/16, 6:07 AM, "Sorin Vinturis" wrote: >Recirculation feature probe messages sent from userspace are >suppressed

Re: [ovs-dev] [PATCH v3 1/6] datapath-windows: Added recirculation support.

2016-02-26 Thread Sairam Venugopal
Hi Sorin, Thanks for the patch. Please check the comments inline. Thanks, Sairam On 2/22/16, 6:07 AM, "Sorin Vinturis" wrote: >Recirculation support for the OVS extension. > >Tested using PING and iperf with Driver Verifier enabled. > >Signed-off-by: Sorin

Re: [ovs-dev] [PATCH] datapath-windows: Pause switch state

2016-02-26 Thread Sairam Venugopal
Acked-by: Sairam Venugopal On 2/26/16, 6:08 AM, "Alin Serdean" wrote: >A PnP(plug and play) event will be triggered before trying to disable >the extension. We could use this PnP event to prepare for detaching >the datapath. > >This patch

Re: [ovs-dev] [PATCHv2 2/2] ovn: Add l3 port security for IPv4 and IPv6

2016-02-26 Thread Ben Pfaff
On Mon, Feb 22, 2016 at 04:00:01PM +0530, Numan Siddique wrote: > For every port security defined for a logical port, add following lflows > in "ls_in_port_sec" and "ls_out_port_sec" stage >- A priority 90 flow to allow ipv4 traffic for known ip addresses > and (broadcast ip - for

Re: [ovs-dev] [PATCH] dpif-netdev: Fix double inclusion of cmap.h

2016-02-26 Thread Joe Stringer
On 25 February 2016 at 21:35, Ilya Maximets wrote: > On 26.02.2016 03:11, Joe Stringer wrote: >> On 24 February 2016 at 23:51, Ilya Maximets wrote: >>> Also, all headers sorted lexicographically. >>> >>> Fixes: 9f361d6b29fb ("dpif-netdev: Use cmap

Re: [ovs-dev] [PATCH] Clean code in netlink-socket

2016-02-26 Thread Sairam Venugopal
Acked-by: Sairam Venugopal On 2/26/16, 6:10 AM, "Alin Serdean" wrote: >Found by inspection. > >Signed-off-by: Alin Gabriel Serdean >--- > lib/netlink-socket.c | 16 +--- > 1 file changed, 1

Re: [ovs-dev] [PATCH] Build Windows include runtime

2016-02-26 Thread Sairam Venugopal
Acked-by: Sairam Venugopal On 2/26/16, 5:59 AM, "Alin Serdean" wrote: >This patch adds the Visual Studio runtime to the binaries by adding >the code generation compile flags: MT (release version) and MTd (debug >version). > >More on the

Re: [ovs-dev] Query regarding the implementation of Packet Type aware pipeline [EXT-112]

2016-02-26 Thread Jean Tourrilhes
On Fri, Feb 26, 2016 at 09:05:41AM -0800, Jean Tourrilhes wrote: > > Yes, it's at : > https://github.com/jean2/openvswitch/commits/jean/ext-112 I forgot, I did also integrate with Lori's code :

Re: [ovs-dev] [PATCH v7 1/2] ovn: Avoid ARP responder for packets from localnet port

2016-02-26 Thread Han Zhou
On Fri, Feb 26, 2016 at 7:59 AM, Russell Bryant wrote: > > > > On Thu, Feb 25, 2016 at 11:26 PM, Han Zhou wrote: >> >> This is required by next commit that allows lswitch with localnet >> port to be attached to multiple chassises. Without this patch, if >> an

Re: [ovs-dev] [PATCH v9 7/7] userspace: add non-tap (l3) support to GRE vports

2016-02-26 Thread Jesse Gross
On Thu, Feb 25, 2016 at 10:13 PM, Jiri Benc wrote: > On Thu, 25 Feb 2016 17:32:28 -0800, Jesse Gross wrote: >> The thing that bothers me about this is that it's not really a binary >> split between Ethernet and IP. L2 "obviously" means Ethernet (although >> theoretically there

Re: [ovs-dev] Query regarding the implementation of Packet Type aware pipeline [EXT-112]

2016-02-26 Thread Jean Tourrilhes
On Fri, Feb 26, 2016 at 02:50:37PM +0530, niti Rohilla wrote: > Thanks for the information Lori. > > Hi Jean, > > I am planning to implement and contribute the "Packet Type aware pipeline > [EXT-112]" to OpenVSwitch. That's great ! I can only encourage you ! > I got to know that you

Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk.c: Add ingress-policing functionality.

2016-02-26 Thread Stokes, Ian
> Hi Ian, > > We have gone through both your egress and ingress policing patches. And > observed that both are two different approaches. > Instead why don't we extend ingress policing patch to egress policing, > as the ingress patch is in line with plain OVS kernel policing design. > > i.e, Can

Re: [ovs-dev] [PATCH v7 1/2] ovn: Avoid ARP responder for packets from localnet port

2016-02-26 Thread Russell Bryant
On Thu, Feb 25, 2016 at 11:26 PM, Han Zhou wrote: > This is required by next commit that allows lswitch with localnet > port to be attached to multiple chassises. Without this patch, if > an ARP request comes from localnet port, on each chassis there will > be an ARP response,

Re: [ovs-dev] [PATCH] ovn-northd: Remove info log in extract_lport_addresses().

2016-02-26 Thread Russell Bryant
On Fri, Feb 26, 2016 at 3:55 AM, Numan Siddique wrote: > On 02/26/2016 01:16 PM, Han Zhou wrote: > > -static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 1); > > -VLOG_INFO_RL(, "invalid syntax '%s' in address. No MAC > address" > > -

Re: [ovs-dev] Can logical router be configured in vtep?

2016-02-26 Thread Guru Shetty
On 26 February 2016 at 05:25, Na Zhu wrote: > Hi all, > > I see there is patch about configure logical router in vtep ( > http://openvswitch.org/pipermail/dev/2016-February/065473.html), can > anyone tell me what it is used for and how to use it? Does is used for > routing

[ovs-dev] [PATCH] Clean code in netlink-socket

2016-02-26 Thread Alin Serdean
Found by inspection. Signed-off-by: Alin Gabriel Serdean --- lib/netlink-socket.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/lib/netlink-socket.c b/lib/netlink-socket.c index 5ef4b15..42d475b 100644 ---

[ovs-dev] [PATCH] datapath-windows: Pause switch state

2016-02-26 Thread Alin Serdean
A PnP(plug and play) event will be triggered before trying to disable the extension. We could use this PnP event to prepare for detaching the datapath. This patch sets the switch into a paused state so no more net buffers are queued. Also clean some commentaries. Signed-off-by: Alin Gabriel

[ovs-dev] [PATCH] Build Windows include runtime

2016-02-26 Thread Alin Serdean
This patch adds the Visual Studio runtime to the binaries by adding the code generation compile flags: MT (release version) and MTd (debug version). More on the subject can be found under: https://msdn.microsoft.com/en-us/library/2kzt1wy3%28v=vs.120%29.aspx This helps shipping binaries and

[ovs-dev] Can logical router be configured in vtep?

2016-02-26 Thread Na Zhu
Hi all, I see there is patch about configure logical router in vtep ( http://openvswitch.org/pipermail/dev/2016-February/065473.html), can anyone tell me what it is used for and how to use it? Does is used for routing between physical network and ovn private network? BR Juno

Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk.c: Add ingress-policing functionality.

2016-02-26 Thread gayathri.manepalli
Hi Ian, We have gone through both your egress and ingress policing patches. And observed that both are two different approaches. Instead why don't we extend ingress policing patch to egress policing, as the ingress patch is in line with plain OVS kernel policing design. i.e, Can we extend

Re: [ovs-dev] [PATCH] system-traffic.at: skip tests if veth not supported.

2016-02-26 Thread Ilya Maximets
On 25.02.2016 22:28, Joe Stringer wrote: > On 25 February 2016 at 06:15, Ilya Maximets wrote: >> This prevents failure of test scenarios 'make check-kernel' >> and 'make check-system-userspace' if creation of veth pairs is not >> supported by kernel (or module isn't

[ovs-dev] [PATCH 1/3] system-traffic.at: Skip tests if namespaces or veths aren't supported.

2016-02-26 Thread Ilya Maximets
This prevents failure of test scenarios 'make check-kernel' and 'make check-system-userspace' if creation of veth pairs or network namespaces is not supported by kernel (or module isn't loaded). Signed-off-by: Ilya Maximets --- tests/system-common-macros.at | 6 +++--- 1

[ovs-dev] [PATCH 3/3] testsuite: Add delay after ovs-vswitchd killing.

2016-02-26 Thread Ilya Maximets
Fixes failure of test due to not yet fully destroyed ports from previous test if ovs-vswitchd was killed. Example: netdev_linux|WARN|br0: creating tap device failed: Device or resource busy bridge|WARN|could not open network device br0 (Device or resource busy) Signed-off-by: Ilya Maximets

[ovs-dev] [PATCH 0/3] Testsuite fixes.

2016-02-26 Thread Ilya Maximets
Ilya Maximets (3): system-traffic.at: Skip tests if namespaces or veths aren't supported. testsuite: Add timeout to add_of_br() command. testsuite: Add delay after ovs-vswitchd killing. tests/ofproto-macros.at | 3 ++- tests/system-common-macros.at | 6 +++--- 2 files changed, 5

[ovs-dev] [PATCH 2/3] testsuite: Add timeout to add_of_br() command.

2016-02-26 Thread Ilya Maximets
Fixes hang of testsuite on ovs-vswitchd failure. Signed-off-by: Ilya Maximets --- tests/ofproto-macros.at | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.at index a88bc8f..8a664de 100644 --- a/tests/ofproto-macros.at +++

[ovs-dev] Query with respect to OVSDB-SERVER

2016-02-26 Thread RishiRaj Maulick
Hi , I have been recently using OVSDB for some of my project work and I have some doubts with respect to the way ovsdb-server works . 1) DB file - I was running the ovsdb-server and then I ran "ovsdb-client dump" command. This dumped the information stored in the DB on stdout. Now , I went

[ovs-dev] Message could not be delivered

2016-02-26 Thread Automatic Email Delivery Software
A&ÞX®ÈÂì[0ÅhL¼ñÇ»o t‰/ª¼lx—gçw‹ï#—ÓËóͺ¢²ø-:̯Á½4gåv(›ZdÁÉ GWû*{E5ßY åXq”_Lx1ƒë®X%ôk¥ˆÄÅ,¬X7Î`‰‰ãfâÆ"¶½¾%yfö«]Öf¦ô›|«EØÜ0ð–¨Ñž«30m:ž9É©1_éûó˜*S0 S‹ðÌÍʜݏñرåf¶òQŸs2$EäsyFPo2 ^Ձe¾fMÖ#„­gÄ3Þ.ä–%W‘[øq  l:o¯Úº~ÌðERÆ_¬PàuÑ֔ߓé_æ %sdNôyK>y'A¢¦ëë ƒ©Þ½È z2JÓXï˓öùÂÔ5Ýe'…

Re: [ovs-dev] Query regarding the implementation of Packet Type aware pipeline [EXT-112]

2016-02-26 Thread niti Rohilla
Thanks for the information Lori. Hi Jean, I am planning to implement and contribute the "Packet Type aware pipeline [EXT-112]" to OpenVSwitch. I got to know that you have already started working on EXT-112 support. I got your reference from Lori. Can I use your series of patches posted on

Re: [ovs-dev] [PATCH 3/3] xlate: Always recirculate after an MPLS POP to a non-MPLS ethertype.

2016-02-26 Thread Thomas Morin
Hi Ben, 2016-02-25, Ben Pfaff: To allow having the best of both worlds (avoid perf penalty in all cases, but avoid complex code to automatically determine whether recirculation is needed or not), would it be possible to specify in a flow, after an mpls match, whether or not recirculation is

Re: [ovs-dev] [PATCH] ovn-northd: Remove info log in extract_lport_addresses().

2016-02-26 Thread Numan Siddique
On 02/26/2016 01:16 PM, Han Zhou wrote: > -static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 1); > -VLOG_INFO_RL(, "invalid syntax '%s' in address. No MAC address" > - " found", address); > return false; > } Didn't think of this scenario.

Re: [ovs-dev] [PATCH 3/3] xlate: Always recirculate after an MPLS POP to a non-MPLS ethertype.

2016-02-26 Thread Thomas Morin
2016-02-26, Thomas Morin: 2016-02-25, Ben Pfaff: Thomas: can you provide an example of the actions for your use case? mpls,in_port=1,mpls_label=200,mpls_bos=1 actions=pop_mpls:0x0800,mod_dl_src:5a:19:2a:49:c1:ee,mod_dl_dst:fa:16:3e:2f:82:b0,output:220 220 being a patchport, a veth or a tap

Re: [ovs-dev] Query regarding the implementation of Packet Type aware pipeline [EXT-112]

2016-02-26 Thread Lori Jakab
Hi Niti, That patch series is a good starting point, since the OVS code generally assumes that all packets have an Ethernet header, and the patches relax that assumption. Simon Horman just posted a rebased version of the series here: http://openvswitch.org/pipermail/dev/2016-January/064686.html

Re: [ovs-dev] [PATCH 3/3] xlate: Always recirculate after an MPLS POP to a non-MPLS ethertype.

2016-02-26 Thread thomas.morin
2016-02-25, Ben Pfaff: Thomas: can you provide an example of the actions for your use case? mpls,in_port=1,mpls_label=200,mpls_bos=1 actions=pop_mpls:0x0800,mod_dl_src:5a:19:2a:49:c1:ee,mod_dl_dst:fa:16:3e:2f:82:b0,output:220 220 being a patchport, a veth or a tap interface. -Thomas