Re: [ovs-dev] [PATCH] flow: Verify that tot_len >= ip_len in miniflow_extract().

2016-07-22 Thread Ben Pfaff
On Sat, Jul 23, 2016 at 02:29:35AM -0300, Flavio Leitner wrote: > On Fri, Jul 22, 2016 at 04:43:50PM -0700, Ben Pfaff wrote: > > miniflow_extract() uses the following quantities when it examines an IPv4 > > header: > > > > size, the number of bytes from the start of the IPv4 header onward > >

Re: [ovs-dev] [PATCH v2] ovn-controller: eliminate stall in ofctrl state machine

2016-07-22 Thread Ben Pfaff
On Fri, Jul 22, 2016 at 11:04:47PM -0400, Lance Richardson wrote: > - Original Message - > > From: "Ben Pfaff" > > To: "Lance Richardson" > > Cc: dev@openvswitch.org > > Sent: Friday, July 22, 2016 6:47:14 PM > > Subject: Re: [ovs-dev] [PATCH v2]

[ovs-dev] sales report

2016-07-22 Thread Jeri Mckee
I am truly sorry that I was not available at the time you called me yesterday. I attached the report with details on sales figures. - Yours faithfully, Jeri Mckee MITIE GROUP Phone: +1 (534) 184-80-81 Fax: +1 (534) 184-80-81 ___ dev mailing list

Re: [ovs-dev] [PATCH] flow: Verify that tot_len >= ip_len in miniflow_extract().

2016-07-22 Thread Flavio Leitner
On Fri, Jul 22, 2016 at 04:43:50PM -0700, Ben Pfaff wrote: > miniflow_extract() uses the following quantities when it examines an IPv4 > header: > > size, the number of bytes from the start of the IPv4 header onward > ip_len, the number of bytes in the IPv4 header (from the IHL field) >

Re: [ovs-dev] [PATCH] release-process.md: Document OVS release process and propose a schedule.

2016-07-22 Thread Ben Pfaff
On Sat, Jul 23, 2016 at 02:01:51AM -0300, Flavio Leitner wrote: > On Tue, Jul 19, 2016 at 10:58:08AM -0700, Ben Pfaff wrote: > [...] > > +Release Scheduling > > +-- > > + > > +Open vSwitch makes releases at the following six-month cadence, which > > +of course is subject to change.

Re: [ovs-dev] Backport Request: dpif-netdev: Remove PMD latency on seq_mutex

2016-07-22 Thread Flavio Leitner
On Fri, Jul 22, 2016 at 10:48:40PM +, Daniele Di Proietto wrote: > I'm not sure I'm 100% comfortable back porting this to branch-2.5 > > I see the change more as a feature rather than a bugfix. > > Also it touches some core modules (seq and rcu) in a non trivial way. > > > What do you guys

Re: [ovs-dev] [PATCH] release-process.md: Document OVS release process and propose a schedule.

2016-07-22 Thread Flavio Leitner
On Tue, Jul 19, 2016 at 10:58:08AM -0700, Ben Pfaff wrote: [...] > +Release Scheduling > +-- > + > +Open vSwitch makes releases at the following six-month cadence, which > +of course is subject to change. > + > +time > +(months) approx datesevent > +

[ovs-dev] Returned mail: see transcript for details

2016-07-22 Thread Returned mail
Your message was not delivered due to the following reason(s): Your message could not be delivered because the destination server was unreachable within the allowed queue period. The amount of time a message is queued before it is returned depends on local configura- tion parameters. Most likely

Re: [ovs-dev] [PATCH v2] ovn-controller: eliminate stall in ofctrl state machine

2016-07-22 Thread Lance Richardson
- Original Message - > From: "Ben Pfaff" > To: "Lance Richardson" > Cc: dev@openvswitch.org > Sent: Friday, July 22, 2016 6:47:14 PM > Subject: Re: [ovs-dev] [PATCH v2] ovn-controller: eliminate stall in ofctrl > state machine > > On Thu, Jul 07, 2016

Re: [ovs-dev] [PATCH 0/2] Python JSON parser improvements

2016-07-22 Thread Ben Pfaff
In that case we should probably invent an include/ovn directory. On Mon, Jul 18, 2016 at 12:19:58PM -0700, Aaron Rosen wrote: > I'm facing this same issue with the _ovn-utils.c Python C extension patch I > posted. If this gets approved I believe I need to so the same thing for the > following

Re: [ovs-dev] [PATCH v2] ovs-lib: Keep internal interface ip during upgrade.

2016-07-22 Thread Daniele Di Proietto
On 22/07/2016 12:54, "Ben Pfaff" wrote: >On Tue, Jun 21, 2016 at 07:27:30PM -0700, Daniele Di Proietto wrote: >> Commit 9b5422a98f81("ovs-lib: Try to call exit before killing.") >> introduced a problem where internal interfaces are destroyed and >> recreated, losing their IP

Re: [ovs-dev] [PATCH 4/9] datapath-windows: Fix bugs in Event.c around subscribe and lock

2016-07-22 Thread Alin Serdean
> -Mesaj original- > De la: Sairam Venugopal [mailto:vsai...@vmware.com] > Trimis: Thursday, July 21, 2016 9:52 PM > Către: Alin Serdean ; Yin Lin > > Cc: dev@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH 4/9] datapath-windows: Fix

Re: [ovs-dev] [PATCH v2] ovs-lib: Keep internal interface ip during upgrade.

2016-07-22 Thread Daniele Di Proietto
2016-07-22 16:02 GMT-07:00 Daniele Di Proietto : > > > 2016-06-22 9:52 GMT-07:00 Darrell Ball : > >> On Tue, Jun 21, 2016 at 7:27 PM, Daniele Di Proietto < >> diproiet...@vmware.com >> > wrote: >> >> > Commit 9b5422a98f81("ovs-lib: Try to call exit before

Re: [ovs-dev] [PATCH 8/9] datapath-windows: Update OvsReadEventCmdHandler in Datapath.c to support different events

2016-07-22 Thread Alin Serdean
Just one comment inlined. > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam > Venugopal > Trimis: Thursday, July 14, 2016 2:39 AM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH 8/9] datapath-windows: Update > OvsReadEventCmdHandler in

Re: [ovs-dev] [PATCH 9/9] datapath-windows: Post Conntrack delete and new events

2016-07-22 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam > Venugopal > Trimis: Thursday, July 14, 2016 2:39 AM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH 9/9] datapath-windows:

Re: [ovs-dev] [PATCH 7/9] datapath-windows: Add support for multiple event queue in Event.c

2016-07-22 Thread Alin Serdean
Looks good. Just a few questions from my side so I get up to speed with the changes in events. Why do we need a lock per eventid ? > +typedef struct _OVS_CT_EVENT_ENTRY { > +OVS_CT_ENTRY entry; > +UINT8 type; > +UINT64 pad[10]; > +} OVS_CT_EVENT_ENTRY, *POVS_CT_EVENT_ENTRY; Why such

Re: [ovs-dev] [PATCH 6/9] datapath-windows: Modify OvsCreateNlMsgFromCtEntry to make it reusable

2016-07-22 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam > Venugopal > Trimis: Thursday, July 14, 2016 2:39 AM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH 6/9] datapath-windows:

Re: [ovs-dev] [PATCH 5/9] datapath-windows: Define new multicast conntrack events

2016-07-22 Thread Alin Serdean
It looks like a mistake was done when setting them up, don't know if it such a good idea to propagate it. Thanks, Alin. > -Mesaj original- > De la: Sairam Venugopal [mailto:vsai...@vmware.com] > Trimis: Friday, July 22, 2016 11:15 PM > Către: Alin Serdean

Re: [ovs-dev] [PATCH 1/2] Move lib/json.h to include/openvswitch

2016-07-22 Thread Ben Pfaff
On Tue, Jul 12, 2016 at 04:37:34PM -0500, Terry Wilson wrote: > To easily allow both in- and out-of-tree building of the Python > wrapper for the OVS JSON parser (e.g. w/ pip), move json.h to > include/openvswitch. This also requires moving lib/{hmap,shash}.h. > > Both hmap.h and shash.h were

Re: [ovs-dev] [v2] test: change replication test to use unix domain socket

2016-07-22 Thread Ben Pfaff
On Fri, Jul 22, 2016 at 04:37:52PM -0700, Andy Zhou wrote: > The ovsdb replication feature is not specific to the ovsdb socket types. > Switching the tests to use Unix domain socket simplifies the tests. > > Signed-off-by: Andy Zhou Not a huge advantage but unix sockets are

Re: [ovs-dev] [PATCH] ovn-controller: Handle physical changes correctly

2016-07-22 Thread Ben Pfaff
On Fri, Jul 22, 2016 at 09:54:26PM +, Ryan Moats wrote: > [1] reported increased failure rates in certain tests > with incremental processing (the numbers are the number of failures > seen in 100 tests): > >2 ovn -- vtep: 3 HVs, 1 VIFs/HV, 1 GW, 1 LS > 10 ovn -- 2 HVs, 2 LS, 1

Re: [ovs-dev] Backport Request: dpif-netdev: Remove PMD latency on seq_mutex

2016-07-22 Thread Vinod, Chegu
Thanks Flavio for checking and Daniel for your consideration. Indeed the issue exists in 2.5 branch. We are treating this more in the bucket of a performance bug fix than a feature. Any specific testing that you would like to see run to help reduce your concern related to changes to the core

[ovs-dev] [PATCH] flow: Verify that tot_len >= ip_len in miniflow_extract().

2016-07-22 Thread Ben Pfaff
miniflow_extract() uses the following quantities when it examines an IPv4 header: size, the number of bytes from the start of the IPv4 header onward ip_len, the number of bytes in the IPv4 header (from the IHL field) tot_len, same as size but taken from IPv4 header Total Length field

[ovs-dev] [v2] test: change replication test to use unix domain socket

2016-07-22 Thread Andy Zhou
The ovsdb replication feature is not specific to the ovsdb socket types. Switching the tests to use Unix domain socket simplifies the tests. Signed-off-by: Andy Zhou --- tests/ovsdb-server.at | 70 ++- 1 file changed, 30

Re: [ovs-dev] [PATCH] [Patch v1] ovn-controller: ignore lflow matching remote VM port

2016-07-22 Thread Ben Pfaff
On Mon, Jul 18, 2016 at 10:32:29AM -0500, Ryan Moats wrote: > "dev" wrote on 07/11/2016 02:59:29 AM: > > > From: Zong Kai LI > > To: dev@openvswitch.org > > Date: 07/11/2016 02:59 AM > > Subject: [ovs-dev] [PATCH] [Patch v1] ovn-controller:

Re: [ovs-dev] [PATCH] [Patch v1] ovn-controller: ignore lflow matching remote VM port

2016-07-22 Thread Ben Pfaff
On Mon, Jul 11, 2016 at 03:59:29PM +0800, Zong Kai LI wrote: > Currently, ovn-controller will install all lflows for a logical > switch, when ovn-controller determines not to skip processing of > that logical switch. > > This will install too many OVS flows. We have 11 tables for logical > switch

Re: [ovs-dev] [PATCH v2] ovs-lib: Keep internal interface ip during upgrade.

2016-07-22 Thread Daniele Di Proietto
2016-06-22 9:52 GMT-07:00 Darrell Ball : > On Tue, Jun 21, 2016 at 7:27 PM, Daniele Di Proietto < > diproiet...@vmware.com > > wrote: > > > Commit 9b5422a98f81("ovs-lib: Try to call exit before killing.") > > introduced a problem where internal interfaces are destroyed and > >

Re: [ovs-dev] [PATCH V13] Function tracer to trace all function calls

2016-07-22 Thread Ben Pfaff
On Tue, Jul 19, 2016 at 09:26:46PM -0500, Ryan Moats wrote: > "dev" wrote on 07/08/2016 07:04:06 PM: > > > From: Nirapada Ghosh/San Jose/IBM@IBMUS > > To: dev@openvswitch.org > > Date: 07/08/2016 07:04 PM > > Subject: [ovs-dev] [PATCH V13] Function tracer to trace

Re: [ovs-dev] Backport Request: dpif-netdev: Remove PMD latency on seq_mutex

2016-07-22 Thread Daniele Di Proietto
I'm not sure I'm 100% comfortable back porting this to branch-2.5 I see the change more as a feature rather than a bugfix. Also it touches some core modules (seq and rcu) in a non trivial way. What do you guys think? Thanks, Daniele On 22/07/2016 15:03, "Flavio Leitner"

Re: [ovs-dev] [PATCH v2] ovn-controller: eliminate stall in ofctrl state machine

2016-07-22 Thread Ben Pfaff
On Thu, Jul 07, 2016 at 08:31:08PM -0400, Lance Richardson wrote: > The "ovn -- 2 HVs, 3 LRs connected via LS, static routes" > test case currently exhibits frequent failures. These failures > occur because, at the time that the test packets are sent to > verify forwarding, no flows have been

Re: [ovs-dev] [PATCH RFC v3 1/1] netdev-dpdk: Add support for DPDK 16.07

2016-07-22 Thread Daniele Di Proietto
: https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/Documentation/RCU/arrayRCU.txt?id=refs/tags/next-20160722#n13 but I think using atomics should prevent the compiler from playing tricks with the index. How about something like the code below? Thanks, Daniele diff --git

Re: [ovs-dev] [add ovsdb lock tests 3/3] tests: add ovsdb lock tests

2016-07-22 Thread Andy Zhou
On Thu, Jun 23, 2016 at 12:31 PM, Ben Pfaff wrote: > On Mon, Jun 06, 2016 at 01:51:16PM -0700, Andy Zhou wrote: > > Add more ovsdb lock tests. > > > > Signed-off-by: Andy Zhou > > This test checks c1-output twice, I suspect that the second check should > be for

Re: [ovs-dev] [add ovsdb lock tests 1/3] ovsdb: fix ovsdb-client --help output format

2016-07-22 Thread Andy Zhou
This patch no longer applies after cond_monitoring patches went in. I will drop it. On Fri, Jul 22, 2016 at 12:59 PM, Andy Zhou wrote: > Thanks for the reminder. I will get them committed soon. > > On Fri, Jul 22, 2016 at 12:49 PM, Ben Pfaff wrote: > >> This series

Re: [ovs-dev] [PATCH] netdev-dummy: fix crash with more than one passive connection

2016-07-22 Thread Ryan Moats
Ben Pfaff wrote on 07/22/2016 05:18:44 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: Lance Richardson , dev@openvswitch.org > Date: 07/22/2016 05:18 PM > Subject: Re: [ovs-dev] [PATCH] netdev-dummy: fix crash with more > than one

Re: [ovs-dev] [PATCH v1] Fix IPFIX test cases issue

2016-07-22 Thread Ben Pfaff
On Thu, Jul 07, 2016 at 11:17:48PM +0800, Benli Ye wrote: > IPFIX statistics 'tx pkts' means the number of successfully > sending IPFIX packets, while 'tx errs' means sending error > IPFIX packets. These two parameters can be affected by whether > listening on port 4739 on local host. This case

Re: [ovs-dev] [PATCH] netdev-dummy: fix crash with more than one passive connection

2016-07-22 Thread Ben Pfaff
On Tue, Jul 19, 2016 at 09:20:37AM -0500, Ryan Moats wrote: > Lance Richardson wrote on 07/19/2016 09:07:41 AM: > > > From: Lance Richardson > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: dev@openvswitch.org > > Date: 07/19/2016 09:07 AM > > Subject: Re:

Re: [ovs-dev] [PATCH] netdev-dummy: fix crash with more than one passive connection

2016-07-22 Thread Ben Pfaff
On Wed, Jul 06, 2016 at 07:39:52PM -0400, Lance Richardson wrote: > Investigation found that Some of the occasional failures in the > "ovn -- vtep: 3 HVs, 1 VIFs/HV, 1 GW, 1 LS" test case are caused > by ovs-vswitchd crashing with SIGSEGV. It turns out that the > crash occurrs when the number of

[ovs-dev] Backport Request: dpif-netdev: Remove PMD latency on seq_mutex

2016-07-22 Thread Flavio Leitner
(adding ovs-dev mailing list and more people interesting on the backport to CC) On Mon, Jul 18, 2016 at 05:31:52AM +, Vinod, Chegu wrote: > Hi Flavio, Karl, > > Is there a version of the following fix available that is compatible with OVS > 2.5? > >

Re: [ovs-dev] ovn test failures

2016-07-22 Thread Ryan Moats
Ben Pfaff wrote on 07/22/2016 02:21:01 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: Guru Shetty , ovs dev > Date: 07/22/2016 02:21 PM > Subject: Re: [ovs-dev] ovn test failures > > On Fri, Jul 22, 2016 at

[ovs-dev] [PATCH] ovn-controller: Handle physical changes correctly

2016-07-22 Thread Ryan Moats
[1] reported increased failure rates in certain tests with incremental processing (the numbers are the number of failures seen in 100 tests): 2 ovn -- vtep: 3 HVs, 1 VIFs/HV, 1 GW, 1 LS 10 ovn -- 2 HVs, 2 LS, 1 lport/LS, 2 peer LRs 52 ovn -- 1 HV, 1 LS, 2 lport/LS, 1 LR 45 ovn -- 1

Re: [ovs-dev] [ovn-ipv6 16/26] packets: Cleanup ND compose functions.

2016-07-22 Thread Justin Pettit
> On Jul 13, 2016, at 12:36 PM, Ben Pfaff wrote: > > On Tue, Jul 12, 2016 at 07:26:29PM +0800, Zong Kai Li wrote: >> On Tue, Jul 12, 2016 at 2:56 PM, Justin Pettit wrote: >>> Rename "compose_nd" and "compose_na" to "compose_nd_sol" and >>> "compose_nd_adv",

Re: [ovs-dev] [PATCH v2 3/3] pvector: Expose non-concurrent priority vector.

2016-07-22 Thread Ben Pfaff
On Wed, Jul 06, 2016 at 05:26:17AM -0700, Jarno Rajahalme wrote: > PMD threads use pvectors but do not need the overhead of the > concurrent version. Expose the non-concurrent version for > that use. > > Note that struct pvector is renamed as struct cpvector (for concurrent > priority vector),

Re: [ovs-dev] [RFC 4/5] dpctl: uses open_type when calling netdev_open

2016-07-22 Thread Daniele Di Proietto
I would prefer if dpctl kept using the datapath types. The translation from database types to datapath type should happen in ofproto, dpctl is supposed to be used to interact with the datapath directly. What do you guys think? The rest of the series looks good to me as well. Thanks, Daniele

Re: [ovs-dev] [PATCH v2 2/3] pvector: Get rid of special purpose of INT_MIN.

2016-07-22 Thread Ben Pfaff
On Wed, Jul 06, 2016 at 05:26:16AM -0700, Jarno Rajahalme wrote: > Allow clients to use the whole priority range. Note that this changes > the semantics of PVECTOR_FOR_EACH_PRIORITY so that the iteration still > continues for entries at the given priority. > > Suggested-by: Ben Pfaff

Re: [ovs-dev] [PATCH v2 1/3] pvector: Move PVECTOR_EXTRA_ALLOC to pvector.c.

2016-07-22 Thread Ben Pfaff
On Wed, Jul 06, 2016 at 05:26:15AM -0700, Jarno Rajahalme wrote: > There is no need to expose PVECTOR_EXTRA_ALLOC in the API. > > Suggested-by: Ben Pfaff > Signed-off-by: Jarno Rajahalme Acked-by: Ben Pfaff

Re: [ovs-dev] [ovs-dev, PATCHv3] ofproto-dpif-sflow: Add snaplen for sample action and sFlow.

2016-07-22 Thread Ben Pfaff
It sounds like snaplen is not very useful in IPFIX. If so, then I'd support removing the IPFIX and sample action support for it. If you agree, will you send a v4? Otherwise, let me know and I'll apply v3. Here's a change I'd like to fold into v3, to better allow for future extensions. It

[ovs-dev] [PATCH] ovs-ofctl: Fix font in manual.

2016-07-22 Thread Ben Pfaff
Without this fix, the remainder of the paragraph appears in bold, which was not intended. Signed-off-by: Ben Pfaff --- utilities/ovs-ofctl.8.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in index

[ovs-dev] sales report

2016-07-22 Thread Mari Holder
I am truly sorry that I was not available at the time you called me yesterday. I attached the report with details on sales figures. - Yours faithfully, Mari Holder PAPUA MINING PLC Phone: +1 (221) 877-24-39 Fax: +1 (221) 877-24-52 ___ dev mailing

[ovs-dev] [PATCH] selinux: Allow ovs-ctl force-reload-kmod.

2016-07-22 Thread Joe Stringer
When invoking ovs-ctl force-reload-kmod via '/etc/init.d/openvswitch force-reload-kmod', spurious errors would output related to 'hostname' and 'ip', and the system's selinux audit log would complain about some of the invocations such as those listed at the end of this commit message. This patch

Re: [ovs-dev] [PATCH branch-2.5 1/2] datapath: backport: Set mark and labels before confirming.

2016-07-22 Thread pravin shelar
On Fri, Jul 22, 2016 at 1:24 PM, Ben Pfaff wrote: > On Fri, Jul 01, 2016 at 11:37:55AM -0700, Pravin B Shelar wrote: >> Upstream commit: >> commit 1c1779fa54b2a9d4e1de990095d790d64b9e00a1 >> Author: Jarno Rajahalme >> Date: Tue Jun 21 14:59:37 2016

Re: [ovs-dev] [PATCH v3 1/4] Add support for 802.1ad (QinQ tunneling)

2016-07-22 Thread Eric Garver
On Sun, Jul 03, 2016 at 08:47:06AM +0800, Xiao Liang wrote: > diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c > index 997cc15..d8eac93 100644 > --- a/lib/ofp-actions.c > +++ b/lib/ofp-actions.c > @@ -1653,21 +1654,19 @@ parse_PUSH_VLAN(char *arg, struct ofpbuf *ofpacts, > return error;

Re: [ovs-dev] Bug#828478: [PATCH v2] ovs-pki: Use SHA-512 instead of SHA-1 as message digest.

2016-07-22 Thread Ben Pfaff
On Wed, Jul 13, 2016 at 10:06:53PM -0500, Ryan Moats wrote: > "dev" wrote on 07/01/2016 08:05:40 PM: > > > From: Ben Pfaff > > To: dev@openvswitch.org > > Cc: Ben Pfaff , Kurt Roeckx , > > 828...@bugs.debian.org > > Date:

Re: [ovs-dev] [PATCH branch-2.5 1/2] datapath: backport: Set mark and labels before confirming.

2016-07-22 Thread Ben Pfaff
On Fri, Jul 01, 2016 at 11:37:55AM -0700, Pravin B Shelar wrote: > Upstream commit: > commit 1c1779fa54b2a9d4e1de990095d790d64b9e00a1 > Author: Jarno Rajahalme > Date: Tue Jun 21 14:59:37 2016 -0700 > > openvswitch: Set mark and labels before confirming. > >

Re: [ovs-dev] [PATCH 4/9] datapath-windows: Fix bugs in Event.c around subscribe and lock

2016-07-22 Thread Sairam Venugopal
Yes, I was also thinking of using the gOvsSwitchContext->dispatchLock to keep it safe. That said, we would want to do the following: 1) Add this to OvsGetOpenInstance() 2) Update all unsafe usages of gOvsSwitchContext to either use OvsGetOpenInstance() or acquire gOvsSwitchContext->dispatchLock.

[ovs-dev] [PATCH] TODO.md: Remove.

2016-07-22 Thread Ben Pfaff
No one has implemented a project from this list in years. Signed-off-by: Ben Pfaff --- Makefile.am | 1 - TODO.md | 280 2 files changed, 281 deletions(-) delete mode 100644 TODO.md diff --git a/Makefile.am

[ovs-dev] [PATCH] Fix typos: s/OSVDB/OVSDB/.

2016-07-22 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- TODO.md | 2 +- tests/ovsdb-data.at | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/TODO.md b/TODO.md index b4542b7..9685324 100644 --- a/TODO.md +++ b/TODO.md @@ -146,7 +146,7 @@ OpenFlow Fuzzer Build a ``fuzzer''

Re: [ovs-dev] [PATCH] tests: Make ovsdb test more robust and faster.

2016-07-22 Thread Ben Pfaff
On Thu, Jul 21, 2016 at 06:22:18AM -0700, Jarno Rajahalme wrote: > Using sleep's is prone to runtime system dependent races, and indeed > this test started consistently failing on my dev VM after an unrelated > change to ovs-vswitchd. Get git of the sleeps and explicitly wait for > the

Re: [ovs-dev] [PATCH 5/9] datapath-windows: Define new multicast conntrack events

2016-07-22 Thread Sairam Venugopal
Yes, I wanted to keep it similar to the VPORT events: enum { OVS_EVENT_CONNECT = ((uint32_t)0x1 << 0), OVS_EVENT_DISCONNECT= ((uint32_t)0x1 << 1), OVS_EVENT_LINK_UP = ((uint32_t)0x1 << 2), OVS_EVENT_LINK_DOWN = ((uint32_t)0x1 << 3), OVS_EVENT_MAC_CHANGE

Re: [ovs-dev] [RFC 0/5] netdev_open conflicting types

2016-07-22 Thread Ben Pfaff
On Mon, Jul 18, 2016 at 02:00:20PM -0300, Thadeu Lima de Souza Cascardo wrote: > This series is a proposal to fix some users of netdev_open and > introduce a new behavior for netdev_open when called with a different > type than the one already opened. These seem fine to me. If you post them with

[ovs-dev] sales report

2016-07-22 Thread Helen Hansen
I am truly sorry that I was not available at the time you called me yesterday. I attached the report with details on sales figures. - Best of luck, Helen Hansen ENERGY TECHNIQUE Phone: +1 (022) 768-83-64 Fax: +1 (022) 768-83-86 ___ dev mailing list

Re: [ovs-dev] [add ovsdb lock tests 1/3] ovsdb: fix ovsdb-client --help output format

2016-07-22 Thread Andy Zhou
Thanks for the reminder. I will get them committed soon. On Fri, Jul 22, 2016 at 12:49 PM, Ben Pfaff wrote: > This series seems to be fully reviewed but it's been sitting unpushed at > the bottom of patchwork for a while. Are you going to apply it? > > Thanks, > > Ben. >

Re: [ovs-dev] [PATCH v2] ovs-lib: Keep internal interface ip during upgrade.

2016-07-22 Thread Ben Pfaff
On Tue, Jun 21, 2016 at 07:27:30PM -0700, Daniele Di Proietto wrote: > Commit 9b5422a98f81("ovs-lib: Try to call exit before killing.") > introduced a problem where internal interfaces are destroyed and > recreated, losing their IP address. Acked-by: Ben Pfaff

Re: [ovs-dev] [add ovsdb lock tests 1/3] ovsdb: fix ovsdb-client --help output format

2016-07-22 Thread Ben Pfaff
This series seems to be fully reviewed but it's been sitting unpushed at the bottom of patchwork for a while. Are you going to apply it? Thanks, Ben. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] release-process.md: Document OVS release process and propose a schedule.

2016-07-22 Thread Ben Pfaff
On Thu, Jul 21, 2016 at 01:32:15PM -0400, Aaron Conole wrote: > Hi Ben, > > Ben Pfaff writes: > > > This document has two different kinds of text: > > > >- The first sections of the document, "Release Strategy" and "Release > > Numbering", describe what we've already been

Re: [ovs-dev] ovn test failures

2016-07-22 Thread Ben Pfaff
On Fri, Jul 22, 2016 at 01:52:18PM -0500, Ryan Moats wrote: > > > Guru Shetty wrote on 07/22/2016 12:31:43 PM: > > > From: Guru Shetty > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: Lance Richardson , ovs dev > > Date:

Re: [ovs-dev] ovn test failures

2016-07-22 Thread Ryan Moats
Guru Shetty wrote on 07/22/2016 12:31:43 PM: > From: Guru Shetty > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: Lance Richardson , ovs dev > Date: 07/22/2016 12:31 PM > Subject: Re: [ovs-dev] ovn test failures > > On 21 July 2016

Re: [ovs-dev] [PATCH monitor_cond V10] RFC OVN: Implementation of conditional monitoring usage

2016-07-22 Thread Darrell Ball
On Thu, Jul 21, 2016 at 4:18 AM, Liran Schour wrote: > Mickey Spiegel/San Jose/IBM wrote on 20/07/2016 08:53:42 AM: > > > From: Mickey Spiegel/San Jose/IBM > > To: Liran Schour/Haifa/IBM@IBMIL > > Cc: Ben Pfaff , dev@openvswitch.org > > Date: 20/07/2016 08:53 AM

[ovs-dev] sales report

2016-07-22 Thread Ivan Lowe
I am truly sorry that I was not available at the time you called me yesterday. I attached the report with details on sales figures. - Yours truly, Ivan Lowe GREAT WESTERN MINING CORP PLC Phone: +1 (326) 063-01-08 Fax: +1 (326) 063-01-79 ___ dev

Re: [ovs-dev] [RFC PATCH v2 1/1] netdev-dpdk: Add support for DPDK 16.07

2016-07-22 Thread Daniele Di Proietto
[...] > @@ -1776,7 +1764,8 @@ netdev_dpdk_get_stats(const struct netdev > > *netdev, struct netdev_stats *stats) > > netdev_dpdk_get_carrier(netdev, ); > > ovs_mutex_lock(>mutex); > > > > -struct rte_eth_xstats *rte_xstats; > > +struct rte_eth_xstat *rte_xstats; > > +struct

Re: [ovs-dev] [PATCH] tests/ovs-monitor-ipsec: Remove --no-wait -vreconnect:emer from ovs-vsctl.

2016-07-22 Thread Ben Pfaff
On Fri, Jul 22, 2016 at 11:02:02AM -0700, Joe Stringer wrote: > On 21 July 2016 at 18:55, Daniele Di Proietto wrote: > > This fixes a sporadic failure of the testcase, where ovsdb-server.log > > contains: > > > > 2016-07-21T21:08:22.279Z|3|jsonrpc|WARN|unix: send

Re: [ovs-dev] [PATCH] tests/ovs-monitor-ipsec: Remove --no-wait -vreconnect:emer from ovs-vsctl.

2016-07-22 Thread Daniele Di Proietto
On 22/07/2016 11:02, "Joe Stringer" wrote: >On 21 July 2016 at 18:55, Daniele Di Proietto wrote: >> This fixes a sporadic failure of the testcase, where ovsdb-server.log >> contains: >> >> 2016-07-21T21:08:22.279Z|3|jsonrpc|WARN|unix: send error:

Re: [ovs-dev] [PATCH v2] ovn-controller: Fix potential null pointer dereferences.

2016-07-22 Thread Ben Pfaff
On Thu, Jul 21, 2016 at 01:38:37PM -0700, Andy Zhou wrote: > On Wed, Jul 20, 2016 at 9:46 PM, Ben Pfaff wrote: > > > Found by inspection. > > > > Signed-off-by: Ben Pfaff > > --- > > v1->v2: Found another one to fix. > > Looks good. > Acked-by: Andy Zhou

Re: [ovs-dev] [PATCH 2/3] ovn-northd: Avoid redundant lookup of logical router port peer.

2016-07-22 Thread Ben Pfaff
On Fri, Jul 22, 2016 at 07:18:04AM -0700, Guru Shetty wrote: > On 19 July 2016 at 09:07, Ben Pfaff wrote: > > > An ovn_port keeps track of its peer in its 'peer' member, but the code > > updated by this commit instead did a redundant lookup of the peer. > > > > Signed-off-by: Ben

Re: [ovs-dev] [PATCH] tests/ovs-monitor-ipsec: Remove --no-wait -vreconnect:emer from ovs-vsctl.

2016-07-22 Thread Joe Stringer
On 21 July 2016 at 18:55, Daniele Di Proietto wrote: > This fixes a sporadic failure of the testcase, where ovsdb-server.log > contains: > > 2016-07-21T21:08:22.279Z|3|jsonrpc|WARN|unix: send error: Broken pipe > 2016-07-21T21:08:22.279Z|4|reconnect|WARN|unix:

Re: [ovs-dev] ovn test failures

2016-07-22 Thread Guru Shetty
On 21 July 2016 at 06:05, Ryan Moats wrote: > "dev" wrote on 07/21/2016 06:32:02 AM: > > > From: Lance Richardson > > To: ovs dev > > Date: 07/21/2016 06:32 AM > > Subject: [ovs-dev] ovn test failures >

Re: [ovs-dev] [PATCH 5/9] datapath-windows: Define new multicast conntrack events

2016-07-22 Thread Alin Serdean
Looks good just one question inlined. > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam > Venugopal > Trimis: Thursday, July 14, 2016 2:39 AM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH 5/9] datapath-windows: Define new multicast >

Re: [ovs-dev] [PATCH 3/9] datapath-windows: Explicitly name vport related event to vportEvent

2016-07-22 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam > Venugopal > Trimis: Thursday, July 14, 2016 2:39 AM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH 3/9] datapath-windows:

Re: [ovs-dev] [PATCH 2/9] datapath-windows: Add supported netlink family protocols to NetlinkProto.h

2016-07-22 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam > Venugopal > Trimis: Thursday, July 14, 2016 2:39 AM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH 2/9] datapath-windows: Add

Re: [ovs-dev] [PATCH 1/9] datapath-windows: Rename OVS_EVENT_ENTRY to OVS_VPORT_EVENT_ENTRY

2016-07-22 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam > Venugopal > Trimis: Thursday, July 14, 2016 2:39 AM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH 1/9] datapath-windows:

Re: [ovs-dev] [PATCH 0/9] Add support for sending Conntrack events

2016-07-22 Thread Alin Serdean
I would prefer if you did the squash because it makes it easier to revert/look over later on. I will review the patches as is. Thanks, Alin. > -Mesaj original- > De la: Sairam Venugopal [mailto:vsai...@vmware.com] > Trimis: Thursday, July 21, 2016 9:19 PM > Către: Alin Serdean

Re: [ovs-dev] [PATCH 4/9] datapath-windows: Fix bugs in Event.c around subscribe and lock

2016-07-22 Thread Alin Serdean
The idea is dpNo could change in odd circumstances. We could use gOvsSwitchContext->dispatchLock and make OvsGetOpenInstance safe by itself. Thanks, Alin. > -Mesaj original- > De la: Sairam Venugopal [mailto:vsai...@vmware.com] > Trimis: Thursday, July 21, 2016 9:52 PM > Către: Alin

Re: [ovs-dev] Considering the possibility of integrating DPDK generic classifier APIs in OVS.

2016-07-22 Thread Gray, Mark D
> [Sugesh] : But still its not as unique as matching on packet fields per se. I still didn't get it but rather than bore the mailing list to death. I just asked him (he sits two seats down from me!). I think this can be worked around but we need to have a good think about the design.

[ovs-dev] sales report

2016-07-22 Thread Timmy Carey
I am truly sorry that I was not available at the time you called me yesterday. I attached the report with details on sales figures. - Warm regards, Timmy Carey OCTOPUS ECLIPSE VCT PLC Phone: +1 (295) 281-26-06 Fax: +1 (295) 281-26-58 ___ dev

[ovs-dev] Returned mail: see transcript for details

2016-07-22 Thread linux-ext4
This Message was undeliverable due to the following reason: Your message was not delivered because the destination computer was not reachable within the allowed queue period. The amount of time a message is queued before it is returned depends on local configura- tion parameters. Most likely

Re: [ovs-dev] Considering the possibility of integrating DPDK generic classifier APIs in OVS.

2016-07-22 Thread Chandran, Sugesh
Hi Mark, Thank you for your response, Please find my reply below, Regards _Sugesh > -Original Message- > From: Gray, Mark D > Sent: Thursday, July 21, 2016 5:34 PM > To: Chandran, Sugesh ; Jesse Gross > > Cc: dev@openvswitch.org; Giller,

Re: [ovs-dev] [ovs-dev, RFC, v2, 1/1] netdev-dpdk: Add support for DPDK 16.07

2016-07-22 Thread Loftus, Ciara
> > On 12.07.2016 12:11, Ciara Loftus wrote: > > This commit introduces support for DPDK 16.07 and consequently breaks > > compatibility with DPDK 16.04. > > > > DPDK 16.07 introduces some changes to various APIs. These have been > > updated in OVS, including: > > * xstats API: changes to

Re: [ovs-dev] [RFC PATCH v2 1/1] netdev-dpdk: Add support for DPDK 16.07

2016-07-22 Thread Loftus, Ciara
> > Hi Ciara, > thanks for the patch. > It mostly looks good to me, except a few comments inline > Thanks, > Daniele Thanks for the review Daniele. I've pushed a new version that includes your suggestions. Responses inline. > > 2016-07-12 2:11 GMT-07:00 Ciara Loftus :

Re: [ovs-dev] [PATCH 1/3] ovn-northd: Only peer router ports to other router ports.

2016-07-22 Thread nickcooper-zhangtonghao
>> A router port's "peer", if set, must point to another router port, but the >> code as written also accepted switch ports. This caused problems when >> switch ports were actually specified. >> >> Reported-by: Gurucharan Shetty >> Reported-at:

[ovs-dev] [PATCH RFC v3 0/1] netdev-dpdk: Add support for DPDK 16.07

2016-07-22 Thread Ciara Loftus
This RFC patch provides initial support for DPDK 16.07-rc3 (release candidate 3) which was tagged July 16th. I plan to submit a full patch once the 16.07 release is final, hopefully later this month. This RFC patch can be used in meantime to test with the DPDK master branch or 16.07-rc3 tag. The

[ovs-dev] [PATCH RFC v3 1/1] netdev-dpdk: Add support for DPDK 16.07

2016-07-22 Thread Ciara Loftus
This commit introduces support for DPDK 16.07 and consequently breaks compatibility with DPDK 16.04. DPDK 16.07 introduces some changes to various APIs. These have been updated in OVS, including: * xstats API: changes to structure of xstats * vhost API: replace virtio-net references with 'vid'

Re: [ovs-dev] [PATCH 3/3] Red Hat Systemd Integration

2016-07-22 Thread Flavio Leitner
On Thu, Jul 21, 2016 at 10:18:51AM -0400, Aaron Conole wrote: > Markos Chandras writes: > > > Hi Aaron, > > > > On 07/20/2016 10:21 PM, Aaron Conole wrote: > >> This commit builds upon some of the recent ovs-ctl changes to build a > >> more integrated systemd setup. A new

Re: [ovs-dev] [PATCH] netdev-dpdk: Add Flow Control support.

2016-07-22 Thread Bodireddy, Bhanuprakash
Thanks for the patch, can you also add the flow control options to the INSTALL-ADVANCED.md? Regards, Bhanu Prakash. >-Original Message- >From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sugesh >Chandran >Sent: Friday, July 22, 2016 2:18 PM >To: dev@openvswitch.org >Subject:

Re: [ovs-dev] [PATCH 2/3] ovn-northd: Avoid redundant lookup of logical router port peer.

2016-07-22 Thread Guru Shetty
On 19 July 2016 at 09:07, Ben Pfaff wrote: > An ovn_port keeps track of its peer in its 'peer' member, but the code > updated by this commit instead did a redundant lookup of the peer. > > Signed-off-by: Ben Pfaff > Acked-by: Gurucharan Shetty > ---

Re: [ovs-dev] [PATCH 1/3] ovn-northd: Only peer router ports to other router ports.

2016-07-22 Thread Guru Shetty
On 19 July 2016 at 09:07, Ben Pfaff wrote: > A router port's "peer", if set, must point to another router port, but the > code as written also accepted switch ports. This caused problems when > switch ports were actually specified. > > Reported-by: Gurucharan Shetty

Re: [ovs-dev] [PATCH] ovn: ovn-northd and von-controller take a high amount of CPU time.

2016-07-22 Thread Guru Shetty
On 21 July 2016 at 23:02, nickcooper-zhangtonghao < nickcooper-zhangtong...@opencloud.tech> wrote: > Hi all, > When setting the logical switch port as the peer of logical router, > I found a large number of ovn-northd log. The process of ovn-northd write > quickly the log > all the time. The

[ovs-dev] sales report

2016-07-22 Thread Minh Barrett
I am truly sorry that I was not available at the time you called me yesterday. I attached the report with details on sales figures. - Best of luck, Minh Barrett LEGENDARY INVESTMENTS Phone: +1 (203) 087-26-12 Fax: +1 (203) 087-26-89 ___ dev mailing

[ovs-dev] [PATCH] netdev-dpdk: Add Flow Control support.

2016-07-22 Thread Sugesh Chandran
Add support for flow-control(mac control frame) to DPDK enabled physical port types. By default, the flow-control is OFF on both rx and tx side. The flow control can be enabled/disabled either when adding a port to OVS or at run time. For eg: To enable flow control support at tx side while adding

[ovs-dev] Returned mail: see transcript for details

2016-07-22 Thread MAILER-DAEMON
The original message was received at Fri, 22 Jul 2016 17:28:55 +0530 from [178.254.251.63] - The following addresses had permanent fatal errors - dev@openvswitch.org ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] [PATCH 9/9] datapath-windows: Post Conntrack delete and new events

2016-07-22 Thread Paul Boca
Acked-by: Paul Boca > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sairam > Venugopal > Sent: Thursday, July 14, 2016 2:39 AM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH 9/9] datapath-windows: Post Conntrack

Re: [ovs-dev] [PATCH 8/9] datapath-windows: Update OvsReadEventCmdHandler in Datapath.c to support different events

2016-07-22 Thread Paul Boca
Besides some alignment issues, looks god. Acked-by: Paul Boca > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Sairam > Venugopal > Sent: Thursday, July 14, 2016 2:39 AM > To: dev@openvswitch.org > Subject: [ovs-dev]

  1   2   >