Re: [ovs-dev] Valgrind memory leak at ovsdb_monitor_table_condition_create

2016-07-24 Thread Liran Schour
William Tu wrote on 23/07/2016 04:20:10 AM: > From: William Tu > To: "" > Cc: Liran Schour/Haifa/IBM@IBMIL > Date: 23/07/2016 04:20 AM > Subject: Valgrind memory leak at ovsdb_monitor_table_condition_create > > Hi, > > Testcases which exercises this code report definitely memory lost. An > ex

Re: [ovs-dev] releasing 2.6: branch Aug 1, release Sep 15

2016-07-24 Thread Thadeu Lima de Souza Cascardo
On Sat, Jul 23, 2016 at 08:59:35AM -0700, Ben Pfaff wrote: > The proposed Open vSwitch release schedule calls for branching 2.6 from > master on Aug. 1, followed by a period of bug fixes and stabilization, > with release on Sep. 15. The proposed release schedule is posted here > for review: >

[ovs-dev] [PATCH V3] ovs-vtep: vtep-ctl and ovs-vtep support of adding explicit tunnel key

2016-07-24 Thread itamaro
From: itamaro This patch adds support for handeling a per-tunnel tunnel key in the ovs-vtep and vtep-ctl to support the usage of neutron L2GW as an inter-cloud gateway. The Neutron spec is available here: https://review.openstack.org/#/c/270786/ The aim of this patch is to support the usage of

Re: [ovs-dev] [PATCH RFC v3 1/1] netdev-dpdk: Add support for DPDK 16.07

2016-07-24 Thread Aaron Conole
Hi Daniele, Daniele Di Proietto writes: > Thanks for the patch. > > I have another concern with this. If we're still going to rely on RCU to > protect the vhost device (and as pointed out by Ilya, I think we should) we > need to use RCU-like semantics on the vid array index. I'm not sure a > bo

[ovs-dev] [PATCH] ovn: remove unnecessary conditional statements.

2016-07-24 Thread nickcooper-zhangtonghao
It is unnecessary to check ‘chassis_id’ again. Signed-off-by: nickcooper-zhangtonghao --- ovn/controller/ovn-controller.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn-controller.c index dcab918..4d9490a 100644

[ovs-dev] [PATCH] ovn: don't create the "" patch port.

2016-07-24 Thread nickcooper-zhangtonghao
It is not necessary to create the logical patch port whose peer named "". Signed-off-by: nickcooper-zhangtonghao --- ovn/controller/patch.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ovn/controller/patch.c b/ovn/controller/patch.c index 707d08b..7e3ae39 100644 --- a/

Re: [ovs-dev] [PATCH] TODO.md: Remove.

2016-07-24 Thread Vladimir Shebordaev
Ben, ok, but does it mean you completely reject recent attempt to implement OF meters in kernel datapath (ab)using tc capabilities? It is OF meter implementation that is the only feature on the list that was worth mentioning since it is the only sensible OF feature that is (yet) totally unimpleme

Re: [ovs-dev] [PATCH V13] Function tracer to trace all function calls

2016-07-24 Thread Ryan Moats
"dev" wrote on 07/08/2016 07:04:06 PM: > From: Nirapada Ghosh/San Jose/IBM@IBMUS > To: dev@openvswitch.org > Date: 07/08/2016 07:04 PM > Subject: [ovs-dev] [PATCH V13] Function tracer to trace all function calls > Sent by: "dev" > > From: Nirapada Ghosh > > In some circumstances, we might need

[ovs-dev] [PATCH 2/2] route-table: flush addresses list when route table is reset

2016-07-24 Thread Thadeu Lima de Souza Cascardo
When the route table is reset, the addresses list may be out of date, as we race for the many netlink socket notifications. A quick fix for this is flushing the addresses list, before dumping the routes and gathering source addresses for them. That way, instead of using invalid source addresses o

[ovs-dev] [PATCH 1/2] ovs-router: ignore IPv6 source addresses for IPv4 routes

2016-07-24 Thread Thadeu Lima de Souza Cascardo
Though this should not happen when we have another address on the device that is IPv4 mapped, we should prevent adding a routing entry to IPv4 with an IPv6 source address. This entry has been observed when the addresses list was out of date. Cached: 172.16.10.1/32 dev br3 SRC fe80::c4d0:14ff:feb1

Re: [ovs-dev] [PATCH 2/2] route-table: flush addresses list when route table is reset

2016-07-24 Thread Thadeu Lima de Souza Cascardo
On Sun, Jul 24, 2016 at 01:07:27PM -0300, Thadeu Lima de Souza Cascardo wrote: > When the route table is reset, the addresses list may be out of date, as we > race > for the many netlink socket notifications. > > A quick fix for this is flushing the addresses list, before dumping the routes > and

Re: [ovs-dev] [PATCH] ovn: remove the dead code.

2016-07-24 Thread Numan Siddique
On Sun, Jul 24, 2016 at 6:26 AM, Ryan Moats wrote: > "dev" wrote on 07/21/2016 05:36:13 AM: > > > From: nickcooper-zhangtonghao > > To: dev@openvswitch.org > > Cc: nickcooper-zhangtonghao > > Date: 07/21/2016 05:36 AM > > Subject: [ovs-dev] [PATCH] ovn: remove the dead code. > > Sent by: "dev"

Re: [ovs-dev] [PATCH] ovn: remove the dead code.

2016-07-24 Thread Ryan Moats
Numan Siddique wrote on 07/24/2016 11:21:07 AM: > From: Numan Siddique > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: nickcooper-zhangtonghao zhangtong...@opencloud.tech>, ovs dev > Date: 07/24/2016 11:21 AM > Subject: Re: [ovs-dev] [PATCH] ovn: remove the dead code. > > On Sun, Jul 24, 2016 at 6:26 A

[ovs-dev] [PATCH] ovn-controller: squelch expected duplicate flow warnings

2016-07-24 Thread Ryan Moats
In the physical processing of ovn-controller, there are two sets of OF flows that are still fully recalculated every cycle: Flows that aren't associated with any logical flow, and Flows calculated based on multicast groups Because these flows are recalculated fully each cycle, full duplicates

Re: [ovs-dev] [PATCH] TODO.md: Remove.

2016-07-24 Thread Ben Pfaff
On Sun, Jul 24, 2016 at 06:10:04PM +0300, Vladimir Shebordaev wrote: > ok, but does it mean you completely reject recent attempt to implement OF > meters in kernel datapath (ab)using tc capabilities? > > It is OF meter implementation that is the only feature on the list that was > worth mentioning

Re: [ovs-dev] [PATCH] ovn: remove unnecessary conditional statements.

2016-07-24 Thread Ben Pfaff
On Sun, Jul 24, 2016 at 07:40:35AM -0700, nickcooper-zhangtonghao wrote: > It is unnecessary to check ‘chassis_id’ again. > > Signed-off-by: nickcooper-zhangtonghao > Thanks, applied. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mai

Re: [ovs-dev] [PATCH] ovn: don't create the "" patch port.

2016-07-24 Thread Ben Pfaff
On Sun, Jul 24, 2016 at 07:58:19AM -0700, nickcooper-zhangtonghao wrote: > It is not necessary to create the logical patch port whose peer named > "". > > Signed-off-by: nickcooper-zhangtonghao > It seems to me that this fix is in the wrong place. If any change is needed, I would suggest that

Re: [ovs-dev] [PATCH] ovn: remove the dead code.

2016-07-24 Thread Ben Pfaff
On Sun, Jul 24, 2016 at 12:04:43PM -0500, Ryan Moats wrote: > Numan Siddique wrote on 07/24/2016 11:21:07 AM: > > > From: Numan Siddique > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: nickcooper-zhangtonghao > zhangtong...@opencloud.tech>, ovs dev > > Date: 07/24/2016 11:21 AM > > Subject: Re: [ov

Re: [ovs-dev] [PATCH] TODO.md: Remove.

2016-07-24 Thread Ben Pfaff
On Sat, Jul 23, 2016 at 07:51:11PM -0500, Ryan Moats wrote: > "dev" wrote on 07/22/2016 03:18:09 PM: > > > From: Ben Pfaff > > To: dev@openvswitch.org > > Cc: Ben Pfaff > > Date: 07/22/2016 03:18 PM > > Subject: [ovs-dev] [PATCH] TODO.md: Remove. > > Sent by: "dev" > > > > No one has implement

Re: [ovs-dev] releasing 2.6: branch Aug 1, release Sep 15

2016-07-24 Thread Ben Pfaff
On Sun, Jul 24, 2016 at 08:39:31AM -0300, Thadeu Lima de Souza Cascardo wrote: > On Sat, Jul 23, 2016 at 08:59:35AM -0700, Ben Pfaff wrote: > > The proposed Open vSwitch release schedule calls for branching 2.6 from > > master on Aug. 1, followed by a period of bug fixes and stabilization, > > with

Re: [ovs-dev] [PATCH] ovs-ofctl: Fix font in manual.

2016-07-24 Thread Ben Pfaff
On Sat, Jul 23, 2016 at 07:48:32PM -0500, Ryan Moats wrote: > "dev" wrote on 07/22/2016 04:33:56 PM: > > > From: Ben Pfaff > > To: dev@openvswitch.org > > Cc: Ben Pfaff > > Date: 07/22/2016 04:34 PM > > Subject: [ovs-dev] [PATCH] ovs-ofctl: Fix font in manual. > > Sent by: "dev" > > > > Withou

Re: [ovs-dev] [PATCH] Fix typos: s/OSVDB/OVSDB/.

2016-07-24 Thread Ben Pfaff
On Sat, Jul 23, 2016 at 07:53:56PM -0500, Ryan Moats wrote: > "dev" wrote on 07/22/2016 03:16:05 PM: > > > From: Ben Pfaff > > To: dev@openvswitch.org > > Cc: Ben Pfaff > > Date: 07/22/2016 03:16 PM > > Subject: [ovs-dev] [PATCH] Fix typos: s/OSVDB/OVSDB/. > > Sent by: "dev" > > > > Signed-off

Re: [ovs-dev] [PATCH RFC v3 1/1] netdev-dpdk: Add support for DPDK 16.07

2016-07-24 Thread Ben Pfaff
On Sun, Jul 24, 2016 at 10:17:13AM -0400, Aaron Conole wrote: > Daniele Di Proietto writes: > > > Thanks for the patch. > > > > I have another concern with this. If we're still going to rely on RCU to > > protect the vhost device (and as pointed out by Ilya, I think we should) we > > need to use

Re: [ovs-dev] [PATCH V13] Function tracer to trace all function calls

2016-07-24 Thread Ben Pfaff
On Sun, Jul 24, 2016 at 10:34:45AM -0500, Ryan Moats wrote: > Ben, if you want to take a deeper look, feel free - I plan on > marking the patch as "Changes Requested" in patchworks once this > message shows up in the review change there. These seem like good comments to me so I'll look at it after

[ovs-dev] [PATCH] Explain initialization when using csum()

2016-07-24 Thread Ryan Moats
The checksum method csum() requires its output location to be intialized to zero when that output location is part of the checksum. Add comments to the various places where csum is called documenting where the initialization has occurred. Signed-off-by: Ryan Moats --- lib/bfd.c|

Re: [ovs-dev] [PATCH] ovn: remove the dead code.

2016-07-24 Thread Ryan Moats
Ben Pfaff wrote on 07/24/2016 12:56:29 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: Numan Siddique , ovs dev > , nickcooper-zhangtonghao zhangtong...@opencloud.tech> > Date: 07/24/2016 12:56 PM > Subject: Re: [ovs-dev] [PATCH] ovn: remove the dead code. > > On Sun, Jul 24, 2016

Re: [ovs-dev] [PATCH] Explain initialization when using csum()

2016-07-24 Thread Ben Pfaff
On Sun, Jul 24, 2016 at 06:36:35PM +, Ryan Moats wrote: > The checksum method csum() requires its output location to be > intialized to zero when that output location is part of the > checksum. Add comments to the various places where csum is > called documenting where the initialization has o

[ovs-dev] [PATCH] ovn-controller: Add incremental processing for multicast groups

2016-07-24 Thread Ryan Moats
The various fixes in handling physical and binding changes have addressed the problems that the original attempt to incrementally process the multicast group table ran into. So, re-add incremental processing of the multicast group table. Notes: - This patch renders the short term changes in [1] ta

Re: [ovs-dev] [PATCH v2] ovn: Make it possible for CMS to detect when the OVN system is up-to-date.

2016-07-24 Thread Ryan Moats
Ben Pfaff wrote on 07/19/2016 01:40:29 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 07/19/2016 01:40 PM > Subject: Re: [ovs-dev] [PATCH v2] ovn: Make it possible for CMS to > detect when the OVN system is up-to-date. > > On Mon, Jul 18, 2016 at 10:29:3

Re: [ovs-dev] [PATCH monitor_cond V10] RFC OVN: Implementation of conditional monitoring usage

2016-07-24 Thread Ryan Moats
"dev" wrote on 07/19/2016 03:44:40 AM: > From: Liran Schour > To: Ben Pfaff > Cc: dev@openvswitch.org > Date: 07/19/2016 03:45 AM > Subject: [ovs-dev] [PATCH monitor_cond V10] RFC OVN: Implementation > of conditional monitoring usage > Sent by: "dev" > > Conditional monitor of: Port_Binding,

[ovs-dev] [PATCH v3] ovn: Make it possible for CMS to detect when the OVN system is up-to-date.

2016-07-24 Thread Ben Pfaff
Until now, there has been no reliable for the CMS (or ovn-nbctl, or anything else) to detect when changes made to the northbound configuration have been passed through to the southbound database or to the hypervisors. This commit adds this feature to the system, by adding sequence numbers to the no

Re: [ovs-dev] [PATCH v2] ovn: Make it possible for CMS to detect when the OVN system is up-to-date.

2016-07-24 Thread Ben Pfaff
On Sun, Jul 24, 2016 at 02:55:25PM -0500, Ryan Moats wrote: > Ben Pfaff wrote on 07/19/2016 01:40:29 PM: > > > From: Ben Pfaff > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: dev@openvswitch.org > > Date: 07/19/2016 01:40 PM > > Subject: Re: [ovs-dev] [PATCH v2] ovn: Make it possible for CMS to > > d

Re: [ovs-dev] [PATCH v2] ovn-controller: eliminate stall in ofctrl state machine

2016-07-24 Thread Ben Pfaff
On Sat, Jul 23, 2016 at 09:35:38AM -0500, Ryan Moats wrote: > While this code is cleaner and more robust, running it against the same > end-to-end tests that I applied to Lance's original/V2 patches doesn't > result in the same small performance gain at larger port densities > and reveals a very sl

Re: [ovs-dev] [PATCH v2] ovn-controller: eliminate stall in ofctrl state machine

2016-07-24 Thread Ryan Moats
Ben Pfaff wrote on 07/24/2016 03:17:18 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: Lance Richardson , dev@openvswitch.org > Date: 07/24/2016 03:17 PM > Subject: Re: [ovs-dev] [PATCH v2] ovn-controller: eliminate stall in > ofctrl state machine > > On Sat, Jul 23, 2016 at 09:35:3

Re: [ovs-dev] [PATCH] ovn: remove the dead code.

2016-07-24 Thread nickcooper-zhangtonghao
I apologize for this mistake. > On Jul 25, 2016, at 2:40 AM, Ryan Moats wrote: > > Ben Pfaff wrote on 07/24/2016 12:56:29 PM: > > > From: Ben Pfaff > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: Numan Siddique , ovs dev > > , nickcooper-zhangtonghao > zhangtong...@opencloud.tech> > > Date: 07/2

Re: [ovs-dev] [PATCH v2] ovn-controller: eliminate stall in ofctrl state machine

2016-07-24 Thread Ben Pfaff
On Sun, Jul 24, 2016 at 04:44:12PM -0500, Ryan Moats wrote: > Ben Pfaff wrote on 07/24/2016 03:17:18 PM: > > > From: Ben Pfaff > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: Lance Richardson , dev@openvswitch.org > > Date: 07/24/2016 03:17 PM > > Subject: Re: [ovs-dev] [PATCH v2] ovn-controller: eli

Re: [ovs-dev] [PATCH v7] ovn-northd: Add logical flows to support native DHCPv4

2016-07-24 Thread Ramu Ramamurthy
Tested to work end-to-end with openstack. On Sat, Jul 23, 2016 at 5:49 AM, Numan Siddique wrote: > OVN implements a native DHCPv4 support which caters to the common > use case of providing an IP address to a booting instance by > providing stateless replies to DHCPv4 requests based on statically

Re: [ovs-dev] [PATCH] ovn-controller: Add incremental processing for multicast groups

2016-07-24 Thread Flaviof
On Sun, Jul 24, 2016 at 2:33 PM, Ryan Moats wrote: > The various fixes in handling physical and binding changes > have addressed the problems that the original attempt to > incrementally process the multicast group table ran into. > So, re-add incremental processing of the multicast group > table

Re: [ovs-dev] [PATCH] ovn-controller: Add incremental processing for multicast groups

2016-07-24 Thread Ryan Moats
Flaviof wrote on 07/24/2016 08:14:19 PM: > From: Flaviof > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: ovs dev > Date: 07/24/2016 08:14 PM > Subject: Re: [ovs-dev] [PATCH] ovn-controller: Add incremental > processing for multicast groups > > On Sun, Jul 24, 2016 at 2:33 PM, Ryan Moats wrote: > The v

Re: [ovs-dev] [PATCH v7] ovn-northd: Add logical flows to support native DHCPv4

2016-07-24 Thread Ramu Ramamurthy
On Sat, Jul 23, 2016 at 5:49 AM, Numan Siddique wrote: > OVN implements a native DHCPv4 support which caters to the common > use case of providing an IP address to a booting instance by > providing stateless replies to DHCPv4 requests based on statically > configured address mappings. To do this i

Re: [ovs-dev] [PATCH] ovn-controller: Add incremental processing for multicast groups

2016-07-24 Thread Flaviof
On Sun, Jul 24, 2016 at 8:20 PM, Ryan Moats wrote: > Flaviof wrote on 07/24/2016 08:14:19 PM: > > > From: Flaviof > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: ovs dev > > Date: 07/24/2016 08:14 PM > > Subject: Re: [ovs-dev] [PATCH] ovn-controller: Add incremental > > processing for multicast gro

[ovs-dev] [Bug Report] physical switch is randomly set err-disabled while inter-connects with ovs-2.4.0

2016-07-24 Thread Zhang Haoyu
Hi all Cisco Switch port will be randomly set err-disabled while connected to ovs-2.4.0, it is very hard to reproduce this problem. From Cisco switch perspective, the port was disabled because receiving a keepalive packet which was originated from the Cisco switch port. Cisco switch port gener

Re: [ovs-dev] [patch_v6 2/2] ovn: Reformat some ovn design documentation.

2016-07-24 Thread Flaviof
Embarrassingly minor nitpicks follow... On Sat, Jul 23, 2016 at 3:18 PM, Darrell Ball wrote: > Some design micro-details (e.g.) register assignments) that may change > over time were moved from the ovn-architecture.7.xml document to the > OVN-DESIGN.md document. A table is added to summarize a

[ovs-dev] [PATCH v3] Windows: Local named pipe implementation

2016-07-24 Thread Alin Serdean
Currently in the case of command line arguments punix/unix, on Windows we create a file, write a TCP port number to connect. This is a security concern. This patch adds support for the command line arguments punix/unix trying to mimic AF_UNIX behind a local named pipe. This patch drops the TCP so

Re: [ovs-dev] [PATCH 1/3] utilities/ovs-ctl.in: Allow non-monitoring daemons

2016-07-24 Thread Flaviof
On Wed, Jul 20, 2016 at 4:21 PM, Aaron Conole wrote: > This commit allows the ovs-ctl command to spawn daemons without the > internal process monitor. This is useful when integrating with, > ex. systemd, which provides its own monitoring facilities. > > Signed-off-by: Aaron Conole > Acked-by: B

Re: [ovs-dev] [PATCH v4] XPS implementation (Second part of XPS patch-set).

2016-07-24 Thread Ilya Maximets
Ping. Best regards, Ilya Maximets. On 13.07.2016 15:34, Ilya Maximets wrote: > This is the second part of XPS patch-set which contains XPS itself. > > Version 4: > * Dropped rwlock related patches. > * Added pointer from 'struct tx_port' to 'struct dp_netdev_port' > to avoid

Re: [ovs-dev] [PATCH v3 0/3] Manual pinning of rxqs (Third part of XPS patch-set).

2016-07-24 Thread Ilya Maximets
Ping. Best regards, Ilya Maximets. On 15.07.2016 14:54, Ilya Maximets wrote: > This is the third and last part of XPS patch-set which contains > implementation of manual pinning of rx queues to pmd threads. > > Manual pinning API was discussed here: > http://openvswitch.org/pipermail/dev/2016-Ju

Re: [ovs-dev] [PATCH monitor_cond V10] RFC OVN: Implementation of conditional monitoring usage

2016-07-24 Thread Liran Schour
Ryan Moats/Omaha/IBM wrote on 24/07/2016 11:03:21 PM: > From: Ryan Moats/Omaha/IBM > To: Liran Schour > Cc: Ben Pfaff , dev@openvswitch.org > Date: 24/07/2016 11:03 PM > Subject: Re: [ovs-dev] [PATCH monitor_cond V10] RFC OVN: > Implementation of conditional monitoring usage > > "dev" wrote on

Re: [ovs-dev] [PATCH monitor_cond V10] RFC OVN: Implementation of conditional monitoring usage

2016-07-24 Thread Liran Schour
"dev" wrote on 25/07/2016 09:03:55 AM: > From: Liran Schour/Haifa/IBM@IBMIL > To: "Ryan Moats" > Cc: dev@openvswitch.org > Date: 25/07/2016 09:04 AM > Subject: Re: [ovs-dev] [PATCH monitor_cond V10] RFC OVN: > Implementation of conditional monitoring usage > Sent by: "dev" > > Ryan Moats/Omah