[ovs-dev] [PATCH] ovn-sb.xml: Remove obsolete documentation of OVN logical flows.

This description might have been accurate for 5 minutes or so, but no longer than that. Signed-off-by: Ben Pfaff --- ovn/ovn-sb.xml | 40 ++-- 1 file changed, 2 insertions(+), 38 deletions(-) diff --git a/ovn/ovn-sb.xml b/ovn/ovn-sb.xml index c5f236e..694135f

[ovs-dev] RFC: two-week feature freeze on master before branching

We've done a good job of getting our features into master before branching for the 2.6 release on the proposed date of Aug. 1. Thanks, everybody. However, I know that some features targeted at 2.6 will be coming in next week, because various developers have already mentioned this. This means tha

[ovs-dev] [PATCH v3] ofproto: Reduce bundle memory use.

Instead of storing the (big) struct ofputil_flow_mod, create the new rule and/or create the rule criteria for matching at bundle message insert time. These can be uninitialized right after the start phase during the commit, which may also reduce the total memory needed during the bundle commit. S

[ovs-dev] [PATCH 2/7] vswitchd: Introduce 'mtu_request' column in Interface.

The 'mtu_request' column can be used to set the MTU of a specific interface. This column is useful because it will allow changing the MTU of DPDK devices (implemented in a future commit), which are not accessible outside the ovs-vswitchd process, but it can be used for kernel interfaces as well.

[ovs-dev] [PATCH 7/7] netdev-dpdk: add support for Jumbo Frames

From: Mark Kavanagh Add support for Jumbo Frames to DPDK-enabled port types, using single-segment-mbufs. Using this approach, the amount of memory allocated to each mbuf to store frame data is increased to a value greater than 1518B (typical Ethernet maximum frame length). The increased space av

[ovs-dev] [PATCH 6/7] netdev: Make netdev_set_mtu() netdev parameter non-const.

Every provider silently drops the const attribute when converting the parameter to the appropriate subclass. Might as well drop the const attribute from the parameter, since this is a "set" function. --- lib/netdev-dummy.c| 2 +- lib/netdev-linux.c| 2 +- lib/netdev-provider.h | 2 +- lib

[ovs-dev] [PATCH 5/7] tests: Add a new MTU test.

Also, netdev-dummy needs to call netdev_change_seq_changed() in set_mtu(). Signed-off-by: Daniele Di Proietto --- lib/netdev-dummy.c| 5 - tests/ofproto-dpif.at | 30 ++ 2 files changed, 34 insertions(+), 1 deletion(-) diff --git a/lib/netdev-dummy.c b/lib/n

[ovs-dev] [PATCH 4/7] netdev-dummy: Add dummy-internal class.

"internal" netdevs are treated specially in OVS (e.g. for MTU), but the dummy datapath remaps both "system" and "internal" devices to the same "dummy" netdev class, so there's no way to discern those in tests. This commit adds a new "dummy-internal" netdev type, which will be used by the dummy dat

[ovs-dev] [PATCH 1/7] ofproto: Consider datapath_type when looking for internal ports.

Interfaces with type "internal" end up having a netdev with type "tap" in the dpif-netdev datapath, so a strcmp will fail to match internal interfaces. We can translate the types with ofproto_port_open_type() before calling strcmp to fix this. This fixes a minor issue where internal interfaces ar

[ovs-dev] [PATCH 3/7] netdev: Pass 'netdev_class' to ->run() and ->wait().

This will allow run() and wait() methods to be shared between different classes and still perform class-specific work. Signed-off-by: Daniele Di Proietto --- lib/netdev-bsd.c | 6 +++--- lib/netdev-dummy.c| 4 ++-- lib/netdev-linux.c| 6 +++--- lib/netdev-provider.h | 14

Re: [ovs-dev] tests: Add new pmd test for pmd-rxq-affinity.

Thanks for the review, applied to master On 28/07/2016 01:59, "Ilya Maximets" wrote: >Thanks for making this. > >Acked-by: Ilya Maximets > >On 27.07.2016 23:12, Daniele Di Proietto wrote: >> This tests that the newly introduced pmd-rxq-affinity option works as >> intended, at least for a sin

Re: [ovs-dev] [PATCH] dpif-netdev: Fix xps revalidation.

Thanks for the fix, applied to master! On 29/07/2016 01:07, "Ilya Maximets" wrote: >Revalidation should work in case of 'dynamic_txqs == true'. > >Fixes: 324c8374852a ("dpif-netdev: XPS (Transmit Packet Steering) >implementation.") >Signed-off-by: Ilya Maximets >--- > lib/dpif-netdev.c | 2

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Add Flow Control support.

I changed the fc_conf initialization to use memset, because clang was complaining about the initializer. I moved the description in vswitch.xml to avoid nesting inside the "Common Columns" group. I changed slightly the wording in vswitch.xml, in case we want to implement this even for non DPDK de

Re: [ovs-dev] [PATCH v2 0/3] datapath: tunneling fixes.

On 26 July 2016 at 15:24, Pravin B Shelar wrote: > First two patches fixes to issues related to geneva and vxlan tunnel. > Third patch is just code improvement. It looks like this patch series introduced breakage for kernels < 3.10 (for branch-2.5): https://travis-ci.org/openvswitch/ovs/builds/14

Re: [ovs-dev] [PATCH v2 25/26] ofproto: Add 'command' to ofproto_flow_mod.

Thanks for the reviews Ben! I pushed the series up to this patch to master. Jarno > On Jul 29, 2016, at 4:23 PM, Ben Pfaff wrote: > > On Thu, Jul 28, 2016 at 05:56:17PM -0700, Jarno Rajahalme wrote: >> This helps releasing ofputil_flow_mod earlier in a later patch. >> >> Signed-off-by: Jarno

Re: [ovs-dev] [PATCH v2 26/26] ofproto: Reduce bundle memory use.

> On Jul 29, 2016, at 4:25 PM, Ben Pfaff wrote: > > On Thu, Jul 28, 2016 at 05:56:18PM -0700, Jarno Rajahalme wrote: >> Instead of storing the (big) struct ofputil_flow_mod, create the new >> rule and/or create the rule criteria for matching at bundle message >> insert time. These can be uninit

Re: [ovs-dev] [PATCH v2 23/26] ofproto: Reduce dependency on ofputil_flow_mod after rule has been created.

> On Jul 29, 2016, at 4:20 PM, Ben Pfaff wrote: > > On Thu, Jul 28, 2016 at 05:56:15PM -0700, Jarno Rajahalme wrote: >> One step towards the goal of removing the ofputil_flow_mod from the >> bundle message. >> >> Signed-off-by: Jarno Rajahalme > > Provokes a warning: > ../ofproto/ofproto.c:49

Re: [ovs-dev] [PATCH v2 26/26] ofproto: Reduce bundle memory use.

On Thu, Jul 28, 2016 at 05:56:18PM -0700, Jarno Rajahalme wrote: > Instead of storing the (big) struct ofputil_flow_mod, create the new > rule and/or create the rule criteria for matching at bundle message > insert time. These can be uninitialized right after the start phase > during the commit, w

Re: [ovs-dev] [PATCH v2 25/26] ofproto: Add 'command' to ofproto_flow_mod.

On Thu, Jul 28, 2016 at 05:56:17PM -0700, Jarno Rajahalme wrote: > This helps releasing ofputil_flow_mod earlier in a later patch. > > Signed-off-by: Jarno Rajahalme Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/m

Re: [ovs-dev] [PATCH v2 24/26] ofproto: Add 'modify_cookie' to ofproto_flow_mod.

On Thu, Jul 28, 2016 at 05:56:16PM -0700, Jarno Rajahalme wrote: > ofproto internally modifies 'modify_cookie' field, and adding a > replica to ofproto_flow_mod allows the ofputil_flow_mod argument to be > changed to a const. > > Signed-off-by: Jarno Rajahalme Acked-by: Ben Pfaff __

Re: [ovs-dev] [PATCH v2 23/26] ofproto: Reduce dependency on ofputil_flow_mod after rule has been created.

On Thu, Jul 28, 2016 at 05:56:15PM -0700, Jarno Rajahalme wrote: > One step towards the goal of removing the ofputil_flow_mod from the > bundle message. > > Signed-off-by: Jarno Rajahalme Provokes a warning: ../ofproto/ofproto.c:4939:71: error: unused parameter 'ofm' [-Werror,-Wunused-parameter

Re: [ovs-dev] [PATCH v2 22/26] ofp-util: remove flow mod's delete_reason.

On Thu, Jul 28, 2016 at 05:56:14PM -0700, Jarno Rajahalme wrote: > We can use the rule's removed_reason instead. > > Signed-off-by: Jarno Rajahalme Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/de

Re: [ovs-dev] [PATCH v2 21/26] ofproto: Support group mods in bundles.

On Thu, Jul 28, 2016 at 05:56:13PM -0700, Jarno Rajahalme wrote: > Allow adding group mods in OpenFlow bundles. Group mods are executed > atomically with any flow mods in the same bundle. Mods are executed > in order, so that groups appearing in flow actions need to be inserted > in to the bundle

Re: [ovs-dev] [PATCH v2 19/26] ofproto: Use ofputil_uninit_group_mod().

> On Jul 29, 2016, at 3:59 PM, Ben Pfaff wrote: > > On Thu, Jul 28, 2016 at 05:56:11PM -0700, Jarno Rajahalme wrote: >> Use ofputil_uninit_group_mod() instead of >> ofputil_bucket_list_destroy(). Currently these have the same effect, >> but this will change in a following patch. >> >> Signed-o

Re: [ovs-dev] [PATCH v2 18/26] ofp-util: Do not free() field that is not allocated.

> On Jul 29, 2016, at 3:57 PM, Ben Pfaff wrote: > > On Thu, Jul 28, 2016 at 05:56:10PM -0700, Jarno Rajahalme wrote: >> Group properties field array is not dynamically allocated, so it >> should not be freed. This has not been a problem, as this function >> has not been called by anyone so far,

Re: [ovs-dev] [patch_v6 1/2] ovn: Fix receive from vxlan in ovn-controller.

On Wed, Jul 27, 2016 at 1:35 PM, Ben Pfaff wrote: > On Sat, Jul 23, 2016 at 01:18:01PM -0700, Darrell Ball wrote: > > This patch enables source node replication in OVN for receive from Vxlan > > tunnels. OVN only supports source node replication mode. > > > > OVN only supports source_node replic

Re: [ovs-dev] [PATCH v2 20/26] meta-flow: Compact struct field_array.

On Thu, Jul 28, 2016 at 05:56:12PM -0700, Jarno Rajahalme wrote: > struct field_array is included in each ofgroup, but the current > implementation is very sparse, using more than 20kb of data. > > Also loop over 1-bits instead of each and every MF type to make > processing faster. > > Signed-off

Re: [ovs-dev] [PATCH v2 16/26] meta-flow: Clean up masking with prerequisities checking.

> On Jul 29, 2016, at 3:54 PM, Ben Pfaff wrote: > > On Thu, Jul 28, 2016 at 05:56:08PM -0700, Jarno Rajahalme wrote: >> Change mf_are_prereqs_ok() take a flow_wildcards pointer, so that the >> wildcards can be set at the same time as the prerequisiteis are >> checked. This makes it easier to wr

[ovs-dev] [patch_v7] ovn: Fix receive from vxlan in ovn-controller.

The changes enable source node replication in OVN for receive from Vxlan tunnels. OVN only supports source node replication mode. This is needed for OVN to interoperate with hardware switches. OVN only supports source_node replication and previously vtep interaction, which used service node repl

Re: [ovs-dev] [PATCH v2 19/26] ofproto: Use ofputil_uninit_group_mod().

On Thu, Jul 28, 2016 at 05:56:11PM -0700, Jarno Rajahalme wrote: > Use ofputil_uninit_group_mod() instead of > ofputil_bucket_list_destroy(). Currently these have the same effect, > but this will change in a following patch. > > Signed-off-by: Jarno Rajahalme I get a warning: ../utilities/ovs-

Re: [ovs-dev] [PATCH v2 18/26] ofp-util: Do not free() field that is not allocated.

On Thu, Jul 28, 2016 at 05:56:10PM -0700, Jarno Rajahalme wrote: > Group properties field array is not dynamically allocated, so it > should not be freed. This has not been a problem, as this function > has not been called by anyone so far, but following patch will. > > Signed-off-by: Jarno Rajah

Re: [ovs-dev] [PATCH v2 17/26] ofproto-dpif-xlate: Hash only fields specified for 'hash' selection method.

On Thu, Jul 28, 2016 at 05:56:09PM -0700, Jarno Rajahalme wrote: > The mask for non-present fields in struct field_array is always zero, > so hashing a prerequisite field that was not also specified for the > "hash" selection method boiled down to hashing a all-zeroes value and > unwildcarding the

Re: [ovs-dev] [PATCH v2 16/26] meta-flow: Clean up masking with prerequisities checking.

On Thu, Jul 28, 2016 at 05:56:08PM -0700, Jarno Rajahalme wrote: > Change mf_are_prereqs_ok() take a flow_wildcards pointer, so that the > wildcards can be set at the same time as the prerequisiteis are > checked. This makes it easier to write more obviously correct code. > > Remove the functions

Re: [ovs-dev] [PATCH v2 12/26] vconn: Better bundle error management.

> On Jul 29, 2016, at 1:32 PM, Ben Pfaff wrote: > > On Thu, Jul 28, 2016 at 05:56:04PM -0700, Jarno Rajahalme wrote: >> It is possible that a bundle add message fails, but the following >> commit succeeds, since the message was not added to the bundle. Make >> ovs-ofctl fail also in these cases

Re: [ovs-dev] [PATCH v2 11/26] vconn: Update length of bundled messages.

> On Jul 29, 2016, at 1:20 PM, Ben Pfaff wrote: > > On Thu, Jul 28, 2016 at 05:56:03PM -0700, Jarno Rajahalme wrote: >> Variable length messages need their length updated before they can be >> added to the bundle. >> >> Message length updating after encoding is sometimes done by the >> encoding

Re: [ovs-dev] [PATCH v2 10/26] ofproto: Make groups versioned.

> On Jul 29, 2016, at 1:18 PM, Ben Pfaff wrote: > > On Thu, Jul 28, 2016 at 05:56:02PM -0700, Jarno Rajahalme wrote: >> This is a prepatory step for adding group mod support for bundles in a >> following patch. >> >> Signed-off-by: Jarno Rajahalme > > I'd usually see remove_groups_rcu() imple

Re: [ovs-dev] [PATCH v2 15/26] meta-flow: Add mf_mask_field_masked().

On Thu, Jul 28, 2016 at 05:56:07PM -0700, Jarno Rajahalme wrote: > Having a masked version allows generating better wildcarding. > > Signed-off-by: Jarno Rajahalme That special case is ugly, maybe we can do better someday. Acked-by: Ben Pfaff ___ dev

Re: [ovs-dev] [PATCH v2 06/26] ofproto: Add generic ofproto_collection.

On Fri, Jul 29, 2016 at 03:17:19PM -0700, Jarno Rajahalme wrote: > > > On Jul 29, 2016, at 12:46 PM, Ben Pfaff wrote: > > > > On Thu, Jul 28, 2016 at 05:55:58PM -0700, Jarno Rajahalme wrote: > >> Define rule_collection in terms of a new ofproto_collection. This > >> makes it easier to add other

Re: [ovs-dev] Read only versions of the *ctl binaries

Ben Pfaff wrote on 07/29/2016 05:27:29 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 07/29/2016 05:27 PM > Subject: Re: [ovs-dev] Read only versions of the *ctl binaries > > On Fri, Jul 29, 2016 at 04:11:00PM -0500, Ryan Moats wrote: > > > > We just rec

Re: [ovs-dev] [PATCH v2 09/26] ofproto: refactor group mods.

> On Jul 29, 2016, at 1:07 PM, Ben Pfaff wrote: > > On Thu, Jul 28, 2016 at 05:56:01PM -0700, Jarno Rajahalme wrote: >> This changes ofproto providers modify_group() to never fail. >> >> Separating major refactoring to a separate patch should make following >> patches easier to review. >> >> S

Re: [ovs-dev] Read only versions of the *ctl binaries

On Fri, Jul 29, 2016 at 04:11:00PM -0500, Ryan Moats wrote: > > We just received a new operational requirement that we have > to restrict access to all binaries that provide RW access to > infrastructure components, but yet still have the ability to > read current state from the infrastructure. >

[ovs-dev] [PATCH v3] ovn: Support for GARP for NAT IPs via localnet

In cases where a DNAT IP is moved to a new router or the SNAT IP is reused with a new mac address, the NAT IPs become unreachable because the external switches/routers have stale ARP entries. This commit aims to fix the problem by sending GARPs for NAT IPs via locanet A new options key "nat-addres

Re: [ovs-dev] [PATCH] ovs-numa: fixed cmask parse with 0x prefix

2016-07-27 23:22 GMT-07:00 Shen, Wei1 : > Thanks for the reply. The INSTALL.DPDK.md has those “0x” prefix used as > example > > > > 212 * dpdk-lcore-mask > > 213 Specifies the CPU cores on which dpdk lcore threads should be > spawned and > > 214 expects hex string (eg '0x123'). > >

Re: [ovs-dev] [PATCH v2 06/26] ofproto: Add generic ofproto_collection.

> On Jul 29, 2016, at 12:46 PM, Ben Pfaff wrote: > > On Thu, Jul 28, 2016 at 05:55:58PM -0700, Jarno Rajahalme wrote: >> Define rule_collection in terms of a new ofproto_collection. This >> makes it easier to add other types of collections later. >> >> This patch makes no functional changes. >

[ovs-dev] [PATCH] Make the PID part of socket path configurable

[Sorry in advance for the formatting, submitting on mobile. Raw patch attached.] As handling software via cgroups is more and more common, PID files are not always needed. This change adds --disable-pid-socket-path to ./configure to build OpenvSwitch without this PID section of the socket path. Th

Re: [ovs-dev] [PATCH v2] ovn-controller: Restore ct zone assignment.

On Fri, Jul 29, 2016 at 3:52 PM, Ryan Moats wrote: > Acked-by: Ryan Moats Thanks, applied to master. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] Read only versions of the *ctl binaries

We just received a new operational requirement that we have to restrict access to all binaries that provide RW access to infrastructure components, but yet still have the ability to read current state from the infrastructure. For OVN/OVS, this means we won't be able to use the following binaries

Re: [ovs-dev] [PATCH 2/4] tests: Remove trim_zeros() from ovn tests.

On 28/07/2016 22:22, "Ben Pfaff" wrote: >On Thu, Jul 28, 2016 at 07:58:04PM -0700, Daniele Di Proietto wrote: >> trim_zeros() is not necessary anymore, since now we don't pad packets in >> the userspace datapath. >> >> Signed-off-by: Daniele Di Proietto > >Oops, I just committed a patch th

Re: [ovs-dev] [PATCH] travis: Fix flake8 failures from flake8 3.0.

On Fri, Jul 29, 2016 at 4:57 PM, Russell Bryant wrote: > > > On Fri, Jul 29, 2016 at 3:30 PM, Andy Zhou wrote: > >> >> >> On Fri, Jul 29, 2016 at 12:18 PM, Russell Bryant wrote: >> >>> The "hacking" plugin for flake8 is not currently compatible with flake8 >>> 3.0. Ensure that we install flake

Re: [ovs-dev] [PATCH v2 05/26] ofproto: Use ofproto_mutex for groups and keep track of referring flows.

> On Jul 29, 2016, at 1:41 PM, Ben Pfaff wrote: > > On Fri, Jul 29, 2016 at 01:19:03PM -0700, Jarno Rajahalme wrote: >> >>> On Jul 29, 2016, at 12:33 PM, Ben Pfaff wrote: >>> >>> On Thu, Jul 28, 2016 at 05:55:57PM -0700, Jarno Rajahalme wrote: Adding groups support for bundles is simpler

Re: [ovs-dev] [PATCH] travis: Fix flake8 failures from flake8 3.0.

On Fri, Jul 29, 2016 at 3:30 PM, Andy Zhou wrote: > > > On Fri, Jul 29, 2016 at 12:18 PM, Russell Bryant wrote: > >> The "hacking" plugin for flake8 is not currently compatible with flake8 >> 3.0. Ensure that we install flake8 2.x on travis-ci. Also update the >> docs to indicate this incompat

Re: [ovs-dev] [PATCH v2 14/26] meta-flow: Add byte access to struct mf_value.

On Thu, Jul 28, 2016 at 05:56:06PM -0700, Jarno Rajahalme wrote: > This allows reducing pointer casting when individual bytes of mf_value > are accessed. First users are in the following patches. > > Signed-off-by: Jarno Rajahalme Acked-by: Ben Pfaff ___

[ovs-dev] FW: OVS branching 2.6

FYI > -Mesaj original- > De la: Ben Pfaff [mailto:b...@ovn.org] > Trimis: Friday, July 29, 2016 11:53 PM > Către: Alin Serdean > Cc: Guru Shetty ; Sairam Venugopal > ; Nithin Raju ; Justin Pettit > ; Alessandro Pilotti > Subiect: Re: OVS branching 2.6 > > Sure, thanks. > > On Fri, Jul

Re: [ovs-dev] [PATCH 3/5] check-kernel: 802.1ad: Add conntrack ping tests for CVLANs.

On 29 July 2016 at 13:48, Eric Garver wrote: > On Fri, Jul 29, 2016 at 11:34:24AM -0700, Joe Stringer wrote: >> On 29 July 2016 at 11:30, Joe Stringer wrote: >> > On 28 July 2016 at 10:54, Eric Garver wrote: >> >> Signed-off-by: Eric Garver >> > >> > Can you describe your setup? (distro, kernel

Re: [ovs-dev] [PATCH 0/5] check-kernel: add 802.1ad tests

On 29 July 2016 at 13:11, Eric Garver wrote: > Hi Joe, > > Thanks for providing feedback. > > On Fri, Jul 29, 2016 at 11:14:36AM -0700, Joe Stringer wrote: >> On 28 July 2016 at 10:54, Eric Garver wrote: >> > This series adds 6 test cases to the "check-kernel" make target for >> > 802.1ad. It is

Re: [ovs-dev] [PATCH 3/5] check-kernel: 802.1ad: Add conntrack ping tests for CVLANs.

On Fri, Jul 29, 2016 at 11:34:24AM -0700, Joe Stringer wrote: > On 29 July 2016 at 11:30, Joe Stringer wrote: > > On 28 July 2016 at 10:54, Eric Garver wrote: > >> Signed-off-by: Eric Garver > > > > Can you describe your setup? (distro, kernel) RHEL-7.2 Upstream kernel 4.7.0-rc7 > > > > This p

Re: [ovs-dev] [PATCH v2 1/7] datapath-windows: Explicitly name vport related event to vportEvent

Hi Guru, Thanks for applying the patches. I will keep note of that for my future patches. I wasn’t aware of the complications it caused. Regards, Sairam From: Guru Shetty mailto:g...@ovn.org>> Date: Friday, July 29, 2016 at 8:46 AM To: Sairam Venugopal mailto:vsai...@vmware.com>> Cc: ovs dev ma

Re: [ovs-dev] [PATCH v2 05/26] ofproto: Use ofproto_mutex for groups and keep track of referring flows.

On Fri, Jul 29, 2016 at 01:19:03PM -0700, Jarno Rajahalme wrote: > > > On Jul 29, 2016, at 12:33 PM, Ben Pfaff wrote: > > > > On Thu, Jul 28, 2016 at 05:55:57PM -0700, Jarno Rajahalme wrote: > >> Adding groups support for bundles is simpler if also groups are > >> modified under ofproto_mutex. >

Re: [ovs-dev] [PATCH v2 02/26] ofproto: Lockless group lookups.

On Fri, Jul 29, 2016 at 01:02:05PM -0700, Jarno Rajahalme wrote: > > > On Jul 29, 2016, at 12:54 PM, Jarno Rajahalme wrote: > > > >> > >> On Jul 29, 2016, at 12:48 PM, Ben Pfaff >> > wrote: > >> > >> On Fri, Jul 29, 2016 at 11:46:49AM -0700, Jarno Rajahalme wrote: > >>>

Re: [ovs-dev] [PATCH v2 13/26] ofproto-dpif: Always forward 'used' from the old_rule.

On Thu, Jul 28, 2016 at 05:56:05PM -0700, Jarno Rajahalme wrote: > Use new rule's flags to determine whether stats should be forwarded > from the old, modified rule to the new rule. This captures the fact > that prior to OpenFlow 1.2, which defines the reset counts flag, the > reset counts semanti

Re: [ovs-dev] [PATCH v2 12/26] vconn: Better bundle error management.

On Thu, Jul 28, 2016 at 05:56:04PM -0700, Jarno Rajahalme wrote: > It is possible that a bundle add message fails, but the following > commit succeeds, since the message was not added to the bundle. Make > ovs-ofctl fail also in these cases. > > Also, the commit should not be sent if any of the b

Re: [ovs-dev] [PATCH 2/5] check-kernel: 802.1ad: Add datapath ping tests for CVLANs.

On Fri, Jul 29, 2016 at 11:26:30AM -0700, Joe Stringer wrote: > On 28 July 2016 at 10:54, Eric Garver wrote: > > Signed-off-by: Eric Garver > > Hmm, on my Ubuntu 14.04 setup these tests fail with kernel 3.13.0-91, > bupass with kernel 3.19.0-58, but not 3.13.0-91. I guess the 3.13 > kernel didn'

Re: [ovs-dev] [PATCH v2 11/26] vconn: Update length of bundled messages.

On Thu, Jul 28, 2016 at 05:56:03PM -0700, Jarno Rajahalme wrote: > Variable length messages need their length updated before they can be > added to the bundle. > > Message length updating after encoding is sometimes done by the > encoding function, but always latest when the message is sent out.

Re: [ovs-dev] [PATCH v2 05/26] ofproto: Use ofproto_mutex for groups and keep track of referring flows.

> On Jul 29, 2016, at 12:33 PM, Ben Pfaff wrote: > > On Thu, Jul 28, 2016 at 05:55:57PM -0700, Jarno Rajahalme wrote: >> Adding groups support for bundles is simpler if also groups are >> modified under ofproto_mutex. >> >> Eliminate the search for rules when deleting a group so that we will >>

Re: [ovs-dev] [PATCH v2 10/26] ofproto: Make groups versioned.

On Thu, Jul 28, 2016 at 05:56:02PM -0700, Jarno Rajahalme wrote: > This is a prepatory step for adding group mod support for bundles in a > following patch. > > Signed-off-by: Jarno Rajahalme I'd usually see remove_groups_rcu() implemented more like this, avoiding the somewhat-confusing copying

Re: [ovs-dev] [PATCH 2/2] fedora: Prioritize OVS modules in weak-updates.

Thanks for the reviews all, I pushed this to master. On 29 July 2016 at 11:53, Flavio Leitner wrote: > On Thu, Jul 28, 2016 at 05:09:38PM -0700, Joe Stringer wrote: >> Out-of-tree modules are installed into the kernel's "extra" modules >> directory for the version that kmod-openvswitch is compile

Re: [ovs-dev] [PATCH 1/2] rhel: Prioritize our vport-foo modules in depmod.

Thanks for the reviews all, I pushed this to master. On 29 July 2016 at 11:46, Flavio Leitner wrote: > On Thu, Jul 28, 2016 at 05:09:37PM -0700, Joe Stringer wrote: >> We've done the same for openvswitch.ko previously, but we really should >> be doing this for vport modules as well; otherwise, de

Re: [ovs-dev] [PATCH 1/5] check-kernel: Add macros to check for and test 802.1ad.

On Fri, Jul 29, 2016 at 11:17:03AM -0700, Joe Stringer wrote: > On 28 July 2016 at 10:54, Eric Garver wrote: > > Add macros OVS_CHECK_8021AD(), ADD_SVLAN() and ADD_CVLAN(). > > > > Signed-off-by: Eric Garver > > --- > > tests/system-common-macros.at | 29 - > > 1 file

Re: [ovs-dev] [PATCH 0/5] check-kernel: add 802.1ad tests

Hi Joe, Thanks for providing feedback. On Fri, Jul 29, 2016 at 11:14:36AM -0700, Joe Stringer wrote: > On 28 July 2016 at 10:54, Eric Garver wrote: > > This series adds 6 test cases to the "check-kernel" make target for > > 802.1ad. It is meant as a counterpart to the 802.1ad work currently > >

Re: [ovs-dev] [PATCH v2 09/26] ofproto: refactor group mods.

On Thu, Jul 28, 2016 at 05:56:01PM -0700, Jarno Rajahalme wrote: > This changes ofproto providers modify_group() to never fail. > > Separating major refactoring to a separate patch should make following > patches easier to review. > > Signed-off-by: Jarno Rajahalme Needs the "sparse" warning fi

Re: [ovs-dev] [PATCH 2/2] fedora: Prioritize OVS modules in weak-updates.

On 29 July 2016 at 11:41, pravin shelar wrote: > On Thu, Jul 28, 2016 at 5:09 PM, Joe Stringer wrote: >> Out-of-tree modules are installed into the kernel's "extra" modules >> directory for the version that kmod-openvswitch is compiled against. For >> all other kernels on the system at install ti

Re: [ovs-dev] [PATCH v2 02/26] ofproto: Lockless group lookups.

> On Jul 29, 2016, at 12:54 PM, Jarno Rajahalme wrote: > >> >> On Jul 29, 2016, at 12:48 PM, Ben Pfaff mailto:b...@ovn.org>> >> wrote: >> >> On Fri, Jul 29, 2016 at 11:46:49AM -0700, Jarno Rajahalme wrote: >>> On Jul 29, 2016, at 11:20 AM, Ben Pfaff >>> > wrote: >>>

Re: [ovs-dev] [PATCH v3] ovn-controller: Persist desired conntrack groups.

Flaviof wrote on 07/28/2016 11:39:00 PM: > From: Flaviof > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: ovs dev > Date: 07/28/2016 11:39 PM > Subject: Re: [ovs-dev] [PATCH v3] ovn-controller: Persist desired > conntrack groups. > > On Thu, Jul 28, 2016 at 5:17 PM, Ryan Moats wrote: > With incremental

Re: [ovs-dev] [PATCH v2 08/26] ofproto: Report flow mods also from bundles.

On Thu, Jul 28, 2016 at 05:56:00PM -0700, Jarno Rajahalme wrote: > Flow mod stats get skewed if they are not reported from bundles. Move > reporting to ofproto_flow_mod_finish() so that it will be done in all > cases. > > Signed-off-by: Jarno Rajahalme Should we backport this fix? Acked-by: Be

Re: [ovs-dev] [PATCH v2 07/26] ofproto: Generalize flow_mod_requester.

On Thu, Jul 28, 2016 at 05:55:59PM -0700, Jarno Rajahalme wrote: > Group mods also need a 'requester', so rename 'flow_mod_requester' as > 'openflow_mod_requester'. > > Signed-off-by: Jarno Rajahalme Acked-by: Ben Pfaff ___ dev mailing list dev@openvs

Re: [ovs-dev] [PATCH v2 02/26] ofproto: Lockless group lookups.

> On Jul 29, 2016, at 12:48 PM, Ben Pfaff wrote: > > On Fri, Jul 29, 2016 at 11:46:49AM -0700, Jarno Rajahalme wrote: >> >>> On Jul 29, 2016, at 11:20 AM, Ben Pfaff wrote: >>> >>> On Thu, Jul 28, 2016 at 05:55:54PM -0700, Jarno Rajahalme wrote: Make groups RCU protected and make group lo

Re: [ovs-dev] [PATCH v2] ovn-controller: Restore ct zone assignment.

Russell Bryant wrote on 07/29/2016 11:27:49 AM: > From: Russell Bryant > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: ovs dev > Date: 07/29/2016 11:28 AM > Subject: Re: [ovs-dev] [PATCH v2] ovn-controller: Restore ct zone assignment. > > On Fri, Jul 29, 2016 at 11:59 AM, Ryan Moats wrote: > "dev"

Re: [ovs-dev] [PATCH v2 02/26] ofproto: Lockless group lookups.

On Fri, Jul 29, 2016 at 11:46:49AM -0700, Jarno Rajahalme wrote: > > > On Jul 29, 2016, at 11:20 AM, Ben Pfaff wrote: > > > > On Thu, Jul 28, 2016 at 05:55:54PM -0700, Jarno Rajahalme wrote: > >> Make groups RCU protected and make group lookups lockless. > >> > >> Signed-off-by: Jarno Rajahalme

Re: [ovs-dev] [PATCH v2 01/26] lib: Separate versioning to its own module.

On Fri, Jul 29, 2016 at 11:42:13AM -0700, Jarno Rajahalme wrote: > > > On Jul 29, 2016, at 11:06 AM, Ben Pfaff wrote: > > > > On Thu, Jul 28, 2016 at 05:55:53PM -0700, Jarno Rajahalme wrote: > >> Separate rule versioning to lib/versions.h to make it easier to use > >> versioning for other data t

Re: [ovs-dev] [PATCH v2 06/26] ofproto: Add generic ofproto_collection.

On Thu, Jul 28, 2016 at 05:55:58PM -0700, Jarno Rajahalme wrote: > Define rule_collection in terms of a new ofproto_collection. This > makes it easier to add other types of collections later. > > This patch makes no functional changes. > > Signed-off-by: Jarno Rajahalme Is there anything ofpro

Re: [ovs-dev] [PATCH v2 05/26] ofproto: Use ofproto_mutex for groups and keep track of referring flows.

On Thu, Jul 28, 2016 at 05:55:57PM -0700, Jarno Rajahalme wrote: > Adding groups support for bundles is simpler if also groups are > modified under ofproto_mutex. > > Eliminate the search for rules when deleting a group so that we will > not keep the mutex for too long. > > Signed-off-by: Jarno R

Re: [ovs-dev] [PATCH] travis: Fix flake8 failures from flake8 3.0.

On Fri, Jul 29, 2016 at 12:18 PM, Russell Bryant wrote: > The "hacking" plugin for flake8 is not currently compatible with flake8 > 3.0. Ensure that we install flake8 2.x on travis-ci. Also update the > docs to indicate this incompatibility. > > Signed-off-by: Russell Bryant > Acked-by: Andy

[ovs-dev] [PATCH] travis: Fix flake8 failures from flake8 3.0.

The "hacking" plugin for flake8 is not currently compatible with flake8 3.0. Ensure that we install flake8 2.x on travis-ci. Also update the docs to indicate this incompatibility. Signed-off-by: Russell Bryant --- .travis/linux-prepare.sh | 2 +- INSTALL.md | 12 +++- 2

Re: [ovs-dev] [PATCH 2/2] fedora: Prioritize OVS modules in weak-updates.

On Thu, Jul 28, 2016 at 05:09:38PM -0700, Joe Stringer wrote: > Out-of-tree modules are installed into the kernel's "extra" modules > directory for the version that kmod-openvswitch is compiled against. For > all other kernels on the system at install time, a symlink is created in > the "weak-updat

Re: [ovs-dev] [PATCH v2 02/26] ofproto: Lockless group lookups.

> On Jul 29, 2016, at 11:20 AM, Ben Pfaff wrote: > > On Thu, Jul 28, 2016 at 05:55:54PM -0700, Jarno Rajahalme wrote: >> Make groups RCU protected and make group lookups lockless. >> >> Signed-off-by: Jarno Rajahalme > > I'd add a little motivation to the commit message. A common reason to >

Re: [ovs-dev] [PATCH 1/2] rhel: Prioritize our vport-foo modules in depmod.

On 29 July 2016 at 11:38, pravin shelar wrote: > On Thu, Jul 28, 2016 at 5:09 PM, Joe Stringer wrote: >> We've done the same for openvswitch.ko previously, but we really should >> be doing this for vport modules as well; otherwise, depmod may try to >> pair upstream vport modules with the out-of-

Re: [ovs-dev] [PATCH 1/2] rhel: Prioritize our vport-foo modules in depmod.

On Thu, Jul 28, 2016 at 05:09:37PM -0700, Joe Stringer wrote: > We've done the same for openvswitch.ko previously, but we really should > be doing this for vport modules as well; otherwise, depmod may try to > pair upstream vport modules with the out-of-tree openvswitch module > (leading to depmod

Re: [ovs-dev] [PATCH 2/2] fedora: Prioritize OVS modules in weak-updates.

On Thu, Jul 28, 2016 at 5:09 PM, Joe Stringer wrote: > Out-of-tree modules are installed into the kernel's "extra" modules > directory for the version that kmod-openvswitch is compiled against. For > all other kernels on the system at install time, a symlink is created in > the "weak-updates" dire

Re: [ovs-dev] [PATCH v2 01/26] lib: Separate versioning to its own module.

> On Jul 29, 2016, at 11:06 AM, Ben Pfaff wrote: > > On Thu, Jul 28, 2016 at 05:55:53PM -0700, Jarno Rajahalme wrote: >> Separate rule versioning to lib/versions.h to make it easier to use >> versioning for other data types. >> >> Signed-off-by: Jarno Rajahalme > > I wish this wasn't called "

Re: [ovs-dev] [PATCH 1/2] rhel: Prioritize our vport-foo modules in depmod.

On Thu, Jul 28, 2016 at 5:09 PM, Joe Stringer wrote: > We've done the same for openvswitch.ko previously, but we really should > be doing this for vport modules as well; otherwise, depmod may try to > pair upstream vport modules with the out-of-tree openvswitch module > (leading to depmod warnings

Re: [ovs-dev] Hitless resynchronisation of forwarding state

> On Jul 1, 2016, at 2:48 AM, Jan Scheurich wrote: > >>> Refreshing the 250K flow entries using the bundle mechanism increases >>> the vswitchd memory linearly up to 1.9 GB, significantly more than the 910 >>> MB one would expect for accommodating two versions of each rule at the >>> moment of t

Re: [ovs-dev] [PATCH 3/5] check-kernel: 802.1ad: Add conntrack ping tests for CVLANs.

On 29 July 2016 at 11:30, Joe Stringer wrote: > On 28 July 2016 at 10:54, Eric Garver wrote: >> Signed-off-by: Eric Garver > > Can you describe your setup? (distro, kernel) > > This particular test seems to fail for me with kernel 3.19.0-58 > (ubuntu) and the out-of-tree module from OVS repo. It

Re: [ovs-dev] [PATCH 3/5] check-kernel: 802.1ad: Add conntrack ping tests for CVLANs.

On 28 July 2016 at 10:54, Eric Garver wrote: > Signed-off-by: Eric Garver Can you describe your setup? (distro, kernel) This particular test seems to fail for me with kernel 3.19.0-58 (ubuntu) and the out-of-tree module from OVS repo. It'd be nice to narrow down to find out why. If you get some

Re: [ovs-dev] [PATCH v2 3/3] pvector: Expose non-concurrent priority vector.

> On Jul 22, 2016, at 2:51 PM, Ben Pfaff wrote: > > On Wed, Jul 06, 2016 at 05:26:17AM -0700, Jarno Rajahalme wrote: >> PMD threads use pvectors but do not need the overhead of the >> concurrent version. Expose the non-concurrent version for >> that use. >> >> Note that struct pvector is renam

Re: [ovs-dev] [PATCH v2] tests: Ignore proxy configuration.

Thanks for the review, pushed to master. Jarno > On Jul 28, 2016, at 10:24 PM, Ben Pfaff wrote: > > On Thu, Jul 28, 2016 at 05:29:44PM -0700, Jarno Rajahalme wrote: >> As any proxy configuration may ruin kernel testsuite tests, it is >> better to ignore all proxy configuration. >> >> Suggest

Re: [ovs-dev] [PATCH 2/5] check-kernel: 802.1ad: Add datapath ping tests for CVLANs.

On 28 July 2016 at 10:54, Eric Garver wrote: > Signed-off-by: Eric Garver Hmm, on my Ubuntu 14.04 setup these tests fail with kernel 3.13.0-91, bupass with kernel 3.19.0-58, but not 3.13.0-91. I guess the 3.13 kernel didn't support 802.1ad? Is there an easy way to figure this out to skip the tes

Re: [ovs-dev] [PATCH v2 04/26] ofproto: Make flow handling more symmetric.

On Thu, Jul 28, 2016 at 05:55:56PM -0700, Jarno Rajahalme wrote: > Remove flow from ofproto data structures in the 'start' phase, even if > we may need to add them back in 'revert' phase. > > This makes bundled group mods easier, as a group delete may also > delete flows, and we need the referring

Re: [ovs-dev] [PATCH v2 03/26] ofproto: Take group references only when needed.

On Thu, Jul 28, 2016 at 05:55:55PM -0700, Jarno Rajahalme wrote: > Avoid unnecessary references when RCU protection suffices. This makes > group lookup memory management more like flow lookup memory > management. > > Signed-off-by: Jarno Rajahalme Acked-by: Ben Pfaff __

Re: [ovs-dev] [PATCH v2 02/26] ofproto: Lockless group lookups.

On Thu, Jul 28, 2016 at 05:55:54PM -0700, Jarno Rajahalme wrote: > Make groups RCU protected and make group lookups lockless. > > Signed-off-by: Jarno Rajahalme I'd add a little motivation to the commit message. A common reason to switch to RCU is performance, but I doubt that this is the motiv

Re: [ovs-dev] [PATCH 1/5] check-kernel: Add macros to check for and test 802.1ad.

On 28 July 2016 at 10:54, Eric Garver wrote: > Add macros OVS_CHECK_8021AD(), ADD_SVLAN() and ADD_CVLAN(). > > Signed-off-by: Eric Garver > --- > tests/system-common-macros.at | 29 - > 1 file changed, 28 insertions(+), 1 deletion(-) > > diff --git a/tests/system-comm

  1   2   >