Update email address.
Signed-off-by: Daniele Venturino <venturino.daniele+...@gmail.com>
---
AUTHORS.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/AUTHORS.rst b/AUTHORS.rst
index 5d8b723f62..5f339b599c 100644
--- a/AUTHORS.rst
+++ b/AUTHORS.rst
@@ -93,7 +93,7 @@
interested in
it.
Regards,
Daniele Venturino
> Il giorno 11 mag 2016, alle ore 16:18, Daniele Venturino
> <daniele.ventur...@m3s.it> ha scritto:
>
> Hi,
> which is the best entry point to identify traffic among hosts connected to a
> OVS switch and not pertaining the co
Hi,
which is the best entry point to identify traffic among hosts connected to a
OVS switch and not pertaining the control plane when the OVS switch is managed
by a SDN controller?
Best regards,
Daniele Venturino
___
dev mailing list
dev
Hi,
I was running some tests on Mininet and Open vSwitch and I noticed
something weird. I'm using few bridges configured with RSTP enabled and no
controller.
I then generate some traffic and I'm able to see the flows installed on
each bridge through the command
*ovs-ofctl dump-flows br0*
If I
It looks like our test setup is having some problems. I'll look into it.
For now, ignore this...
Best Regards,
Daniele
Il 28 gen 2016 5:11 PM, "Daniele Venturino" <daniele.ventur...@m3s.it> ha
scritto:
> Hi,
> I was running some tests on Mininet and Open vSwitch and I not
Maybe we could destroy the hmap with the mutex still locked.
Anyway, looks good to me.
Acked-by: Daniele Venturino <daniele.ventur...@m3s.it
<mailto:daniele.ventur...@m3s.it>>
> Il giorno 05 gen 2016, alle ore 22:38, William Tu <u9012...@gmail.com> ha
> scritto:
&
Carlo was involved in the testing and validation processes of the Rapid
Spanning Tree Implementation.
I also updated the Copyright string in some files.
Signed-off by: Daniele Venturino <daniele.ventur...@m3s.it>
---
AUTHORS | 1 +
lib/rstp-common.h | 3 ++-
li
I agree with Jarno, that assignment is not necessary.
Daniele
2015-04-16 22:52 GMT+02:00 Ben Pfaff b...@nicira.com:
On Thu, Apr 16, 2015 at 12:54:44PM -0700, Jarno Rajahalme wrote:
On Apr 16, 2015, at 11:13 AM, Ben Pfaff b...@nicira.com wrote:
Kevin Lo ran the LLVM scan-build tool
Acked-by: Daniele Venturino daniele.ventur...@m3s.it
2015-04-16 21:58 GMT+02:00 Jarno Rajahalme jrajaha...@nicira.com:
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
---
lib/rstp-state-machines.c |1 -
1 file changed, 1 deletion(-)
diff --git a/lib/rstp-state-machines.c b/lib
Looks good to me.
I also did some fast tests and the behaviour is now correct.
I saw that this has already been merged, but here's my ack
Acked-by: Daniele Venturino daniele.ventur...@m3s.it
Il giorno 06/mar/2015, alle ore 05:21, Ben Pfaff b...@nicira.com ha scritto:
On Thu, Mar 05, 2015
...@nicira.com:
On Wed, Feb 25, 2015 at 04:00:36PM +0100, Daniele Venturino wrote:
+STP and RSTP are mutually exclusive. If both are
enabled, RSTP
+will be used.
I think this might not be true.
If it has not been changed, when STP or RSTP is enabled it should
Is this patch still pending?
It doesn't change much, but it clarifies the correlation between
admin_point_to_point_mac
and oper_point_to_point_mac.
Daniele
2014-12-11 20:59 GMT+01:00 Ben Pfaff b...@nicira.com:
On Mon, Nov 24, 2014 at 03:42:48PM +0100, Daniele Venturino wrote:
With this patch
I don't recall if we arrived at a decision about this.
Daniele
2014-11-24 15:02 GMT+01:00 Daniele Venturino daniele.ventur...@m3s.it:
commit bacdb85ad82f981697245eefb40a3b360cfe379b
Author: Alex Wang al...@nicira.com
Date: Tue Jul 15 18:52:19 2014 -0700
stp: Make stp-disabled port
Hi,
+STP and RSTP are mutually exclusive. If both are enabled, RSTP
+will be used.
I think this might not be true.
If it has not been changed, when STP or RSTP is enabled it should not be
possible to enable the other one on the same bridge.
This is done in
should consider how the calling sites use these functions, as some of
them changed in the last series that was merged recently.
Jarno
On Nov 20, 2014, at 11:35 AM, Daniele Venturino daniele.ventur...@m3s.it
mailto:daniele.ventur...@m3s.it wrote:
We didn’t merge this patch back in september
I’m sending a patch to make more clear the effect of the
admin_point_to_point_mac value on the oper_point_to_point_mac value.
Does Open vSwitch detect if a port is connected to a point-to-point LAN?
Daniele
Il giorno 15/nov/2014, alle ore 14:34, Daniele Venturino
daniele.ventur...@m3s.it ha
With this patch, the effect of the admin_point_to_point_mac value on the
oper_point_to_point_mac value is more clear.
Signed-off-by: Daniele Venturino daniele.ventur...@m3s.it
---
lib/rstp.c | 55 ---
1 file changed, 32 insertions(+), 23
Rajahalme jrajaha...@nicira.com-
Thanks!
Jarno
On Nov 6, 2014, at 7:31 AM, Daniele Venturino daniele.ventur...@m3s.it
wrote:
With this patch setters invoke procedures only if values have changed.
Also rstp_set_bridge_address__() keeps the existing priority
Update man page explaining that the auto detection of point to point LANs is
not implemented.
Signed-off by: Martino Fornasa m...@fornasa.it
---
utilities/ovs-vsctl.8.in | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/utilities/ovs-vsctl.8.in b/utilities/ovs-vsctl.8.in
Update the NEWS section with some information about testing.
Signed-off by: Martino Fornasa m...@fornasa.it
---
NEWS | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/NEWS b/NEWS
index 40a0db0..ea8c6c0 100644
--- a/NEWS
+++ b/NEWS
@@ -41,9 +41,9 @@ Post-v2.3.0
-
, at 2:08 AM, Daniele Venturino daniele.ventur...@m3s.it
mailto:daniele.ventur...@m3s.it wrote:
Il giorno 10/set/2014, alle ore 18:54, Jarno Rajahalme
jrajaha...@nicira.com mailto:jrajaha...@nicira.com ha scritto:
Daniele,
See comments below.
Also, it would be preferable to send
.
Jarno
On Nov 17, 2014, at 9:13 AM, Daniele Venturino daniele.ventur...@m3s.it
mailto:daniele.ventur...@m3s.it wrote:
The problem must be that the port number and the hash value get out of
sync, i.e., when the port number is changed. Please try the patch below on
top of your patch
bundle_move() expects two “struct ofbundle” as arguments.
Signed-off-by: Daniele Venturino daniele.ventur...@m3s.it
---
ofproto/ofproto-dpif.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 8778ed2..3f8768d 100644
as arguments.
Regards,
Daniele
Il giorno 14/nov/2014, alle ore 22:56, Jarno Rajahalme
jrajaha...@nicira.com ha scritto:
On Nov 14, 2014, at 9:19 AM, Daniele Venturino daniele.ventur...@m3s.it
mailto:daniele.ventur...@m3s.it wrote:
Why lose the ‘_WITH_HASH’? It seems pointless
2014-11-15 0:40 GMT+01:00 Jarno Rajahalme jrajaha...@nicira.com:
On Nov 14, 2014, at 2:50 PM, Daniele Venturino daniele.ventur...@m3s.it
wrote:
You're right, it's used only in rstp_port_set_admin_point_to_point_mac__()
where it's set, if the old value change. The action
;
+}
}
+
if (validate_received_bpdu(p, bpdu, bpdu_size) == 0) {
p-rcvd_bpdu = true;
p-rx_rstp_bpdu_cnt++;
Acked-by: Jarno Rajahalme jrajaha...@nicira.com
On Nov 6, 2014, at 7:31 AM, Daniele Venturino daniele.ventur...@m3s.it
wrote:
Signed-off-by: Daniele Venturino daniele.ventur...@m3s.it
bridge. Feel free to suggest any improvement on this.
Daniele
2014-11-14 1:11 GMT+01:00 Jarno Rajahalme jrajaha...@nicira.com:
Daniele,
See comments inline.
Thanks!
Jarno
On Nov 6, 2014, at 7:31 AM, Daniele Venturino daniele.ventur...@m3s.it
wrote:
All MAC addresses previously
:
This patch needs a proper commit message, e.g., why the change is needed?
Thanks,
Jarno
On Nov 6, 2014, at 7:31 AM, Daniele Venturino daniele.ventur...@m3s.it
wrote:
Signed-off-by: Daniele Venturino daniele.ventur...@m3s.it
---
lib/rstp.c | 14 ++
1 file changed, 10
I'm sending a v2 of this patch with all the requested modifications.
Regards,
Daniele
2014-11-14 1:17 GMT+01:00 Jarno Rajahalme jrajaha...@nicira.com:
Daniele,
See my comments below,
Thanks!
Jarno
On Nov 6, 2014, at 7:31 AM, Daniele Venturino daniele.ventur...@m3s.it
wrote
On Nov 6, 2014, at 7:31 AM, Daniele Venturino daniele.ventur...@m3s.it
wrote:
Invoke move_rstp__() in
rstp_port_set_administrative_bridge_port__() if
port is not initializing.
Explain in the commit message why this is needed. And lose the indentation…
Also, tests/rstp.at needs
standard.
Daniele
2014-11-14 0:23 GMT+01:00 Jarno Rajahalme jrajaha...@nicira.com:
This patch needs a proper commit message. Explain what was wrong, and why
the fix is correct.
Regards,
Jarno
On Nov 6, 2014, at 7:31 AM, Daniele Venturino daniele.ventur...@m3s.it
wrote:
Signed-off
and the answer to the AUTO question below, I can accept and
push this patch.
Thanks!
Jarno
On Nov 6, 2014, at 7:31 AM, Daniele Venturino daniele.ventur...@m3s.it
wrote:
Signed-off-by: Daniele Venturino daniele.ventur...@m3s.it
---
lib/rstp-common.h| 6 --
lib/rstp.c
global
condition BEGIN supersedes all other global conditions, and once asserted
remains asserted until all state blocks have executed to the point that
variable assignments and other consequences of their execution remain
unchanged.
Signed-off-by: Daniele Venturino daniele.ventur...@m3s.it
---
lib
below, otherwise:
Acked-by: Jarno Rajahalme jrajaha...@nicira.com
On Nov 6, 2014, at 7:31 AM, Daniele Venturino daniele.ventur...@m3s.it
wrote:
With this commit, RSTP is able to flush from the MAC learning table
entries pertaining to a single port. Before this commit the whole
table
2014-11-14 19:46 GMT+01:00 Jarno Rajahalme jrajaha...@nicira.com:
On Nov 14, 2014, at 9:36 AM, Daniele Venturino daniele.ventur...@m3s.it
wrote:
A possible commit message:
Admin-port-state is the Administrative Bridge Port state variable defined
in the 802.1D-2004 standard.
It can be set
...@nicira.com:
On Nov 14, 2014, at 11:09 AM, Daniele Venturino daniele.ventur...@m3s.it
wrote:
2014-11-14 19:46 GMT+01:00 Jarno Rajahalme jrajaha...@nicira.com:
On Nov 14, 2014, at 9:36 AM, Daniele Venturino daniele.ventur...@m3s.it
wrote:
A possible commit message:
Admin-port-state
Set rcdv_tcn and return OTHER_INFO when a
TOPOLOGY_CHANGE_NOTIFICATION_BPDU is received.
Signed-off-by: Daniele Venturino daniele.ventur...@m3s.it
---
lib/rstp-state-machines.c | 8
1 file changed, 8 insertions(+)
diff --git a/lib/rstp-state-machines.c b/lib/rstp-state
Invoke move_rstp__() in rstp_port_set_administrative_bridge_port__() if
port is not initializing.
Signed-off-by: Daniele Venturino daniele.ventur...@m3s.it
---
lib/rstp.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/lib/rstp.c b/lib/rstp.c
Hi.
We tested the RSTP implementation against the IXIA IxANVL validation software.
This allowed us to fix some small bugs, and the implementation now passes
such tests with success!
Please find attached the patch series.
It appears that patches 12 and 17 break the RSTP dummy test, while all
All other similar port_role_transition_sm states are named like this.
Signed-off-by: Daniele Venturino daniele.ventur...@m3s.it
---
lib/rstp-common.h | 2 +-
lib/rstp-state-machines.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/rstp-common.h b/lib
If the DesignatedBridgeID Bridge Address component is equal to that
component of the Bridge's own bridge priority vector skip to the next
port.
Signed-off-by: Daniele Venturino daniele.ventur...@m3s.it
---
lib/rstp-state-machines.c | 2 +-
1 file changed, 1 insertion
Signed-off-by: Daniele Venturino daniele.ventur...@m3s.it
---
lib/rstp-state-machines.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/rstp-state-machines.c b/lib/rstp-state-machines.c
index 1912d7e..5c03385 100644
--- a/lib/rstp-state-machines.c
+++ b/lib/rstp-state
Signed-off-by: Daniele Venturino daniele.ventur...@m3s.it
---
lib/rstp-state-machines.c | 12
1 file changed, 12 insertions(+)
diff --git a/lib/rstp-state-machines.c b/lib/rstp-state-machines.c
index e03f720..ade2d61 100644
--- a/lib/rstp-state-machines.c
+++ b/lib/rstp-state
designated_bridge_id, designated_port_id and designated_path_cost are
now displayed in rstp_status when using 'ovs-vsctl list port'.
Signed-off-by: Daniele Venturino daniele.ventur...@m3s.it
---
lib/rstp.c | 10 --
lib/rstp.h | 6 --
ofproto
The bridge_port_id is never conveyed in Configuration Messages, but is
used as a tie-breaker within a Bridge. This patch extends the
comparison to this fifth field in a rstp_priority_vector.
Signed-off-by: Daniele Venturino daniele.ventur...@m3s.it
---
lib/rstp-state
)
treats a Port as no longer active when it becomes an Alternate, Backup,
or Disabled Port and stops learning from received frames.
Signed-off-by: Daniele Venturino daniele.ventur...@m3s.it
---
lib/rstp.h | 12 +++-
lib/stp.c| 12
Signed-off-by: Daniele Venturino daniele.ventur...@m3s.it
---
lib/rstp.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/lib/rstp.c b/lib/rstp.c
index e3007e2..55c43c0 100644
--- a/lib/rstp.c
+++ b/lib/rstp.c
@@ -523,8 +523,9 @@ static void
When the condition associated with a global transition is met, it
supersedes all other exit conditions including UCT.
Signed-off-by: Daniele Venturino daniele.ventur...@m3s.it
---
lib/rstp-state-machines.c | 139 +++---
1 file changed, 130
Signed-off-by: Daniele Venturino daniele.ventur...@m3s.it
---
lib/rstp-common.h| 6 --
lib/rstp.c | 31 ++-
lib/rstp.h | 9 -
ofproto/ofproto-dpif.c | 4 +++-
ofproto/ofproto.h| 2 ++
utilities/ovs-vsctl.8
With this patch setters invoke procedures only if values have changed.
Also rstp_set_bridge_address__() keeps the existing priority in the
bridge_identifier.
Signed-off-by: Daniele Venturino daniele.ventur...@m3s.it
---
lib/rstp.c | 80
With this commit, RSTP is able to flush from the MAC learning table
entries pertaining to a single port. Before this commit the whole table
was flushed every time a port requested flushing actions.
Signed-off-by: Daniele Venturino daniele.ventur...@m3s.it
---
lib/rstp.c
in the 802.1q-2008 standard.
Signed-off-by: Daniele Venturino daniele.ventur...@m3s.it
---
lib/rstp-state-machines.c | 27 +--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/lib/rstp-state-machines.c b/lib/rstp-state-machines.c
index dc25b00..31909a5 100644
A Config BPDU always conveys a Designated Port Role.
Signed-off-by: Daniele Venturino daniele.ventur...@m3s.it
---
lib/rstp-state-machines.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/lib/rstp-state-machines.c b/lib/rstp-state-machines.c
index
recovering from
some component failures.
Signed-off-by: Daniele Venturino daniele.ventur...@m3s.it
---
lib/rstp-common.h | 4
lib/rstp-state-machines.c | 21 +++
lib/rstp.c| 51 ++-
lib/rstp.h
Il giorno 11/set/2014, alle ore 19:09, Jarno Rajahalme jrajaha...@nicira.com
ha scritto:
On Sep 11, 2014, at 5:49 AM, Daniele Venturino daniele.ventur...@m3s.it
wrote:
Il giorno 09/set/2014, alle ore 22:04, Daniele Venturino
daniele.ventur...@m3s.it ha scritto:
Il giorno 09/set
format-patch” does that automatically.
Jarno
I’ll send the next group of patches as a series.
On Sep 10, 2014, at 1:28 AM, Daniele Venturino daniele.ventur...@m3s.it
wrote:
See commit bacdb85ad82f981697245eefb40a3b360cfe379b.
Signed-off by: Daniele Venturino daniele.ventur...@m3s.it
Il giorno 09/set/2014, alle ore 22:04, Daniele Venturino
daniele.ventur...@m3s.it ha scritto:
Il giorno 09/set/2014, alle ore 20:07, Jarno Rajahalme
jrajaha...@nicira.com ha scritto:
On Sep 9, 2014, at 3:53 AM, Daniele Venturino venturino.dani...@gmail.com
wrote:
Thanks
Signed-off by: Daniele Venturino daniele.ventur...@m3s.it
---
lib/rstp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/rstp.c b/lib/rstp.c
index 5914a1d..b213b44 100644
--- a/lib/rstp.c
+++ b/lib/rstp.c
@@ -951,7 +951,8 @@ rstp_initialize_port_defaults__(struct
Signed-off by: Daniele Venturino daniele.ventur...@m3s.it
---
lib/rstp-common.h | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/lib/rstp-common.h b/lib/rstp-common.h
index 4e0d398..587f88c 100644
--- a/lib/rstp-common.h
+++ b/lib/rstp-common.h
@@ -225,19
See commit 24f8381214966e90819bf4a9ecabf076cbfc1b08.
Signed-off by: Daniele Venturino daniele.ventur...@m3s.it
---
lib/rstp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/rstp.c b/lib/rstp.c
index b213b44..f2f1dce 100644
--- a/lib/rstp.c
+++ b/lib/rstp.c
@@ -168,7
See commit bacdb85ad82f981697245eefb40a3b360cfe379b.
Signed-off by: Daniele Venturino daniele.ventur...@m3s.it
---
lib/rstp.h | 42 +++---
ofproto/ofproto-dpif-xlate.c | 6 +++---
2 files changed, 42 insertions(+), 6 deletions(-)
diff
Acked-by: Daniele Venturino daniele.ventur...@m3s.it
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme jrajaha...@nicira.com:
Existing STP and RSTP test cases only test the protocols with test
utilities. These tests test them as part of OVS using the
netdev-dummy device.
Signed-off-by: Jarno
Acked-by: Daniele Venturino daniele.ventur...@m3s.it
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme jrajaha...@nicira.com:
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
---
lib/rstp-state-machines.c | 22 --
ofproto/ofproto-dpif.c| 11 ++-
vswitchd
Acked-by: Daniele Venturino daniele.ventur...@m3s.it
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme jrajaha...@nicira.com:
Set the stp port name before enabling it, so that debugging messages
have the name to print out.
Do not treat the first state initialization as a state change. Zero
Acked-by: Daniele Venturino daniele.ventur...@m3s.it
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme jrajaha...@nicira.com:
Move port's configuration options where they belong, add typing, and
correct errors.
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
---
vswitchd/vswitch.xml | 130
Acked-by: Daniele Venturino daniele.ventur...@m3s.it
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme jrajaha...@nicira.com:
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
---
lib/rstp-common.h |7 ---
1 file changed, 7 deletions(-)
diff --git a/lib/rstp-common.h b/lib/rstp
Acked-by: Daniele Venturino daniele.ventur...@m3s.it
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme jrajaha...@nicira.com:
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
---
lib/rstp.c | 132
++--
lib/rstp.h | 12 +++---
2 files
Acked-by: Daniele Venturino daniele.ventur...@m3s.it
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme jrajaha...@nicira.com:
Prior to this patch the default values for ports were set in three
different places. This refactors them all to one helper function.
Signed-off-by: Jarno Rajahalme jrajaha
Acked-by: Daniele Venturino daniele.ventur...@m3s.it
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme jrajaha...@nicira.com:
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
---
lib/rstp.c | 54 ++
1 file changed, 22 insertions(+), 32
Acked-by: Daniele Venturino daniele.ventur...@m3s.it
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme jrajaha...@nicira.com:
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
---
lib/rstp.c | 39 ++-
ofproto/ofproto-dpif.c |2 +-
2 files
Acked-by: Daniele Venturino daniele.ventur...@m3s.it
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme jrajaha...@nicira.com:
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
---
lib/rstp.c | 34 --
lib/rstp.h | 42
Acked-by: Daniele Venturino daniele.ventur...@m3s.it
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme jrajaha...@nicira.com:
Current code expects there to be a single thread that is responsible
for creating rstp and creating and deleting rstp_port objects. rstp
objects are also deleted from other
Acked-by: Daniele Venturino daniele.ventur...@m3s.it
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme jrajaha...@nicira.com:
Change the RSTP send_bpdu interface so that a recursive mutex is not
needed.
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
---
lib/rstp-common.h |2
Acked-by: Daniele Venturino daniele.ventur...@m3s.it
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme jrajaha...@nicira.com:
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
---
lib/rstp-state-machines.c | 398
+
1 file changed, 182 insertions
Acked-by: Daniele Venturino daniele.ventur...@m3s.it
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme jrajaha...@nicira.com:
Testing for sameness first makes the logic simpler to follow.
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
---
lib/rstp-state-machines.c | 57
Acked-by: Daniele Venturino daniele.ventur...@m3s.it
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme jrajaha...@nicira.com:
It was only used to guard against unintialized list.
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
---
lib/rstp-common.h |1 -
lib/rstp-state-machines.c
Acked-by: Daniele Venturino daniele.ventur...@m3s.it
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme jrajaha...@nicira.com:
Finding a given port is faster.
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
---
lib/rstp-common.h |5 +++--
lib/rstp-state-machines.c | 30
. Anyway, if you still want to merge it and mark it
as experimental is still fine by me, since I'll be able to rebase my
patches on your version.
On Sep 3, 2014, at 7:44 AM, Daniele Venturino venturino.dani...@gmail.com
wrote:
I looked and applied the patches. They’re good to me, I just have some
Il giorno 09/set/2014, alle ore 20:07, Jarno Rajahalme jrajaha...@nicira.com
ha scritto:
On Sep 9, 2014, at 3:53 AM, Daniele Venturino venturino.dani...@gmail.com
wrote:
Thanks for the review!
It would be nice to have an Acked-by from you to the series. However, I plan
to squash
is a minimally rebased version of the
v5 sent on ovs-dev on June 12th, 2014. Rest of the series is my
proposal for fixes and enhancements.
I could have reordered and squashed some of the patches together, but
that would have been more work...
Daniele Venturino (1):
Rapid Spanning Tree Protocol
We noticed there was a problem on frame forwarding on blocked ports. We're
sending an updated version (v5) of the patch.
Il giorno 05/giu/2014, alle ore 16:50, Daniele Venturino
daniele.ventur...@m3s.it ha scritto:
This is an updated version of the patch after Jarno review.
Modifications
...@fornasa.it
+ * Daniele Venturino daniele.ventur...@m3s.it
+ *
+ * References to IEEE 802.1D-2004 standard are enclosed in square brackets.
+ * E.g. [17.3], [Table 17-1], etc.
+ *
+ */
+
+#ifndef RSTP_H
+#define RSTP_H 1
+
+#include stdint.h
+#include stdbool.h
+#include compiler.h
+/* Bridge State Machine. */
+/* [17.28] Port Role Selection state machine. */
+
+void
+updt_role_disabled_tree(struct rstp * r)
Is ther a specfc resn to contrct the first word in the nam of this functn?
We try to strictly follow the naming used in the IEEE 802.1D-2004 standard, as
it
This is the diff between RSTP patch v3 and v2 (the one sent on February 24th).
---
diff --git a/v1/lib/rstp.c b/v2/lib/rstp.c
index 2725707..d226967 100644
--- a/v1/lib/rstp.c
+++ b/v2/lib/rstp.c
@@ -1076,6 +1076,20 @@ rstp_port_get_aux(struct rstp_port *p)
return aux;
}
+/* Returns true
is not allowed to be empty
It seems correct to use the command:
ovs-vsctl set Bridge br0 stp_enable=false
Signed-off by: Daniele Venturino daniele.ventur...@m3s.it
---
utilities/ovs-vsctl.8.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/ovs-vsctl.8.in b
85 matches
Mail list logo
