Re: [ovs-dev] OVS 2.6.1 release?

2016-11-01 Thread Pravin Shelar
On Mon, Oct 31, 2016 at 1:30 PM, Justin Pettit wrote: > >> On Oct 31, 2016, at 6:10 AM, Richard Theis wrote: >> >> > So, it turns out my fix does not introduce any new problems. I have >> > just posted >> > it, so consider if you want to wait to apply it before releasing. >> >> Just checking on t

Re: [ovs-dev] [PATCH v2] datapath: geneve: Handle vlan tag

2016-11-01 Thread Pravin Shelar
On Tue, Nov 1, 2016 at 11:41 AM, Joe Stringer wrote: > On 1 November 2016 at 11:35, Pravin B Shelar wrote: >> The compat vlan code ignores vlan tag for inner packet >> on egress path. Following patch fixes this by inserting the >> tag for inner packet before tunnel encaps

[ovs-dev] [PATCH v2] datapath: geneve: Handle vlan tag

2016-11-01 Thread Pravin B Shelar
The compat vlan code ignores vlan tag for inner packet on egress path. Following patch fixes this by inserting the tag for inner packet before tunnel encapsulation. Signed-off-by: Pravin B Shelar --- datapath/linux/compat/geneve.c | 33 +++-- 1 file changed, 31

Re: [ovs-dev] [PATCH] datapath: geneve: Handle vlan tag

2016-11-01 Thread Pravin Shelar
On Tue, Nov 1, 2016 at 11:06 AM, Joe Stringer wrote: > On 1 November 2016 at 10:48, Pravin Shelar wrote: >> On Tue, Nov 1, 2016 at 10:30 AM, Joe Stringer wrote: >>> On 31 October 2016 at 22:00, Pravin B Shelar wrote: >>>> The compat vlan code ignores vlan tag f

Re: [ovs-dev] [PATCH] datapath: geneve: Handle vlan tag

2016-11-01 Thread Pravin Shelar
On Tue, Nov 1, 2016 at 10:30 AM, Joe Stringer wrote: > On 31 October 2016 at 22:00, Pravin B Shelar wrote: >> The compat vlan code ignores vlan tag for inner packet >> on egress path. Following patch fixes this by inserting the >> tag for inner packet before tunnel encaps

Re: [ovs-dev] [PATCH v2] datapath: backport: vxlan: avoid using stale vxlan socket.

2016-10-31 Thread Pravin Shelar
On Mon, Oct 31, 2016 at 5:24 PM, Joe Stringer wrote: > On 31 October 2016 at 14:36, Pravin B Shelar wrote: >> Upstream commit: >> commit c6fcc4fc5f8b592600c7409e769ab68da0fb1eca >> Author: pravin shelar >> Date: Fri Oct 28 09:59:15 2016 -0700 >>

[ovs-dev] [PATCH] datapath: geneve: Handle vlan tag

2016-10-31 Thread Pravin B Shelar
The compat vlan code ignores vlan tag for inner packet on egress path. Following patch fixes this by inserting the tag for inner packet before tunnel encapsulation. Signed-off-by: Pravin B Shelar --- datapath/linux/compat/geneve.c | 26 -- 1 file changed, 24 insertions

[ovs-dev] [PATCH v2] datapath: backport: vxlan: avoid using stale vxlan socket.

2016-10-31 Thread Pravin B Shelar
Upstream commit: commit c6fcc4fc5f8b592600c7409e769ab68da0fb1eca Author: pravin shelar Date: Fri Oct 28 09:59:15 2016 -0700 vxlan: avoid using stale vxlan socket. When vxlan device is closed vxlan socket is freed. This operation can race with vxlan-xmit function which

Re: [ovs-dev] [PATCH 1/3] datapath: backport: vxlan: avoid using stale vxlan socket.

2016-10-31 Thread Pravin Shelar
On Mon, Oct 31, 2016 at 2:05 PM, Joe Stringer wrote: > On 29 October 2016 at 21:33, Pravin B Shelar wrote: >> Upstream commit: >> commit c6fcc4fc5f8b592600c7409e769ab68da0fb1eca >> Author: pravin shelar >> Date: Fri Oct 28 09:59:15 2016 -0700 >>

Re: [ovs-dev] OVS 2.6.1 release?

2016-10-31 Thread Pravin Shelar
On Mon, Oct 31, 2016 at 9:57 AM, Justin Pettit wrote: > >> On Oct 18, 2016, at 10:14 PM, Pravin Shelar wrote: >> >> On Tue, Oct 18, 2016 at 8:35 AM, Justin Pettit wrote: >>> >>>> On Oct 18, 2016, at 5:31 PM, Russell Bryant wrote: >>>> >&

[ovs-dev] [PATCH 3/3] lisp: avoid using stale lisp socket.

2016-10-29 Thread Pravin B Shelar
This patch is similar to earlier vxlan patch. Lisp device close operation frees lisp socket. This operation can race with lisp-xmit function which dereferences lisp socket. Following patch uses RCU mechanism to avoid this situation. Signed-off-by: Pravin B Shelar --- datapath/linux/compat

[ovs-dev] [PATCH 2/3] datapath: backport: geneve: avoid using stale geneve socket.

2016-10-29 Thread Pravin B Shelar
Upstream commit: commit fceb9c3e38252992bbf1a3028cc2f7b871211533 Author: pravin shelar Date: Fri Oct 28 09:59:16 2016 -0700 geneve: avoid using stale geneve socket. This patch is similar to earlier vxlan patch. Geneve device close operation frees geneve socket. This

[ovs-dev] [PATCH 1/3] datapath: backport: vxlan: avoid using stale vxlan socket.

2016-10-29 Thread Pravin B Shelar
Upstream commit: commit c6fcc4fc5f8b592600c7409e769ab68da0fb1eca Author: pravin shelar Date: Fri Oct 28 09:59:15 2016 -0700 vxlan: avoid using stale vxlan socket. When vxlan device is closed vxlan socket is freed. This operation can race with vxlan-xmit function which

Re: [ovs-dev] [RFC PATCH] datapath: allow tunnels to be created with rtnetlink

2016-10-26 Thread Pravin Shelar
On Wed, Oct 26, 2016 at 2:55 AM, Thadeu Lima de Souza Cascardo wrote: > On Tue, Oct 25, 2016 at 08:21:55PM -0700, Pravin Shelar wrote: >> > The fallback option should already work, then. We can make sure during >> > testing >> > that is the case, so there would be

Re: [ovs-dev] [RFC PATCH] datapath: allow tunnels to be created with rtnetlink

2016-10-25 Thread Pravin Shelar
On Tue, Oct 25, 2016 at 11:00 AM, Thadeu Lima de Souza Cascardo wrote: > On Thu, Oct 20, 2016 at 10:30:41AM -0700, Pravin Shelar wrote: >> On Tue, Sep 20, 2016 at 7:01 AM, Thadeu Lima de Souza Cascardo >> wrote: >> > In order to use rtnetlink to create new tunne

Re: [ovs-dev] [PATCH v2] datapath: compat: tunnel: Check if device is UP.

2016-10-21 Thread Pravin Shelar
On Fri, Oct 21, 2016 at 11:39 AM, Joe Stringer wrote: > On 21 October 2016 at 11:37, Joe Stringer wrote: >> On 21 October 2016 at 10:55, Pravin B Shelar wrote: >>> On upstream kernel datapath OVS make use of networking devices >>> where networking stack does check

Re: [ovs-dev] [PATCH v2] datapath: compat: tunnel: Check if device is UP.

2016-10-21 Thread Pravin Shelar
On Fri, Oct 21, 2016 at 11:37 AM, Joe Stringer wrote: > On 21 October 2016 at 10:55, Pravin B Shelar wrote: >> On upstream kernel datapath OVS make use of networking devices >> where networking stack does check if device is UP. following >> patch adds same check in cas

[ovs-dev] [PATCH v2] datapath: compat: tunnel: Check if device is UP.

2016-10-21 Thread Pravin B Shelar
+0x3a9/0x3c0 [] __sys_sendmsg+0x51/0x90 [] SyS_sendmsg+0x12/0x20 [] system_call_fastpath+0x16/0x1b Reported-by: Huanglili (lee) Signed-off-by: Pravin B Shelar --- v1-v2: Use dev-kfree-skb() --- datapath/linux/compat/geneve.c | 3 +++ datapath/linux/compat/include/linux

Re: [ovs-dev] [PATCH net-next v12 8/9] openvswitch: allow L3 netdev ports

2016-10-20 Thread Pravin Shelar
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote: > Allow ARPHRD_NONE interfaces to be added to ovs bridge. > > Based on previous versions by Lorand Jakab and Simon Horman. > > Signed-off-by: Lorand Jakab > Signed-off-by: Simon Horman > Signed-off-by: Jiri Benc Acke

Re: [ovs-dev] [PATCH net-next v12 7/9] openvswitch: add Ethernet push and pop actions

2016-10-20 Thread Pravin Shelar
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote: > It's not allowed to push Ethernet header in front of another Ethernet > header. > > It's not allowed to pop Ethernet header if there's a vlan tag. This > preserves the invariant that L3 packet never has a vlan tag. > > Based on previous versions

Re: [ovs-dev] [PATCH net-next v12 6/9] openvswitch: netlink: support L3 packets

2016-10-20 Thread Pravin Shelar
y supported for Ethernet packets. > > Based on previous versions by Lorand Jakab and Simon Horman. > > Signed-off-by: Lorand Jakab > Signed-off-by: Simon Horman > Signed-off-by: Jiri Benc Acked-by: Pravin B Shelar ___ dev mail

Re: [ovs-dev] [PATCH net-next v12 5/9] openvswitch: add processing of L3 packets

2016-10-20 Thread Pravin Shelar
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote: > Support receiving, extracting flow key and sending of L3 packets (packets > without an Ethernet header). > > Note that even after this patch, non-Ethernet interfaces are still not > allowed to be added to bridges. Similarly, netlink interface for

Re: [ovs-dev] [PATCH] datapath: compat: tunnel: Check if device is UP.

2016-10-20 Thread Pravin Shelar
On Thu, Oct 20, 2016 at 6:49 PM, Joe Stringer wrote: > On 19 October 2016 at 11:27, Pravin B Shelar wrote: >> On upstream kernel datapath OVS make use of networking devices >> where networking stack does check if device is UP. following >> patch adds same check in cas

Re: [ovs-dev] [PATCH 1/2] datapath: Support a fixed size of 128 distinct labels.

2016-10-20 Thread Pravin Shelar
than 64bit labels are required. > > We still only allocate the extension if its needed. > > Signed-off-by: Florian Westphal > Signed-off-by: Pablo Neira Ayuso > > Signed-off-by: Jarno Rajahalme Acked-by: Pravin B Shelar ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/2] configure: Support compiling with Linux 4.8.

2016-10-20 Thread Pravin Shelar
On Tue, Oct 18, 2016 at 5:01 PM, Jarno Rajahalme wrote: > Datapath should now compile and work with Linux 4.8. > > Signed-off-by: Jarno Rajahalme Acked-by: Pravin B Shelar ___ dev mailing list dev@openvswitch.org http://openvswitch.or

Re: [ovs-dev] [PATCH net-next v12 5/9] openvswitch: add processing of L3 packets

2016-10-20 Thread Pravin Shelar
On Wed, Oct 19, 2016 at 9:52 AM, Jiri Benc wrote: > On Tue, 18 Oct 2016 22:13:45 -0700, Pravin Shelar wrote: >> On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote: >> > - skb_reset_network_header(skb); >> > + skb->protocol = parse_ethertype(s

Re: [ovs-dev] [RFC PATCH] datapath: allow tunnels to be created with rtnetlink

2016-10-20 Thread Pravin Shelar
On Tue, Sep 20, 2016 at 7:01 AM, Thadeu Lima de Souza Cascardo wrote: > In order to use rtnetlink to create new tunnel vports, the backported > tunnels require some code that was removed from their upstream version, > mainly the necessary code for newlink and for start_xmit. > > This patch adds ba

Re: [ovs-dev] [PATCH] tnl-ports: fix missing netdev_close

2016-10-19 Thread Pravin Shelar
On Fri, Oct 14, 2016 at 7:12 AM, Thadeu Lima de Souza Cascardo wrote: > There were leaks on netdev_close references. Whenever an address was removed > from an interface, it was possible that a race would make the netlink message > be > processed and no address be found on the interface, causing i

Re: [ovs-dev] [PATCH net-next v2 1/2] openvswitch: remove unused functions

2016-10-19 Thread Pravin Shelar
On Wed, Oct 19, 2016 at 2:26 AM, Jiri Benc wrote: > ovs_vport_deferred_free is not used anywhere. It's the only caller of > free_vport_rcu thus this one can be removed, too. > > Signed-off-by: Jiri Benc Acked-by: Pravin B Shelar ___

Re: [ovs-dev] [PATCH net-next v2 2/2] openvswitch: remove unnecessary EXPORT_SYMBOLs

2016-10-19 Thread Pravin Shelar
On Wed, Oct 19, 2016 at 2:26 AM, Jiri Benc wrote: > Some symbols exported to other modules are really used only by > openvswitch.ko. Remove the exports. > > Tested by loading all 4 openvswitch modules, nothing breaks. > > Signed-off-by: Jiri Benc Acked-b

[ovs-dev] [PATCH] datapath: compat: tunnel: Check if device is UP.

2016-10-19 Thread Pravin B Shelar
+0x3a9/0x3c0 [] __sys_sendmsg+0x51/0x90 [] SyS_sendmsg+0x12/0x20 [] system_call_fastpath+0x16/0x1b Reported-by: Huanglili (lee) Signed-off-by: Pravin B Shelar --- datapath/linux/compat/geneve.c | 6 ++ datapath/linux/compat/ip_gre.c | 3 +++ datapath/linux/compat/lisp.c | 5

Re: [ovs-dev] OVS 2.6.1 release?

2016-10-18 Thread Pravin Shelar
On Tue, Oct 18, 2016 at 8:35 AM, Justin Pettit wrote: > >> On Oct 18, 2016, at 5:31 PM, Russell Bryant wrote: >> >>> On Tue, Oct 18, 2016 at 4:54 AM, Justin Pettit wrote: >>> > On Oct 17, 2016, at 5:54 PM, Ben Pfaff wrote: >>> > >>> >> On Mon, Oct 17, 2016 at 09:14:33AM -0400, Russell Bryant wr

Re: [ovs-dev] [PATCH net-next v12 1/9] openvswitch: use hard_header_len instead of hardcoded ETH_HLEN

2016-10-18 Thread Pravin Shelar
ket going to L3 interface (the L2 header is included in the packet > lenght), > * L3 packet going to L3 interface. > > Signed-off-by: Jiri Benc Acked-by: Pravin B Shelar ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH net-next v12 9/9] openvswitch: use ipgre tunnel rather than gretap tunnel

2016-10-18 Thread Pravin Shelar
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote: > From: Simon Horman > > This allows GRE tunnels to send and receive both > layer 2 packets (packets with an ethernet header) and > layer 3 packets (packets without an ethernet header). > > Signed-off-by: Simon Horman > Signed-off-by: Jiri Benc

Re: [ovs-dev] [PATCH net-next v12 5/9] openvswitch: add processing of L3 packets

2016-10-18 Thread Pravin Shelar
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote: > Support receiving, extracting flow key and sending of L3 packets (packets > without an Ethernet header). > > Note that even after this patch, non-Ethernet interfaces are still not > allowed to be added to bridges. Similarly, netlink interface for

Re: [ovs-dev] [PATCH net-next v12 3/9] openvswitch: pass mac_proto to ovs_vport_send

2016-10-18 Thread Pravin Shelar
the output interface hard_header_len but rather the L2 header of the > particular packet. For example, ARPHRD_NONE tunnels that encapsulate > Ethernet should get at least the Ethernet header. > > Signed-off-by: Jiri Benc Acked-by: Pravin B Shelar

Re: [ovs-dev] [PATCH net-next v12 2/9] openvswitch: add mac_proto field to the flow key

2016-10-18 Thread Pravin Shelar
Sounds hacky, although I kind of like this. > > After thinking about pros and cons, I implemented (1). Seems to be most > clear of the three options. But I'm happy to implement (2) or (3) if it's > deemed better. I like approach taken by this patch. Acked-by: Pravin B Shelar ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH net-next v12 0/9] openvswitch: support for layer 3 encapsulated packets

2016-10-18 Thread Pravin Shelar
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote: > At the core of this patch set is removing the assumption in Open vSwitch > datapath that all packets have Ethernet header. Support for layer 3 GRE > tunnels is also added by this patchset. > > The implementation relies on the presence of pop_eth

Re: [ovs-dev] [PATCH net-next v12 4/9] openvswitch: support MPLS push and pop for L3 packets

2016-10-18 Thread Pravin Shelar
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote: > Update Ethernet header only if there is one. > > Signed-off-by: Jiri Benc Acked-by: Pravin B Shelar ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH net-next] openvswitch: remove unnecessary EXPORT_SYMBOLs

2016-10-18 Thread Pravin Shelar
On Tue, Oct 18, 2016 at 4:47 AM, Jiri Benc wrote: > Many symbols exported to other modules are really used only by > openvswitch.ko. Remove the exports. > > Tested by loading all 4 openvswitch modules, nothing breaks. > > Signed-off-by: Jiri Benc > --- > net/openvswitch/datapath.c | 2 -- >

Re: [ovs-dev] [PATCH 01/12] dpcls: Use 32 packet batches for lookups.

2016-10-12 Thread Pravin Shelar
On Tue, Oct 11, 2016 at 8:33 AM, Fischetti, Antonio wrote: > Comments inline. > > Thanks, > Antonio > >> -Original Message- >> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Jarno >> Rajahalme >> Sent: Friday, October 7, 2016 10:08 PM >> To: Bodireddy, Bhanuprakash >> Cc: dev

Re: [ovs-dev] [PATCH ovs RFC 0/9] Introducing HW offload support for openvswitch

2016-10-12 Thread Pravin Shelar
Sorry for jumping in a bit late. I have couple of high level comments below. On Thu, Oct 6, 2016 at 10:10 AM, Rony Efraim wrote: > From: Joe Stringer [mailto:j...@ovn.org] Sent: Thursday, October 06, 2016 > 5:06 AM >> >> Subject: Re: [ovs-dev] [PATCH ovs RFC 0/9] Introducing HW offload support

Re: [ovs-dev] [PATCH ovs RFC 9/9] netdev-linux: add tc ingress qdisc support

2016-10-05 Thread Pravin Shelar
gt; >>> >> >>>Signed-off-by: Paul Blakey >> >>>Signed-off-by: Shahar Klein >> >I don't plan to review all of these patches but this one caught my eye. >> >> any specail reason for not looking on this series? &g

Re: [ovs-dev] [PATCH/RFC 00/12] Programming Open vSwitch (-like) flows into hardware using SwitchDev

2016-09-30 Thread pravin shelar
hdev offloads. 7. This could be a just a bug, but patch 11 changes OVS_FLOW_CMD_SET API where flow key has changed a required parameter from optional. Why not allow switchdev offload API for userspace similar to TC flower offload? or we could use flower API for switchdev flow offload. Thanks, Pravin. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] openvswitch: Allow external IPsec tunnel management.

2016-09-27 Thread pravin shelar
On Mon, Sep 26, 2016 at 1:15 PM, pravin shelar wrote: > On Mon, Sep 26, 2016 at 11:49 AM, Ansis Atteka wrote: >> >> >> On 26 September 2016 at 03:48, Pravin B Shelar wrote: >>> >>> OVS GRE IPsec tunnel support has multiple issues, Therefore >> >

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

2016-09-26 Thread pravin shelar
On Mon, Sep 26, 2016 at 9:53 AM, Jiri Benc wrote: > Reviving a very old thread, sorry. Simon handed this over to me, I'm > preparing v12. > > On Fri, 15 Jul 2016 14:07:37 -0700, pravin shelar wrote: >> I am not sure if you can use only mac_len to detect L3 packet. This >

Re: [ovs-dev] [PATCH] testsuite: Ignore IPsec deprecation msg.

2016-09-26 Thread pravin shelar
On Mon, Sep 26, 2016 at 3:08 PM, Joe Stringer wrote: > On 26 September 2016 at 13:24, Pravin B Shelar wrote: >> Fixes test failure seen due to the IPsec tunnel deprecation >> messages in test logs. >> >> Fixes: 9e9d0384910e ("openvswitch: deprecates s

[ovs-dev] [PATCH] testsuite: Ignore IPsec deprecation msg.

2016-09-26 Thread Pravin B Shelar
Fixes test failure seen due to the IPsec tunnel deprecation messages in test logs. Fixes: 9e9d0384910e ("openvswitch: deprecates support for IPsec tunnel port."). Reported-by: Joe Stringer Signed-off-by: Pravin B Shelar --- tests/ofproto-macros.at | 1 + 1 file changed, 1 insertio

Re: [ovs-dev] [PATCH] openvswitch: Allow external IPsec tunnel management.

2016-09-26 Thread pravin shelar
On Mon, Sep 26, 2016 at 11:49 AM, Ansis Atteka wrote: > > > On 26 September 2016 at 03:48, Pravin B Shelar wrote: >> >> OVS GRE IPsec tunnel support has multiple issues, Therefore > > s/issues,/issues. >> >> it was deprecated in OVS 2.6. >> >>

[ovs-dev] [PATCH] openvswitch: Allow external IPsec tunnel management.

2016-09-25 Thread Pravin B Shelar
pipeline to set skb-mark and using xfrm to implement IPsec tunnels. xfrm can match on the skb-mark to encrypt selective tunnel traffic. VMware-BZ: 1710701 Signed-off-by: Pravin B Shelar --- This is targeted for OVS master branch only. --- NEWS | 1 + README.md

Re: [ovs-dev] [PATCH] openvswitch: deprecates support for IPsec tunnel port.

2016-09-24 Thread pravin shelar
On Fri, Sep 23, 2016 at 11:27 PM, Ansis Atteka wrote: > > > On 21 September 2016 at 03:26, Pravin B Shelar wrote: >> >> OVS IPsec tunnel support has issues: >> 1. It only works for GRE. >> 2. only works on Debian. >> 3. It does not allow user to match on

Re: [ovs-dev] [PATCH] openvswitch: Allow external IPsec tunnel management.

2016-09-23 Thread pravin shelar
On Fri, Sep 23, 2016 at 12:54 PM, Ansis Atteka wrote: > On Fri, Sep 23, 2016 at 1:12 AM, pravin shelar wrote: >> On Thu, Sep 22, 2016 at 11:59 AM, Ansis Atteka wrote: >>> >>> >>> On 20 September 2016 at 20:52, Pravin B Shelar wrote: >>>> >

Re: [ovs-dev] [PATCH] openvswitch: Allow external IPsec tunnel management.

2016-09-22 Thread pravin shelar
On Thu, Sep 22, 2016 at 11:59 AM, Ansis Atteka wrote: > > > On 20 September 2016 at 20:52, Pravin B Shelar wrote: >> >> OVS IPsec tunnel support has issues: >> 1. It only works for GRE. >> >> 2. only works on Debian. >> >> 3. It does not

[ovs-dev] [PATCH] openvswitch: deprecates support for IPsec tunnel port.

2016-09-20 Thread Pravin B Shelar
OVS IPsec tunnel support has issues: 1. It only works for GRE. 2. only works on Debian. 3. It does not allow user to match on packet-mark on packet received on tunnel ports. This patch deprecates support for IPsec tunnel port. Signed-off-by: Pravin B Shelar --- After discussing this patch

[ovs-dev] [PATCH] openvswitch: Allow external IPsec tunnel management.

2016-09-20 Thread Pravin B Shelar
. This way user can use external daemon to manage IPsec tunnel traffic and stir it using skb-mark match action in OVS bridge. This patch deprecates support for IPsec tunnel port. Signed-off-by: Pravin B Shelar --- NEWS| 2 ++ debian/changelog| 2 ++ debian/control

Re: [ovs-dev] [PATCH] datapath: avoid deferred execution of recirc actions

2016-09-20 Thread pravin shelar
mes a non-issue > for currently failing scenarios because it is no longer used when > there are three or fewer recursions through ovs_execute_actions(). > > Suggested-by: Pravin Shelar > > Signed-off-by: Lance Richardson I pushed patch to master and branc

Re: [ovs-dev] [PATCH v2 2/2] openvswitch: use percpu flow stats

2016-09-17 Thread pravin shelar
t; ~15Mpps when forwarding between two 40GbE ports with a single flow > configured on the datapath. > > This has been tested on a system with possible CPUs 0-7,16-23. After > module removal, there were no corruption on the slab cache. > > Signed-off-by: Thadeu Lima de Souza Cascardo

Re: [ovs-dev] [PATCH v2 1/2] openvswitch: fix flow stats accounting when node 0 is not possible

2016-09-17 Thread pravin shelar
considered, as it's not a possible node. > > Tested that statistics are not zero on a system with only node 1 > possible. Also compile-tested with CONFIG_NUMA off. > > Signed-off-by: Thadeu Lima de Souza Cascardo Acked-by: Pravin B Shelar _

Re: [ovs-dev] [PATCH] NEWS: Add known issues for v2.6.0.

2016-09-15 Thread pravin shelar
On Thu, Sep 15, 2016 at 4:26 PM, Joe Stringer wrote: > Signed-off-by: Joe Stringer > --- > Pravin, does the GRE note look correct? > --- > NEWS | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git a/NEWS b/NEWS > index 8c78b3676cf3..19570

Re: [ovs-dev] [PATCH] datapath: compat: tunnels: Log error during initialization.

2016-09-15 Thread pravin shelar
On Thu, Sep 15, 2016 at 3:24 PM, Jesse Gross wrote: > On Thu, Sep 15, 2016 at 2:57 PM, Pravin B Shelar wrote: >> At present OVS compat tunneling can fail due to conflict with >> already loaded tunneling kernel module. In this case openvswitch >> kernel module loading fail

[ovs-dev] [PATCH] datapath: compat: tunnels: Log error during initialization.

2016-09-15 Thread Pravin B Shelar
At present OVS compat tunneling can fail due to conflict with already loaded tunneling kernel module. In this case openvswitch kernel module loading fails silently. Following patch give more clues about what went wrong. Signed-off-by: Pravin B Shelar --- datapath/linux/compat/geneve.c | 1

Re: [ovs-dev] [PATCH net-next] openvswitch: avoid deferred execution of recirc actions

2016-09-13 Thread pravin shelar
gt; With this change, the deferred action fifo size becomes a non-issue > for currently failing scenarios because it is no longer used when > there are three or fewer recursions through ovs_execute_actions(). > > Suggested-by: Pravin Shelar > Signed-off-by: Lance

Re: [ovs-dev] [PATCH] datapath: compat: geneve: use ovs specific device type for compat geneve module.

2016-09-12 Thread pravin shelar
I pushed patch to master and branch-2.6. Thanks. On Mon, Sep 12, 2016 at 4:03 PM, Joe Stringer wrote: > On 12 September 2016 at 14:55, Jesse Gross wrote: >> On Mon, Sep 12, 2016 at 2:48 PM, Pravin B Shelar wrote: >>> This allows openvswitch and geneve module co-exi

[ovs-dev] [PATCH] datapath: compat: geneve: use ovs specific device type for compat geneve module.

2016-09-12 Thread Pravin B Shelar
This allows openvswitch and geneve module co-exist kernel on newer kernels. Reported-by: Joe Stringer Signed-off-by: Pravin B Shelar --- datapath/linux/compat/geneve.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath/linux/compat/geneve.c b/datapath/linux/compat

Re: [ovs-dev] [PATCH 2/2] openvswitch: use percpu flow stats

2016-09-12 Thread pravin shelar
On Fri, Sep 9, 2016 at 1:41 PM, Thadeu Lima de Souza Cascardo wrote: > Instead of using flow stats per NUMA node, use it per CPU. When using > megaflows, the stats lock can be a bottleneck in scalability. > > On a E5-2690 12-core system, usual throughput went from ~4Mpps to > ~15Mpps when forwardi

Re: [ovs-dev] [PATCH] openvswitch: use alias for genetlink family names

2016-09-10 Thread pravin shelar
On Fri, Sep 9, 2016 at 1:42 PM, Thadeu Lima de Souza Cascardo wrote: > When userspace tries to create datapaths and the module is not loaded, > it will simply fail. With this patch, the module will be automatically > loaded. > > Signed-off-by: Thadeu Lima de Souza Cascardo Ack

Re: [ovs-dev] [PATCH net-next v22 3/3] openvswitch: 802.1AD Flow handling, actions, vlan parsing, netlink attributes

2016-09-07 Thread pravin shelar
TPID encoded along with ctci in nested attributes. > > This is based on Thomas F Herbert's original v20 patch. I made some > small clean ups and bug fixes. > > Signed-off-by: Thomas F Herbert > Signed-off-by: Eric Garver > --- Thanks for finishin

Re: [ovs-dev] [PATCH net-next v22 2/3] vlan: Check for vlan ethernet types for 8021.q or 802.1ad

2016-09-07 Thread pravin shelar
Patch based on one originally by Thomas F Herbert. > > Signed-off-by: Thomas F Herbert > Signed-off-by: Eric Garver Acked-by: Pravin B Shelar ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH net-next v22 1/3] openvswitch: 802.1ad uapi changes.

2016-09-07 Thread pravin shelar
On Wed, Sep 7, 2016 at 9:56 AM, Eric Garver wrote: > From: Thomas F Herbert > > openvswitch: Add support for 8021.AD > > Change the description of the VLAN tpid field. > > Signed-off-by: Thomas F Herbert Acked-by: Pravin B Shelar __

Re: [ovs-dev] [PATCH net-next v21 3/4] openvswitch: 802.1AD Flow handling, actions, vlan parsing, netlink attributes

2016-09-02 Thread pravin shelar
On Fri, Sep 2, 2016 at 2:42 PM, pravin shelar wrote: > On Thu, Sep 1, 2016 at 1:45 PM, Eric Garver wrote: >> Add support for 802.1ad including the ability to push and pop double >> tagged vlans. Add support for 802.1ad to netlink parsing and flow >> conversion. Use

Re: [ovs-dev] [PATCH net-next v21 4/4] openvswitch: report error on VLAN nlattr in ovs_key_from_nlattrs()

2016-09-02 Thread pravin shelar
On Thu, Sep 1, 2016 at 1:45 PM, Eric Garver wrote: > With 802.1ad support these are parsed and set upfront by > parse_vlan_from_nlattrs() before ovs_key_from_nlattrs() is ever called. > As such we should never see a VLAN attribute in ovs_key_from_nlattrs(). > > Signed-off-by: Eric Garver > --- >

Re: [ovs-dev] [PATCH net-next v21 3/4] openvswitch: 802.1AD Flow handling, actions, vlan parsing, netlink attributes

2016-09-02 Thread pravin shelar
On Thu, Sep 1, 2016 at 1:45 PM, Eric Garver wrote: > Add support for 802.1ad including the ability to push and pop double > tagged vlans. Add support for 802.1ad to netlink parsing and flow > conversion. Uses double nested encap attributes to represent double > tagged vlan. Inner TPID encoded alon

Re: [ovs-dev] [PATCH net-next v21 2/4] vlan: Check for vlan ethernet types for 8021.q or 802.1ad

2016-09-02 Thread pravin shelar
Patch based on one originally by Thomas F Herbert. > > Signed-off-by: Thomas F Herbert > Signed-off-by: Eric Garver Acked-by: Pravin B Shelar ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH net-next v21 1/4] openvswitch: 802.1ad uapi changes.

2016-09-02 Thread pravin shelar
On Thu, Sep 1, 2016 at 1:45 PM, Eric Garver wrote: > From: Thomas F Herbert > > openvswitch: Add support for 8021.AD > > Change the description of the VLAN tpid field. > > Signed-off-by: Thomas F Herbert Acked-by: Pravin B Shelar __

Re: [ovs-dev] [PATCH] datapath: Add support for kernel 4.7

2016-08-22 Thread pravin shelar
On Mon, Aug 22, 2016 at 2:40 PM, Jesse Gross wrote: > On Mon, Aug 22, 2016 at 2:24 PM, Pravin B Shelar wrote: >> Signed-off-by: Pravin B Shelar >> --- >> .travis.yml| 1 + >> .travis/linux-build.sh | 12 >> FAQ.md

[ovs-dev] [PATCH] datapath: Add support for kernel 4.7

2016-08-22 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar --- .travis.yml| 1 + .travis/linux-build.sh | 12 FAQ.md | 2 +- NEWS | 2 +- acinclude.m4 | 4 ++-- 5 files changed, 17 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml

Re: [ovs-dev] [PATCH] tests: Avoid race in tunnel-push-pop tests.

2016-08-18 Thread pravin shelar
o avoid being affected by the timing of flow eviction. > > Signed-off-by: Jesse Gross LGTM Acked-by: Pravin B Shelar ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2] datapath: compat: backport LCO optimization.

2016-08-18 Thread pravin shelar
On Thu, Aug 18, 2016 at 2:35 PM, Jesse Gross wrote: > On Wed, Aug 17, 2016 at 10:17 PM, pravin shelar wrote: >> On Wed, Aug 17, 2016 at 5:26 PM, Jesse Gross wrote: >>> On Wed, Aug 17, 2016 at 10:23 AM, Pravin B Shelar wrote: >>>> diff --git a/datapath/linux/compat

Re: [ovs-dev] [PATCH v2] datapath: compat: backport LCO optimization.

2016-08-17 Thread pravin shelar
On Wed, Aug 17, 2016 at 5:26 PM, Jesse Gross wrote: > On Wed, Aug 17, 2016 at 10:23 AM, Pravin B Shelar wrote: >> diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c >> index 89df07f..48a56b9 100644 >> --- a/datapath/linux/compat/gso.c >> +++ b/

[ovs-dev] [PATCH v2] datapath: compat: backport LCO optimization.

2016-08-17 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar --- acinclude.m4 | 1 + datapath/linux/compat/gso.c | 12 ++-- datapath/linux/compat/include/linux/skbuff.h | 23 +++ datapath/linux/compat/ip_tunnels_core.c | 8 +++- datapath/linux

Re: [ovs-dev] [PATCH 1/3] datapath: compat: backport LCO optimization.

2016-08-17 Thread pravin shelar
On Tue, Aug 16, 2016 at 6:31 PM, Jesse Gross wrote: > On Mon, Aug 15, 2016 at 2:11 PM, Pravin B Shelar wrote: >> diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c >> index 89df07f..f973fb4 100644 >> --- a/datapath/linux/compat/gso.c >> +++ b/

Re: [ovs-dev] [PATCH 3/3] datapath: compat: gso: use sg and csum features for segmentation.

2016-08-16 Thread pravin shelar
On Tue, Aug 16, 2016 at 6:32 PM, Jesse Gross wrote: > On Mon, Aug 15, 2016 at 2:11 PM, Pravin B Shelar wrote: >> With use of LCO support we can finally enable SG and CSUM >> features for GSO backport. >> >> Signed-off-by: Pravin B Shelar > > I don't know i

[ovs-dev] [PATCH 3/3] datapath: compat: gso: use sg and csum features for segmentation.

2016-08-15 Thread Pravin B Shelar
With use of LCO support we can finally enable SG and CSUM features for GSO backport. Signed-off-by: Pravin B Shelar --- datapath/linux/compat/gso.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c index f973fb4

[ovs-dev] [PATCH 1/3] datapath: compat: backport LCO optimization.

2016-08-15 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar --- acinclude.m4 | 1 + datapath/linux/compat/gso.c | 6 -- datapath/linux/compat/include/linux/skbuff.h | 23 +++ datapath/linux/compat/ip_tunnels_core.c | 8 +++- datapath/linux/compat

[ovs-dev] [PATCH 2/3] datapath: compat: handle_offloads: remove csum_help param.

2016-08-15 Thread Pravin B Shelar
and remove the code that was conditional upon it. Signed-off-by: Edward Cree Signed-off-by: David S. Miller Signed-off-by: Pravin B Shelar --- datapath/linux/compat/include/net/ip_tunnels.h | 2 +- datapath/linux/compat/include/net/udp_tunnel.h | 2 +- datapath/linux/compa

Re: [ovs-dev] [PATCH v2] datapath: backport: openvswitch: do not ignore netdev errors when creating tunnel vports

2016-08-15 Thread pravin shelar
On Mon, Aug 15, 2016 at 10:04 AM, Jesse Gross wrote: > On Mon, Aug 15, 2016 at 9:57 AM, Pravin B Shelar wrote: >> Upstream commit: >> commit 4b5b9ba553f9aa5f484ab972fc9b58061885ceca >> Author: Martynas Pumputis >> Date: Tue Aug 9 16:24:50 2016 +0100 &g

Re: [ovs-dev] [PATCH 2/2] datapath: backport: openvswitch: do not ignore netdev errors when creating tunnel vports

2016-08-15 Thread pravin shelar
On Sat, Aug 13, 2016 at 10:11 AM, Jesse Gross wrote: > On Fri, Aug 12, 2016 at 10:49 AM, Pravin B Shelar wrote: >> Upstream commit: >> commit 4b5b9ba553f9aa5f484ab972fc9b58061885ceca >> Author: Martynas Pumputis >> Date: Tue Aug 9 16:24:50 2016 +0100 &g

[ovs-dev] [PATCH v2] datapath: backport: openvswitch: do not ignore netdev errors when creating tunnel vports

2016-08-15 Thread Pravin B Shelar
ance that the tunnel vport creation completed successfully. Signed-off-by: Martynas Pumputis Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Signed-off-by: Pravin B Shelar --- datapath/vport-geneve.c | 9 - datapath/vport-gre.c| 11 +-- datapath

Re: [ovs-dev] [PATCH 1/2] datapath: backport: OVS: Ignore negative headroom value

2016-08-15 Thread pravin shelar
On Sat, Aug 13, 2016 at 10:08 AM, Jesse Gross wrote: > On Fri, Aug 12, 2016 at 10:49 AM, Pravin B Shelar wrote: >> Upstream commit: >> commit 5ef9f289c4e698054e5687edb54f0da3cdc9173a >> Author: Ian Wienand >> Date: Wed Aug 3 15:44:57 2016 +1000 >

[ovs-dev] [PATCH 1/2] datapath: backport: OVS: Ignore negative headroom value

2016-08-12 Thread Pravin B Shelar
id=1361414 Signed-off-by: Ian Wienand Signed-off-by: David S. Miller Signed-off-by: Pravin B Shelar --- datapath/vport-internal_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath/vport-internal_dev.c b/datapath/vport-internal_dev.c index 198bae6..482af37

[ovs-dev] [PATCH 2/2] datapath: backport: openvswitch: do not ignore netdev errors when creating tunnel vports

2016-08-12 Thread Pravin B Shelar
ance that the tunnel vport creation completed successfully. Signed-off-by: Martynas Pumputis Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Signed-off-by: Pravin B Shelar --- datapath/vport-geneve.c | 9 - datapath/vport-gre.c| 11 +-- datapath

Re: [ovs-dev] [PATCH] datapath: compat: keep skb mark across tunnel devices.

2016-08-12 Thread pravin shelar
On Thu, Aug 11, 2016 at 10:33 PM, Joe Stringer wrote: > On 11 August 2016 at 19:43, Pravin B Shelar wrote: >> Older kernel skb_scrub_packet() has bug which resets skb mark for >> all packet. It is fixed during 3.18 release where it is reset >> only for packets crossing

[ovs-dev] [PATCH] datapath: compat: keep skb mark across tunnel devices.

2016-08-11 Thread Pravin B Shelar
kbuff: Do not scrub skb mark within the same name space"). VMware-BZ: #1710701 Signed-off-by: Pravin B Shelar --- acinclude.m4 | 2 -- datapath/linux/compat/include/linux/skbuff.h | 2 +- datapath/linux/compat/skbuff-openvswitch.c | 2 +- 3 files changed, 2

Re: [ovs-dev] [PATCH v2] datapath: compat: keep skb encapsulation zero on older kernel.

2016-08-11 Thread pravin shelar
On Thu, Aug 11, 2016 at 2:23 PM, Jesse Gross wrote: > On Thu, Aug 11, 2016 at 2:12 PM, Pravin B Shelar wrote: >> When using compat GSO there is no need to turn on skb >> encapsulation bit since OVS does not use any tunnel GSO >> functionality from the networking stack

[ovs-dev] [PATCH v2] datapath: compat: keep skb encapsulation zero on older kernel.

2016-08-11 Thread Pravin B Shelar
When using compat GSO there is no need to turn on skb encapsulation bit since OVS does not use any tunnel GSO functionality from the networking stack. Signed-off-by: Pravin B Shelar --- datapath/linux/compat/gso.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a

Re: [ovs-dev] [PATCH 3/3] datapath: compat: vxlan: fix vxlan_notify_add_rx_port().

2016-08-11 Thread pravin shelar
On Thu, Aug 11, 2016 at 1:54 PM, Jesse Gross wrote: > On Wed, Aug 10, 2016 at 10:34 AM, Pravin B Shelar wrote: >> Same as earlier patch this fixes vxlan recieve offload implementation. >> >> Signed-off-by: Pravin B Shelar > > Acked-by: Jesse Gross Thanks for revi

Re: [ovs-dev] [PATCH 1/3] datapath: compat: keep skb encapsulation zero on older kernel.

2016-08-11 Thread pravin shelar
On Thu, Aug 11, 2016 at 1:17 PM, Jesse Gross wrote: > On Wed, Aug 10, 2016 at 10:34 AM, Pravin B Shelar wrote: >> When using compat GSO there is no need to turn on skb >> encapsulation bit since OVS does not use any tunnel GSO >> functionality from the networking stack

[ovs-dev] [PATCH 2/3] datapath: compat: geneve: fix geneve_notify_add_rx_port()

2016-08-10 Thread Pravin B Shelar
Remove mutual exclusion between udp-gro registration and geneve receive port registration. Signed-off-by: Pravin B Shelar --- acinclude.m4 | 4 +++ datapath/linux/Modules.mk| 1 + datapath/linux/compat/geneve.c | 44

[ovs-dev] [PATCH 3/3] datapath: compat: vxlan: fix vxlan_notify_add_rx_port().

2016-08-10 Thread Pravin B Shelar
Same as earlier patch this fixes vxlan recieve offload implementation. Signed-off-by: Pravin B Shelar --- datapath/linux/compat/vxlan.c | 43 +-- 1 file changed, 17 insertions(+), 26 deletions(-) diff --git a/datapath/linux/compat/vxlan.c b/datapath

[ovs-dev] [PATCH 1/3] datapath: compat: keep skb encapsulation zero on older kernel.

2016-08-10 Thread Pravin B Shelar
When using compat GSO there is no need to turn on skb encapsulation bit since OVS does not use any tunnel GSO functionality from the networking stack. Signed-off-by: Pravin B Shelar --- datapath/linux/compat/ip_tunnels_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/datapath/linux

  1   2   3   4   5   6   7   8   9   10   >