Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

On Tue, Aug 2, 2016 at 7:56 AM, Russell Bryant <russ...@ovn.org> wrote: > > On Tue, Aug 2, 2016 at 12:20 AM, Ryan Moats <rmo...@us.ibm.com> wrote: > >> This commit creates wrapper scripts for the *ctl commands to use >> --dry-run for those that have them, and to a

Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

all all of these. They're also not documented anywhere. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

On Sat, Jul 30, 2016 at 4:19 PM, Mickey Spiegel <mickeys@gmail.com> wrote: > On Fri, Jul 29, 2016 at 10:28 AM, Mickey Spiegel <emspi...@us.ibm.com> > wrote: > > > > -"dev" <dev-boun...@openvswitch.org> wrote: - > >> To: Mickey Sp

Re: [ovs-dev] [PATCH] ovn-controller: if 'ovn-bridge-mappings' unconfigured, return directly.

On Mon, Aug 1, 2016 at 12:09 PM, Russell Bryant <russ...@ovn.org> wrote: > > > On Mon, Aug 1, 2016 at 12:00 PM, Ben Pfaff <b...@ovn.org> wrote: > >> On Mon, Aug 01, 2016 at 02:55:26AM -0700, nickcooper-zhangtonghao wrote: >> > If the chassis doesn't configur

Re: [ovs-dev] [PATCH] ovn-controller: if 'ovn-bridge-mappings' unconfigured, return directly.

necessary code. The most notable improvement seems to be skipping a loop over all Port_Binding records in every call to patch_run. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2] ovn-controller: Restore ct zone assignment.

On Fri, Jul 29, 2016 at 3:52 PM, Ryan Moats <rmo...@us.ibm.com> wrote: > Acked-by: Ryan Moats <rmo...@us.ibm.com> Thanks, applied to master. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] travis: Fix flake8 failures from flake8 3.0.

On Fri, Jul 29, 2016 at 4:57 PM, Russell Bryant <russ...@ovn.org> wrote: > > > On Fri, Jul 29, 2016 at 3:30 PM, Andy Zhou <az...@ovn.org> wrote: > >> >> >> On Fri, Jul 29, 2016 at 12:18 PM, Russell Bryant <russ...@ovn.org> wrote: >> >>&

Re: [ovs-dev] [PATCH] travis: Fix flake8 failures from flake8 3.0.

On Fri, Jul 29, 2016 at 3:30 PM, Andy Zhou <az...@ovn.org> wrote: > > > On Fri, Jul 29, 2016 at 12:18 PM, Russell Bryant <russ...@ovn.org> wrote: > >> The "hacking" plugin for flake8 is not currently compatible with flake8 >> 3.0. Ensure that we

[ovs-dev] [PATCH] travis: Fix flake8 failures from flake8 3.0.

The "hacking" plugin for flake8 is not currently compatible with flake8 3.0. Ensure that we install flake8 2.x on travis-ci. Also update the docs to indicate this incompatibility. Signed-off-by: Russell Bryant <russ...@ovn.org> --- .travis/linux-prepare.sh |

Re: [ovs-dev] [PATCH 5/5] ovsdb-idl: Wake up ovsdb_idl_loop when a transaction commits.

ack cloud > tomorrow > > and run some rally tests against it to see if indeed does result in a > > measurable change in performance. > > This commit is not supposed to be a performance fix, it's supposed to be > a correctness fix. > > I don't have a really good example of the kind of thing that it fixes so > I'm happy to sit on it for a while until I do. It makes sense to me. Acked-by: Russell Bryant <russ...@ovn.org> -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

CL stage. The "priority" values are only relevant within the > context of an ACL stage. > > ACL rules that do not specify an ACL stage are applied to the > default "acl" stage. > > Signed-off-by: Mickey Spiegel <mickeys....@gm

Re: [ovs-dev] [PATCH v2] ovn-controller: Restore ct zone assignment.

On Fri, Jul 29, 2016 at 11:59 AM, Ryan Moats <rmo...@us.ibm.com> wrote: > "dev" <dev-boun...@openvswitch.org> wrote on 07/29/2016 10:18:49 AM: > > > From: Russell Bryant <russ...@ovn.org> > > To: dev@openvswitch.org > > Date: 07/29/2016 10:19

Re: [ovs-dev] [PATCH v2] ovn-controller: Restore ct zone assignment.

On Fri, Jul 29, 2016 at 11:18 AM, Russell Bryant <russ...@ovn.org> wrote: > From: Babu Shanmugam <bscha...@redhat.com> > > Recent commits reorganizing bindings handling and also moving ct zone > assignment to ovn-controller.c caused ct zone assignment to no longer

[ovs-dev] [PATCH v2] ovn-controller: Restore ct zone assignment.

uld be assigning ct zones for. Prior to this change, all_lports was always empty. Signed-off-by: Babu Shanmugam <bscha...@redhat.com> Co-authored-by: Russell Bryant <russ...@ovn.org> Signed-off-by: Russell Bryant <russ...@ovn.org> --- ov

Re: [ovs-dev] [PATCH] ovn-controller: Remove old values from local_ids.

On Thu, Jul 28, 2016 at 6:13 PM, Ryan Moats <rmo...@us.ibm.com> wrote: > "dev" <dev-boun...@openvswitch.org> wrote on 07/28/2016 04:22:41 PM: > > > From: Russell Bryant <russ...@ovn.org> > > To: dev@openvswitch.org > > Date: 07/28/2016 04

[ovs-dev] [PATCH] ovn-controller: Remove old values from local_ids.

ports was moved to another chassis. We would end up with two chassis fighting over the binding of the child ports. Signed-off-by: Russell Bryant <russ...@ovn.org> --- ovn/controller/binding.c | 5 + 1 file changed, 5 insertions(+) diff --git a/ovn/controller/binding.c b/ovn/cont

Re: [ovs-dev] [PATCH] ovn: Rename "gateway" to "l3gateway".

On Thu, Jul 28, 2016 at 9:45 AM, Guru Shetty <g...@ovn.org> wrote: > On 26 July 2016 at 13:49, Russell Bryant <russ...@ovn.org> wrote: > >> When L3 gateway support was added, it introduced a port type called >> "gateway" and a corresponding option called &q

Re: [ovs-dev] [PATCH 2/2] ovs-dev.py: Update for python3.

On Thu, Jul 28, 2016 at 2:11 PM, Joe Stringer <j...@ovn.org> wrote: > On 28 July 2016 at 11:02, Russell Bryant <russ...@ovn.org> wrote: > > > > > > On Mon, May 16, 2016 at 5:56 PM, Joe Stringer <j...@ovn.org> wrote: > >> > >> Adapt to p

Re: [ovs-dev] [PATCH] ovn-controller: Add datapath-type in chassis:external_ids

that's the use case. It seems pretty round about, but this is easiest way for us to integrate into OpenStack today. Exposing it as an external_id on the Chassis seemed like a pretty non-intrusive way to expose the info. Hopefully it's not *too* offensive. :-) -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/2] ovs-dev.py: Update for python3.

On Mon, May 16, 2016 at 5:56 PM, Joe Stringer <j...@ovn.org> wrote: > Adapt to python-2.6+, including support for 3. > > Signed-off-by: Joe Stringer <j...@ovn.org> > Acked-by: Russell Bryant <russ...@ovn.org> -- Russell Bryant __

Re: [ovs-dev] [PATCH] ovn-controller: update_ct_zone operates always on empty set

On Wed, Jul 27, 2016 at 1:44 AM, Babu Shanmugam <bscha...@redhat.com> wrote: > > > On Wednesday 27 July 2016 06:43 AM, Russell Bryant wrote: > > On Tue, Jul 26, 2016 at 6:46 AM, <bscha...@redhat.com> wrote: > >> From: Babu Shanmugam <bscha...@redhat.com>

Re: [ovs-dev] [PATCH] ovn: Rename "gateway" to "l3gateway".

On Tue, Jul 26, 2016 at 5:07 PM, Kyle Mestery <mest...@mestery.com> wrote: > On Tue, Jul 26, 2016 at 3:49 PM, Russell Bryant <russ...@ovn.org> wrote: > > When L3 gateway support was added, it introduced a port type called > > "gateway" and a corresponding op

Re: [ovs-dev] [PATCH] doc: Update INSTALL.Docker.md to reflect it's focus on OVN

orking with Docker. > > This change updates the title, as well as the opening paragraphs > to more accurately reflect what the document is talking about. > > Signed-off-by: Kyle Mestery <mest...@mestery.com> > > Seems fine to me, but I thi

Re: [ovs-dev] [PATCH v2] ovn-controller: Restore all_lports for update_ct_zone

nt to allocate > + * a conntrack zone ID for each one, as we'll be creating > + * a patch port for each one. */ > + sset_add(all_lports, binding_rec->logical_port); > +} > +} > + > This seems to undo the benefits of the original change to do "incremental procesing" in binding.c. It seems like we weren't that far from a complete fix in Babu's first patch. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ovn-controller: update_ct_zone operates always on empty set

On Wed, Jul 27, 2016 at 8:34 AM, Ryan Moats <rmo...@us.ibm.com> wrote: > "dev" <dev-boun...@openvswitch.org> wrote on 07/27/2016 12:44:38 AM: > > > From: Babu Shanmugam <bscha...@redhat.com> > > To: Russell Bryant <russ...@ovn.org> > > Cc

Re: [ovs-dev] ovsdb active backup deployment

On Tue, Jul 26, 2016 at 3:48 PM, Andy Zhou <az...@ovn.org> wrote: > > > On Tue, Jul 26, 2016 at 11:59 AM, Russell Bryant <russ...@ovn.org> wrote: > >> >> >> On Tue, Jul 26, 2016 at 2:41 PM, Andy Zhou <az...@ovn.org> wrote: >> >>>

Re: [ovs-dev] [PATCH] ovn-controller: update_ct_zone operates always on empty set

ths, > _lports); > } > > if (br_int && chassis_id) { > -- > 2.5.5 > > ___ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev > -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] [PATCH v1] ovn-northd: Fix {}-enclosed constants for ND responder

On Tue, Jul 26, 2016 at 2:02 AM, Zong Kai LI <zealo...@gmail.com> wrote: > It missed comma as constant seperator in match string for ND responder. > > Signed-off-by: Zong Kai LI <zealo...@gmail.com> Thanks! I applied this to master

[ovs-dev] [PATCH] ovn: Rename "gateway" to "l3gateway".

uot;. This patch renames the L3 gateway port type and option to "l3gateway" and "l3gateway-chassis" to make things a little more clear and consistent. Signed-off-by: Russell Bryant <russ...@ovn.org> --- ovn/controller/binding.c | 2 +- ovn/controller/patch.c |

Re: [ovs-dev] [PATCH v3] Scanning only changed entries in the ovnsb

lumn [1]. Therefore, > ovnsb_db_run should only look the entry that are changed with its Chassis > column. There is no need to initialize by iterating every entry in the > Port_binding table. Please correct me if my understanding is incorrect. > Thanks. > What if the Chassis column changes in some Port_Binding records while ovn-northd isn't running? -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v3] ovn: Make it possible for CMS to detect when the OVN system is up-to-date.

--- > v1->v2: Rebase to fix up database version number. > v3: Rebase due to changes on master. > The code looks sane and seems to be working for me with some basic testing. Cool feature, thanks! Acked-by: Russell Bryant <russ...@ovn.org> -- Russell Bryant _

Re: [ovs-dev] ovsdb active backup deployment

On Tue, Jul 26, 2016 at 2:41 PM, Andy Zhou <az...@ovn.org> wrote: > > > On Tue, Jul 26, 2016 at 5:37 AM, Russell Bryant <russ...@ovn.org> wrote: > >> >> >> On Mon, Jul 25, 2016 at 8:15 PM, Andy Zhou <az...@ovn.org> wrote: >> >>&

Re: [ovs-dev] Compiler warnings with gcc 6.1 (On Fedora 24)

ke it > > work without warnings. > > > > ​Thanks for the pointers. I will give it a try. > Hi, Numan. I'm using Fedora 24 and I don't see these warnings. I'm not sure what's different. $ gcc --version gcc (GCC) 6.1.1 20160621 (Red Hat 6.1.1-3) -- Russell Bryant ___

Re: [ovs-dev] [PATCH] python: Send old values of the updated cols in notify for update2

n idl to work with monitor_cond") > Signed-off-by: Numan Siddique <nusid...@redhat.com> > Is there a test case that could be updated or expanded to catch this issue? -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] [PATCH v1] ovs-dev: add set type for ovs.idl.data.Datum.from_python

I applied this to master with some minor updates to the commit message. You posted this as a "v1", but it actually appears to be a v2 of an earlier patch. I included the Acked-by and Tested-by headers from v1. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v6 1/1] ovn: Apply ACL changes to existing connections.

On Thu, Jul 7, 2016 at 1:13 PM, Justin Pettit <jpet...@ovn.org> wrote: > > > On Jun 30, 2016, at 10:14 PM, Russell Bryant <russ...@ovn.org> wrote: > > > > diff --git a/ovn/northd/ovn-northd.8.xml b/ovn/northd/ovn-northd.8.xml > > index 260cc14..d2bddcb 10064

Re: [ovs-dev] [PATCH] ovn: Add datapth of gateway port tolocal_datapaths

we can see them not being created > without this code and being created with it and avoid later > regressions. > You might want to consider an end-to-end test that sets up this scenario and makes sure a packet makes it through. That covers more than just making sure a port binding is created

Re: [ovs-dev] [PATCH] release-process.md: Document OVS release process and propose a schedule.

On Wed, Jul 20, 2016 at 12:30 PM, Ben Pfaff <b...@ovn.org> wrote: > On Wed, Jul 20, 2016 at 10:00:22AM -0400, Russell Bryant wrote: > > On Tue, Jul 19, 2016 at 1:58 PM, Ben Pfaff <b...@ovn.org> wrote: > > > > > This document has two different kinds of text:

Re: [ovs-dev] [PATCH] release-process.md: Document OVS release process and propose a schedule.

gt; +T + 4 Aug 1 Feb 1branch-x.y forks from master > +T + 5.5 Sep 15 Mar 15 branch-x.y released as version x.y.0 > + > +Contact > +--- > + > +Please use dev@openvswitch.org to discuss the Open vSwitch development > +and release process. > I think this is

Re: [ovs-dev] [PATCH v2] ovn: Make it possible for CMS to detect when the OVN system is up-to-date.

On Tue, Jul 19, 2016 at 3:45 PM, Ben Pfaff <b...@ovn.org> wrote: > On Tue, Jul 19, 2016 at 10:06:09AM -0400, Russell Bryant wrote: > > On Mon, Jul 18, 2016 at 2:30 PM, Ben Pfaff <b...@ovn.org> wrote: > > > > > Until now, there has been no reliable for the CMS (

Re: [ovs-dev] [PATCH v2] ovn-sbctl: eliminate a spurious test case error cause

ed in ovs-nbctl and > > ovn-vtep-controller tests, so fix it there as well. > > > > Signed-off-by: Lance Richardson <lrich...@redhat.com> > > --- > > This looks simple enough, applies clean and passes unit tests, > so. If it were a crash, I'd look for a tes

Re: [ovs-dev] [PATCH v2] ovn: Make it possible for CMS to detect when the OVN system is up-to-date.

creasing. */ > Would this also get hit if nb_cfg overflows? That would sure be a *lot* of transactions, though ... -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] SFC-Summary: MultiTenant

l be neutron trunk-subport-add T1 \ A vlan 1 \ > B vlan 2 Is my understanding correct? thanks,Farhad. > ___ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev > ___

Re: [ovs-dev] [PATCH] ovn-northd.8.xml: Remove outdated flow.

On Fri, Jul 15, 2016 at 1:11 PM, Ryan Moats <rmo...@us.ibm.com> wrote: > Russell Bryant <russ...@ovn.org> wrote on 07/15/2016 11:38:14 AM: > > > From: Russell Bryant <russ...@ovn.org> > > To: dev@openvswitch.org > > Cc: Ryan Moats/Omaha/IBM@IBMUS, Russel

Re: [ovs-dev] [PATCH] ovn: Add 128-bit support for ct_label

ill take care of it from next time.​ An easy way to do this is to use the "-s" option to "git commit". It automatically adds the header for you in the correct format. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ovn-controller: Drop remove_local_datapath_by_binding().

On Mon, Jul 18, 2016 at 4:56 PM, Ryan Moats <rmo...@us.ibm.com> wrote: > Russell Bryant <russ...@ovn.org> wrote on 07/18/2016 03:47:34 PM: > > > From: Russell Bryant <russ...@ovn.org> > > To: dev@openvswitch.org > > Cc: Ryan Moats/Omaha/IBM@IBMUS, Russel

[ovs-dev] [PATCH] ovn-controller: Drop remove_local_datapath_by_binding().

g_run to incremental processing.") Signed-off-by: Russell Bryant <russ...@ovn.org> --- ovn/controller/binding.c | 29 + 1 file changed, 9 insertions(+), 20 deletions(-) diff --git a/ovn/controller/binding.c b/ovn/controller/binding.c index adf4127..bc6df32

Re: [ovs-dev] [PATCH] ovn-controller: Remove local_datapaths_by_uuid.

On Mon, Jul 18, 2016 at 4:22 PM, Ryan Moats <rmo...@us.ibm.com> wrote: > Russell Bryant <russ...@ovn.org> wrote on 07/18/2016 03:01:41 PM: > > > From: Russell Bryant <russ...@ovn.org> > > To: dev@openvswitch.org > > Cc: Ryan Moats/Omaha/IBM@IBMUS, Russel

Re: [ovs-dev] [PATCH] ovn: Remove a completed TODO item.

On Mon, Jul 18, 2016 at 3:45 PM, Kyle Mestery <mest...@mestery.com> wrote: > On Mon, Jul 18, 2016 at 2:32 PM, Russell Bryant <russ...@ovn.org> wrote: > > This TODO item was implemented a while ago, so remove it from the TODO > > file. > > > > Fixes: 0e

[ovs-dev] [PATCH] ovn-controller: Remove local_datapaths_by_uuid.

binding.c included a static local_datapaths_by_uuid but it was not used for anything. In fact, the hash node used when inserting into this hmap is overwritten in another code path for a different hmap. Fixes: 263064aeaa31 ("Convert binding_run to incremental processing.") Signed-off-b

Re: [ovs-dev] [PATCH v2] ovn-controller: Clean up bindings handling.

On Sat, Jul 16, 2016 at 10:31 PM, Ryan Moats <rmo...@us.ibm.com> wrote: > "dev" <dev-boun...@openvswitch.org> wrote on 07/14/2016 02:47:52 PM: > > > From: Russell Bryant <russ...@ovn.org> > > To: dev@openvswitch.org > > Date: 07/14/2016 02:48

[ovs-dev] [PATCH] ovn: Remove a completed TODO item.

This TODO item was implemented a while ago, so remove it from the TODO file. Fixes: 0ee8aaf658dd ("ovn: Send GARP on localnet.") Signed-off-by: Russell Bryant <russ...@ovn.org> --- ovn/TODO | 6 -- 1 file changed, 6 deletions(-) diff --git a/ovn/TODO b/ovn/TODO index 0a6225d

Re: [ovs-dev] [PATCH v2] ovn-controller-vtep: occasional failure in "binding 1" test case

st -z "`vtep-ctl list physical_port p0`"]) > > +OVS_WAIT_UNTIL([test -z "`vtep-ctl list physical_port p1`"]) > > # should see empty chassis column in both binding entries. > > AT_CHECK_UNQUOTED([ovn-sbctl --columns=chassis list Port_Binding | cut > -d > > ':' -f2 | tr -d ' ' | sort], [0], [dnl > > > > -- > > 2.5.5 > > > > > Acked-by: Darrell Ball <dlu...@gmail.com> Thanks! Applied to master. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ovn-northd: Remove extraneous ip4 mulicast logical flow.

On Thu, Jul 14, 2016 at 4:38 PM, Russell Bryant <russ...@ovn.org> wrote: > > > On Thu, Jul 14, 2016 at 2:47 PM, Flaviof <fla...@flaviof.com> wrote: > >> On Thu, Jul 14, 2016 at 2:34 PM, Ryan Moats <rmo...@us.ibm.com> wrote: >> >> > IPv4 mult

[ovs-dev] [PATCH] ovn-northd.8.xml: Remove outdated flow.

This flow was a duplicate and was removed in a previous commit. Update the docs to reflect the removal. Fixes: 6a9d35dde4a9 ("ovn-northd: Remove extraneous ip4 mulicast logical flow.") Signed-off-by: Russell Bryant <russ...@ovn.org> --- ovn/northd/ovn-northd.8.xml | 5 - 1

Re: [ovs-dev] [patch_v2] ovs-vtep: Handle tunnel key configuration in any order.

"ovn-controller-vtep - vtep-macs 1". > > Russell (since you commented on v1), does this look good to you? > > I'm not super familiar with ovs-vtep, either. This patch looks straight forward enough to me, though. Acked-by: Russell Bryant <russ...@ovn.org> > Thanks

Re: [ovs-dev] [PATCH] ovn-northd: Remove extraneous ip4 mulicast logical flow.

on to add > > a lower priority rule for it. > > > > Signed-off-by: Ryan Moats <rmo...@us.ibm.com> > > > > Acked-by: Flavio Fernandes <fla...@flaviof.com> > > Thanks, applied to master. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH v2] ovn-controller: Clean up bindings handling.

as needed. Found by inspection. Signed-off-by: Russell Bryant <russ...@ovn.org> --- ovn/controller/binding.c | 77 1 file changed, 32 insertions(+), 45 deletions(-) v1->v2: - Add lport_to_iface shash built each run in get_local_iface_ids d

[ovs-dev] [PATCH] ovn-controller: Clean up bindings handling.

references to freed memory. Instead, replace it with a new global sset of logical port IDs called 'local_ids'. This is used to track when interfaces have been added or removed. Found by inspection. Signed-off-by: Russell Bryant <russ...@ovn.org> --- ovn/controller/binding.c

Re: [ovs-dev] [PATCH] ovn-sbctl: Adjust formatting of lflow-list.

On Wed, Jul 13, 2016 at 2:08 PM, Ben Pfaff <b...@ovn.org> wrote: > On Wed, Jul 13, 2016 at 01:50:58PM -0400, Russell Bryant wrote: > > Adjust the field width for a couple of elements in the output of the > > lflow-list sub-command of ovn-sbctl. We now have a table ID of 1

[ovs-dev] [PATCH] ovn-sbctl: Adjust formatting of lflow-list.

, left justify values in fields, as I find that to look a little nicer. Also update sample output in OVN-Tutorial.md to match the current state. Signed-off-by: Russell Bryant <russ...@ovn.org> --- ovn/utilities/ovn-sbctl.c | 2 +- tutorial/OVN-Tutorial.md

Re: [ovs-dev] SFC-Summary: MultiTenant

apsulation (VLAN ID, MPLS header, whatever) would be used to differentiate the traffic for each networking in/out of that VIF. I had started adding the ability to use MPLS for this in my prototype for this reason, as that was what networking-sfc had defined. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2] ovn: Support l2gateway-chassis option in "l2gateway" logical ports

s_rec && ctx->ovnsb_idl_txn) { VLOG_INFO("Releasing l2gateway port %s from this chassis.", binding_rec->logical_port); sbrec_port_binding_set_chassis(binding_rec, NULL); -- Russell Bryant __

Re: [ovs-dev] [PATCH] ovn: Support chassis option in "l2gateway" logical ports

On Fri, Jul 8, 2016 at 9:36 AM, Numan Siddique <nusid...@redhat.com> wrote: > On Jul 8, 2016 8:04 PM, "Russell Bryant" <russ...@ovn.org> wrote: > > > > > > > > On Thu, Jul 7, 2016 at 11:47 PM, Numan Siddique <nusid...@redhat.com> > wrot

Re: [ovs-dev] [patch_v1] ovn: Remove unreferenced patched datapaths

-to-end test cases, including the use of the kernel datapath. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ovn: Support chassis option in "l2gateway" logical ports

On Thu, Jul 7, 2016 at 11:47 PM, Numan Siddique <nusid...@redhat.com> wrote: > Thanks for the review Russel. > Please see comments inline. > > On Fri, Jul 8, 2016 at 1:19 AM, Russell Bryant <russ...@ovn.org> wrote: > >> Thanks for working on this! A few comme

Re: [ovs-dev] [PATCH V2] ovn test: Skip "send gratuitous arp on localnet" if no Python installed

d gratuitous arp on localnet]) > > AT_KEYWORDS([ovn]) > > +AT_SKIP_IF([test $HAVE_PYTHON = no]) > > ovn_start > > ovn-nbctl ls-add lsw0 > > net_add n1 > > -- > > 2.7.2.windows.1 > > ___ > > dev mailing li

Re: [ovs-dev] [patch_v1] ovn: Remove unreferenced patched datapaths

/* Clean up stale patched datapaths. */ > +struct patched_datapath *pd_cur_node, *pd_next_node; > +HMAP_FOR_EACH_SAFE (pd_cur_node, pd_next_node, hmap_node, > patched_datapaths) { > +if (pd_cur_node->stale == true) { > +hmap_remove(patched_datapaths, _cur_node->h

Re: [ovs-dev] [PATCH] ovn-sbctl: Change lport-(un)bind to lsp-(un)bind.

On Sat, Jul 2, 2016 at 12:27 PM, Ben Pfaff <b...@ovn.org> wrote: > On Fri, Jun 24, 2016 at 04:37:58PM -0400, Russell Bryant wrote: > > A previous commit changed the command names in ovn-nbctl from lport-* to > > lsp-*. Change lport-bind and lport-unbind in ovn-sbctl to matc

Re: [ovs-dev] [PATCH] ovn: Support chassis option in "l2gateway" logical ports

@@ ovn-nbctl lsp-set-addresses lp2 f0:00:00:00:00:02 > > ovn-nbctl lsp-add lsw0 lp-gw > ovn-nbctl lsp-set-type lp-gw l2gateway > -ovn-nbctl lsp-set-options lp-gw network_name=physnet1 > +ovn-nbctl lsp-set-options lp-gw network_name=physnet1 chassis=hv_gw > l2gateway-chassis after

[ovs-dev] [PATCH] OVN-Tutorial: Update sample output.

A previous patch made some additions to section 1 of this tutorial. This patch includes updates to the sample output that I got while testing the additions to the tutorial. Signed-off-by: Russell Bryant <russ...@ovn.org> --- tutorial/OVN-Tutorial.m

Re: [ovs-dev] [PATCH] ovn: improve OVN tutorial.

on since the first section was intended as the simplest possible example. None of that is a big deal, I just wanted to share some thoughts in case you want to keep working on this. I'm also going to post a follow-up patch that updates some out of date sample output. -- Russell Bryant __

Re: [ovs-dev] [PATCH] INSTALL.Docker.md: Clarify OVS python library path.

he instructions in INSTALL.md, > you > +should specify the path. The path in that case depends on the options > passed > +to ./configure. (It is usually either '/usr/share/openvswitch/python' or > +'/usr/local/share/openvswitch/python'.) > + > [INSTALL.md]: INSTALL.md > [op

Re: [ovs-dev] [PATCH v2] ovn-controller: Remove old address set after change.

On Thu, Jul 7, 2016 at 1:52 PM, Flaviof wrote: > On Thu, Jul 7, 2016 at 2:37 PM, Ryan Moats wrote: > > > Currently, when address set value changes, ovn controller > > doesn't remove the old entry from the tracking hash, it > > just adds the new one,

Re: [ovs-dev] [PATCH v6 1/1] ovn: Apply ACL changes to existing connections.

On Thu, Jul 7, 2016 at 12:13 PM, Justin Pettit <jpet...@ovn.org> wrote: > > > On Jun 30, 2016, at 10:14 PM, Russell Bryant <russ...@ovn.org> wrote: > > > > diff --git a/ovn/northd/ovn-northd.8.xml b/ovn/northd/ovn-northd.8.xml > > index 260cc14..d2bddcb 1

Re: [ovs-dev] [PATCH] Remove old address set after change.

On Thu, Jul 7, 2016 at 1:04 PM, Russell Bryant <russ...@ovn.org> wrote: > > > On Thu, Jul 7, 2016 at 12:18 PM, Thadeu Lima de Souza Cascardo < > casca...@redhat.com> wrote: > >> On Thu, Jul 07, 2016 at 11:24:25AM -0500, Ryan Moats wrote: >> > Curr

Re: [ovs-dev] [PATCH] Remove old address set after change.

> expr_macros_remove(_address_sets, > addr_set_rec->name); > > address_set_destroy(addr_set); > > addr_set = NULL; > > -- > > 2.7.4 (Apple Git-66) > > > > ___ > > de

Re: [ovs-dev] [PATCH v6 0/1] ovn: Apply ACL changes to existing connections.

On Sun, Jul 3, 2016 at 1:40 PM, Ben Pfaff <b...@ovn.org> wrote: > On Thu, Jun 30, 2016 at 04:14:04PM -0400, Russell Bryant wrote: > > Prior to this commit, once a connection had been committed to the > > connection tracker, the connection would continue to be allowed, e

Re: [ovs-dev] [PATCH v5] ovn: Add software l2 gateway.

On Fri, Jun 24, 2016 at 9:29 PM, Justin Pettit <jpet...@ovn.org> wrote: > > > On Jun 23, 2016, at 12:34 PM, Russell Bryant <russ...@ovn.org> wrote: > > > > This patch implements one approach to using ovn-controller to implement > > a software l2 gatewa

Re: [ovs-dev] [PATCH 4/4] ovn: Test that port state goes up and down.

On Fri, Jun 24, 2016 at 5:24 PM, Ryan Moats <rmo...@us.ibm.com> wrote: > > Acked-by: Ryan Moats <rmo...@us.ibm.com> > > Having this would have prevented today's fire drill :) > > Thanks, Ryan. I applied this patch to master. -- Russell Bryant _

Re: [ovs-dev] [PATCH v3 1/2] Add address set support.

them by name. > > > > $name > > > > This '$name' can be used in the expresssions like > > > > {addr1, addr2, $name, ... } > > {$name} > > $name > > > > A future patch will expose the ability to define address sets for use. >

[ovs-dev] [PATCH v6 1/1] ovn: Apply ACL changes to existing connections.

09c8-d179-4915-9eb2-f53426ae16dd" && ip4 && tcp && tcp.dst == 22)), action=(ct_commit(ct_label=0/1); next;) table=1( ls_out_acl), priority= 2001, match=((!ct.est || (ct.est && ct_label[0] == 1)) && (outport == "0a7409c8-d179-4915-9eb2-f53426a

[ovs-dev] [PATCH v6 0/1] ovn: Apply ACL changes to existing connections.

t it is only setting 1 bit of ct_label. - This version now has all the changes requested by Justin Pettit, so is ready for his review. v5->v6: - Applied patch 1/2 in v5 with minor updates. - Rebase final patch. [PATCH] ovn: Apply ACL changes to existing connections. --

Re: [ovs-dev] [PATCH v5 1/2] ovn: Add ct_commit(ct_mark=INT, ct_label=INT); action.

On Mon, Jun 27, 2016 at 6:43 AM, Justin Pettit <jpet...@ovn.org> wrote: > > > On Jun 17, 2016, at 10:16 PM, Russell Bryant <russ...@ovn.org> wrote: > > > > diff --git a/ovn/lib/actions.c b/ovn/lib/actions.c > > index 5f0bf19..495d502 100644 > > --- a/

Re: [ovs-dev] [PATCH v1] Add new column compute_types to OVN_Southbound

On Fri, Jun 24, 2016 at 4:37 PM, Amitabha Biswas <azbis...@gmail.com> wrote: > On Jun 24, 2016, at 6:41 AM, Russell Bryant <russ...@ovn.org> wrote: > > > On Wed, Jun 22, 2016 at 5:55 PM, Amitabha Biswas <azbis...@gmail.com> > wrote: > >> > On Jun 22

[ovs-dev] [PATCH] ovn-sbctl: Change lport-(un)bind to lsp-(un)bind.

A previous commit changed the command names in ovn-nbctl from lport-* to lsp-*. Change lport-bind and lport-unbind in ovn-sbctl to match. Signed-off-by: Russell Bryant <russ...@ovn.org> --- ovn/utilities/ovn-sbctl.c| 12 ++-- tests/ovn-controller-vtep.at | 10 +- tes

Re: [ovs-dev] [PATCH 0/4] Restore ovn-controller binding functionality.

On Fri, Jun 24, 2016 at 3:59 PM, Ben Pfaff <b...@ovn.org> wrote: > On Fri, Jun 24, 2016 at 03:52:07PM -0400, Russell Bryant wrote: > > "Convert binding_run to incremental processing" caused a regression > > in port binding handling. This was seen in OpenStack CI.

Re: [ovs-dev] [PATCH] rhel: Fix RHEL package build breakage

<aatt...@ovn.org> > Acked-by: Russell Bryant <russ...@ovn.org> -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 4/4] ovn: Test that port state goes up and down.

On Fri, Jun 24, 2016 at 3:52 PM, Russell Bryant <russ...@ovn.org> wrote: > Some previous commits broke ovn-controller binding handling such that > ovn-controller never cleared out the chassis column of the Port_Binding > table. This broke OpenStack CI for OVN. This patch adds an

[ovs-dev] [PATCH 2/4] Revert "lport: Persist lport_index and mcgroup_index structures."

This reverts commit 4470328bc4e0081479351e39a1964a78fe19be1b. Signed-off-by: Russell Bryant <russ...@ovn.org> --- ovn/controller/lport.c | 221 +++- ovn/controller/lport.h | 22 +--- ovn/controller/ovn-controller.c | 16 ++- 3 files c

[ovs-dev] [PATCH 3/4] Revert "Convert binding_run to incremental processing."

This reverts commit 263064aeaa31e758538773fac571dff0cb246cde. Signed-off-by: Russell Bryant <russ...@ovn.org> --- ovn/controller/binding.c| 205 ++-- ovn/controller/binding.h| 4 +- ovn/controller/encaps.c | 3 - ovn/controll

[ovs-dev] [PATCH 1/4] Revert "ovn-controller: Use new ovsdb-idl helpers to make logic more readable."

This reverts commit 9a33cd70f4f8bf5922ef05caf32e6da748c57f1a. Signed-off-by: Russell Bryant <russ...@ovn.org> --- ovn/controller/binding.c | 11 +++ ovn/controller/encaps.c | 19 ++- ovn/controller/lport.c | 18 -- ovsdb/ovsdb-idlc.in

[ovs-dev] [PATCH 4/4] ovn: Test that port state goes up and down.

Some previous commits broke ovn-controller binding handling such that ovn-controller never cleared out the chassis column of the Port_Binding table. This broke OpenStack CI for OVN. This patch adds an OVN test case that would have caught this issue. Signed-off-by: Russell Bryant <r

[ovs-dev] [PATCH 0/4] Restore ovn-controller binding functionality.

"lport: Persist lport_index and mcgroup_index [PATCH 3/4] Revert "Convert binding_run to incremental processing." [PATCH 4/4] ovn: Test that port state goes up and down. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [OVN] Potential scalability bug in ovn-northd on creating and binding large number of lports

membership and requiring restart of all instances of ovn-northd any time an instance of ovn-northd is added or removed to the cluster The paper linked seems to describe some more complete approaches. It seems like a very well explored area and that I should do more reading on the topic. I'd love to hear any ideas for preferred approaches from others if you have them. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v1] Add new column compute_types to OVN_Southbound

n network name. There will probably be more ... there is an unresolved issue where our OpenStack plugin needs to know whether a given Chassis is using the DPDK or Linux datapath so it can tell the compute part of OpenStack (nova) what virtual interface type to use for VMs on that host. I'v

Re: [ovs-dev] [OVN] Potential scalability bug in ovn-northd on creating and binding large number of lports

mental processing > model. > > Ben, Justin, Yusheng can one of you talk to an ETA for when the nlog > ovn-northd code base will start to land in the review queue? That will > provide input on whether doing an interim patch series is worth the effort > or not... > Incremental processing is one angle. The other we need to have on the roadmap is some type of sharding. This is important for HA purposes, as well. We need to be able to run multiple instances of ovn-northd that each only operate on a subset of the full data set. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/1] rpm: Update rhel/automake.mk to build via mock

tch are > +documented in [INSTALL.md]. > + > +However, to build the kmod packages require the following specific > packages > This sentence is a little awkward. Changing "require" to "requires" may be enough. We could also make it "building the kmod pack

[ovs-dev] [PATCH v5] ovn: Add software l2 gateway.

port also gets bound to a chassis while a localnet port does not. This binding is not done by ovn-controller. It is left as an administrative function. In the case of OpenStack, the Neutron plugin will do this. Signed-off-by: Russell Bryant <russ...@ovn.org> Acked-by: Ryan Moats &l

Re: [ovs-dev] [PATCH v2] Travis: Added python plugins flake8 and hacking.

ip install --user flake8 > +pip install --user hacking > Should these commands also include --disable-pip-version-check? I suspect we're getting warning output without it. I think you can actually just add flake8 and hacking to the end of a single pip command. Thanks for adding this!

<    1   2   3   4   5   6   7   8   9   10   >