[ovs-dev] [PATCH 40/55] ovs-vtep: Fix Python 3 compatibility.

2015-12-21 Thread Russell Bryant
Also fix style issues found by the flake8 tool and add ovs-vtep to the list of files checked in the pep8 tox environment. Signed-off-by: Russell Bryant --- python/tox.ini | 2 +- vtep/ovs-vtep | 96 +- 2 files changed, 56 insertions

[ovs-dev] [PATCH 37/55] ovs-monitor-ipsec: Fix Python 3 compatibility.

2015-12-21 Thread Russell Bryant
Signed-off-by: Russell Bryant --- debian/ovs-monitor-ipsec | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/debian/ovs-monitor-ipsec b/debian/ovs-monitor-ipsec index d35ec46..1f1562d 100755 --- a/debian/ovs-monitor-ipsec +++ b/debian/ovs-monitor-ipsec

[ovs-dev] [PATCH 38/55] ovs-monitor-ipsec: Minor style fixes.

2015-12-21 Thread Russell Bryant
Remove an unused import and use "is None" instead of "== None". Also add this script to the list of what's checked in the pep8 tox environment. Signed-off-by: Russell Bryant --- debian/ovs-monitor-ipsec | 5 ++--- python/tox.ini | 2 +- 2 files changed, 3 i

[ovs-dev] [PATCH 39/55] ovs-pcap: Fix Python 3 compatibility.

2015-12-21 Thread Russell Bryant
Also address style errors found by flake8 and add it to the list of files checked in the pep8 tox environment. Signed-off-by: Russell Bryant --- python/tox.ini| 2 +- utilities/ovs-pcap.in | 17 +++-- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/python

[ovs-dev] [PATCH 35/55] python: Fix object comparisons in Python 3.

2015-12-21 Thread Russell Bryant
n Python 2. We have to implement the comparisons explicitly for Python 3. Signed-off-by: Russell Bryant --- python/ovs/db/data.py | 23 +++ python/ovs/db/idl.py | 15 +++ 2 files changed, 38 insertions(+) diff --git a/python/ovs/db/data.py b/python/ovs/db/dat

[ovs-dev] [PATCH 36/55] python: Deal with str and byte differences.

2015-12-21 Thread Russell Bryant
Python 3 has separate types for strings and bytes. Python 2 used the same type for both. We need to convert strings to bytes before writing them out to a socket. We also need to convert data read from the socket to a string. Signed-off-by: Russell Bryant --- python/ovs/jsonrpc.py | 10

[ovs-dev] [PATCH 33/55] python: Don't compare None and int.

2015-12-21 Thread Russell Bryant
Comparing None to an integer worked in Python 2, but fails in Python 3. Signed-off-by: Russell Bryant --- python/ovs/reconnect.py | 2 +- tests/test-reconnect.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/python/ovs/reconnect.py b/python/ovs/reconnect.py index

[ovs-dev] [PATCH 34/55] tests: Deal with Python output differences.

2015-12-21 Thread Russell Bryant
checking for the expected result. Signed-off-by: Russell Bryant --- tests/test-ovsdb.py | 2 +- tests/unixctl-py.at | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/test-ovsdb.py b/tests/test-ovsdb.py index 9d18ec3..0f345c1 100644 --- a/tests/test-ovsdb.py

[ovs-dev] [PATCH 32/55] tests: Python style fixes.

2015-12-21 Thread Russell Bryant
Make flake8 run clean against these. Also use isinstance() instead of direct type comparisons. Update the tox config to run flake8 against these files, as well. Signed-off-by: Russell Bryant --- python/tox.ini| 2 +- tests/MockXenAPI.py | 3 +++ tests/test-daemon.py

[ovs-dev] [PATCH 28/55] python: Add basic testing of ovs.json.

2015-12-21 Thread Russell Bryant
. Signed-off-by: Russell Bryant --- python/automake.mk| 3 ++- python/ovs/tests/test_json.py | 58 +++ 2 files changed, 60 insertions(+), 1 deletion(-) create mode 100644 python/ovs/tests/test_json.py diff --git a/python/automake.mk b/python

[ovs-dev] [PATCH 31/55] tests: Make Python 3 compatible.

2015-12-21 Thread Russell Bryant
Apply fixes to the Python scripts in the main ovs test suite to make them work with both Python 2 and Python 3. This makes use of the 'six' module, but six is already a dependency for the ovs Python lib, which is being used here. Signed-off-by: Russell Bryant --- tests/test-json.py

[ovs-dev] [PATCH 29/55] python: Run ovsdb-doc from tox.

2015-12-21 Thread Russell Bryant
, as we don't want the nroff output sent to stdout in this case. Signed-off-by: Russell Bryant --- ovsdb/ovsdb-doc | 19 --- python/tox.ini | 1 + 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/ovsdb/ovsdb-doc b/ovsdb/ovsdb-doc index ee5fcb3..9ee48d9 1

[ovs-dev] [PATCH 30/55] python: Remove reamining direct type comarisons.

2015-12-21 Thread Russell Bryant
oid a bug I haven't hit yet and it's more Pythonic, anyway. Signed-off-by: Russell Bryant --- python/ovs/db/data.py | 6 +++--- python/ovs/db/idl.py | 28 ++-- python/ovs/db/parser.py | 6 +++--- python/ovs/db/schema.py | 2 +- python/ovs/json

[ovs-dev] [PATCH 27/55] python: Use six.unichr().

2015-12-21 Thread Russell Bryant
six.unichr() is equivalent to unichr() in Python 2 and chr() in Python 3. Signed-off-by: Russell Bryant --- python/ovs/json.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/ovs/json.py b/python/ovs/json.py index a59a0c2..db74397 100644 --- a/python/ovs/json.py +++ b

[ovs-dev] [PATCH 26/55] python: Drop use of sys.maxint.

2015-12-21 Thread Russell Bryant
make the Python 3.4 test environment pass successfully (tox -e py34). Signed-off-by: Russell Bryant --- python/ovs/db/schema.py | 6 +++--- python/ovs/db/types.py | 26 +- python/ovs/json.py | 2 +- python/ovs/vlog.py | 2 +- 4 files changed, 18 insertions(+

[ovs-dev] [PATCH 25/55] python: Don't use StringIO directly.

2015-12-21 Thread Russell Bryant
StringIO.StringIO in Python 2 became io.StringIO in Python 3. Use six.StringIO which is an alias for the two cases. Signed-off-by: Russell Bryant --- python/ovs/json.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/python/ovs/json.py b/python/ovs/json.py index c1dcd63

[ovs-dev] [PATCH 24/55] check-structs: Make Python 3 compatible.

2015-12-21 Thread Russell Bryant
Signed-off-by: Russell Bryant --- build-aux/check-structs | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/build-aux/check-structs b/build-aux/check-structs index f79f235..449fd41 100755 --- a/build-aux/check-structs +++ b/build-aux/check-structs @@ -1,5 +1,7 @@ #! /usr

[ovs-dev] [PATCH 18/55] python: Drop unicode type.

2015-12-21 Thread Russell Bryant
Python 2 had str and unicode. Python 3 only has str, which is always a unicode string. Drop use of unicode with the help of six.text_type (unicode in py2 and str in py3) and six.string_types ([str, unicode] in py2 and [str] in py3). Signed-off-by: Russell Bryant --- python/ovs/db/data.py

[ovs-dev] [PATCH 21/55] xml2nroff: Make compatible with Python 3.

2015-12-21 Thread Russell Bryant
t for Python 2, as items() returns a list instead of an iterator in Python 2. We're dealing with a very small set of items here so it really doesn't matter. Signed-off-by: Russell Bryant --- build-aux/xml2nroff | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --

[ovs-dev] [PATCH 22/55] ovsdb-doc: Make compatible with Python 3.

2015-12-21 Thread Russell Bryant
Signed-off-by: Russell Bryant --- ovsdb/ovsdb-doc | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/ovsdb/ovsdb-doc b/ovsdb/ovsdb-doc index 5cf26ee..ee5fcb3 100755 --- a/ovsdb/ovsdb-doc +++ b/ovsdb/ovsdb-doc @@ -14,6 +14,8 @@ # See the License for the sp

[ovs-dev] [PATCH 23/55] extract-ofp: Python 3 compatibility.

2015-12-21 Thread Russell Bryant
Fix build-aux/extract-ofp-* scripts to be compatible with both Python 2 and Python 3. The fixes do not require any new dependencies. Signed-off-by: Russell Bryant --- build-aux/extract-ofp-actions | 72 ++- build-aux/extract-ofp-errors | 38

[ovs-dev] [PATCH 19/55] python: Drop use of types.StringTypes.

2015-12-21 Thread Russell Bryant
types.StringTypes does not exist in Python 3. We can use six.string_types, instead. Signed-off-by: Russell Bryant --- python/ovs/unixctl/__init__.py | 4 +++- python/ovs/unixctl/client.py | 5 +++-- python/ovs/unixctl/server.py | 3 +-- 3 files changed, 7 insertions(+), 5 deletions

[ovs-dev] [PATCH 20/55] python: Drop use of types.FunctionType.

2015-12-21 Thread Russell Bryant
This code asserted that the callback argument was of type types.FunctionType. It's more pythonic to just check that the argument is callable, and not specifically that it's a function. There are other ways to implement a callback than types.FunctionType. Signed-off-by: Russ

[ovs-dev] [PATCH 17/55] python: Drop usage of long type.

2015-12-21 Thread Russell Bryant
similar checks nearby while I was at it. Signed-off-by: Russell Bryant --- python/ovs/db/data.py | 20 python/ovs/db/idl.py| 4 ++-- python/ovs/db/parser.py | 15 ++- python/ovs/db/types.py | 20 +--- python/ovs/json.py | 21

[ovs-dev] [PATCH 14/55] python: Stop use of tuple parameter unpacking

2015-12-21 Thread Russell Bryant
never used so the fix is even simpler. Signed-off-by: Russell Bryant --- python/ovstest/udp.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python/ovstest/udp.py b/python/ovstest/udp.py index d6e6162..acd28d5 100644 --- a/python/ovstest/udp.py +++ b/python/ovstest/udp.py

[ovs-dev] [PATCH 16/55] python: Convert dict iterators.

2015-12-21 Thread Russell Bryant
the case where we want an iterator, we now use the six.iter*() helpers. If we want a list, we explicitly create a list from the iterator. Signed-off-by: Russell Bryant --- python/ovs/db/data.py | 18 ++ python/ovs/db/idl.py| 34 ++ python/ovs

[ovs-dev] [PATCH 15/55] python: Stop using xrange().

2015-12-21 Thread Russell Bryant
ing xrange() from Python 2 or range() from Python 3. Signed-off-by: Russell Bryant --- python/ovs/json.py | 2 ++ python/ovs/ovsuuid.py| 2 ++ python/ovs/socket_util.py| 4 +++- python/ovs/unixctl/server.py | 2 ++ python/ovs/vlog.py | 2 ++ python/ovstest/util.py

[ovs-dev] [PATCH 11/55] python: Fix print function compatibility.

2015-12-21 Thread Russell Bryant
The print statement from Python 2 is a function in Python 3. Enable print function support for Python 2 and convert print statements to function calls. Signed-off-by: Russell Bryant --- python/ovstest/rpcserver.py | 4 +++- python/ovstest/tests.py | 36

[ovs-dev] [PATCH 13/55] python: Fix xmlrpclib imports.

2015-12-21 Thread Russell Bryant
issue, but the six library provides helpers for Python 2 and 3 compatibility for many different issues. This is just the first of many uses of the six library. Signed-off-by: Russell Bryant --- INSTALL.md | 2 +- m4/openvswitch.m4 | 6 ++ python/ovstest/rpcserver.py

[ovs-dev] [PATCH 12/55] python: Add missing Apache License headers.

2015-12-21 Thread Russell Bryant
Signed-off-by: Russell Bryant --- python/ovs/dirs.py | 12 python/ovstest/tests.py | 12 2 files changed, 24 insertions(+) diff --git a/python/ovs/dirs.py b/python/ovs/dirs.py index 10571db..dae9288 100644 --- a/python/ovs/dirs.py +++ b/python/ovs/dirs.py @@ -1,3

[ovs-dev] [PATCH 09/55] python: Fix several pep8 whitespace errors.

2015-12-21 Thread Russell Bryant
ameter equals E261 at least two spaces before inline comment E262 inline comment should start with '# ' E265 block comment should start with '# ' E271 multiple spaces after keyword Signed-off-by: Russell Bryant --- python/ovs/daemon.py | 2 -- python/ovs/db/

[ovs-dev] [PATCH 10/55] python: Inherit from object.

2015-12-21 Thread Russell Bryant
class Vlog now inherits from "object". This is a "new style" Python class, which isn't new at all at this point. This was introduced back in Python 2.x, and some Python 2 code won't work as expected without it. In Python 3, this happens implicitly. Signed-off-by: R

[ovs-dev] [PATCH 07/55] python: Resolve pep8 comparison errors.

2015-12-21 Thread Russell Bryant
e the import to make this more clear and eliminate the error. Signed-off-by: Russell Bryant --- python/ovs/db/idl.py| 2 +- python/ovs/db/parser.py | 2 +- python/ovs/db/schema.py | 10 ++ python/ovs/json.py | 2 +- python/ovs/jsonrpc.py | 2 +- python/tox.ini | 2

[ovs-dev] [PATCH 08/55] python: Restrict line length to 79 chars.

2015-12-21 Thread Russell Bryant
Resolve pep8 error: E501 line too long (80 > 79 characters) Signed-off-by: Russell Bryant --- python/ovs/db/idl.py | 6 -- python/ovs/dirs.py| 10 +- python/ovs/socket_util.py | 12 python/tox.ini| 2 +- 4 files changed, 18 inserti

[ovs-dev] [PATCH 04/55] python: Fix invalid variable reference.

2015-12-21 Thread Russell Bryant
This code referred to "rows" where it meant to refer to "fetched_rows". Signed-off-by: Russell Bryant --- python/ovs/db/idl.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/ovs/db/idl.py b/python/ovs/db/idl.py index 5e3466e..8d50f65 100644 --- a/

[ovs-dev] [PATCH 06/55] python: Resolve pep8 blank line errors.

2015-12-21 Thread Russell Bryant
Resolve pep8 errors E302 and E303: E302 expected 2 blank lines, found 1 E303 too many blank lines (3) Signed-off-by: Russell Bryant --- python/ovs/poller.py | 1 + python/ovs/timeval.py | 3 +++ python/ovs/unixctl/__init__.py | 1 + python/ovs/unixctl/server.py | 1

[ovs-dev] [PATCH 03/55] python: Remove unused imports and variables.

2015-12-21 Thread Russell Bryant
Signed-off-by: Russell Bryant --- python/ovs/socket_util.py| 5 ++--- python/ovs/unixctl/client.py | 2 -- python/ovstest/vswitch.py| 3 --- 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/python/ovs/socket_util.py b/python/ovs/socket_util.py index 3bd4750..a01c3aa 100644

[ovs-dev] [PATCH 05/55] python: Add pep8 test environment.

2015-12-21 Thread Russell Bryant
PEP8 is the Python formatting standard. This test environment catches cases where the code deviates from this standard. We exclude all of the rules currently violated so we can start with a passing configuration. They can be removed over time when they get cleaned up. Signed-off-by: Russell

[ovs-dev] [PATCH 01/55] python: Set up initial tox test environment.

2015-12-21 Thread Russell Bryant
quickly reproduces the problem that the library fails to install for Python 3. Future patches will start addressing Python 3 compatibility. Signed-off-by: Russell Bryant --- python/.gitignore| 3 +++ python/automake.mk | 10 +- python/ovs/tests/__init__.py | 1

[ovs-dev] [PATCH 00/55] Python 3 support.

2015-12-21 Thread Russell Bryant
branch using the OpenStack integration for OVN, which uses the ovs Python library. Russell Bryant (54): python: Set up initial tox test environment. python: Remove unused imports and variables. python: Fix invalid variable reference. python: Add pep8 test environment. python:

[ovs-dev] [PATCH 02/55] python: Start fixing some Python 3 issues.

2015-12-21 Thread Russell Bryant
From: Terry Wilson This patch fixes just the Python 3 problems found by running: python3 setup.py install There are still many other issues to be fixed, but this is a start. Signed-off-by: Terry Wilson Signed-off-by: Russell Bryant --- python/ovs/daemon.py | 31

[ovs-dev] [PATCH] tests: Add ovn keyword to all ovn tests.

2015-12-21 Thread Russell Bryant
Autotest keywords are helpful for running a subset of the test suite. This patch makes it so you can run all OVN tests using the 'ovn' keyword. $ make check TESTSUITEFLAGS="-k ovn" Signed-off-by: Russell Bryant --- tests/ovn-controller-vtep.at | 1 + tests/ovn-controller.

Re: [ovs-dev] [PATCH] Do not add ARP replies in the lswitch pipeline to all the lports

2015-12-21 Thread Russell Bryant
On 12/21/2015 02:52 PM, Ben Pfaff wrote: > On Mon, Dec 21, 2015 at 10:39:29AM -0500, Russell Bryant wrote: >> On 12/21/2015 09:55 AM, Numan Siddique wrote: >>> On 12/21/2015 08:13 PM, Russell Bryant wrote: >>>> On 12/21/2015 09:27 AM, Numan Siddique wrote: >>>

Re: [ovs-dev] [PATCH] Remove broken pip warning logs from ovsdb-server.log for ovn tests

2015-12-21 Thread Russell Bryant
On 12/21/2015 02:01 AM, Numan Siddique wrote: > Taken the fix from the commit d3292dd... (in ovn-controller-vtep.at) > > Signed-off-by: Numan Siddique Thanks for the patch! I fixed the typo in the commit message (s/pip/pipe/) and pushed this to master. -- Russe

Re: [ovs-dev] [PATCH] Do not add ARP replies in the lswitch pipeline to all the lports

2015-12-21 Thread Russell Bryant
On 12/21/2015 09:55 AM, Numan Siddique wrote: > On 12/21/2015 08:13 PM, Russell Bryant wrote: >> On 12/21/2015 09:27 AM, Numan Siddique wrote: >> What problem are you addressing here? It seems we would want the flows >> created, even when the port is not up yet. Otherwise,

Re: [ovs-dev] [PATCH] Do not add ARP replies in the lswitch pipeline to all the lports

2015-12-21 Thread Russell Bryant
ms we would want the flows created, even when the port is not up yet. Otherwise, when the port does come up, ovn-controller has an incomplete logical flow table. I think the logical flow table should be independent of port state and location. Thanks, -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] Add Passive TCP connection to IDL

2015-12-20 Thread Russell Bryant
like IPv6 is tested in tests/ovsdb-idl.at. Take a look and see what you think. > I will submit the new code with the modifications again. Thanks! The convention is to submit the next one with a subject of "[PATCH v2] ...". You can do that with git send-e

Re: [ovs-dev] [PATCH] stream-ssl: Fix misleading bound address format.

2015-12-19 Thread Russell Bryant
IPv6 support for > OpenFlow, OVSDB, NetFlow, and sFlow.). > > Reported-by: meishengxin > Reported-at: > http://openvswitch.org/pipermail/discuss/2015-December/019694.html > Signed-off-by: Ben Pfaff Acked-by: Russell Bryant You could also add a Fixes header: Fixes: e731

Re: [ovs-dev] [RFC 00/55] Add Python 3 support.

2015-12-19 Thread Russell Bryant
On 12/19/2015 07:37 AM, Russell Bryant wrote: > On 12/18/2015 06:16 PM, Justin Pettit wrote: >> >>> On Dec 18, 2015, at 12:12 PM, Russell Bryant wrote: >>> >>> I'm only submitting the cover letter for this RFC. The current state of >>>

Re: [ovs-dev] [RFC 00/55] Add Python 3 support.

2015-12-19 Thread Russell Bryant
On 12/18/2015 06:16 PM, Justin Pettit wrote: > >> On Dec 18, 2015, at 12:12 PM, Russell Bryant wrote: >> >> I'm only submitting the cover letter for this RFC. The current state of >> the patches can be seen on github. >> >> https://github.com/open

[ovs-dev] [RFC 00/55] Add Python 3 support.

2015-12-18 Thread Russell Bryant
nstalled) and passes. If anyone has their own Python code they'd like to try against this branch, I'd love to hear your test feedback. Thanks! Russell Bryant (54): python: Set up initial tox test environment. python: Remove unused imports and variables. python: Fix invalid var

Re: [ovs-dev] [PATCH] Add Passive TCP connection to IDL

2015-12-17 Thread Russell Bryant
tream(object): > try: > sock, addr = self.socket.accept() > ovs.socket_util.set_nonblocking(sock) > -return 0, Stream(sock, "unix:%s" % addr, 0) > +if (sock.family == socket.AF_UNIX): > +

Re: [ovs-dev] [PATCH 1/5] ovn-ctl: Add daemon status functions.

2015-12-16 Thread Russell Bryant
, but in case you disagree, I don't feel strongly, so have an ack if > you want: > Acked-by: Ben Pfaff It seems reasonable that you might want to check the status of only ovn-controller on a hypervisor, for example. We could have a third "status" arg that checks all though. Acked-by: Russell Bryant -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/5] debian: Add a package for OVN common components.

2015-12-16 Thread Russell Bryant
e that does not have an > openvswitch switch running; it might even be preferred in a large > deployment. What do you think? ovn-ctl assumes ovsdb-server is running locally for ovn-northd right now. Is ovsdb-server in the -switch package? -- Russell Bryant __

Re: [ovs-dev] [PATCH] ovn: Use constants for conntrack state bits.

2015-12-15 Thread Russell Bryant
On 12/15/2015 02:36 PM, Joe Stringer wrote: > On 14 December 2015 at 09:54, Russell Bryant wrote: >> A previous commit fixed this code to match changes to the conntrack >> state bit assignments. This patch further updates the code to use >> the defined constants to en

Re: [ovs-dev] [PATCH 4/5] debian: Add a package for OVN central components.

2015-12-15 Thread Russell Bryant
ovn package that includes ovn-controller and ovn-northd. It all seemed small enough that one package seemed fine, but I'd be OK splitting them, too, if there's good reason. The other big difference is the service name. Here you're using "ovn-central" where the systemd unit

Re: [ovs-dev] [PATCH 1/5] ovn-ctl: Add daemon status functions.

2015-12-15 Thread Russell Bryant
) > +daemon_status ovn-controller || exit 1 > +;; > help) > usage > ;; > Acked-by: Russell Bryant -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ovn: Use constants for conntrack state bits.

2015-12-14 Thread Russell Bryant
On 12/14/2015 12:54 PM, Russell Bryant wrote: > A previous commit fixed this code to match changes to the conntrack > state bit assignments. This patch further updates the code to use > the defined constants to ensure this code adapts automatically to any > possible future changes.

[ovs-dev] [PATCH] ovn: Use constants for conntrack state bits.

2015-12-14 Thread Russell Bryant
A previous commit fixed this code to match changes to the conntrack state bit assignments. This patch further updates the code to use the defined constants to ensure this code adapts automatically to any possible future changes. Signed-off-by: Russell Bryant Requested-by: Joe Stringer --- lib

Re: [ovs-dev] [PATCH] ovn: Use constants for conntrack state bits.

2015-12-14 Thread Russell Bryant
On 12/11/2015 04:29 PM, Joe Stringer wrote: > On 10 December 2015 at 09:12, Russell Bryant wrote: >> A previous commit fixed this code to match changes to the conntrack >> state bit assignments. This patch further updates the code to use >> the defined constants to en

Re: [ovs-dev] missing Hyper-V and OVN meetings this week

2015-12-14 Thread Russell Bryant
e Hyper-V meeting next week, after I'm back. > (The OVN meeting that week is on Christmas Eve; we might want to cancel > it.) Yes, let's cancel the one next week. The week after is New Year's Eve, so I suggest we postpone OVN meeting

Re: [ovs-dev] [ovs] ovn-nbctl:add db commands help (#93)

2015-12-11 Thread Russell Bryant
On 12/11/2015 11:02 AM, Russell Bryant wrote: > On 12/10/2015 09:13 PM, Justin Pettit wrote: >> >>> On Dec 10, 2015, at 9:49 AM, Russell Bryant wrote: >>> >>> It looks like xml.dom.minidom doesn't support it. We'd have to manually >>> implem

Re: [ovs-dev] [PATCH 5/5] xml2nroff: Read whole file instead of line by line.

2015-12-11 Thread Russell Bryant
On 12/10/2015 09:22 PM, Justin Pettit wrote: > >> On Dec 10, 2015, at 11:29 AM, Russell Bryant wrote: >> >> The previous code processed the input file line by line, but I think >> it looks a little more straight forward to just process the whole file >> at once.

Re: [ovs-dev] [PATCH] ovn: Fix ACLs for child logical ports.

2015-12-11 Thread Russell Bryant
> Acked-by: Justin Pettit > > I'd suggest cherry-picking this to "branch-2.5", too. Thanks for the review. I added your suggested comment, your ACK, and then pushed this to master and branch-2.5. -- Russell Bryant ___ dev mailin

Re: [ovs-dev] [PATCH] ovn-controller: Add clarifying comment about main loop in binding_run().

2015-12-11 Thread Russell Bryant
sb_idl) { > if (sset_find_and_delete(&lports, binding_rec->logical_port) || > (binding_rec->parent_port && binding_rec->parent_port[0] && > Acked-by: Russell Bryant -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [ovs] ovn-nbctl:add db commands help (#93)

2015-12-11 Thread Russell Bryant
On 12/10/2015 09:13 PM, Justin Pettit wrote: > >> On Dec 10, 2015, at 9:49 AM, Russell Bryant wrote: >> >> It looks like xml.dom.minidom doesn't support it. We'd have to manually >> implement the interpretation of xi:include. That might be OK for our >

[ovs-dev] [PATCH 3/5] xml2nroff: Fix issues pointed out by flake8.

2015-12-10 Thread Russell Bryant
This patch includes a few minor fixes pointed out by the flake8 tool. It drops an unused variable and the related imports, adds some blank lines where the PEP8 formatting standard indicates they should be, and does a comparison with None as "is None" instead of "== None". Si

[ovs-dev] [PATCH 2/5] xml2nroff: Don't use import *.

2015-12-10 Thread Russell Bryant
It's generally considered bad style to do a wildcard import. It makes it more difficult to figure out where things come from. Signed-off-by: Russell Bryant --- build-aux/xml2nroff | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/build-aux/xml2nroff b/buil

[ovs-dev] [PATCH 4/5] xml2nroff: Don't use built-in function name.

2015-12-10 Thread Russell Bryant
Don't use "input" as a variable name, as input is a built-in Python function. Signed-off-by: Russell Bryant --- build-aux/xml2nroff | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/build-aux/xml2nroff b/build-aux/xml2nroff index 314a5e1..d55a0d3 100755

[ovs-dev] [PATCH 5/5] xml2nroff: Read whole file instead of line by line.

2015-12-10 Thread Russell Bryant
The previous code processed the input file line by line, but I think it looks a little more straight forward to just process the whole file at once. This patch also explicitly closes the file after reading its contents. Signed-off-by: Russell Bryant --- build-aux/xml2nroff | 12 +--- 1

[ovs-dev] [PATCH 1/5] xml2nroff: Drop duplicated usage().

2015-12-10 Thread Russell Bryant
The usage() function was included twice. Drop the one that was out of date. Signed-off-by: Russell Bryant --- build-aux/xml2nroff | 12 1 file changed, 12 deletions(-) diff --git a/build-aux/xml2nroff b/build-aux/xml2nroff index 1f8519a..127d4cc 100755 --- a/build-aux/xml2nroff

[ovs-dev] [PATCH 0/5] xml2nroff minor cleanups.

2015-12-10 Thread Russell Bryant
Don't use built-in function name. [PATCH 5/5] xml2nroff: Read whole file instead of line by line. xml2nroff | 43 ++- 1 file changed, 14 insertions(+), 29 deletions(-) -- Russell Bryant ___ dev m

Re: [ovs-dev] [ovs] ovn-nbctl:add db commands help (#93)

2015-12-10 Thread Russell Bryant
On 12/09/2015 10:43 PM, Wei Li wrote: > 在 2015/12/8 22:57, Russell Bryant 写道: >> On 12/08/2015 01:06 AM, Wei Li wrote: >>> >>> 在 2015/12/7 23:30, Russell Bryant 写道: >>>> Can you update the man page, as well? >>>> >>> I would like to do

[ovs-dev] [PATCH] ovn: Use constants for conntrack state bits.

2015-12-10 Thread Russell Bryant
A previous commit fixed this code to match changes to the conntrack state bit assignments. This patch further updates the code to use the defined constants to ensure this code adapts automatically to any possible future changes. Signed-off-by: Russell Bryant Requested-by: Joe Stringer --- lib

Re: [ovs-dev] [PATCH] CONTRIBUTING: Document the Fixes header.

2015-12-09 Thread Russell Bryant
On 12/09/2015 02:35 PM, Joe Stringer wrote: > On 9 December 2015 at 11:05, Russell Bryant wrote: >> Document the use of the Fixes header to refer to a commit that >> introduced a bug being fixed. >> >> Signed-off-by: Russell Bryant >> --- >> CONTRIBUTIN

[ovs-dev] [PATCH] CONTRIBUTING: Document the Fixes header.

2015-12-09 Thread Russell Bryant
Document the use of the Fixes header to refer to a commit that introduced a bug being fixed. Signed-off-by: Russell Bryant --- CONTRIBUTING.md | 8 1 file changed, 8 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 97ab9cb..247c1d9 100644 --- a/CONTRIBUTING.md +++ b

Re: [ovs-dev] [PATCH] ovn: Fix ct_state bit mappings in OVN symtab.

2015-12-09 Thread Russell Bryant
On 12/08/2015 06:20 PM, Joe Stringer wrote: > On 8 December 2015 at 14:34, Russell Bryant wrote: >> The OVN symbol table contained outdated mappings between connection >> states and the corresponding bit in the ct_state field. This patch >> updates the symbol table with

[ovs-dev] [PATCH] ovn: Fix ct_state bit mappings in OVN symtab.

2015-12-08 Thread Russell Bryant
The OVN symbol table contained outdated mappings between connection states and the corresponding bit in the ct_state field. This patch updates the symbol table with the proper values as defined in lib/packets.h. Signed-off-by: Russell Bryant --- ovn/controller/lflow.c | 8 1 file

Re: [ovs-dev] [ovs] ovn-nbctl:add db commands help (#93)

2015-12-08 Thread Russell Bryant
On 12/08/2015 01:06 AM, Wei Li wrote: > > > 在 2015/12/7 23:30, Russell Bryant 写道: >> >> Can you update the man page, as well? >> > I would like to do this,but have a question > > There is a reference to /db-ctl-base.man/ in /ovn-sbctl.8.in/ implement >

Re: [ovs-dev] ovn-nbctl:What are router commands like?

2015-12-08 Thread Russell Bryant
On 12/07/2015 06:46 PM, Ben Pfaff wrote: > On Mon, Dec 07, 2015 at 01:13:27PM -0500, Russell Bryant wrote: >> I'm looking at this again and I think it's worth keeping because the >> output is a bit friendlier. >> >> How about supporting both &q

Re: [ovs-dev] ovn-nbctl:What are router commands like?

2015-12-07 Thread Russell Bryant
? I'm looking at this again and I think it's worth keeping because the output is a bit friendlier. How about supporting both "show LSWITCH" and "show LROUTER". The implementation would just have to search both tables for a match on name or UUID. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] ovn-nbctl:What are router commands like?

2015-12-03 Thread Russell Bryant
gt; addresses='"00:00:00:00:ff:01"' > lrp_uuid=`ovn-nbctl \ > -- --id=@lrp create Logical_Router_port name=lrp1 \ > network=11.0.0.1/24 mac='"00:00:00:00:ff:02"' \ > -- add Logical_Router lr0 ports @lrp \ > -- lport-add sw1 lrp1-attachment` > ovn-nbctl set Logical_port lrp1-attachment type=router \ > options:router-port=$lrp_uuid \ > addresses='"00:00:00:00:ff:02"' -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] python/ovs: Add passive TCP connection to IDL

2015-12-02 Thread Russell Bryant
other mail clients here: https://www.kernel.org/doc/Documentation/email-clients.txt -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2] NEWS: Add OVN.

2015-12-02 Thread Russell Bryant
On 12/02/2015 11:39 AM, Ben Pfaff wrote: > On Wed, Dec 02, 2015 at 11:37:11AM -0500, Russell Bryant wrote: >> Add OVN to NEWS as a post-2.4.0 feature. >> >> Signed-off-by: Russell Bryant > > I like "experimental" because I think we might still be making >

[ovs-dev] [PATCH v2] NEWS: Add OVN.

2015-12-02 Thread Russell Bryant
Add OVN to NEWS as a post-2.4.0 feature. Signed-off-by: Russell Bryant --- NEWS | 4 1 file changed, 4 insertions(+) v1->v2: - s/initial/experimental/ diff --git a/NEWS b/NEWS index cae265f..dd0295c 100644 --- a/NEWS +++ b/NEWS @@ -31,6 +31,10 @@ Post-v2.4.0 - Add support

Re: [ovs-dev] [PATCH] NEWS: Add OVN.

2015-12-02 Thread Russell Bryant
On 12/02/2015 11:21 AM, Justin Pettit wrote: > I think I would go with experimental, since I don't think it should be used > in production yet. I'm hopeful that the release after 2.5 will be one that > people can start using. OK, agreed. I'll do a v2 using "exper

[ovs-dev] [PATCH] NEWS: Add OVN.

2015-12-02 Thread Russell Bryant
Add OVN to NEWS as a post-2.4.0 feature. Signed-off-by: Russell Bryant --- NEWS | 4 1 file changed, 4 insertions(+) I considered s/initial/experimental/ in this NEWS entry, but I'm curious what others think is appropriate. Mainly I was thinking we might want to mark it as experim

Re: [ovs-dev] python/ovs: Add passive TCP connection to IDL

2015-12-01 Thread Russell Bryant
quot; , > Sukhdev Kapur mailto:sukh...@arista.com>>,"Migliaccio, > Armando" It looks like you intended to post a patch here, but the patch content is missing. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH repost] physical: Improve treatment of localnet non-VLAN logical ports.

2015-11-30 Thread Russell Bryant
t least drop any VLAN tagged packets at the beginning of the logical flow table. So, it looked like if any unexpectedly tagged packets hit an untagged localnet port's input flow, it would just get dropped as soon as it got to the logical flows. Handling it mor

Re: [ovs-dev] [PATCH] AUTHORS: Update email address.

2015-11-30 Thread Russell Bryant
On 11/30/2015 02:37 PM, Justin Pettit wrote: > Acked-by: Justin Pettit Thanks, I pushed this to master. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] AUTHORS: Update email address.

2015-11-30 Thread Russell Bryant
Update AUTHORS to use the email address I'm now using as the primary address for ovs work. Signed-off-by: Russell Bryant --- AUTHORS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AUTHORS b/AUTHORS index 483410e..1c51aeb 100644 --- a/AUTHORS +++ b/AUTHORS @@ -166,7 +

Re: [ovs-dev] [PATCH] datapath-windows: fix MIN() macro

2015-11-25 Thread Russell Bryant
N(_a, _b) ((_a) > (_b) ? (_b) : (_a)) > #define ARRAY_SIZE(_x) ((sizeof(_x))/sizeof (_x)[0]) > #define OVS_SWITCH_PORT_ID_INVALID (NDIS_SWITCH_PORT_ID)(-1) > > Acked-by: Russell Bryant I think the commit message could be a bit better though. It doesn't say anything

Re: [ovs-dev] [PATCH] ovn: Update BFD item in the ovn TODO list.

2015-11-23 Thread Russell Bryant
On 11/23/2015 12:38 PM, Ben Pfaff wrote: > On Mon, Nov 23, 2015 at 11:25:01AM -0500, Russell Bryant wrote: >> Update the BFD todo item to clarify where we might use BFD as it >> previously seemed to imply we wanted to enable it for all >> hypervisor-to-hypervisor tunnels

Re: [ovs-dev] [PATCH] ovn: Update BFD item in the ovn TODO list.

2015-11-23 Thread Russell Bryant
On 11/23/2015 02:42 PM, Justin Pettit wrote: > >> On Nov 23, 2015, at 11:36 AM, Kyle Mestery wrote: >> >>> On Mon, Nov 23, 2015 at 12:52 PM, Russell Bryant wrote: >>> >>> >>> Ah ha! That's the change I was looking for but couldn't sp

Re: [ovs-dev] [PATCH] ovn: Update BFD item in the ovn TODO list.

2015-11-23 Thread Russell Bryant
On Mon, Nov 23, 2015 at 1:46 PM, Justin Pettit wrote: > > > On Nov 23, 2015, at 10:27 AM, Russell Bryant wrote: > > > > On 11/23/2015 11:36 AM, Kyle Mestery wrote: > >> On Mon, Nov 23, 2015 at 10:25 AM, Russell Bryant >> <mailto:russ...@ovn.org>> wr

Re: [ovs-dev] [PATCH] ovn-northd.8: Correct syntax for OVN strings.

2015-11-23 Thread Russell Bryant
t = P; > -inport = \"\"; /* Allow sending out inport. */ > +inport = ""; /* Allow sending out inport. */ > output; > > > Acked-by: Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [RFC] Extremely crude conntrack resubmit test case

2015-11-23 Thread Russell Bryant
On 11/23/2015 01:27 PM, Ben Pfaff wrote: > On Thu, Nov 05, 2015 at 09:06:32PM -0500, Russell Bryant wrote: >> This patch includes a really crude test case demonstrating the problem >> I'm seeing with resubmitting to a table that does ct() multiple times. >> It only

Re: [ovs-dev] [PATCH] ovn: Update BFD item in the ovn TODO list.

2015-11-23 Thread Russell Bryant
On 11/23/2015 11:36 AM, Kyle Mestery wrote: > On Mon, Nov 23, 2015 at 10:25 AM, Russell Bryant <mailto:russ...@ovn.org>> wrote: > > Update the BFD todo item to clarify where we might use BFD as it > previously seemed to imply we wanted to enable it for all >

[ovs-dev] [PATCH] ovn: Update BFD item in the ovn TODO list.

2015-11-23 Thread Russell Bryant
Update the BFD todo item to clarify where we might use BFD as it previously seemed to imply we wanted to enable it for all hypervisor-to-hypervisor tunnels. Signed-off-by: Russell Bryant --- This patch attemptes to update the TODO item based on our ML discussion. Alternatively, we could just

Re: [ovs-dev] [PATCH] ovn: Enabled BFD for tunnel monitoring in ovn-controller

2015-11-23 Thread Russell Bryant
On 11/23/2015 11:11 AM, Ben Pfaff wrote: > On Mon, Nov 23, 2015 at 10:56:34AM -0500, Russell Bryant wrote: >> On 11/23/2015 10:49 AM, Ben Pfaff wrote: >>> I think we'll need more rationale than that. BFD is expensive without a >>> good reason. >> &g

<    4   5   6   7   8   9   10   11   12   13   >