Re: [ovs-dev] [PATCH v2 2/6] vlog: Simplify module definition.

; > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Russell Bryant <russ...@ovn.org> A couple of things confused me here so I had to bug you on IRC. :-) Some comments might be helpful: > @@ -181,12 +174,23 @@ void vlog_rate_limit(const struct vlog_module *, enum > vlog_le

Re: [ovs-dev] [PATCH v2 3/6] vlog: Stop using explicit references to external log modules.

k" that runs any of > the utilities, since they make these calls as one of their first tasks > during initialization. > > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Russell Bryant <russ...@ovn.org> -- Russell Bryant

Re: [ovs-dev] [PATCH v2 1/6] vlog: Make 'vlog_modules' private to vlog.c.

t; I noticed this as well when reading through this API earlier and was wondering.. Acked-by: Russell Bryant <russ...@ovn.org> -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v4 3/3] ovn-controller: Allocate ct zones for localnet ports.

On 02/02/2016 05:19 PM, Ben Pfaff wrote: > On Mon, Jan 25, 2016 at 05:02:03PM -0500, Russell Bryant wrote: >> Previously, all ct() actions applied to localnet ports used the default >> conntrack zone. We should allocate a ct zone ID for all localnet ports >> just like we do

Re: [ovs-dev] [RFC] ovn-controller: Only process lflows for local datapaths.

y sufficient, right? I assume so if ovsdb-server is not multi-threaded (I didn't think so..). Our current tools don't make separating these databases easy. ovn-ctl doesn't support it, and the OVN packaging makes use of ovn-ctl. This area could use some enhancement to give more flexibility.

Re: [ovs-dev] [RFC] ovn-controller: Only process lflows for local datapaths.

On 02/02/2016 05:36 PM, Ben Pfaff wrote: > Acked-by: Ben Pfaff <b...@ovn.org> Thanks, I pushed this to master with some updated comments with your suggestion of a better algorithm. -- Russell Bryant ___ dev mailing list dev@openvswitch

Re: [ovs-dev] [RFC] ovn-controller: Only process lflows for local datapaths.

On 02/03/2016 10:36 AM, Russell Bryant wrote: > On 02/02/2016 05:36 PM, Ben Pfaff wrote: >> Acked-by: Ben Pfaff <b...@ovn.org> > > Thanks, I pushed this to master with some updated comments with your > suggestion of a better algorithm. > Sigh, I meant to ad

Re: [ovs-dev] [PATCH] ovn: Connect to remote lports through localnet port.

ng you should go try to fix these things, because I don't know that you can. I'm just trying to think through the impact of these changes on the semantics of an OVN logical switch. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v4 3/3] ovn-controller: Allocate ct zones for localnet ports.

On 02/03/2016 01:59 PM, Justin Pettit wrote: > >> On Feb 3, 2016, at 7:14 AM, Russell Bryant <russ...@ovn.org> wrote: >> >> I started backporting this to branch-2.5. There's some conflicts and >> then the test case seems to lock up my laptop. At that point I w

Re: [ovs-dev] OVN: proposal of introducing nlog engine to ovn-northd

On 02/01/2016 02:12 PM, Ben Pfaff wrote: > On Mon, Feb 01, 2016 at 10:12:49AM -0500, Russell Bryant wrote: Thanks a lot for the background and references. >> In general, I definitely agree that this problem is something we need to >> work on. I've been wanting to look in

Re: [ovs-dev] [PATCH 11/11] python: Deal with str and byte differences.

On 02/02/2016 04:34 PM, Russell Bryant wrote: > On 02/02/2016 04:24 PM, Ben Pfaff wrote: >> On Fri, Jan 22, 2016 at 09:32:33PM -0500, Russell Bryant wrote: >>> Python 3 has separate types for strings and bytes. Python 2 used the >>> same type for both. We need to conv

Re: [ovs-dev] [PATCH 11/11] python: Deal with str and byte differences.

On 02/02/2016 04:24 PM, Ben Pfaff wrote: > On Fri, Jan 22, 2016 at 09:32:33PM -0500, Russell Bryant wrote: >> Python 3 has separate types for strings and bytes. Python 2 used the >> same type for both. We need to convert strings to bytes before writing >> them out to a

Re: [ovs-dev] [PATCH] flake8: Fix use of --select and --ignore.

On 02/02/2016 04:30 PM, Ben Pfaff wrote: > On Fri, Jan 22, 2016 at 02:53:13PM -0500, Russell Bryant wrote: >> The flake8 command evolved over a series of patches and now includes the >> use of both --select and --ignore. Unfortunately, this wasn't doing >> what I thought.

Re: [ovs-dev] [PATCH 10/11] python: Fix object comparisons in Python 3.

On 02/02/2016 04:22 PM, Ben Pfaff wrote: > On Fri, Jan 22, 2016 at 09:32:32PM -0500, Russell Bryant wrote: >> Python 3 no longer supports __cmp__. Instead, we have to implement the >> "rich comparison" operators. We implement __eq__ and __lt__ and use >> functo

[ovs-dev] [PATCH 01/14] tests: Deal with Python output differences.

ing for the expected result. Signed-off-by: Russell Bryant <russ...@ovn.org> --- tests/test-json.py | 8 +--- tests/test-ovsdb.py | 2 +- tests/unixctl-py.at | 8 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/tests/test-json.py b/tests/test-json.py ind

[ovs-dev] [PATCH 02/14] configure: Check for presence of Python 3.

The configure script already checked for Python 2 (>=2.7). Add another check for Python 3 (>=3.4). This will be used later for automatically running tests with Python 3 as well if available. Signed-off-by: Russell Bryant <russ...@ovn.org> --- configure.ac | 1 + m4/openvsw

[ovs-dev] [PATCH 04/14] check-structs.at: Run for both Python 2 and 3.

remains. Signed-off-by: Russell Bryant <russ...@ovn.org> --- tests/check-structs.at | 39 +++ 1 file changed, 23 insertions(+), 16 deletions(-) diff --git a/tests/check-structs.at b/tests/check-structs.at index 4163c30..ddfcbfa 100644 --- a/tests/check-stru

[ovs-dev] [PATCH 03/14] check-structs: Make Python 3 compatible.

The only Python 3 errors here were the use of print. The rest of the changes make it so we can check this file with flake8. Signed-off-by: Russell Bryant <russ...@ovn.org> --- Makefile.am | 2 +- build-aux/check-structs | 30 -- 2 files chang

[ovs-dev] [PATCH 09/14] jsonrpc-py.at: Run tests with Python 2 and 3.

Convert these Python tests to run with both Python 2 and 3. Signed-off-by: Russell Bryant <russ...@ovn.org> --- tests/jsonrpc-py.at | 79 +++-- 1 file changed, 47 insertions(+), 32 deletions(-) diff --git a/tests/jsonrpc-py.at b/tests/j

[ovs-dev] [PATCH 07/14] ovsdb-idl.at: Run tests with both Python 2 and 3.

Update Python tests to run for both Python 2 and Python 3. Signed-off-by: Russell Bryant <russ...@ovn.org> --- tests/ovsdb-idl.at | 56 ++ 1 file changed, 40 insertions(+), 16 deletions(-) diff --git a/tests/ovsdb-idl.at b/tests/ovsdb-

[ovs-dev] [PATCH 08/14] library.at: Run tests for Python 2 and 3.

Update Python tests to run for both Python 2 and 3. Signed-off-by: Russell Bryant <russ...@ovn.org> --- tests/library.at | 34 ++ 1 file changed, 22 insertions(+), 12 deletions(-) diff --git a/tests/library.at b/tests/library.at index d5dcb12..11a405b

[ovs-dev] [PATCH 05/14] json.at: Run for Python 2 and 3.

Run json.at tests for both Python 2 and 3 if available. Signed-off-by: Russell Bryant <russ...@ovn.org> --- tests/json.at | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/tests/json.at b/tests/json.at index 8846ac9..a4c40c8 100644 --- a/tests/j

[ovs-dev] [PATCH 00/14] Finish support for Python 3.

This is this final series for Python 3 support. It refactors the test suite to run Python tests against both Python 2 and 3. Russell Bryant (14): tests: Deal with Python output differences. configure: Check for presence of Python 3. check-structs: Make Python 3 compatible. check

[ovs-dev] [PATCH 10/14] reconnect.at: Run tests for Python 2 and 3.

Update the reconnect tests to use both Python 2 and 3. Signed-off-by: Russell Bryant <russ...@ovn.org> --- tests/reconnect.at | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tests/reconnect.at b/tests/reconnect.at index 9ebe183..c88ca78 100644 --- a/tests/reconn

[ovs-dev] [PATCH 06/14] ovsdb.at: Run Python tests for Python 2 and 3.

. Signed-off-by: Russell Bryant <russ...@ovn.org> --- tests/ovsdb.at | 52 +++- 1 file changed, 47 insertions(+), 5 deletions(-) diff --git a/tests/ovsdb.at b/tests/ovsdb.at index 3e9918a..2e87ef3 100644 --- a/tests/ovsdb.at +++ b/tests/ov

Re: [ovs-dev] [RFC] ovn-controller: Only process lflows for local datapaths.

On 02/02/2016 05:21 PM, Ben Pfaff wrote: > On Tue, Feb 02, 2016 at 05:01:35PM -0500, Russell Bryant wrote: >> On 02/02/2016 04:49 PM, Ben Pfaff wrote: >>> On Thu, Jan 21, 2016 at 03:21:00PM -0500, Russell Bryant wrote: >>>> Previously, ovn-controller translated log

[ovs-dev] [PATCH 14/14] NEWS: Claim support for Python 3.

Also update the Python ovs package info to note that both Python 2 and 3 are supported. Signed-off-by: Russell Bryant <russ...@ovn.org> --- NEWS| 3 +++ python/setup.py | 6 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index e683dae..46600c8

[ovs-dev] [PATCH 13/14] vlog.at: Run tests for Python 2 and 3.

Update these Python tests to run with both Python 2 and 3. Signed-off-by: Russell Bryant <russ...@ovn.org> --- tests/vlog.at | 174 +- 1 file changed, 99 insertions(+), 75 deletions(-) diff --git a/tests/vlog.at b/tests/vlog.at

[ovs-dev] [PATCH 12/14] unixctl-py.at: Run tests for Python 2 and 3.

Update these Python tests to run with both Python 2 and 3. Signed-off-by: Russell Bryant <russ...@ovn.org> --- tests/unixctl-py.at | 198 +--- 1 file changed, 111 insertions(+), 87 deletions(-) diff --git a/tests/unixctl-py.at b/tests/u

[ovs-dev] [PATCH 11/14] daemon-py.at: Run tests with Python 2 and 3.

Update these Python tests to run with both Python 2 and 3. Signed-off-by: Russell Bryant <russ...@ovn.org> --- tests/daemon-py.at | 483 - 1 file changed, 260 insertions(+), 223 deletions(-) diff --git a/tests/daemon-py.at b/tests/daemon

Re: [ovs-dev] [RFC] ovn-controller: Only process lflows for localdatapaths.

s really use all your logical switches and logical > routers, it won't help. > Right. When I wrote this, the test configuration in use at the time had a lot of networks, I believe. It just looked like some low hanging fruit until someone can work on incremental flow calcu

Re: [ovs-dev] [PATCH] ovn-northd: Don't set custon log level defaults.

On 02/01/2016 12:21 PM, Ben Pfaff wrote: > On Mon, Feb 01, 2016 at 10:01:23AM -0500, Russell Bryant wrote: >> ovn-northd set some custom log level defaults, which I believe were >> copied from ovs-vsctl. Other daemons don't set this. The difference in >> behavior in ovn-no

Re: [ovs-dev] OVN: proposal of introducing nlog engine to ovn-northd

On 02/01/2016 02:52 PM, Saurabh Shrivastava (सौरभ श्रीवास्तव) wrote: > How about reusing Openstack Congress which is already out there and also > implements something like nlog? One simple reason is that Congress is written in Python, while OVN is written in C. -- Russell

[ovs-dev] [OVN] Applying ACL changes to existing connections

started playing a bit today and tweaked the logical flows to get a bit closer, but I don't have a complete solution. Has anyone else thought about this? -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] Does OPEN mean open affiliation too?

s, > -chris > > P.S. I know you know, but full disclosure -- I work for Red Hat. I also work for Red Hat. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] ovn-northd: Don't set custon log level defaults.

Moats <rmo...@us.ibm.com> Reported-at: https://bugs.launchpad.net/bugs/1539994 Signed-off-by: Russell Bryant <russ...@ovn.org> --- ovn/northd/ovn-northd.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index 4f03287..8083e25 1006

Re: [ovs-dev] OVN: proposal of introducing nlog engine to ovn-northd

or. That's about as far as I've gone though. I haven't written any code yet because I keep staying busy with other things. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] INSTALL.md: Fix shell command line formatting.

On Saturday, January 30, 2016, Justin Pettit wrote: > > > On Jan 29, 2016, at 3:18 PM, Jarno Rajahalme > wrote: > > > > Some shell command lines were quited inconsistently from others. > s/quited/quoted/

Re: [ovs-dev] [PATCH] ovn: Remove top ovn directory from PATHs.

.maxim...@samsung.com> Thanks for the patch! I applies this to master and branch-2.5. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/3] Documentation: Add information about committer policies.

t...@ovn.org> Acked-by: Russell Bryant <russ...@ovn.org> -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/3] Documentation: Clarify committer documentation.

), 20 deletions(-) Nice cleanup. Words are hard. Acked-by: Russell Bryant <russ...@ovn.org> -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 3/3] Documentation: Change committer files to ".md" format.

> create mode 100644 Documentation/committer-grant-revocation.md > delete mode 100644 Documentation/committer-responsibilities > create mode 100644 Documentation/committer-responsibilities.md Thanks. This is much easier to read, even in plain text form. Acked-by: Russell

Re: [ovs-dev] [PATCH] rhel: Clarify instructions for RHEL 7.

On 01/29/2016 12:04 PM, Thomas F Herbert wrote: > > > On 1/28/16 3:46 PM, Russell Bryant wrote: >> On 01/28/2016 02:55 PM, Russell Bryant wrote: >>> On 01/28/2016 12:56 PM, Guru Shetty wrote: >>>> >>>> On 28 January 2016 at 08:46, Russell Brya

Re: [ovs-dev] [PATCH] build: Fix for rename of MAINTAINERS file.

On 01/29/2016 08:10 PM, Andy Zhou wrote: > > > On Fri, Jan 29, 2016 at 4:53 PM, Russell Bryant <russ...@ovn.org > <mailto:russ...@ovn.org>> wrote: > > I renamed MAINTAINERS to MAINTAINERS.md, but forgot to update > Makefile.am to reflect the new name

Re: [ovs-dev] [PATCH] MAINTAINERS: convert to .md format.

On 01/29/2016 04:49 PM, Justin Pettit wrote: > Acked-by: Justin Pettit <jpet...@ovn.org> Pushed to master, thanks! -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] build: Fix for rename of MAINTAINERS file.

I renamed MAINTAINERS to MAINTAINERS.md, but forgot to update Makefile.am to reflect the new name. Signed-off-by: Russell Bryant <russ...@ovn.org> --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) I already pushed this to master since it was a trivial fix for som

Re: [ovs-dev] [PATCH] committer-grant-revocation.md: Fix link and clarify location.

Acked-by: Russell Bryant <russ...@ovn.org> On Friday, January 29, 2016, Justin Pettit <jpet...@ovn.org> wrote: > Signed-off-by: Justin Pettit <jpet...@ovn.org <javascript:;>> > --- > Documentation/committer-grant-revocation.md | 2 +- > 1 file changed, 1

Re: [ovs-dev] [PATCH] rhel: Clarify instructions for RHEL 7.

<g...@ovn.org <mailto:g...@ovn.org>> applied to master, thanks for the review! -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/3] Documentation: Add information about committer policies.

On 01/29/2016 04:29 PM, Justin Pettit wrote: > >> On Jan 29, 2016, at 7:40 AM, Russell Bryant <russ...@ovn.org> wrote: >> >> On 01/29/2016 05:09 AM, Justin Pettit wrote: >>> These files were only available on the openvswitch.org mailing list. >> >&g

[ovs-dev] [PATCH] MAINTAINERS: convert to .md format.

-by: Russell Bryant <russ...@ovn.org> --- MAINTAINERS| 31 --- MAINTAINERS.md | 29 + 2 files changed, 29 insertions(+), 31 deletions(-) delete mode 100644 MAINTAINERS create mode 100644 MAINTAINERS.md diff --git a/MAINTAI

[ovs-dev] [PATCH v2] rhel: Make openvswitch-kmod-fedora.spec build.

how to generate a debuginfo pacakge. I turned off the debug package for now. At least it builds now, which is an improvement. Signed-off-by: Russell Bryant <russ...@ovn.org> Suggested-by: Flavio Leitner <f...@redhat.com> --- rhel/openvswitch-kmod-fedora.spec.in | 24 +++

Re: [ovs-dev] [PATCH] rhel: Clarify instructions for RHEL 7.

On 01/29/2016 02:34 PM, Thomas F Herbert wrote: > > > On 1/29/16 12:43 PM, Russell Bryant wrote: >> On 01/29/2016 12:04 PM, Thomas F Herbert wrote: >>> >>> On 1/28/16 3:46 PM, Russell Bryant wrote: >>>> On 01/28/2016 02:55 PM, Russell Bryant wrote: &g

Re: [ovs-dev] [PATCH v2] rhel: Make openvswitch-kmod-fedora.spec build.

On 01/29/2016 03:59 PM, Flavio Leitner wrote: > On Fri, 29 Jan 2016 14:42:54 -0500 > Russell Bryant <russ...@ovn.org> wrote: > >> I tried building this package on Fedora 23 and it failed for a couple >> of different reasons. >> >> This package tried to ins

Re: [ovs-dev] [PATCH 1/3] ovn: Add port_security proposal

On 01/28/2016 10:11 AM, Numan Siddique wrote: > On 01/28/2016 08:04 PM, Russell Bryant wrote: >> You raised another thread about the proposed syntax here: >> >> http://openvswitch.org/pipermail/dev/2016-January/064921.html >> >> Let's make sure we agree on that b

[ovs-dev] [PATCH] rhel: Clarify instructions for RHEL 7.

neither 16 or 17 are supported releases anymore. Signed-off-by: Russell Bryant <russ...@ovn.org> --- INSTALL.Fedora.md | 11 ++- INSTALL.RHEL.md | 4 2 files changed, 10 insertions(+), 5 deletions(-) NOTE: The kmod build doesn't actually work for me, but I believe the instruct

Re: [ovs-dev] [PATCH 0/1] Fix Rhel spec file for kmod RPM

On 01/28/2016 10:45 AM, Thomas F Herbert wrote: > On 1/28/16 9:54 AM, Russell Bryant wrote: >> On 01/28/2016 08:48 AM, Thomas F Herbert wrote: >>> In the process of building RPM's in OVS-OPNFV project, it was >>> discovered that the >>> Rhel spec file for build

Re: [ovs-dev] [PATCH 1/3] ovn: Add port_security proposal

ackets to 192.168.1.255 >> (based >> + on the subnet mask), 255.255.255.255, and any address n >> 224.0.0.0/4. >> + The host may not send ARPs with a source Ethernet address other >> than >> + 80:fa:5b:06:72:b7 or source IPv4

[ovs-dev] [PATCH] rhel: Make openvswitch-kmod-fedora.spec build.

how to generate a debuginfo pacakge. I turned off the debug package for now. At least it builds now, which is an improvement. Signed-off-by: Russell Bryant <russ...@ovn.org> --- rhel/openvswitch-kmod-fedora.spec.in | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff

Re: [ovs-dev] [PATCH] rhel: Clarify instructions for RHEL 7.

On 01/28/2016 02:55 PM, Russell Bryant wrote: > On 01/28/2016 12:56 PM, Guru Shetty wrote: >> >> >> On 28 January 2016 at 08:46, Russell Bryant <russ...@ovn.org >> <mailto:russ...@ovn.org>> wrote: >> >> The rpm build instructions did not clar

Re: [ovs-dev] [PATCH] rhel: Clarify instructions for RHEL 7.

On 01/28/2016 12:56 PM, Guru Shetty wrote: > > > On 28 January 2016 at 08:46, Russell Bryant <russ...@ovn.org > <mailto:russ...@ovn.org>> wrote: > > The rpm build instructions did not clarify what spec files were to be > used for RHEL 7 and its derivativ

Re: [ovs-dev] [PATCH 1/3] ovn: Add port_security proposal

t_security documentation, it seems to suggest that this form is also allowed: 1) ["MAC1 MAC2 MAC3 IP1 IP2 IP3"] Is that intentional? or should we require this instead which seems to be what you and Han were discussing? 2) ["MAC1 IP1 IP2 IP3

Re: [ovs-dev] How OVN do SNAT/DNAT/VPN

t point, we will still have the problem of how to implement SNAT for VMs that do not have a floating IP. I don't know how that's going to work yet. A central network node is how OpenStack solves it today, but it's not the only possible solution. -- Russell Bryant _

Re: [ovs-dev] [PATCH 1/4] Add MAINTAINERS file.

On 01/27/2016 06:55 PM, Ben Pfaff wrote: > Acked-by: Ben Pfaff <b...@ovn.org> Thanks. I pushed this patch to master and dropped the rest of the series. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman

Re: [ovs-dev] [PATCH 0/1] Fix Rhel spec file for kmod RPM

> > Thomas F Herbert (1): > Fix RHEL Spec file for kmod RPM install. > > rhel/openvswitch-kmod-rhel6.spec.in | 2 -- > rhel/openvswitch-kmod.files | 3 --- > 2 files changed, 5 deletions(-) > delete mode 100644 rhel/openvswitch-kmod.files > -- Russell Brya

Re: [ovs-dev] [PATCHv2 branch2-4] rhel: provide our own SELinux custom policy package

On Wednesday, January 27, 2016, Flavio Leitner <f...@sysclose.org> wrote: > On Thu, 21 Jan 2016 17:09:42 -0500 > Russell Bryant <russ...@ovn.org <javascript:;>> wrote: > > > On 01/20/2016 05:59 PM, Ansis Atteka wrote: > > > CentOS, RHEL and Fed

Re: [ovs-dev] [PATCH 2/4] MAINTAINERS: Start listing area maintainers.

On 01/27/2016 06:56 PM, Ben Pfaff wrote: > On Wed, Jan 27, 2016 at 03:38:03PM -0500, Russell Bryant wrote: >> Adopt a subset of the syntax used in the Linux kernel MAINTAINERS file >> for expressing maintainership of subsets of the code base. To start, I >> added a catch-all

Re: [ovs-dev] [PATCH 2/4] MAINTAINERS: Start listing area maintainers.

On Wednesday, January 27, 2016, Justin Pettit <jpet...@ovn.org> wrote: > > > On Jan 27, 2016, at 4:45 PM, Russell Bryant <russ...@ovn.org > <javascript:;>> wrote: > > > > I'm OK going either way here, but hopefully that helps explain my > > motiv

Re: [ovs-dev] [PATCH 2/2] vlog: Add vlog/close command.

On Wednesday, January 27, 2016, Russell Bryant <russ...@ovn.org> wrote: > On 12/08/2015 01:59 PM, Ben Pfaff wrote: > > Requested-by: P R Dinesh > > Requested-at: https://github.com/openvswitch/ovs/pull/94 > > Signed-off-by: Ben Pfaff <b...@ovn.org <javascript

Re: [ovs-dev] [PATCH v4 3/3] ovn-controller: Allocate ct zones for localnet ports.

On 01/27/2016 02:06 PM, Han Zhou wrote: > > > On Wed, Jan 27, 2016 at 10:32 AM, Russell Bryant <russ...@ovn.org > <mailto:russ...@ovn.org>> wrote: >> > >> > Shall we add it ONLY IF it is on a local datapath (which means it is >> > realized as a

Re: [ovs-dev] [PATCH v4 3/3] ovn-controller: Allocate ct zones for localnet ports.

On 01/27/2016 02:34 AM, Han Zhou wrote: > > > On Mon, Jan 25, 2016 at 2:02 PM, Russell Bryant <russ...@ovn.org > <mailto:russ...@ovn.org>> wrote: >> >> Previously, all ct() actions applied to localnet ports used the default >> conntrack zone. We sho

Re: [ovs-dev] How OVN do SNAT/DNAT/VPN

nectivity between logical and physical networks is using vtep gateways (TOR switches or software that implements in the hardware_vtep ovsdb schema). There's not really an equivalent in the existing OVS support, and I don't think this is feature complete enough yet anyway except

[ovs-dev] [PATCH 0/4] Create MAINTAINERS file.

knowledge. Russell Bryant (4): Add MAINTAINERS file. MAINTAINERS: Start listing area maintainers. MAINTAINERS: Add entry for datapath/. MAINTAINERS: Add entry for vtep/. MAINTAINERS | 93 + 1 file changed, 93 insertions

[ovs-dev] [PATCH 3/4] MAINTAINERS: Add entry for datapath/.

Signed-off-by: Russell Bryant <russ...@ovn.org> --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6000fa6..eade9e5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -64,6 +64,13 @@ Descriptions of section entries: X:ne

[ovs-dev] [PATCH 1/4] Add MAINTAINERS file.

, but I just copied what was currently in AUTHORS. This can be fixed when AUTHORS gets fixed, too. Signed-off-by: Russell Bryant <russ...@ovn.org> --- MAINTAINERS | 30 ++ 1 file changed, 30 insertions(+) create mode 100644 MAINTAINERS diff --git a/MAINTAI

[ovs-dev] [PATCH 4/4] MAINTAINERS: Add entry for vtep/.

Signed-off-by: Russell Bryant <russ...@ovn.org> --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index eade9e5..91e22ea 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -79,6 +79,12 @@ L: dev@openvswitch.org Q: https://patchwork.ozla

Re: [ovs-dev] [RFC] ovsdb-idl: improved error handling for non-existent db

n anything. Maybe it should return an error in this case? or is there a better way to know we're in this state? My main thought is that the user of the ovsdb_idl API should decide how to handle this condition. ovn-nbctl/ovn-sbctl for example can decide that logging an error and exiting is what makes the most sense, but that may not always be the case. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH 2/4] MAINTAINERS: Start listing area maintainers.

-by: Russell Bryant <russ...@ovn.org> --- MAINTAINERS | 50 ++ 1 file changed, 50 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 299e0b5..6000fa6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -28,3 +28,53 @@ Pravin B Shelar

Re: [ovs-dev] [PATCH 1/2] tests: Add vlog tests for C implementation to match Python tests.

> 3 files changed, 319 insertions(+) > create mode 100644 tests/test-unixctl.c Acked-by: Russell Bryant <russ...@ovn.org> -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/2] vlog: Add vlog/close command.

On 12/08/2015 01:59 PM, Ben Pfaff wrote: > Requested-by: P R Dinesh > Requested-at: https://github.com/openvswitch/ovs/pull/94 > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Russell Bryant <russ...@ovn.org> Some comments/questions inline ... > --- &g

Re: [ovs-dev] [PATCH V4] Add Passive TCP connection to IDL.

nor simplification: passive = remove.startswith('ptcp:') > + > +if passive: > +session = ovs.jsonrpc.Session.open(remote) > +session.run() > +session.run() A comment would be helpful in the code here to explain why you're calling session.run() twice here. O

Re: [ovs-dev] [PATCH v3 2/2] ovn: Fix localnet ports on the same chassis.

On 01/25/2016 02:26 AM, Han Zhou wrote: > Looks good to me, and tested. Thanks for the feedback! -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH monitor_cond V2 11/12] python: move Python idl to work with monitor_cond

om_json(self, table, > + uuid, row_update['modify'])) > +changed = True > +else: > +raise error.Error(' unknown operation', > + row_update) > +return changed > + > def __process_update(self, table, uuid, old, new): > """Returns True if a column changed, False otherwise.""" > row = table.rows.get(uuid) > @@ -439,6 +548,42 @@ class Idl(object): > self.notify(op, row, Row.from_json(self, table, uuid, old)) > return changed > > +def __add_default(self, table, row_update): > +for column in table.columns.itervalues(): > +if column.name not in row_update: > +if ((table.name not in self.readonly) or > +(table.name in self.readonly) and > +(column.name not in self.readonly[table.name])): > +if column.type.n_min != 0 and not column.type.is_map(): > +if column.type.key.type == ovs.db.types.UuidType: > +row_update[column.name] = > ovs.ovsuuid.to_json(column.type.key.type.default) Line length here is too long. Please install 'flake8', re-run configure, and then fix any issues it complains about, which should include lines that are too long. -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ovs-rcu: Improve comments on ovsrcu_postpone().

\ > + /* Verify that ARG is a pointer type. */ \ > (void) sizeof(*(ARG)), \ > ovsrcu_postpone__((void (*)(void *))(FUNCTION), ARG)) > > Pretty clever checks. :-) Acked-by: Russell Bryant <r

[ovs-dev] [PATCH v4 2/3] ovn: Fix localnet ports on the same chassis.

v/2016-January/064413.html Signed-off-by: Russell Bryant <russ...@ovn.org> Tested-by: Kyle Mestery <mest...@mestery.com Acked-By: Kyle Mestery <mest...@mestery.com> Tested-by: Han Zhou <zhou...@gmail.com> --- ovn/controller/ovn-controller.8.xml | 7 +- ovn/controller/ovn-co

[ovs-dev] [PATCH v4 1/3] ovn-controller: Move local_datapaths calculation.

earlier in the main loop, making it easier to re-use. Signed-off-by: Russell Bryant <russ...@ovn.org> Acked-by: Han Zhou <zhou...@gmail.com> --- ovn/controller/binding.c| 18 +- ovn/controller/binding.h| 3 ++- ovn/controller/ovn-contr

[ovs-dev] [PATCH v4 0/3] localnet port fixes

v3->v4: - Added patch #3, which fixes another localnet bug I came across. I added it to this existing series as the fix depends on changes in this series. Russell Bryant (3): ovn-controller: Move local_datapaths calculation. ovn: Fix localnet ports on the same chassis. ovn-control

[ovs-dev] [PATCH v4 3/3] ovn-controller: Allocate ct zones for localnet ports.

. Signed-off-by: Russell Bryant <russ...@ovn.org> --- ovn/controller/binding.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/ovn/controller/binding.c b/ovn/controller/binding.c index c9649eb..ce9cccf 100644 --- a/ovn/controller/binding.c +++ b/ovn/controller/binding.c @@ -189,6 +

Re: [ovs-dev] [PATCH] [RFC] lib/ovs-thread: set pthread stack size to 128k

per, aux); > if (error) { > ovs_abort(error, "pthread_create failed"); > } > I don't actually have feedback on the more important question of how best to deal with your issue, but fwiw, you need a pthread_attr_destroy() after pthread_create(). -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] flake8: Fix use of --select and --ignore.

specified in --select. This patch runs flake8 twice, once with --select and once with --ignore to actually enforce the full desired set of warnings. No additional violations had been introduced, but I noticed this while working on some other patches. Signed-off-by: Russell Bryant <russ...@ovn.

Re: [ovs-dev] [PATCH v2 5/5] python: Remove old style classes.

On 01/22/2016 12:03 AM, Ben Pfaff wrote: > On Tue, Jan 12, 2016 at 02:45:49PM -0500, Russell Bryant wrote: >> Python 3 removed support for "old-style classes". Classes should always >> inherit from object to get consistent behavior between Python 2 and 3. >> >

[ovs-dev] [PATCH 06/11] python: Drop use of sys.maxint.

the Python 3.4 test environment pass successfully (tox -e py34). Signed-off-by: Russell Bryant <russ...@ovn.org> --- python/ovs/db/schema.py | 6 +++--- python/ovs/db/types.py | 26 +- python/ovs/json.py | 2 +- python/ovs/vlog.py | 2 +- 4 files chang

[ovs-dev] [PATCH 11/11] python: Deal with str and byte differences.

Python 3 has separate types for strings and bytes. Python 2 used the same type for both. We need to convert strings to bytes before writing them out to a socket. We also need to convert data read from the socket to a string. Signed-off-by: Russell Bryant <russ...@ovn.org> --- pyth

[ovs-dev] [PATCH 02/11] python: Drop unicode type.

Python 2 had str and unicode. Python 3 only has str, which is always a unicode string. Drop use of unicode with the help of six.text_type (unicode in py2 and str in py3) and six.string_types ([str, unicode] in py2 and [str] in py3). Signed-off-by: Russell Bryant <russ...@ovn.org> ---

[ovs-dev] [PATCH 09/11] python: Don't compare None and int.

Comparing None to an integer worked in Python 2, but fails in Python 3. Signed-off-by: Russell Bryant <russ...@ovn.org> --- python/ovs/reconnect.py | 2 +- tests/test-reconnect.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/python/ovs/reconnect.py b/pyth

[ovs-dev] [PATCH 07/11] python: Use six.unichr().

six.unichr() is equivalent to unichr() in Python 2 and chr() in Python 3. Signed-off-by: Russell Bryant <russ...@ovn.org> --- python/ovs/json.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/ovs/json.py b/python/ovs/json.py index a59a0c2..db74397 100644 --- a/

[ovs-dev] [PATCH 05/11] python: Don't use StringIO directly.

StringIO.StringIO in Python 2 became io.StringIO in Python 3. Use six.StringIO which is an alias for the two cases. Signed-off-by: Russell Bryant <russ...@ovn.org> --- python/ovs/json.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/python/ovs/json.py b/pyth

[ovs-dev] [PATCH 01/11] python: Drop usage of long type.

the similar checks nearby while I was at it. Signed-off-by: Russell Bryant <russ...@ovn.org> --- python/ovs/db/data.py | 20 python/ovs/db/idl.py| 4 ++-- python/ovs/db/parser.py | 15 ++- python/ovs/db/types.py | 20 +--- python/ovs/j

[ovs-dev] [PATCH 03/11] python: Drop use of types.StringTypes.

types.StringTypes does not exist in Python 3. We can use six.string_types, instead. Signed-off-by: Russell Bryant <russ...@ovn.org> --- python/ovs/unixctl/__init__.py | 4 +++- python/ovs/unixctl/client.py | 5 +++-- python/ovs/unixctl/server.py | 3 +-- 3 files changed, 7 insertions

[ovs-dev] [PATCH 08/11] python: Remove reamining direct type comparisons.

a bug I haven't hit yet and it's more Pythonic, anyway. Signed-off-by: Russell Bryant <russ...@ovn.org> --- python/ovs/db/data.py | 6 +++--- python/ovs/db/idl.py | 28 ++-- python/ovs/db/parser.py | 6 +++--- python/ovs/db/schema.py | 2 +- python/ovs/j

[ovs-dev] [PATCH 04/11] python: Drop use of types.FunctionType.

This code asserted that the callback argument was of type types.FunctionType. It's more pythonic to just check that the argument is callable, and not specifically that it's a function. There are other ways to implement a callback than types.FunctionType. Signed-off-by: Russell Bryant <r

<    5   6   7   8   9   10   11   12   13   14   >