Re: [ovs-dev] [PATCH] ofproto: Inline actions in struct rule_actions.

2014-04-29 Thread Jarno Rajahalme
On Apr 29, 2014, at 2:51 PM, Ben Pfaff wrote: > On Fri, Apr 25, 2014 at 08:49:10AM -0700, Jarno Rajahalme wrote: >> Allocate struct rule_actions and the space for the actions at once. >> This reduces one memory indirection and helps reduce cache misses >> visible in perf annotations. >> >> Fix

Re: [ovs-dev] [PATCH] ofproto: Inline actions in struct rule_actions.

2014-04-29 Thread Ben Pfaff
On Fri, Apr 25, 2014 at 08:49:10AM -0700, Jarno Rajahalme wrote: > Allocate struct rule_actions and the space for the actions at once. > This reduces one memory indirection and helps reduce cache misses > visible in perf annotations. > > Fix some old comments referring to ref count, since we now u

[ovs-dev] [PATCH] ofproto: Inline actions in struct rule_actions.

2014-04-25 Thread Jarno Rajahalme
Allocate struct rule_actions and the space for the actions at once. This reduces one memory indirection and helps reduce cache misses visible in perf annotations. Fix some old comments referring to ref count, since we now use RCU for this. Enforce constness of the actions throughout the code. Si