+enum admin_port_state {
+RSTP_ADMIN_BRIDGE_PORT_STATE_DISABLED = 0,
+RSTP_ADMIN_BRIDGE_PORT_STATE_ENABLED = 1
+};
+
+enum oper_p2p_mac_state {
+RSTP_OPER_P2P_MAC_STATE_DISABLED = 0,
+RSTP_OPER_P2P_MAC_STATE_ENABLED = 1
+};
+
+/* State enumerations for state machines
Jarno Rajahalme wrote:
Daniele, Martino,
Thank you for the contribution, and sorry that it has taken so long for me to
get to the review!
[...]
Dear all,
we are working on Jarno revision, and we will provide shortly a revised patch.
In the meantime, I would like to ask for advice on an issue
From: dev dev-boun...@openvswitch.org on behalf of Martino Fornasa
m...@fornasa.it
Sent: Monday, May 26, 2014 9:50 AM
To: Jarno Rajahalme
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v3] Rapid Spanning Protocol Implementation (IEEE
802.1D) + functional tests
Jarno Rajahalme
On Wed, Apr 30, 2014 at 04:27:47PM +0200, Daniele Venturino wrote:
In lib/mac-learning.h there is a function (mac_learning_flush()) to
flush the whole table. Is there a function to flush the entries
pertaining to a single port?
There's bundle_flush_macs() in ofproto/ofproto-dpif.c.
+/* Bridge State Machine. */
+/* [17.28] Port Role Selection state machine. */
+
+void
+updt_role_disabled_tree(struct rstp * r)
Is ther a specfc resn to contrct the first word in the nam of this functn?
We try to strictly follow the naming used in the IEEE 802.1D-2004 standard, as
it
Jarno Rajahalme wrote:
Another high-level thing is that in OVS we use the ‘ovs_beXX’ types to annotate
integers in network byte order, and the corresponding ‘uintXX_t’ types for the
host byte order equivalents. You would use ovs_beXX types to define the BPDUs,
and then convert each member to
On Apr 29, 2014, at 7:40 AM, Martino Fornasa m...@fornasa.it wrote:
Jarno Rajahalme wrote:
Also, we have defined the type ‘stp_identifier’ in lib/stp.h. I’d like you
to use it (with the accompanying formatting tools) also for RSTP (maybe move
them to lib/util.h to use them both from STP
Jarno Rajahalme wrote:
move_rstp() does not check ‘changes’ before clearing it. Consider enforcing the
invariant,
or maybe do not bother setting ‘changes’ right before calling ‘move_rstp()’ ?
Not clear to me. Function move_rstp does check 'changes':
move_rstp(struct rstp *rstp )
{
int
On Apr 28, 2014, at 2:09 AM, Martino Fornasa m...@fornasa.it wrote:
Jarno Rajahalme wrote:
move_rstp() does not check ‘changes’ before clearing it. Consider enforcing
the invariant,
or maybe do not bother setting ‘changes’ right before calling ‘move_rstp()’ ?
Not clear to me.
Jarno Rajahalme wrote:
Daniele, Martino,
Thank you for the contribution, and sorry that it has taken so long for me to
get to the review!
Thank you for the thorough revision.
We are going to take a deeper look at it and provide modifications/comments.
B.R., Martino.
This is the diff between RSTP patch v3 and v2 (the one sent on February 24th).
---
diff --git a/v1/lib/rstp.c b/v2/lib/rstp.c
index 2725707..d226967 100644
--- a/v1/lib/rstp.c
+++ b/v2/lib/rstp.c
@@ -1076,6 +1076,20 @@ rstp_port_get_aux(struct rstp_port *p)
return aux;
}
+/* Returns true
11 matches
Mail list logo
