Re: [ovs-dev] [PATCH v3 07/12] dpif-netdev: Cache align netdev_flow_keys.

2016-10-19 Thread Ben Pfaff
On Wed, Oct 19, 2016 at 01:42:50PM -0700, Jarno Rajahalme wrote: > > > On Oct 19, 2016, at 10:01 AM, Joe Stringer wrote: > > > > On 14 October 2016 at 07:37, Bhanuprakash Bodireddy > > wrote: > >> Aligning the 'keys' array seems to have positive performance impact. > >> > >> Signed-off-by: Bha

Re: [ovs-dev] [PATCH v3 07/12] dpif-netdev: Cache align netdev_flow_keys.

2016-10-19 Thread Daniele Di Proietto
2016-10-19 13:42 GMT-07:00 Jarno Rajahalme : > > > On Oct 19, 2016, at 10:01 AM, Joe Stringer wrote: > > > > On 14 October 2016 at 07:37, Bhanuprakash Bodireddy > > wrote: > >> Aligning the 'keys' array seems to have positive performance impact. > >> > >> Signed-off-by: Bhanuprakash Bodireddy >

Re: [ovs-dev] [PATCH v3 07/12] dpif-netdev: Cache align netdev_flow_keys.

2016-10-19 Thread Jarno Rajahalme
> On Oct 19, 2016, at 10:01 AM, Joe Stringer wrote: > > On 14 October 2016 at 07:37, Bhanuprakash Bodireddy > wrote: >> Aligning the 'keys' array seems to have positive performance impact. >> >> Signed-off-by: Bhanuprakash Bodireddy >> Co-authored-by: Antonio Fischetti >> Signed-off-by: Anto

Re: [ovs-dev] [PATCH v3 07/12] dpif-netdev: Cache align netdev_flow_keys.

2016-10-19 Thread Joe Stringer
On 14 October 2016 at 07:37, Bhanuprakash Bodireddy wrote: > Aligning the 'keys' array seems to have positive performance impact. > > Signed-off-by: Bhanuprakash Bodireddy > Co-authored-by: Antonio Fischetti > Signed-off-by: Antonio Fischetti > Acked-by: Daniele Di Proietto It looks like the

[ovs-dev] [PATCH v3 07/12] dpif-netdev: Cache align netdev_flow_keys.

2016-10-14 Thread Bhanuprakash Bodireddy
Aligning the 'keys' array seems to have positive performance impact. Signed-off-by: Bhanuprakash Bodireddy Co-authored-by: Antonio Fischetti Signed-off-by: Antonio Fischetti Acked-by: Daniele Di Proietto --- lib/dpif-netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a