Re: [ovs-dev] [PATCH v6] datapath-windows: Add Geneve support

ithin Raju <nit...@vmware.com<mailto:nit...@vmware.com>> Cc: Yin Lin <li...@vmware.com<mailto:li...@vmware.com>>, "dev@openvswitch.org<mailto:dev@openvswitch.org>" <dev@openvswitch.org<mailto:dev@openvswitch.org>> Subject: Re: [ovs-dev] [PAT

Re: [ovs-dev] [PATCH v6] datapath-windows: Add Geneve support

On Fri, Jun 17, 2016 at 5:10 PM, Yin Lin wrote: > Thanks Alin and Nithin for the review and Jesse for the clarification. > > I've addressed all the comments except this one: > > "One general comment is that we are validating the tunnel options in the > hot path - basically for

Re: [ovs-dev] [PATCH v6] datapath-windows: Add Geneve support

Thanks Alin and Nithin for the review and Jesse for the clarification. I've addressed all the comments except this one: "One general comment is that we are validating the tunnel options in the hot path - basically for each packet when we execute the actions for the flow. Obvious solution for

Re: [ovs-dev] [PATCH v6] datapath-windows: Add Geneve support

On Wed, Jun 15, 2016 at 10:12 PM, Nithin Raju wrote: diff --git a/datapath-windows/ovsext/Geneve.c b/datapath-windows/ovsext/Geneve.c new file mode 100644 index 000..8190a15 --- /dev/null +++ b/datapath-windows/ovsext/Geneve.c >>[...] +

Re: [ovs-dev] [PATCH v6] datapath-windows: Add Geneve support

Hi Jesse, Thanks for the comments. My responses inlined. >>> /* Number of packet attributes required to store OVS tunnel key. */ >>>-#define NUM_PKT_ATTR_REQUIRED 3 >>>+#define NUM_PKT_ATTR_REQUIRED 35 >>>+#define TUN_OPT_MAX_LEN 255 >> >> Wouldn¹t it have been better for alignment purposes to

Re: [ovs-dev] [PATCH v6] datapath-windows: Add Geneve support

On Wed, Jun 15, 2016 at 3:43 PM, Nithin Raju wrote: > -Original Message- > From: Yin Lin > Date: Monday, June 13, 2016 at 1:39 PM > To: "dev@openvswitch.org" , Nithin Raju > > Subject: [PATCH v6]

Re: [ovs-dev] [PATCH v6] datapath-windows: Add Geneve support

Hi Yin, Thanks for the patch. The code looks good overall, but for the comments. One general observation is that I saw a few instances where you were declaring variables in the middle of a scope. While it is legal, IMO, it makes the code ugly esp. if the code is not written in blocks. So, I¹d

Re: [ovs-dev] [PATCH v6] datapath-windows: Add Geneve support

Please add a commit message to the patch. Looking forward to v7. Thanks, Alin. > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Yin Lin > Trimis: Monday, June 13, 2016 11:39 PM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH v6] dat

[ovs-dev] [PATCH v6] datapath-windows: Add Geneve support

Signed-off-by: Yin Lin --- datapath-windows/automake.mk | 2 + datapath-windows/ovsext/Actions.c | 74 ++- datapath-windows/ovsext/Debug.h| 1 + datapath-windows/ovsext/DpInternal.h | 29 ++- datapath-windows/ovsext/Flow.c | 173

[ovs-dev] [PATCH v6] datapath-windows: Add Geneve support

Signed-off-by: Yin Lin --- datapath-windows/automake.mk | 2 + datapath-windows/ovsext/Actions.c | 74 ++- datapath-windows/ovsext/Debug.h| 1 + datapath-windows/ovsext/DpInternal.h | 29 ++- datapath-windows/ovsext/Flow.c | 173