Re: [ovs-dev] [db-ctl-base v2 1/3] db-ctl-base: do not expose get_table() API

2015-07-13 Thread Andy Zhou
nitpick, could we move this deletion to next commit? Make sense. I moved it. Acked-by: Alex Wang al...@nicira.com Thanks for the review. Pushed to master. /* ctl_fatal() also logs the error, so it is preferred in this file. */ @@ -250,9 +247,8 @@ struct ctl_table_class { * entry. */

Re: [ovs-dev] [db-ctl-base v2 1/3] db-ctl-base: do not expose get_table() API

2015-07-11 Thread Alex Wang
On Thu, Jul 9, 2015 at 1:27 PM, Andy Zhou az...@nicira.com wrote: Both get_table() and set_cloum() APIs are mostly used within db-ctl-base library. This patch makes both private to the library. Add a new ctl_set_colum() API for library client. The changes are cleanups. No functional

[ovs-dev] [db-ctl-base v2 1/3] db-ctl-base: do not expose get_table() API

2015-07-09 Thread Andy Zhou
Both get_table() and set_cloum() APIs are mostly used within db-ctl-base library. This patch makes both private to the library. Add a new ctl_set_colum() API for library client. The changes are cleanups. No functional changes. Signed-off-by: Andy Zhou az...@nicira.com --- lib/db-ctl-base.c