Thanks. I agree that we should remove IPFIX and sample action support.
I will send v4 for review.
Regards,
William
On Fri, Jul 22, 2016 at 2:38 PM, Ben Pfaff wrote:
> It sounds like snaplen is not very useful in IPFIX. If so, then I'd
> support removing the IPFIX and sample action support for i
It sounds like snaplen is not very useful in IPFIX. If so, then I'd
support removing the IPFIX and sample action support for it.
If you agree, will you send a v4? Otherwise, let me know and I'll apply
v3.
Here's a change I'd like to fold into v3, to better allow for future
extensions. It match
Hi William,
Comments inline.
On 7/12/16, 12:06 PM, "William Tu" wrote:
>Hi Wenyu and Daniel,
>
>Thanks for your feedback.
>
>On Mon, Jul 11, 2016 at 1:50 AM, Wenyu Zhang wrote:
>> Hi William,
>>
>> In your patch, no codes about supporting ³snaplen" in IPFIX included.
>>IPFIX
>> still get the l
Hi Wenyu and Daniel,
Thanks for your feedback.
On Mon, Jul 11, 2016 at 1:50 AM, Wenyu Zhang wrote:
> Hi William,
>
> In your patch, no codes about supporting “snaplen" in IPFIX included. IPFIX
> still get the length of packet as before, whatever the packet is truncated.
> If user put a non-zero
Hi William,
In your patch, no codes about supporting “snaplen" in IPFIX included. IPFIX
still get the length of packet as before, whatever the packet is truncated.
If user put a non-zero ‘snaplen’ in IPFIX sample action, the IPFIX result
should be incorrect. So the ‘snaplen’ in the flow-based I
Hi William,
OK, I got it. Thanks for Explanation. Maybe more detail should be put in the
comments.
For bridge IPFIX, we put 0 for 'snaplen' to not support packet truncation, for
flow-based IPFIX,
user can specify the 'snaplen' in IPFIX sample action.
For IPFIX, we only use the original pack
Hi Daniel,
Thanks for reviewing the patch.
Indeed, the way sFlow sets up the datapath does not require the
OpenFlow sample action, and changing OVSDB/compose_sample_action() is
sufficient to program the datapath sample action for current sFlow use
case. So if IPFIX does not use 'snaplen', or there
Hi William,
I saw that you submitted the patch below. It's about adding 'snaplen' for
sample action and sFlow.
https://patchwork.ozlabs.org/patch/645013/
I'm still confused whether sFlow uses the openflow sample action. In my
opinion, sFlow only uses the datapath
sample action, not the sample a
