Re: [ovs-dev] [patch net-next 01/13] openvswitch: split flow structures into ovs specific and generic ones

2014-09-17 Thread Jesse Gross
On Wed, Sep 17, 2014 at 1:34 AM, Jiri Pirko wrote: > Thu, Sep 04, 2014 at 10:46:28PM CEST, pshe...@nicira.com wrote: >>On the other hand if vswitchd uses common interface (switchdev) there >>is no need to extend ovs kernel interface. For example specifying >>extra metadata, like (sw only, hw olny,

Re: [ovs-dev] [patch net-next 01/13] openvswitch: split flow structures into ovs specific and generic ones

2014-09-17 Thread Jiri Pirko
Thu, Sep 04, 2014 at 10:46:28PM CEST, pshe...@nicira.com wrote: >On Thu, Sep 4, 2014 at 5:33 AM, Jiri Pirko wrote: >> Wed, Sep 03, 2014 at 08:41:39PM CEST, pshe...@nicira.com wrote: >>>On Wed, Sep 3, 2014 at 2:24 AM, Jiri Pirko wrote: After this, flow related structures can be used in other

Re: [ovs-dev] [patch net-next 01/13] openvswitch: split flow structures into ovs specific and generic ones

2014-09-04 Thread Pravin Shelar
On Thu, Sep 4, 2014 at 5:33 AM, Jiri Pirko wrote: > Wed, Sep 03, 2014 at 08:41:39PM CEST, pshe...@nicira.com wrote: >>On Wed, Sep 3, 2014 at 2:24 AM, Jiri Pirko wrote: >>> After this, flow related structures can be used in other code. >>> >>> Signed-off-by: Jiri Pirko >>> --- >>> include/net/sw

Re: [ovs-dev] [patch net-next 01/13] openvswitch: split flow structures into ovs specific and generic ones

2014-09-04 Thread Jiri Pirko
Wed, Sep 03, 2014 at 08:41:39PM CEST, pshe...@nicira.com wrote: >On Wed, Sep 3, 2014 at 2:24 AM, Jiri Pirko wrote: >> After this, flow related structures can be used in other code. >> >> Signed-off-by: Jiri Pirko >> --- >> include/net/sw_flow.h | 99 ++ >

Re: [ovs-dev] [patch net-next 01/13] openvswitch: split flow structures into ovs specific and generic ones

2014-09-04 Thread Jiri Pirko
Wed, Sep 03, 2014 at 08:42:18PM CEST, pshe...@nicira.com wrote: >On Wed, Sep 3, 2014 at 8:20 AM, John Fastabend >wrote: >> On 09/03/2014 02:24 AM, Jiri Pirko wrote: >>> >>> After this, flow related structures can be used in other code. >>> >>> Signed-off-by: Jiri Pirko >>> --- >> >> >> Hi Jiri,

Re: [ovs-dev] [patch net-next 01/13] openvswitch: split flow structures into ovs specific and generic ones

2014-09-04 Thread Jiri Pirko
Wed, Sep 03, 2014 at 05:20:25PM CEST, john.fastab...@gmail.com wrote: >On 09/03/2014 02:24 AM, Jiri Pirko wrote: >>After this, flow related structures can be used in other code. >> >>Signed-off-by: Jiri Pirko >>--- > >Hi Jiri, > >As I indicated before I'm looking into integrating this with some >h

Re: [ovs-dev] [patch net-next 01/13] openvswitch: split flow structures into ovs specific and generic ones

2014-09-03 Thread Jamal Hadi Salim
On 09/03/14 17:59, Pravin Shelar wrote: Both of us are saying same thing. What I meant was for OVS use-case, where OVS wants to use offload for switching flows, vswitchd userspace process can program HW offload using kernel HW offload APIs directly from userspace, rather than going through OVS k

Re: [ovs-dev] [patch net-next 01/13] openvswitch: split flow structures into ovs specific and generic ones

2014-09-03 Thread Pravin Shelar
On Wed, Sep 3, 2014 at 2:22 PM, Jamal Hadi Salim wrote: > On 09/03/14 14:41, Pravin Shelar wrote: >> >> On Wed, Sep 3, 2014 at 2:24 AM, Jiri Pirko wrote: > > >> HW offload API should be separate from OVS module. > > > The above part i agree with. Infact it is very odd that it seems > hard to get

Re: [ovs-dev] [patch net-next 01/13] openvswitch: split flow structures into ovs specific and generic ones

2014-09-03 Thread Jamal Hadi Salim
On 09/03/14 14:41, Pravin Shelar wrote: On Wed, Sep 3, 2014 at 2:24 AM, Jiri Pirko wrote: HW offload API should be separate from OVS module. The above part i agree with. Infact it is very odd that it seems hard to get this point across ;-> This has following advantages. 1. It can be manag

Re: [ovs-dev] [patch net-next 01/13] openvswitch: split flow structures into ovs specific and generic ones

2014-09-03 Thread Jamal Hadi Salim
On 09/03/14 11:20, John Fastabend wrote: Also I have some filters that can match on offset/length/mask tuples. As far as I can tell this is going to have to be yet another interface? Or would it be worth the effort to define the flow key more generically. My initial guess is I'll just write a se

Re: [ovs-dev] [patch net-next 01/13] openvswitch: split flow structures into ovs specific and generic ones

2014-09-03 Thread Pravin Shelar
On Wed, Sep 3, 2014 at 8:20 AM, John Fastabend wrote: > On 09/03/2014 02:24 AM, Jiri Pirko wrote: >> >> After this, flow related structures can be used in other code. >> >> Signed-off-by: Jiri Pirko >> --- > > > Hi Jiri, > > As I indicated before I'm looking into integrating this with some > hard

Re: [ovs-dev] [patch net-next 01/13] openvswitch: split flow structures into ovs specific and generic ones

2014-09-03 Thread Pravin Shelar
On Wed, Sep 3, 2014 at 2:24 AM, Jiri Pirko wrote: > After this, flow related structures can be used in other code. > > Signed-off-by: Jiri Pirko > --- > include/net/sw_flow.h | 99 ++ > net/openvswitch/actions.c | 3 +- > net/openvswitch/datapath.

Re: [ovs-dev] [patch net-next 01/13] openvswitch: split flow structures into ovs specific and generic ones

2014-09-03 Thread John Fastabend
On 09/03/2014 02:24 AM, Jiri Pirko wrote: After this, flow related structures can be used in other code. Signed-off-by: Jiri Pirko --- Hi Jiri, As I indicated before I'm looking into integrating this with some hardware here. Progress is a bit slow but starting to look at it.The i40e/ixgbe dr