This function doesn't modify its 'dst_table' parameter, so it might as well
be marked const.
Signed-off-by: Ben Pfaff
---
lib/ovsdb-idl-provider.h | 2 +-
lib/ovsdb-idl.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/ovsdb-idl-provider.h
Some upcoming tests will add extra trickiness to the IDL internal graph.
This worries me, because the IDL doesn't have any checks for its graph
consistency. This commit adds some.
Signed-off-by: Ben Pfaff
---
lib/ovsdb-idl.c| 122
I wrote this code and if I have to rediscover how it works, it's time to
improve the commnts.
Signed-off-by: Ben Pfaff
---
lib/ovsdb-idl-provider.h | 36
lib/ovsdb-idl.c | 4 ++--
2 files changed, 38 insertions(+), 2 deletions(-)
I noticed that there were lots of calls to ovsdb_datum_sort_unique() from
"set" functions in generated IDL code. This moves that call into common
code, reducing redundancy.
There are more calls to the same function that are a little harder to
remove.
Signed-off-by: Ben Pfaff
---
The "sparse" checker used to warn about sizeof(bool). These days, it does
not warn (without -Wsizeof-bool), so remove this ugly special case.
If you have a version of "sparse" that still warns by default, please
upgrade to a version that includes commit 2667c2d4ab33 (sparse: Allow
override of
Signed-off-by: Ben Pfaff
---
lib/ovsdb-idl.c | 36 +++-
1 file changed, 19 insertions(+), 17 deletions(-)
diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c
index 3dbf0f7..ffee4b6 100644
--- a/lib/ovsdb-idl.c
+++ b/lib/ovsdb-idl.c
@@ -3080,23 +3080,6 @@
There were lots of bits of code emitting "assert(inited);". This combines
many of them.
Signed-off-by: Ben Pfaff
---
ovsdb/ovsdb-idlc.in | 33 -
1 file changed, 12 insertions(+), 21 deletions(-)
diff --git a/ovsdb/ovsdb-idlc.in
This changes several instances of
size_t i;
for (i = 0; i < ...; i++)
into:
for (size_t i = 0; i < ...; i++)
in generated code, making it slightly more compact and easier to read.
Signed-off-by: Ben Pfaff
---
ovsdb/ovsdb-idlc.in | 19 +--
1 file
Signed-off-by: Ben Pfaff
---
ovn/controller-vtep/ovn-controller-vtep.c | 3 --
ovn/controller/ovn-controller.c | 3 --
ovn/northd/ovn-northd.c | 3 --
ovn/utilities/ovn-nbctl.c | 1 -
ovn/utilities/ovn-sbctl.c | 1 -
This switches from code that looks like:
if (keyRow) {
...
}
to:
if (!keyRow) {
continue;
}
...
which is a little easier to generate because the indentation of ... is
constant.
Signed-off-by: Ben Pfaff
---
ovsdb/ovsdb-idlc.in | 42
This replaces _table_classes[OVSREC_TABLE_OPEN_VSWITCH] by the
easier to read and equivalent _table_open_vswitch in generated code.
Signed-off-by: Ben Pfaff
---
ovsdb/ovsdb-idlc.in | 57 +++--
1 file changed, 29 insertions(+), 28
This replaces ovsrec_open_vswitch_columns[OVSREC_OPEN_VSWITCH_COL_CUR_CFG]
by the easier to read and equivalent ovsrec_open_vswitch_col_cur_cfg in
generated code.
Signed-off-by: Ben Pfaff
---
ovsdb/ovsdb-idlc.in | 66 +++--
1 file
There's no reason to have three copies of this code for every smap-type
column.
The code wasn't a perfect match for ovsdb_datum_from_smap(), so this commit
also changes ovsdb_datum_from_smap() to better suit it. It only had one
caller and the new design is adequate for that caller.
Signed-off-by: Ben Pfaff
---
ovsdb/ovsdb-idlc.in | 37 -
1 file changed, 20 insertions(+), 17 deletions(-)
diff --git a/ovsdb/ovsdb-idlc.in b/ovsdb/ovsdb-idlc.in
index 2900bd9..0031636 100755
--- a/ovsdb/ovsdb-idlc.in
+++ b/ovsdb/ovsdb-idlc.in
Signed-off-by: Ben Pfaff
---
ovsdb/ovsdb-idlc.1 | 5 -
ovsdb/ovsdb-idlc.in | 1 -
2 files changed, 6 deletions(-)
diff --git a/ovsdb/ovsdb-idlc.1 b/ovsdb/ovsdb-idlc.1
index 4a33261..b44757b 100644
--- a/ovsdb/ovsdb-idlc.1
+++ b/ovsdb/ovsdb-idlc.1
@@ -56,11 +56,6 @@ defines a
At an early point in OVS development, OVS was built with fixed default
directories for pidfiles and sockets. This meant that it was necessary to
use lots of --pidfile and --unixctl options in the testsuite, to point the
daemons to where they should put these files (since the testsuite cannot
and
On Thu, Oct 06, 2016 at 11:33:39AM +0900, Joe Stringer wrote:
> This warning breaks the build on travis:
> lib/json.c:1627:12: error: symbol 'chars_escaping' was not declared.
> Should it be static?
>
> CC: Esteban Rodriguez Betancourt
> Reported-At:
This warning breaks the build on travis:
lib/json.c:1627:12: error: symbol 'chars_escaping' was not declared.
Should it be static?
CC: Esteban Rodriguez Betancourt
Reported-At: https://travis-ci.org/openvswitch/ovs/jobs/165300417
Fixes: 644ecb10a661 ("json: Serialize strings
On 27 September 2016 at 21:45, Paul Blakey wrote:
> Openvswitch currently configures the kerenel datapath via netlink over an
> internal ovs protocol.
>
> This patch series offers a new provider: dpif-netlink-tc that uses the tc
> flower protocol
> to offload ovs rules into
"dev" wrote on 10/05/2016 01:19:34 PM:
> From: Ryan Moats/Omaha/IBM@IBMUS
> To: Ben Pfaff
> Cc: dev@openvswitch.org
> Date: 10/05/2016 01:20 PM
> Subject: Re: [ovs-dev] [ovs-dev,v2,2/4] ovn-controller: add quiet mode
> Sent by: "dev"
ovs_idl_txn is checked before various routines (like patch_run) execute.
However, flow calculation and installation does not also check this
variable, which can lead to oscillations as described in [1].
[1] http://openvswitch.org/pipermail/dev/2016-October/080247.html
Signed-off-by: Ryan Moats
When I ran "make check-valgrind -j10" and the testsuite needed to be
rebuilt, two copies of it were rebuilt in parallel and sometimes they
raced with each other. I don't have the full story on exactly why this
happened, but this commit, which eliminates redundant dependencies from
check-*
ip4.dst implies ip, udp.dst implies udp, and tcp.dst implies tcp.
Signed-off-by: Ben Pfaff
---
ovn/northd/ovn-northd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
index 4668d9e..9bb49e8 100644
---
AT_KEYWORDS are mostly there to make it easier to find the tests you're
looking for. One might, for example, mark tests as "positive" or
"negative" so you can select the tests you want to run on that basis.
They're also useful for cases where Autotest just isn't good at splitting
words: for
Signed-off-by: Ben Pfaff
---
tests/ovn-sbctl.at | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/tests/ovn-sbctl.at b/tests/ovn-sbctl.at
index 9393eef..26b05af 100644
--- a/tests/ovn-sbctl.at
+++ b/tests/ovn-sbctl.at
@@ -87,6 +87,7 @@
This fixes a few races for port bindings appearing and being bound to
a chassis. The ones changed to use "ovn-sbctl wait-until" were previously
only waiting until a Port_Binding record appeared (created by ovn-northd),
but not until the Port_Binding record's 'chassis' column was set (by
After setting the subnet, ovn-northd needs to process the changes before
setting the dynamic addresses.
Signed-off-by: Ben Pfaff
---
tests/ovn.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/ovn.at b/tests/ovn.at
index 9baa1df..c4a600a 100644
---
A number of instances of "{i}" in this test should have been "${i}".
Signed-off-by: Ben Pfaff
---
tests/ovn.at | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tests/ovn.at b/tests/ovn.at
index 05e1349..4214a00 100644
--- a/tests/ovn.at
+++
It can take a way for dynamic addresses to propagate through ovn-northd,
so wait for it to happen.
Signed-off-by: Ben Pfaff
---
tests/ovn.at | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/tests/ovn.at b/tests/ovn.at
index 4214a00..9baa1df 100644
The test assumed that ovn-northd could delete the MAC_Binding rows
instantly, but it may take a while.
Signed-off-by: Ben Pfaff
---
tests/ovn.at | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/tests/ovn.at b/tests/ovn.at
index 948716b..05e1349 100644
This e-mail is a duplicate - ignore
On Wed, Oct 5, 2016 at 6:06 PM, Darrell Ball wrote:
> There has been enough confusion regarding logical switch datapath
> arp responders in ovn to warrant some additional comments;
> hence add a general description regarding why they exist
There has been enough confusion regarding logical switch datapath
arp responders in ovn to warrant some additional comments;
hence add a general description regarding why they exist and
document the special cases.
Signed-off-by: Darrell Ball
---
ovn/northd/ovn-northd.8.xml |
There has been enough confusion regarding logical switch datapath
arp responders in ovn to warrant some additional comments;
hence add a general description regarding why they exist and
document the special cases.
Signed-off-by: Darrell Ball
---
Note this patch is meant to be
On Wed, Oct 05, 2016 at 04:20:45AM -0700, nickcooper-zhangtonghao wrote:
> Signed-off-by: nickcooper-zhangtonghao
>
Thanks for pointing out the omission. I ended up doing significant
further work here. I applied the following final patch.
On Wed, Oct 05, 2016 at 04:20:44AM -0700, nickcooper-zhangtonghao wrote:
> Signed-off-by: nickcooper-zhangtonghao
>
Thanks, applied to master.
___
dev mailing list
dev@openvswitch.org
On Wed, Oct 05, 2016 at 04:20:43AM -0700, nickcooper-zhangtonghao wrote:
> The command "ovn-nbctl lrp-add" should not set the MAC address
> which length is invalid to logical router port. This patch
> updates the eth_addr_from_string() to check trailing characters.
> We should use the ovs_scan()
On Wed, Oct 05, 2016 at 04:20:42AM -0700, nickcooper-zhangtonghao wrote:
> Fixes: 8639f9be("ovn-northd, tests: Adding IPAM to ovn-northd.")
> The IPAM tests began to fail occasionally. Adding --wait=sb
> to commands triggering address allocation eliminated these failures.
>
> Signed-off-by:
On Wed, Oct 05, 2016 at 01:57:47PM +0530, bscha...@redhat.com wrote:
> From: Babu Shanmugam
>
> This patch adds support for marking qos on IP packets based on arbitrary
> match criteria for a logical switch.
>
> Signed-off-by: Babu Shanmugam
>
I made a correction inline
On Tue, Oct 4, 2016 at 10:04 PM, Darrell Ball wrote:
> This patch adds datapaths of interest support where only datapaths of
> local interest are monitored by the ovn-controller ovsdb client. The
> idea is to do a flood fill in ovn-controller of
On Wed, Oct 5, 2016 at 2:37 PM, Mickey Spiegel
wrote:
> On Wed, Oct 5, 2016 at 10:08 AM, Darrell Ball wrote:
>
>> There has been enough confusion regarding logical switch datapath
>> arp responders in ovn to warrant some additional comments;
>> hence add
On Wed, Oct 5, 2016 at 10:08 AM, Darrell Ball wrote:
> There has been enough confusion regarding logical switch datapath
> arp responders in ovn to warrant some additional comments;
> hence add a general description regarding why they exist and
> document the special cases.
>
>
@Switch.c: Modifies OvsActivateSwitch() function
to mark the switch as activated only if the
the status is success. The callers itself
only call this method when the isActivated
flag is unset.
Signed-off-by: Shashank Ram
---
datapath-windows/ovsext/Switch.c | 3 +--
1 file
On 5 October 2016 at 10:44, Ben Pfaff wrote:
> On Tue, Oct 04, 2016 at 09:56:15AM -0700, Gurucharan Shetty wrote:
> > A Container running inside a VM can have a connection to the
> > hosting VM (parent port) in the logical topology (for e.g via a router).
> > So we should be able
A Container running inside a VM can have a connection to the
hosting VM (parent port) in the logical topology (for e.g via a router).
So we should be able to loop-back into the same VM, even if the
final packet delivered does not have any tags in it.
Reported-by: Dustin Spinhirne
On 2016-10-05 17:29, Ben Pfaff wrote:
On Wed, Oct 05, 2016 at 10:05:50AM +, Stephen Finucane wrote:
[snip]
3) Rework docs into a series of guides
I see the following guides as being helpful
- Installation guide
- Usage guide
- Contributor guide
I had a 'testing-guide',
On Tue, Oct 4, 2016 at 1:37 PM, Ben Pfaff wrote:
> On Wed, Sep 28, 2016 at 10:00:19AM +0530, bscha...@redhat.com wrote:
> > v2 -> v3:
> > - Handling few edged cases in the OCF script as suggested by
> > Andrew Beekhof
> >
> > This patch contains changes required to run a
Ben Pfaff wrote on 10/05/2016 01:04:36 PM:
> From: Ben Pfaff
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: dev@openvswitch.org
> Date: 10/05/2016 01:04 PM
> Subject: Re: [ovs-dev,v2,2/4] ovn-controller: add quiet mode
>
> On Wed, Oct 05, 2016 at 12:52:57PM -0500, Ryan Moats
On Wed, Oct 05, 2016 at 12:52:57PM -0500, Ryan Moats wrote:
> Ben Pfaff wrote on 10/05/2016 12:37:26 PM:
>
> > From: Ben Pfaff
> > To: Ryan Moats/Omaha/IBM@IBMUS
> > Cc: dev@openvswitch.org
> > Date: 10/05/2016 12:37 PM
> > Subject: Re: [ovs-dev,v2,2/4]
Ben Pfaff wrote on 10/05/2016 12:37:26 PM:
> From: Ben Pfaff
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: dev@openvswitch.org
> Date: 10/05/2016 12:37 PM
> Subject: Re: [ovs-dev,v2,2/4] ovn-controller: add quiet mode
>
> On Tue, Oct 04, 2016 at 05:11:37PM -0500, Ryan Moats
On Wed, Oct 5, 2016 at 8:58 AM, Ben Pfaff wrote:
> On Wed, Oct 05, 2016 at 05:53:14PM +0300, Or Gerlitz wrote:
>> On 10/5/2016 3:27 AM, Ben Pfaff wrote:
>> >On Tue, Sep 27, 2016 at 03:46:04PM +0300, Paul Blakey wrote:
>> >>>Add tc ingress qdisc support so we can add qdisc
>> >>>as a
On Tue, Oct 04, 2016 at 09:56:15AM -0700, Gurucharan Shetty wrote:
> A Container running inside a VM can have a connection to the
> hosting VM (parent port) in the logical topology (for e.g via a router).
> So we should be able to loop-back into the same VM, even if the
> final packet delivered
On Wed, Oct 05, 2016 at 10:05:50AM +, Stephen Finucane wrote:
> On 2016-10-04 22:01, Ben Pfaff wrote:
> >On Sat, Oct 01, 2016 at 08:01:29PM +0100, Stephen Finucane wrote:
> >>Since the move to GitHub, OVS has increasingly used Markdown for all of
> >>its documentation. This seems like a
On Wed, Oct 05, 2016 at 04:47:21PM +, Rodriguez Betancourt, Esteban wrote:
> The existing implementation uses a switch with
> many conditions, that when compiled is translated
> to a not optimal series of conditional jumps.
>
> With a lookup table the generated code has less conditional
There has been enough confusion regarding logical switch datapath
arp responders in ovn to warrant some additional comments;
hence add a general description regarding why they exist and
document the special cases.
Signed-off-by: Darrell Ball
---
v1->v2: Dropped RFC code change
On Wed, Oct 05, 2016 at 05:50:24PM +0530, Numan Siddique wrote:
> SSL support is added to the ovs/stream.py. pyOpenSSL library is used
> to support SSL. If this library is not present, then the SSL stream
> is not registered with the Stream class.
>
> Signed-off-by: Numan Siddique
The existing implementation uses a switch with
many conditions, that when compiled is translated
to a not optimal series of conditional jumps.
With a lookup table the generated code has less conditional jumps,
that should translate in improving the CPU ability to predict the
jumps.
Performance
On Wed, Oct 05, 2016 at 11:09:39AM -0400, Aaron Conole wrote:
> Ben Pfaff writes:
>
> > On Thu, Sep 08, 2016 at 07:58:21PM +0100, Markos Chandras wrote:
> >> On 09/08/2016 05:50 PM, Aaron Conole wrote:
> >> >
> >> >> It sounds like new feature territory, but you do make a case for
I just noticed this email. It sounds beneficial, but no patch was
included. Do you want to send the patch?
On Wed, Sep 07, 2016 at 08:58:02PM +, Rodriguez Betancourt, Esteban wrote:
> The existing implementation uses a switch with
> many conditions, that when compiled is translated
> to a
On Tue, Oct 04, 2016 at 06:17:08PM -0700, Jarno Rajahalme wrote:
>
> > On Oct 4, 2016, at 2:32 PM, Ben Pfaff wrote:
> >
> > On Fri, Sep 30, 2016 at 11:08:19AM -0700, Jarno Rajahalme wrote:
> >> When deleting a bridge it is currently possible to delete a mater
> >> without deleting
On 4 October 2016 at 16:01, Ben Pfaff wrote:
> Reported-by: Hui Kang
> Signed-off-by: Ben Pfaff
>
Acked-by: Gurucharan Shetty
> ---
> INSTALL.Docker.md | 13 +
> 1 file changed, 13 insertions(+)
>
> diff --git
Thanks!
On Tue, Oct 04, 2016 at 08:38:19PM -0400, Hui Kang wrote:
> I like your version better.
> I am ok abandoning this patch. Thanks.
>
> - Hui
>
> On Tue, Oct 4, 2016 at 7:01 PM, Ben Pfaff wrote:
> > On Tue, Oct 04, 2016 at 04:33:02PM -0400, Hui Kang wrote:
> >>
On Wed, Oct 05, 2016 at 05:53:14PM +0300, Or Gerlitz wrote:
> On 10/5/2016 3:27 AM, Ben Pfaff wrote:
> >On Tue, Sep 27, 2016 at 03:46:04PM +0300, Paul Blakey wrote:
> >>>Add tc ingress qdisc support so we can add qdisc
> >>>as a qos on port or through config.
> >>>usage:
> >>>ovs-vsctl -- set port
On Wed, Oct 05, 2016 at 10:07:59AM +, Stephen Finucane wrote:
> Speaking of licenses, I've included the Apache 2.0 license header at the top
> of all reworked docs. Is this necessary?
I think that it is a good idea to do this. A fair number of projects
use different source and documentation
Ben Pfaff writes:
> On Thu, Sep 08, 2016 at 07:58:21PM +0100, Markos Chandras wrote:
>> On 09/08/2016 05:50 PM, Aaron Conole wrote:
>> >
>> >> It sounds like new feature territory, but you do make a case for
>> > it being considered a set of fixes ...
>> >
>> > I agree - it
As discussed in [1], what the incremental processing code
actually accomplished was that the ovn-controller would
be "quiet" and not burn CPU when things weren't changing.
This patch set recreates this state by calculating whether
changes have occured that would require a full calculation
to be
On 10/5/2016 3:27 AM, Ben Pfaff wrote:
On Tue, Sep 27, 2016 at 03:46:04PM +0300, Paul Blakey wrote:
>Add tc ingress qdisc support so we can add qdisc
>as a qos on port or through config.
>usage:
>ovs-vsctl -- set port qos=@newq -- --id=@newq create \
>qos type=linux-ingress
>where is a
Daniele Di Proietto writes:
> Looks like we forgot to add the copyright headers to netdev-dpdk.h.
> Looking at the contribution history of the file, this commit adds the
> header with Red Hat copyright.
>
> CC: Aaron Conole
> Signed-off-by: Daniele Di
SSL support is added to the ovs/stream.py. pyOpenSSL library is used
to support SSL. If this library is not present, then the SSL stream
is not registered with the Stream class.
Signed-off-by: Numan Siddique
---
python/ovs/poller.py | 8 +
python/ovs/stream.py | 91
The original message was received at Wed, 5 Oct 2016 17:19:44 +0530
from [5.250.163.206]
- The following addresses had permanent fatal errors -
___
dev mailing list
dev@openvswitch.org
Thanks very much.
> On Oct 4, 2016, at 5:12 AM, Guru Shetty wrote:
>
> I applied the patch. For future, when you version, please have some sort of
> versioning information that tells the difference between the versions below
> the "---" line.
Signed-off-by: nickcooper-zhangtonghao
---
ovn/utilities/ovn-nbctl.c | 6 ++
tests/ovn-nbctl.at| 16
2 files changed, 22 insertions(+)
diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c
index 453ff72..572370f
Fixes: 8639f9be("ovn-northd, tests: Adding IPAM to ovn-northd.")
The IPAM tests began to fail occasionally. Adding --wait=sb
to commands triggering address allocation eliminated these failures.
Signed-off-by: nickcooper-zhangtonghao
---
tests/ovn.at | 16
Signed-off-by: nickcooper-zhangtonghao
---
ovn/utilities/ovn-nbctl.8.xml | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/ovn/utilities/ovn-nbctl.8.xml b/ovn/utilities/ovn-nbctl.8.xml
index 7cd515f..70798dc 100644
---
The command "ovn-nbctl lrp-add" should not set the MAC address
which length is invalid to logical router port. This patch
updates the eth_addr_from_string() to check trailing characters.
We should use the ovs_scan() to check the "addresses" owned by
the logical port, instead of
>
>
>
> stderr:
> Traceback (most recent call last):
> File "../../../../tests/test-ovsdb.py", line 835, in
> main(sys.argv)
> File "../../../../tests/test-ovsdb.py", line 830, in main
> func(*args)
> File "../../../../tests/test-ovsdb.py", line 592, in do_idl
> while
On 2016-10-05 00:32, Ben Pfaff wrote:
On Wed, Oct 05, 2016 at 09:25:11AM +0900, Joe Stringer wrote:
On 2 October 2016 at 04:01, Stephen Finucane
wrote:
> This is essentially the output of 'sphinx-quickstart' but with parts of
> the Makefile merged into the existing
On 2016-10-04 22:01, Ben Pfaff wrote:
On Sat, Oct 01, 2016 at 08:01:29PM +0100, Stephen Finucane wrote:
Since the move to GitHub, OVS has increasingly used Markdown for all
of
its documentation. This seems like a natural fit, given Markdown's low
overhead and support in the GitHub web UI.
On Wednesday 05 October 2016 12:05 AM, Ben Pfaff wrote:
On Wed, Sep 07, 2016 at 11:40:12AM +0530,bscha...@redhat.com wrote:
>From: Babu Shanmugam
>
>This patch adds support for marking qos on IP packets based on arbitrary
>match criteria for a logical switch.
>
From: Babu Shanmugam
This patch adds support for marking qos on IP packets based on arbitrary
match criteria for a logical switch.
Signed-off-by: Babu Shanmugam
Suggested-by: Mickey Spiegel
Acked-by: Mickey Spiegel
79 matches
Mail list logo