[ovs-dev] [PATCH 14/15] ovsdb-idl: Mark ovsdb_idl_get_row_arc() parameter const.

2016-10-05 Thread Ben Pfaff
This function doesn't modify its 'dst_table' parameter, so it might as well be marked const. Signed-off-by: Ben Pfaff --- lib/ovsdb-idl-provider.h | 2 +- lib/ovsdb-idl.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ovsdb-idl-provider.h

[ovs-dev] [PATCH 15/15] ovsdb-idl: Check internal graph in OVSDB tests.

2016-10-05 Thread Ben Pfaff
Some upcoming tests will add extra trickiness to the IDL internal graph. This worries me, because the IDL doesn't have any checks for its graph consistency. This commit adds some. Signed-off-by: Ben Pfaff --- lib/ovsdb-idl.c| 122

[ovs-dev] [PATCH 13/15] ovsdb-idl: Add some more implementation comments.

2016-10-05 Thread Ben Pfaff
I wrote this code and if I have to rediscover how it works, it's time to improve the commnts. Signed-off-by: Ben Pfaff --- lib/ovsdb-idl-provider.h | 36 lib/ovsdb-idl.c | 4 ++-- 2 files changed, 38 insertions(+), 2 deletions(-)

[ovs-dev] [PATCH 11/15] ovsdb-idl: Sort and unique-ify datum in ovsdb_idl_txn_write().

2016-10-05 Thread Ben Pfaff
I noticed that there were lots of calls to ovsdb_datum_sort_unique() from "set" functions in generated IDL code. This moves that call into common code, reducing redundancy. There are more calls to the same function that are a little harder to remove. Signed-off-by: Ben Pfaff ---

[ovs-dev] [PATCH 12/15] ovsdb-idlc: Remove special case for "sizeof bool".

2016-10-05 Thread Ben Pfaff
The "sparse" checker used to warn about sizeof(bool). These days, it does not warn (without -Wsizeof-bool), so remove this ugly special case. If you have a version of "sparse" that still warns by default, please upgrade to a version that includes commit 2667c2d4ab33 (sparse: Allow override of

[ovs-dev] [PATCH 10/15] ovsdb-idl: Improve comment on ovsdb_idl_txn_write[_clone]().

2016-10-05 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/ovsdb-idl.c | 36 +++- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c index 3dbf0f7..ffee4b6 100644 --- a/lib/ovsdb-idl.c +++ b/lib/ovsdb-idl.c @@ -3080,23 +3080,6 @@

[ovs-dev] [PATCH 08/15] ovsdb-idlc: Consolidate assertions.

2016-10-05 Thread Ben Pfaff
There were lots of bits of code emitting "assert(inited);". This combines many of them. Signed-off-by: Ben Pfaff --- ovsdb/ovsdb-idlc.in | 33 - 1 file changed, 12 insertions(+), 21 deletions(-) diff --git a/ovsdb/ovsdb-idlc.in

[ovs-dev] [PATCH 07/15] ovsdb-idlc: Declare loop variables in for statements in generated code.

2016-10-05 Thread Ben Pfaff
This changes several instances of size_t i; for (i = 0; i < ...; i++) into: for (size_t i = 0; i < ...; i++) in generated code, making it slightly more compact and easier to read. Signed-off-by: Ben Pfaff --- ovsdb/ovsdb-idlc.in | 19 +-- 1 file

[ovs-dev] [PATCH 09/15] ovsdb-idlc: Eliminate _init() function from generated code.

2016-10-05 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- ovn/controller-vtep/ovn-controller-vtep.c | 3 -- ovn/controller/ovn-controller.c | 3 -- ovn/northd/ovn-northd.c | 3 -- ovn/utilities/ovn-nbctl.c | 1 - ovn/utilities/ovn-sbctl.c | 1 -

[ovs-dev] [PATCH 04/15] ovsdb-idlc: Simplify code generation to parse sets and maps of references.

2016-10-05 Thread Ben Pfaff
This switches from code that looks like: if (keyRow) { ... } to: if (!keyRow) { continue; } ... which is a little easier to generate because the indentation of ... is constant. Signed-off-by: Ben Pfaff --- ovsdb/ovsdb-idlc.in | 42

[ovs-dev] [PATCH 05/15] ovsdb-idlc: Make generated references to table classes easier to read.

2016-10-05 Thread Ben Pfaff
This replaces _table_classes[OVSREC_TABLE_OPEN_VSWITCH] by the easier to read and equivalent _table_open_vswitch in generated code. Signed-off-by: Ben Pfaff --- ovsdb/ovsdb-idlc.in | 57 +++-- 1 file changed, 29 insertions(+), 28

[ovs-dev] [PATCH 06/15] ovsdb-idlc: Make generated references to columns easier to read.

2016-10-05 Thread Ben Pfaff
This replaces ovsrec_open_vswitch_columns[OVSREC_OPEN_VSWITCH_COL_CUR_CFG] by the easier to read and equivalent ovsrec_open_vswitch_col_cur_cfg in generated code. Signed-off-by: Ben Pfaff --- ovsdb/ovsdb-idlc.in | 66 +++-- 1 file

[ovs-dev] [PATCH 01/15] ovsdb-idlc: Use ovsdb_datum_from_smap() instead of open-coding it.

2016-10-05 Thread Ben Pfaff
There's no reason to have three copies of this code for every smap-type column. The code wasn't a perfect match for ovsdb_datum_from_smap(), so this commit also changes ovsdb_datum_from_smap() to better suit it. It only had one caller and the new design is adequate for that caller.

[ovs-dev] [PATCH 03/15] ovsdb-idlc: Factor out sorting columns.

2016-10-05 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- ovsdb/ovsdb-idlc.in | 37 - 1 file changed, 20 insertions(+), 17 deletions(-) diff --git a/ovsdb/ovsdb-idlc.in b/ovsdb/ovsdb-idlc.in index 2900bd9..0031636 100755 --- a/ovsdb/ovsdb-idlc.in +++ b/ovsdb/ovsdb-idlc.in

[ovs-dev] [PATCH 02/15] ovsdb-idlc: Remove obsolete documentation and usage.

2016-10-05 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- ovsdb/ovsdb-idlc.1 | 5 - ovsdb/ovsdb-idlc.in | 1 - 2 files changed, 6 deletions(-) diff --git a/ovsdb/ovsdb-idlc.1 b/ovsdb/ovsdb-idlc.1 index 4a33261..b44757b 100644 --- a/ovsdb/ovsdb-idlc.1 +++ b/ovsdb/ovsdb-idlc.1 @@ -56,11 +56,6 @@ defines a

[ovs-dev] [PATCH] tests: Get rid of overly specific --pidfile and --unixctl options.

2016-10-05 Thread Ben Pfaff
At an early point in OVS development, OVS was built with fixed default directories for pidfiles and sockets. This meant that it was necessary to use lots of --pidfile and --unixctl options in the testsuite, to point the daemons to where they should put these files (since the testsuite cannot and

Re: [ovs-dev] [PATCH] json: Fix non-static json char lookup table.

2016-10-05 Thread Ben Pfaff
On Thu, Oct 06, 2016 at 11:33:39AM +0900, Joe Stringer wrote: > This warning breaks the build on travis: > lib/json.c:1627:12: error: symbol 'chars_escaping' was not declared. > Should it be static? > > CC: Esteban Rodriguez Betancourt > Reported-At:

[ovs-dev] [PATCH] json: Fix non-static json char lookup table.

2016-10-05 Thread Joe Stringer
This warning breaks the build on travis: lib/json.c:1627:12: error: symbol 'chars_escaping' was not declared. Should it be static? CC: Esteban Rodriguez Betancourt Reported-At: https://travis-ci.org/openvswitch/ovs/jobs/165300417 Fixes: 644ecb10a661 ("json: Serialize strings

Re: [ovs-dev] [PATCH ovs RFC 0/9] Introducing HW offload support for openvswitch

2016-10-05 Thread Joe Stringer
On 27 September 2016 at 21:45, Paul Blakey wrote: > Openvswitch currently configures the kerenel datapath via netlink over an > internal ovs protocol. > > This patch series offers a new provider: dpif-netlink-tc that uses the tc > flower protocol > to offload ovs rules into

Re: [ovs-dev] [ovs-dev,v2,2/4] ovn-controller: add quiet mode

2016-10-05 Thread Ryan Moats
"dev" wrote on 10/05/2016 01:19:34 PM: > From: Ryan Moats/Omaha/IBM@IBMUS > To: Ben Pfaff > Cc: dev@openvswitch.org > Date: 10/05/2016 01:20 PM > Subject: Re: [ovs-dev] [ovs-dev,v2,2/4] ovn-controller: add quiet mode > Sent by: "dev"

[ovs-dev] [PATCH] ovn-controller: honor ovs_idl_txn when calculating and installing flows.

2016-10-05 Thread Ryan Moats
ovs_idl_txn is checked before various routines (like patch_run) execute. However, flow calculation and installation does not also check this variable, which can lead to oscillations as described in [1]. [1] http://openvswitch.org/pipermail/dev/2016-October/080247.html Signed-off-by: Ryan Moats

[ovs-dev] [PATCH] tests: Fix double-rebuild of testsuite for "check-valgrind".

2016-10-05 Thread Ben Pfaff
When I ran "make check-valgrind -j10" and the testsuite needed to be rebuilt, two copies of it were rebuilt in parallel and sometimes they raced with each other. I don't have the full story on exactly why this happened, but this commit, which eliminates redundant dependencies from check-*

[ovs-dev] [PATCH] ovn-northd: Drop redundant matching constraints in build_stateful().

2016-10-05 Thread Ben Pfaff
ip4.dst implies ip, udp.dst implies udp, and tcp.dst implies tcp. Signed-off-by: Ben Pfaff --- ovn/northd/ovn-northd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index 4668d9e..9bb49e8 100644 ---

[ovs-dev] [PATCH 7/7] ovn: Remove weird or unneeded keywords from tests.

2016-10-05 Thread Ben Pfaff
AT_KEYWORDS are mostly there to make it easier to find the tests you're looking for. One might, for example, mark tests as "positive" or "negative" so you can select the tests you want to run on that basis. They're also useful for cases where Autotest just isn't good at splitting words: for

[ovs-dev] [PATCH 5/7] ovn: Wait for ovn-northd to catch up in "ovn-sbctl" test.

2016-10-05 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- tests/ovn-sbctl.at | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/ovn-sbctl.at b/tests/ovn-sbctl.at index 9393eef..26b05af 100644 --- a/tests/ovn-sbctl.at +++ b/tests/ovn-sbctl.at @@ -87,6 +87,7 @@

[ovs-dev] [PATCH 6/7] ovn: Fix some races in ovn-controller-vtep tests.

2016-10-05 Thread Ben Pfaff
This fixes a few races for port bindings appearing and being bound to a chassis. The ones changed to use "ovn-sbctl wait-until" were previously only waiting until a Port_Binding record appeared (created by ovn-northd), but not until the Port_Binding record's 'chassis' column was set (by

[ovs-dev] [PATCH 4/7] ovn: Fix race in "ovn -- ipam" test.

2016-10-05 Thread Ben Pfaff
After setting the subnet, ovn-northd needs to process the changes before setting the dynamic addresses. Signed-off-by: Ben Pfaff --- tests/ovn.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ovn.at b/tests/ovn.at index 9baa1df..c4a600a 100644 ---

[ovs-dev] [PATCH 2/7] ovn: Fix bugs in port security test.

2016-10-05 Thread Ben Pfaff
A number of instances of "{i}" in this test should have been "${i}". Signed-off-by: Ben Pfaff --- tests/ovn.at | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index 05e1349..4214a00 100644 --- a/tests/ovn.at +++

[ovs-dev] [PATCH 3/7] ovn: Fix some races in IPAM connectivity test.

2016-10-05 Thread Ben Pfaff
It can take a way for dynamic addresses to propagate through ovn-northd, so wait for it to happen. Signed-off-by: Ben Pfaff --- tests/ovn.at | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index 4214a00..9baa1df 100644

[ovs-dev] [PATCH 1/7] ovn: Fix races in MAC_Binding deletion test.

2016-10-05 Thread Ben Pfaff
The test assumed that ovn-northd could delete the MAC_Binding rows instantly, but it may take a while. Signed-off-by: Ben Pfaff --- tests/ovn.at | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index 948716b..05e1349 100644

Re: [ovs-dev] [patch_v3] ovn: Add additional comments regarding arp responders.

2016-10-05 Thread Darrell Ball
This e-mail is a duplicate - ignore On Wed, Oct 5, 2016 at 6:06 PM, Darrell Ball wrote: > There has been enough confusion regarding logical switch datapath > arp responders in ovn to warrant some additional comments; > hence add a general description regarding why they exist

[ovs-dev] [patch_v3] ovn: Add additional comments regarding arp responders.

2016-10-05 Thread Darrell Ball
There has been enough confusion regarding logical switch datapath arp responders in ovn to warrant some additional comments; hence add a general description regarding why they exist and document the special cases. Signed-off-by: Darrell Ball --- ovn/northd/ovn-northd.8.xml |

[ovs-dev] [CudaMailTagged] [patch_v3] ovn: Add additional comments regarding arp responders.

2016-10-05 Thread Darrell Ball
There has been enough confusion regarding logical switch datapath arp responders in ovn to warrant some additional comments; hence add a general description regarding why they exist and document the special cases. Signed-off-by: Darrell Ball --- Note this patch is meant to be

Re: [ovs-dev] [PATCH 4/4] ovn-nbctl: Improve ovn-nbctl manpage

2016-10-05 Thread Ben Pfaff
On Wed, Oct 05, 2016 at 04:20:45AM -0700, nickcooper-zhangtonghao wrote: > Signed-off-by: nickcooper-zhangtonghao > Thanks for pointing out the omission. I ended up doing significant further work here. I applied the following final patch.

Re: [ovs-dev] [PATCH 3/4] ovn-nbctl: Fix memory leak in nbctl_lr_route_add

2016-10-05 Thread Ben Pfaff
On Wed, Oct 05, 2016 at 04:20:44AM -0700, nickcooper-zhangtonghao wrote: > Signed-off-by: nickcooper-zhangtonghao > Thanks, applied to master. ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] [PATCH 2/4] ovn-nbctl: Check the length of MAC address

2016-10-05 Thread Ben Pfaff
On Wed, Oct 05, 2016 at 04:20:43AM -0700, nickcooper-zhangtonghao wrote: > The command "ovn-nbctl lrp-add" should not set the MAC address > which length is invalid to logical router port. This patch > updates the eth_addr_from_string() to check trailing characters. > We should use the ovs_scan()

Re: [ovs-dev] [PATCH 1/4] ovn: make ipam tests more reliable

2016-10-05 Thread Ben Pfaff
On Wed, Oct 05, 2016 at 04:20:42AM -0700, nickcooper-zhangtonghao wrote: > Fixes: 8639f9be("ovn-northd, tests: Adding IPAM to ovn-northd.") > The IPAM tests began to fail occasionally. Adding --wait=sb > to commands triggering address allocation eliminated these failures. > > Signed-off-by:

Re: [ovs-dev] [PACTCH v14] DSCP marking on packets

2016-10-05 Thread Ben Pfaff
On Wed, Oct 05, 2016 at 01:57:47PM +0530, bscha...@redhat.com wrote: > From: Babu Shanmugam > > This patch adds support for marking qos on IP packets based on arbitrary > match criteria for a logical switch. > > Signed-off-by: Babu Shanmugam >

Re: [ovs-dev] [patch_v5] ovn: Add datapaths of interest filtering.

2016-10-05 Thread Darrell Ball
I made a correction inline On Tue, Oct 4, 2016 at 10:04 PM, Darrell Ball wrote: > This patch adds datapaths of interest support where only datapaths of > local interest are monitored by the ovn-controller ovsdb client. The > idea is to do a flood fill in ovn-controller of

Re: [ovs-dev] [patch_v2] ovn: Add additional comments regarding arp responders.

2016-10-05 Thread Darrell Ball
On Wed, Oct 5, 2016 at 2:37 PM, Mickey Spiegel wrote: > On Wed, Oct 5, 2016 at 10:08 AM, Darrell Ball wrote: > >> There has been enough confusion regarding logical switch datapath >> arp responders in ovn to warrant some additional comments; >> hence add

Re: [ovs-dev] [patch_v2] ovn: Add additional comments regarding arp responders.

2016-10-05 Thread Mickey Spiegel
On Wed, Oct 5, 2016 at 10:08 AM, Darrell Ball wrote: > There has been enough confusion regarding logical switch datapath > arp responders in ovn to warrant some additional comments; > hence add a general description regarding why they exist and > document the special cases. > >

[ovs-dev] [PATCH] datapath_windows: Set isActivated flag only on success

2016-10-05 Thread Shashank Ram
@Switch.c: Modifies OvsActivateSwitch() function to mark the switch as activated only if the the status is success. The callers itself only call this method when the isActivated flag is unset. Signed-off-by: Shashank Ram --- datapath-windows/ovsext/Switch.c | 3 +-- 1 file

Re: [ovs-dev] [PATCH] ovn-controller: Container can have connection to a hosting VM.

2016-10-05 Thread Guru Shetty
On 5 October 2016 at 10:44, Ben Pfaff wrote: > On Tue, Oct 04, 2016 at 09:56:15AM -0700, Gurucharan Shetty wrote: > > A Container running inside a VM can have a connection to the > > hosting VM (parent port) in the logical topology (for e.g via a router). > > So we should be able

[ovs-dev] [PATCH v2] ovn-controller: Container can have connection to a hosting VM.

2016-10-05 Thread Gurucharan Shetty
A Container running inside a VM can have a connection to the hosting VM (parent port) in the logical topology (for e.g via a router). So we should be able to loop-back into the same VM, even if the final packet delivered does not have any tags in it. Reported-by: Dustin Spinhirne

Re: [ovs-dev] [RFC 0/5] Integrate Sphinx documentation generator

2016-10-05 Thread Stephen Finucane
On 2016-10-05 17:29, Ben Pfaff wrote: On Wed, Oct 05, 2016 at 10:05:50AM +, Stephen Finucane wrote: [snip] 3) Rework docs into a series of guides I see the following guides as being helpful - Installation guide - Usage guide - Contributor guide I had a 'testing-guide',

Re: [ovs-dev] [PATCH v3 0/4] High availability support for OVN DB servers using pacemaker

2016-10-05 Thread Andy Zhou
On Tue, Oct 4, 2016 at 1:37 PM, Ben Pfaff wrote: > On Wed, Sep 28, 2016 at 10:00:19AM +0530, bscha...@redhat.com wrote: > > v2 -> v3: > > - Handling few edged cases in the OCF script as suggested by > > Andrew Beekhof > > > > This patch contains changes required to run a

Re: [ovs-dev] [ovs-dev,v2,2/4] ovn-controller: add quiet mode

2016-10-05 Thread Ryan Moats
Ben Pfaff wrote on 10/05/2016 01:04:36 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 10/05/2016 01:04 PM > Subject: Re: [ovs-dev,v2,2/4] ovn-controller: add quiet mode > > On Wed, Oct 05, 2016 at 12:52:57PM -0500, Ryan Moats

Re: [ovs-dev] [ovs-dev,v2,2/4] ovn-controller: add quiet mode

2016-10-05 Thread Ben Pfaff
On Wed, Oct 05, 2016 at 12:52:57PM -0500, Ryan Moats wrote: > Ben Pfaff wrote on 10/05/2016 12:37:26 PM: > > > From: Ben Pfaff > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: dev@openvswitch.org > > Date: 10/05/2016 12:37 PM > > Subject: Re: [ovs-dev,v2,2/4]

Re: [ovs-dev] [ovs-dev,v2,2/4] ovn-controller: add quiet mode

2016-10-05 Thread Ryan Moats
Ben Pfaff wrote on 10/05/2016 12:37:26 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 10/05/2016 12:37 PM > Subject: Re: [ovs-dev,v2,2/4] ovn-controller: add quiet mode > > On Tue, Oct 04, 2016 at 05:11:37PM -0500, Ryan Moats

Re: [ovs-dev] [PATCH ovs RFC 9/9] netdev-linux: add tc ingress qdisc support

2016-10-05 Thread Pravin Shelar
On Wed, Oct 5, 2016 at 8:58 AM, Ben Pfaff wrote: > On Wed, Oct 05, 2016 at 05:53:14PM +0300, Or Gerlitz wrote: >> On 10/5/2016 3:27 AM, Ben Pfaff wrote: >> >On Tue, Sep 27, 2016 at 03:46:04PM +0300, Paul Blakey wrote: >> >>>Add tc ingress qdisc support so we can add qdisc >> >>>as a

Re: [ovs-dev] [PATCH] ovn-controller: Container can have connection to a hosting VM.

2016-10-05 Thread Ben Pfaff
On Tue, Oct 04, 2016 at 09:56:15AM -0700, Gurucharan Shetty wrote: > A Container running inside a VM can have a connection to the > hosting VM (parent port) in the logical topology (for e.g via a router). > So we should be able to loop-back into the same VM, even if the > final packet delivered

Re: [ovs-dev] [RFC 0/5] Integrate Sphinx documentation generator

2016-10-05 Thread Ben Pfaff
On Wed, Oct 05, 2016 at 10:05:50AM +, Stephen Finucane wrote: > On 2016-10-04 22:01, Ben Pfaff wrote: > >On Sat, Oct 01, 2016 at 08:01:29PM +0100, Stephen Finucane wrote: > >>Since the move to GitHub, OVS has increasingly used Markdown for all of > >>its documentation. This seems like a

Re: [ovs-dev] [PATCH v2 1/1] json: Serialize strings using a lookup table

2016-10-05 Thread Ben Pfaff
On Wed, Oct 05, 2016 at 04:47:21PM +, Rodriguez Betancourt, Esteban wrote: > The existing implementation uses a switch with > many conditions, that when compiled is translated > to a not optimal series of conditional jumps. > > With a lookup table the generated code has less conditional

[ovs-dev] [patch_v2] ovn: Add additional comments regarding arp responders.

2016-10-05 Thread Darrell Ball
There has been enough confusion regarding logical switch datapath arp responders in ovn to warrant some additional comments; hence add a general description regarding why they exist and document the special cases. Signed-off-by: Darrell Ball --- v1->v2: Dropped RFC code change

Re: [ovs-dev] [PATCH v2] python: Add SSL support to the python ovs client library

2016-10-05 Thread Ben Pfaff
On Wed, Oct 05, 2016 at 05:50:24PM +0530, Numan Siddique wrote: > SSL support is added to the ovs/stream.py. pyOpenSSL library is used > to support SSL. If this library is not present, then the SSL stream > is not registered with the Stream class. > > Signed-off-by: Numan Siddique

[ovs-dev] [PATCH v2 1/1] json: Serialize strings using a lookup table

2016-10-05 Thread Rodriguez Betancourt, Esteban
The existing implementation uses a switch with many conditions, that when compiled is translated to a not optimal series of conditional jumps. With a lookup table the generated code has less conditional jumps, that should translate in improving the CPU ability to predict the jumps. Performance

Re: [ovs-dev] [Backport Request] For branch-2.5, backport rhel-systemd integration

2016-10-05 Thread Ben Pfaff
On Wed, Oct 05, 2016 at 11:09:39AM -0400, Aaron Conole wrote: > Ben Pfaff writes: > > > On Thu, Sep 08, 2016 at 07:58:21PM +0100, Markos Chandras wrote: > >> On 09/08/2016 05:50 PM, Aaron Conole wrote: > >> > > >> >> It sounds like new feature territory, but you do make a case for

Re: [ovs-dev] json: Serialize strings using a lookup table

2016-10-05 Thread Ben Pfaff
I just noticed this email. It sounds beneficial, but no patch was included. Do you want to send the patch? On Wed, Sep 07, 2016 at 08:58:02PM +, Rodriguez Betancourt, Esteban wrote: > The existing implementation uses a switch with > many conditions, that when compiled is translated > to a

Re: [ovs-dev] [PATCH] ofproto: Always delete rules before deleting a meter.

2016-10-05 Thread Ben Pfaff
On Tue, Oct 04, 2016 at 06:17:08PM -0700, Jarno Rajahalme wrote: > > > On Oct 4, 2016, at 2:32 PM, Ben Pfaff wrote: > > > > On Fri, Sep 30, 2016 at 11:08:19AM -0700, Jarno Rajahalme wrote: > >> When deleting a bridge it is currently possible to delete a mater > >> without deleting

Re: [ovs-dev] [PATCH] INSTALL.Docker: Explain how to set up a system-id.

2016-10-05 Thread Guru Shetty
On 4 October 2016 at 16:01, Ben Pfaff wrote: > Reported-by: Hui Kang > Signed-off-by: Ben Pfaff > Acked-by: Gurucharan Shetty > --- > INSTALL.Docker.md | 13 + > 1 file changed, 13 insertions(+) > > diff --git

Re: [ovs-dev] [PATCH v2] Fix missing system-id in INSTALL.Docker

2016-10-05 Thread Ben Pfaff
Thanks! On Tue, Oct 04, 2016 at 08:38:19PM -0400, Hui Kang wrote: > I like your version better. > I am ok abandoning this patch. Thanks. > > - Hui > > On Tue, Oct 4, 2016 at 7:01 PM, Ben Pfaff wrote: > > On Tue, Oct 04, 2016 at 04:33:02PM -0400, Hui Kang wrote: > >>

Re: [ovs-dev] [PATCH ovs RFC 9/9] netdev-linux: add tc ingress qdisc support

2016-10-05 Thread Ben Pfaff
On Wed, Oct 05, 2016 at 05:53:14PM +0300, Or Gerlitz wrote: > On 10/5/2016 3:27 AM, Ben Pfaff wrote: > >On Tue, Sep 27, 2016 at 03:46:04PM +0300, Paul Blakey wrote: > >>>Add tc ingress qdisc support so we can add qdisc > >>>as a qos on port or through config. > >>>usage: > >>>ovs-vsctl -- set port

Re: [ovs-dev] [RFC 1/5] Add initial sphinx configuration

2016-10-05 Thread Ben Pfaff
On Wed, Oct 05, 2016 at 10:07:59AM +, Stephen Finucane wrote: > Speaking of licenses, I've included the Apache 2.0 license header at the top > of all reworked docs. Is this necessary? I think that it is a good idea to do this. A fair number of projects use different source and documentation

Re: [ovs-dev] [Backport Request] For branch-2.5, backport rhel-systemd integration

2016-10-05 Thread Aaron Conole
Ben Pfaff writes: > On Thu, Sep 08, 2016 at 07:58:21PM +0100, Markos Chandras wrote: >> On 09/08/2016 05:50 PM, Aaron Conole wrote: >> > >> >> It sounds like new feature territory, but you do make a case for >> > it being considered a set of fixes ... >> > >> > I agree - it

[ovs-dev] [PATCH v3] ovn-controller: add quiet mode

2016-10-05 Thread Ryan Moats
As discussed in [1], what the incremental processing code actually accomplished was that the ovn-controller would be "quiet" and not burn CPU when things weren't changing. This patch set recreates this state by calculating whether changes have occured that would require a full calculation to be

Re: [ovs-dev] [PATCH ovs RFC 9/9] netdev-linux: add tc ingress qdisc support

2016-10-05 Thread Or Gerlitz
On 10/5/2016 3:27 AM, Ben Pfaff wrote: On Tue, Sep 27, 2016 at 03:46:04PM +0300, Paul Blakey wrote: >Add tc ingress qdisc support so we can add qdisc >as a qos on port or through config. >usage: >ovs-vsctl -- set port qos=@newq -- --id=@newq create \ >qos type=linux-ingress >where is a

Re: [ovs-dev] [PATCH 02/13] netdev-nodpdk.c: Add missing copyright.

2016-10-05 Thread Aaron Conole
Daniele Di Proietto writes: > Looks like we forgot to add the copyright headers to netdev-dpdk.h. > Looking at the contribution history of the file, this commit adds the > header with Red Hat copyright. > > CC: Aaron Conole > Signed-off-by: Daniele Di

[ovs-dev] [PATCH v2] python: Add SSL support to the python ovs client library

2016-10-05 Thread Numan Siddique
SSL support is added to the ovs/stream.py. pyOpenSSL library is used to support SSL. If this library is not present, then the SSL stream is not registered with the Stream class. Signed-off-by: Numan Siddique --- python/ovs/poller.py | 8 + python/ovs/stream.py | 91

[ovs-dev] RETURNED MAIL: SEE TRANSCRIPT FOR DETAILS

2016-10-05 Thread MAILER-DAEMON
The original message was received at Wed, 5 Oct 2016 17:19:44 +0530 from [5.250.163.206] - The following addresses had permanent fatal errors - ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] [PATCH v10] ovn-nbctl: Add LB commands.

2016-10-05 Thread nickcooper-zhangtonghao
Thanks very much. > On Oct 4, 2016, at 5:12 AM, Guru Shetty wrote: > > I applied the patch. For future, when you version, please have some sort of > versioning information that tells the difference between the versions below > the "---" line.

[ovs-dev] [PATCH 3/4] ovn-nbctl: Fix memory leak in nbctl_lr_route_add

2016-10-05 Thread nickcooper-zhangtonghao
Signed-off-by: nickcooper-zhangtonghao --- ovn/utilities/ovn-nbctl.c | 6 ++ tests/ovn-nbctl.at| 16 2 files changed, 22 insertions(+) diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c index 453ff72..572370f

[ovs-dev] [PATCH 1/4] ovn: make ipam tests more reliable

2016-10-05 Thread nickcooper-zhangtonghao
Fixes: 8639f9be("ovn-northd, tests: Adding IPAM to ovn-northd.") The IPAM tests began to fail occasionally. Adding --wait=sb to commands triggering address allocation eliminated these failures. Signed-off-by: nickcooper-zhangtonghao --- tests/ovn.at | 16

[ovs-dev] [PATCH 4/4] ovn-nbctl: Improve ovn-nbctl manpage

2016-10-05 Thread nickcooper-zhangtonghao
Signed-off-by: nickcooper-zhangtonghao --- ovn/utilities/ovn-nbctl.8.xml | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/ovn/utilities/ovn-nbctl.8.xml b/ovn/utilities/ovn-nbctl.8.xml index 7cd515f..70798dc 100644 ---

[ovs-dev] [PATCH 2/4] ovn-nbctl: Check the length of MAC address

2016-10-05 Thread nickcooper-zhangtonghao
The command "ovn-nbctl lrp-add" should not set the MAC address which length is invalid to logical router port. This patch updates the eth_addr_from_string() to check trailing characters. We should use the ovs_scan() to check the "addresses" owned by the logical port, instead of

Re: [ovs-dev] [PATCH] python: Add SSL support to the python ovs client library

2016-10-05 Thread Numan Siddique
> > > > stderr: > Traceback (most recent call last): > File "../../../../tests/test-ovsdb.py", line 835, in > main(sys.argv) > File "../../../../tests/test-ovsdb.py", line 830, in main > func(*args) > File "../../../../tests/test-ovsdb.py", line 592, in do_idl > while

Re: [ovs-dev] [RFC 1/5] Add initial sphinx configuration

2016-10-05 Thread Stephen Finucane
On 2016-10-05 00:32, Ben Pfaff wrote: On Wed, Oct 05, 2016 at 09:25:11AM +0900, Joe Stringer wrote: On 2 October 2016 at 04:01, Stephen Finucane wrote: > This is essentially the output of 'sphinx-quickstart' but with parts of > the Makefile merged into the existing

Re: [ovs-dev] [RFC 0/5] Integrate Sphinx documentation generator

2016-10-05 Thread Stephen Finucane
On 2016-10-04 22:01, Ben Pfaff wrote: On Sat, Oct 01, 2016 at 08:01:29PM +0100, Stephen Finucane wrote: Since the move to GitHub, OVS has increasingly used Markdown for all of its documentation. This seems like a natural fit, given Markdown's low overhead and support in the GitHub web UI.

Re: [ovs-dev] [PATCH v13 2/2] DSCP marking on packets

2016-10-05 Thread Babu Shanmugam
On Wednesday 05 October 2016 12:05 AM, Ben Pfaff wrote: On Wed, Sep 07, 2016 at 11:40:12AM +0530,bscha...@redhat.com wrote: >From: Babu Shanmugam > >This patch adds support for marking qos on IP packets based on arbitrary >match criteria for a logical switch. >

[ovs-dev] [PACTCH v14] DSCP marking on packets

2016-10-05 Thread bschanmu
From: Babu Shanmugam This patch adds support for marking qos on IP packets based on arbitrary match criteria for a logical switch. Signed-off-by: Babu Shanmugam Suggested-by: Mickey Spiegel Acked-by: Mickey Spiegel