Re: Backport for OWB 1.7.x

2018-11-05 Thread Romain Manni-Bucau
Ok I get it now, so this is not *this* commit you want but one before - likely https://github.com/apache/openwebbeans/commit/92f94b68ae125d171ac26e6a3cbf26b6a3f54513 - but it was included in the commit you backported ;). makes sense to include that in 1.7 branch IMHO Romain Manni-Bucau

Re: Backport for OWB 1.7.x

2018-11-05 Thread Daniel Cunha
Of course, the issue happening when I'm using JDK11 :) Em seg, 5 de nov de 2018 às 15:33, Daniel Cunha escreveu: > Hi Romain, > > Well... that change make me possible to continue create my singleton > startup like it: > > import javax.annotation.PostConstruct; > import

Re: Backport for OWB 1.7.x

2018-11-05 Thread Daniel Cunha
Hi Romain, Well... that change make me possible to continue create my singleton startup like it: import javax.annotation.PostConstruct; import javax.annotation.PreDestroy; import javax.ejb.Singleton; import javax.ejb.Startup; @Singleton @Startup public class KernelShutdownListener {

Re: Backport for OWB 1.7.x

2018-11-05 Thread Romain Manni-Bucau
Hi Daniel, Do you know which part implies the "need", this commit was not suppose to change anything since the code was already supporting java 11, it was just intended to prepare potential change later on. Did a small change in the behavior was introduced - if so it was not intended from my

Backport for OWB 1.7.x

2018-11-05 Thread Daniel Cunha
Hi Folks, we got an issue with Java 11 and TomEE 7.0.x and we need the backport for it: https://github.com/apache/openwebbeans/pull/13 Please take a look at those changes and let me know what do you think. Thank you. -- Daniel "soro" Cunha https://twitter.com/dvlc_

[GitHub] openwebbeans pull request #13: Backport: extracting unsafe proxy code in an ...

2018-11-05 Thread danielsoro
GitHub user danielsoro opened a pull request: https://github.com/apache/openwebbeans/pull/13 Backport: extracting unsafe proxy code in an Unsafe class - no foncti… …onal change You can merge this pull request into a Git repository by running: $ git pull