Re: Adding Comments To Source Code

@mark: do you still want to run the release? otherwise i will do it tonight, no reason to delay it IMHO Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github

Re: Adding Comments To Source Code

> > We need a release from master before I think then it sounds possible to me. Sounds good to me. Then we can take the master to jakarta.* and pom version to 3.0.0 Side note: our jakarta artifacts run well with CDI SE/notEE 2.0 > certification already but were only tested against javax TCK AFAIK

Re: Adding Comments To Source Code

We need a release from master before I think then it sounds possible to me. Side note: our jakarta artifacts run well with CDI SE/notEE 2.0 certification already but were only tested against javax TCK AFAIK. Le ven. 5 juin 2020 à 15:40, Gurkan Erdogdu a écrit : > OK I agree. > Lets focus on imp

Re: Adding Comments To Source Code

OK I agree. Lets focus on improving the OWB. What is the latest status of TCK covering regarding latest Jakarta EE CDI specification? Also, as I remembered Mark created a branch for Jakarta EE API? Can we migrate those to master? On Fri, Jun 5, 2020 at 4:38 PM Romain Manni-Bucau wrote: > I agre

Re: Adding Comments To Source Code

I agree comments are important but they must not paraphrase the code, look at the two first comments of this commit: https://github.com/apache/openwebbeans/commit/c2b07386e2bd9a702a4fab07696e1a0cdcb792c7#diff-75cef79164caacdbcadbd8e8bcc87c3eR48. I learn that the construct constructs and the init me

Re: Adding Comments To Source Code

I again totally agree with you but think about the others. For example, I may not be clever to understand what the code is doing without any comment. For me, comments are as important as source code. On Fri, Jun 5, 2020 at 4:26 PM Romain Manni-Bucau wrote: > About classloader proxy: > > suspect

Re: Adding Comments To Source Code

About classloader proxy: suspect I can need a more precise request - sadly I wrote this class so I understand it :s. But the only thing in this whole class is putting a proxy class in a map in https://github.com/apache/openwebbeans/blob/master/webbeans-impl/src/main/java/org/apache/webbeans/servic

Re: Adding Comments To Source Code

Also, for how to write comments, please look at Spring or SpringBoot code base. Just an example file : https://github.com/spring-projects/spring-framework/blob/master/spring-beans/src/main/java/org/springframework/beans/BeanUtils.java On Fri, Jun 5, 2020 at 4:09 PM Gurkan Erdogdu wrote: > Look a

Re: Adding Comments To Source Code

Look at https://github.com/apache/openwebbeans/blob/master/webbeans-impl/src/main/java/org/apache/webbeans/service/ClassLoaderProxyService.java On Fri, Jun 5, 2020 at 12:46 PM Mark Struberg wrote: > We intentionally removed comments which do not add any value. > > Just check the history. We de

Re: Adding Comments To Source Code

We intentionally removed comments which do not add any value. Just check the history. We deleted many @inheritdoc without any additional information. Or JavaDoc like /** sets the blablub */ for setBlablub(); It just adds useless lines of code and results in 30% more code one has to parse when r

Re: Adding Comments To Source Code

Hi Gurkan, do you have examples? Personally I'm not a big fan of this kind of comments https://github.com/apache/openwebbeans/blob/91dcbf2484c7da9aeba9a90712a4a16f8438c84f/webbeans-impl/src/main/java/org/apache/webbeans/component/OwbBean.java#L100 It fully paraphrases the method and increase the u

Adding Comments To Source Code

Hi folks I am reviewing the source code, but there are codes without comments in many places. Please can you review the codes and write comments?I know this is boring, but commenting is very important. Otherwise, it is not possible to understand what is going on in your code. Regards. Gurkan