[GitHub] orc pull request #154: ORC-228 Make MemoryManagerImpl.ROWS_BETWEEN_CHECKS co...

2017-08-11 Thread prasanthj
Github user prasanthj commented on a diff in the pull request: https://github.com/apache/orc/pull/154#discussion_r132805602 --- Diff: java/core/src/java/org/apache/orc/impl/MemoryManagerImpl.java --- @@ -81,6 +81,7 @@ public Thread getOwner() { */ public

[GitHub] orc pull request #154: ORC-228 Make MemoryManagerImpl.ROWS_BETWEEN_CHECKS co...

2017-08-11 Thread ekoifman
Github user ekoifman commented on a diff in the pull request: https://github.com/apache/orc/pull/154#discussion_r132804794 --- Diff: java/core/src/java/org/apache/orc/impl/MemoryManagerImpl.java --- @@ -81,6 +81,7 @@ public Thread getOwner() { */ public

[GitHub] orc issue #154: ORC-228 Make MemoryManagerImpl.ROWS_BETWEEN_CHECKS configura...

2017-08-11 Thread ekoifman
Github user ekoifman commented on the issue: https://github.com/apache/orc/pull/154 @prasanthj could you review please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] orc pull request #154: ORC-228 Make MemoryManagerImpl.ROWS_BETWEEN_CHECKS co...

2017-08-11 Thread prasanthj
Github user prasanthj commented on a diff in the pull request: https://github.com/apache/orc/pull/154#discussion_r132804639 --- Diff: java/core/src/java/org/apache/orc/impl/MemoryManagerImpl.java --- @@ -81,6 +81,7 @@ public Thread getOwner() { */ public

[GitHub] orc pull request #154: ORC-228 Make MemoryManagerImpl.ROWS_BETWEEN_CHECKS co...

2017-08-11 Thread ekoifman
GitHub user ekoifman opened a pull request: https://github.com/apache/orc/pull/154 ORC-228 Make MemoryManagerImpl.ROWS_BETWEEN_CHECKS configurable You can merge this pull request into a Git repository by running: $ git pull https://github.com/ekoifman/orc ORC-228

Re: [DISCUSS] ORC 2.0

2017-08-11 Thread Gopal Vijayaraghavan
Hi, > My intention is that we can iterate on the UNSTABLE-PRE-2.0 format without > cross-version compatibility. It will only be used for developer testing. Sounds good - I tested Hive can communicate this to ORC correctly. set hive.exec.orc.write.format="UNSTABLE-PRE-2.0"; offers a very

Re: [DISCUSS] ORC 2.0

2017-08-11 Thread Owen O'Malley
Ok, I created ORC-229 https://issues.apache.org/jira/browse/ORC-229 so that we'll have a new OrcFile.Version of UNSTABLE-PRE-2.0. If you look at the associated pull request, you can see the comments in the code are pretty clear that users should stay away. I also added a logged warning when the

[GitHub] orc pull request #153: ORC-229. Add an UNSTABLE-PRE-2.0 file format version.

2017-08-11 Thread omalley
GitHub user omalley opened a pull request: https://github.com/apache/orc/pull/153 ORC-229. Add an UNSTABLE-PRE-2.0 file format version. You can merge this pull request into a Git repository by running: $ git pull https://github.com/omalley/orc orc-229 Alternatively you can

[GitHub] orc pull request #151: ORC-226 Support getWriterId in c++ reader interface

2017-08-11 Thread omalley
Github user omalley commented on a diff in the pull request: https://github.com/apache/orc/pull/151#discussion_r132734446 --- Diff: c++/include/orc/Reader.hh --- @@ -288,6 +288,17 @@ namespace orc { virtual uint64_t getCompressionSize() const = 0; /** +