Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/orc/pull/233#discussion_r175257375
--- Diff: c++/src/Vector.cc ---
@@ -436,4 +438,8 @@ namespace orc {
+ static_cast(
(data.capacity() + nanoseconds.capacity()) *
Github user stiga-huang commented on a diff in the pull request:
https://github.com/apache/orc/pull/233#discussion_r175257358
--- Diff: c++/src/ColumnPrinter.cc ---
@@ -710,7 +713,10 @@ namespace orc {
writeString(buffer, "null");
} else {
int64_t nano
Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/orc/pull/233#discussion_r175257368
--- Diff: c++/src/ColumnWriter.cc ---
@@ -1194,12 +1194,11 @@ namespace orc {
bool hasNull = false;
for (uint64_t i = 0; i < numValues; ++i) {
Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/orc/pull/233#discussion_r175257109
--- Diff: c++/src/ColumnPrinter.cc ---
@@ -710,7 +713,10 @@ namespace orc {
writeString(buffer, "null");
} else {
int64_t nanos = n
Github user stiga-huang commented on a diff in the pull request:
https://github.com/apache/orc/pull/233#discussion_r175256695
--- Diff: c++/src/Vector.cc ---
@@ -436,4 +438,8 @@ namespace orc {
+ static_cast(
(data.capacity() + nanoseconds.capacity(
Github user stiga-huang commented on a diff in the pull request:
https://github.com/apache/orc/pull/233#discussion_r175256539
--- Diff: c++/src/ColumnWriter.cc ---
@@ -1194,12 +1194,11 @@ namespace orc {
bool hasNull = false;
for (uint64_t i = 0; i < numValues; ++i
Github user stiga-huang commented on a diff in the pull request:
https://github.com/apache/orc/pull/233#discussion_r175256583
--- Diff: c++/src/ColumnWriter.cc ---
@@ -1194,12 +1194,11 @@ namespace orc {
bool hasNull = false;
for (uint64_t i = 0; i < numValues; ++i
Github user stiga-huang commented on a diff in the pull request:
https://github.com/apache/orc/pull/233#discussion_r175256428
--- Diff: c++/src/ColumnPrinter.cc ---
@@ -710,7 +713,10 @@ namespace orc {
writeString(buffer, "null");
} else {
int64_t nano
