guiyanakuang commented on pull request #841:
URL: https://github.com/apache/orc/pull/841#issuecomment-895734124
Thanks for the reviewing and merging! @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dongjoon-hyun merged pull request #843:
URL: https://github.com/apache/orc/pull/843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dongjoon-hyun merged pull request #841:
URL: https://github.com/apache/orc/pull/841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
williamhyun opened a new pull request #843:
URL: https://github.com/apache/orc/pull/843
### What changes were proposed in this pull request?
This PR aims to fix NaN error at orc-tools `meta` command.
### Why are the changes needed?
To fix invalid output
```
$
William Hyun created ORC-929:
Summary: Fix NaN at orc-tools 'meta' command
Key: ORC-929
URL: https://issues.apache.org/jira/browse/ORC-929
Project: ORC
Issue Type: Improvement
With five +1's (three binding) and no -1's the vote passes. I'll publish
the release.
Thank you, Dongjoon, Kyle, William, and Gang for voting.
.. Owen
On Mon, Aug 9, 2021 at 7:41 PM Gang Wu wrote:
> +1.
>
> - Verified checksum and GPG.
> - Built and ran unit tests for both Java and C++.
>
>
+1.
- Verified checksum and GPG.
- Built and ran unit tests for both Java and C++.
Best,
Gang
On Tue, Aug 10, 2021 at 1:31 AM Owen O'Malley
wrote:
> Thanks for the votes, Dongjoon, Kyle, and William!
>
> We need one more PMC vote.
>
> Thanks,
>Owen
>
> On Sat, Aug 7, 2021 at 5:12 PM
guiyanakuang commented on pull request #841:
URL: https://github.com/apache/orc/pull/841#issuecomment-895666127
> Please follow the guideline by using`2-space indentation` in the new file.
>
> * https://orc.apache.org/develop/coding/
>
> ```
> Indentation should be 2
guiyanakuang commented on a change in pull request #841:
URL: https://github.com/apache/orc/pull/841#discussion_r685613269
##
File path:
java/bench/hive/src/java/org/apache/orc/bench/hive/rowfilter/RowFilterInputState.java
##
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache
dongjoon-hyun commented on a change in pull request #841:
URL: https://github.com/apache/orc/pull/841#discussion_r685600601
##
File path:
java/bench/hive/src/java/org/apache/orc/bench/hive/rowfilter/RowFilterInputState.java
##
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache
dongjoon-hyun commented on a change in pull request #841:
URL: https://github.com/apache/orc/pull/841#discussion_r685600498
##
File path:
java/bench/hive/src/java/org/apache/orc/bench/hive/rowfilter/RowFilterInputState.java
##
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache
dongjoon-hyun commented on pull request #841:
URL: https://github.com/apache/orc/pull/841#issuecomment-895629482
No problem, @guiyanakuang . Thank you for updating.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
guiyanakuang commented on pull request #841:
URL: https://github.com/apache/orc/pull/841#issuecomment-895594763
> Thank you for making a PR, @guiyanakuang .
>
> For findbugs `DM_EXIT`, you can add an exclusion like the following.
>
> ```
> $ git grep DM_EXIT
>
dongjoon-hyun commented on pull request #841:
URL: https://github.com/apache/orc/pull/841#issuecomment-895493983
Please try the following, @guiyanakuang .
```
--- a/java/bench/hive/src/findbugs/exclude.xml
+++ b/java/bench/hive/src/findbugs/exclude.xml
@@ -14,7 +14,7 @@
-->
dongjoon-hyun commented on pull request #842:
URL: https://github.com/apache/orc/pull/842#issuecomment-895489931
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dongjoon-hyun commented on pull request #841:
URL: https://github.com/apache/orc/pull/841#issuecomment-895489411
cc @omalley , @pgaref , @williamhyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dependabot[bot] opened a new pull request #842:
URL: https://github.com/apache/orc/pull/842
Bumps [byte-buddy](https://github.com/raphw/byte-buddy) from 1.10.19 to
1.11.12.
Release notes
Sourced from https://github.com/raphw/byte-buddy/releases;>byte-buddy's
releases.
dongjoon-hyun merged pull request #840:
URL: https://github.com/apache/orc/pull/840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Dongjoon Hyun created ORC-928:
-
Summary: Bump checkstyle from 8.44 to 8.45.1
Key: ORC-928
URL: https://issues.apache.org/jira/browse/ORC-928
Project: ORC
Issue Type: Test
Components:
dongjoon-hyun commented on pull request #840:
URL: https://github.com/apache/orc/pull/840#issuecomment-895413040
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Thanks for the votes, Dongjoon, Kyle, and William!
We need one more PMC vote.
Thanks,
Owen
On Sat, Aug 7, 2021 at 5:12 PM William Hyun wrote:
> +1
>
> I tested locally, looks good to me.
>
> Thank you All,
> William
>
> On 2021/08/05 18:11:07, Kyle Bendickson
> wrote:
> > +1 for the
guiyanakuang commented on a change in pull request #841:
URL: https://github.com/apache/orc/pull/841#discussion_r685149454
##
File path:
java/bench/hive/src/java/org/apache/orc/bench/hive/rowfilter/RowFilterInputState.java
##
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache
Yiqun Zhang created ORC-927:
---
Summary: Extracting duplicate codes for RowFilterBenchmark
Key: ORC-927
URL: https://issues.apache.org/jira/browse/ORC-927
Project: ORC
Issue Type: Improvement
guiyanakuang opened a new pull request #841:
URL: https://github.com/apache/orc/pull/841
### What changes were proposed in this pull request?
Create a new class RowFilterInputState to hold duplicate code.
### Why are the changes needed?
Easier to maintain.
dongjoon-hyun commented on pull request #839:
URL: https://github.com/apache/orc/pull/839#issuecomment-895044553
I'll cherry-pick this to branch-1.7 for Apache ORC 1.7.0, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
dongjoon-hyun commented on pull request #838:
URL: https://github.com/apache/orc/pull/838#issuecomment-895043817
For this one, I'll test and cherry-pick to branch-1.7 for Apache ORC 1.7.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
dongjoon-hyun merged pull request #839:
URL: https://github.com/apache/orc/pull/839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dongjoon-hyun merged pull request #838:
URL: https://github.com/apache/orc/pull/838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dongjoon-hyun commented on a change in pull request #838:
URL: https://github.com/apache/orc/pull/838#discussion_r685000544
##
File path: java/core/src/test/org/apache/orc/util/TestOrcUtils.java
##
@@ -42,8 +44,7 @@ public void testBloomFilterIncludeColumns() {
dongjoon-hyun commented on a change in pull request #838:
URL: https://github.com/apache/orc/pull/838#discussion_r684998075
##
File path: java/core/src/test/org/apache/orc/TestTypeDescription.java
##
@@ -269,31 +269,31 @@ public void testBadFindSubtype() {
dongjoon-hyun commented on a change in pull request #838:
URL: https://github.com/apache/orc/pull/838#discussion_r684997268
##
File path: java/core/src/test/org/apache/orc/TestRowFilteringSkip.java
##
@@ -614,10 +614,10 @@ public void testDoubleRoundRobbinRowFilterCallback()
dongjoon-hyun commented on a change in pull request #838:
URL: https://github.com/apache/orc/pull/838#discussion_r684996896
##
File path: java/core/src/test/org/apache/orc/TestRowFilteringSkip.java
##
@@ -172,10 +172,10 @@ public void testDecimalRepeatingFilterCallback()
dependabot[bot] opened a new pull request #840:
URL: https://github.com/apache/orc/pull/840
Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.44 to
8.45.1.
Release notes
Sourced from https://github.com/checkstyle/checkstyle/releases;>checkstyle's
releases.
dongjoon-hyun commented on a change in pull request #838:
URL: https://github.com/apache/orc/pull/838#discussion_r684996028
##
File path: java/core/src/findbugs/exclude.xml
##
@@ -56,4 +56,44 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
dongjoon-hyun merged pull request #837:
URL: https://github.com/apache/orc/pull/837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dongjoon-hyun merged pull request #836:
URL: https://github.com/apache/orc/pull/836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dependabot[bot] commented on pull request #834:
URL: https://github.com/apache/orc/pull/834#issuecomment-895030754
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor
dongjoon-hyun closed pull request #834:
URL: https://github.com/apache/orc/pull/834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dongjoon-hyun commented on pull request #836:
URL: https://github.com/apache/orc/pull/836#issuecomment-895030632
Thank you, @williamhyun !
Merged to main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
39 matches
Mail list logo
