dongjoon-hyun commented on pull request #848:
URL: https://github.com/apache/orc/pull/848#issuecomment-896524268
The changes look feasible. Let's wait and see the CI results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
dongjoon-hyun commented on pull request #847:
URL: https://github.com/apache/orc/pull/847#issuecomment-896510073
You are added to the Apache ORC contributor group and I assigned ORC-933 to
you, @krystalics .
Welcome again!
--
This is an automated message from the Apache Git Service.
dongjoon-hyun merged pull request #847:
URL: https://github.com/apache/orc/pull/847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dongjoon-hyun commented on a change in pull request #847:
URL: https://github.com/apache/orc/pull/847#discussion_r686497550
##
File path: java/examples/src/java/org/apache/orc/examples/AdvancedReader.java
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation
dongjoon-hyun commented on pull request #848:
URL: https://github.com/apache/orc/pull/848#issuecomment-896489481
The error comes here. Let me take a look at this.
-
https://github.com/airlift/aircompressor/blob/master/src/main/java/io/airlift/compress/snappy/UnsafeUtil.java#L52
--
krystalics commented on pull request #847:
URL: https://github.com/apache/orc/pull/847#issuecomment-896489312
> Or, you can do it via Web browser at the following link. Please find and
click `Fetch upstream`.
>
> * https://github.com/krystalics/orc/tree/example-advanced-reader
dongjoon-hyun commented on a change in pull request #847:
URL: https://github.com/apache/orc/pull/847#discussion_r686477128
##
File path: java/examples/src/java/org/apache/orc/examples/AdvancedReader.java
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation
krystalics commented on a change in pull request #847:
URL: https://github.com/apache/orc/pull/847#discussion_r686476960
##
File path: java/examples/src/java/org/apache/orc/examples/AdvancedReader.java
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation
dongjoon-hyun commented on pull request #848:
URL: https://github.com/apache/orc/pull/848#issuecomment-896485275
Oh, interesting. Your PR reveals that our benchmark fails at Java 16+. This
is really an invaluable test coverage!
```
[WARN ] Problem opening checksum file:
krystalics commented on a change in pull request #847:
URL: https://github.com/apache/orc/pull/847#discussion_r686476521
##
File path: java/examples/src/java/org/apache/orc/examples/AdvancedReader.java
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation
dongjoon-hyun edited a comment on pull request #847:
URL: https://github.com/apache/orc/pull/847#issuecomment-896484087
Or, you can do it via Web browser at the following link. Please find and
click `Fetch upstream`.
- https://github.com/krystalics/orc/tree/example-advanced-reader
--
dongjoon-hyun commented on pull request #847:
URL: https://github.com/apache/orc/pull/847#issuecomment-896483712
The branch is still far behind. Please rebase it and force-push it to remove
`java/examples/pom.xml` from this PR.
--
This is an automated message from the Apache Git
krystalics commented on pull request #847:
URL: https://github.com/apache/orc/pull/847#issuecomment-896482903
> In addition, the example is an executable uber jar.
>
> ```
> $ java -jar target/orc-examples-1.8.0-SNAPSHOT-uber.jar
> ORC Java Examples
>
> usage: java -jar
dongjoon-hyun commented on a change in pull request #847:
URL: https://github.com/apache/orc/pull/847#discussion_r686475108
##
File path: java/examples/src/java/org/apache/orc/examples/AdvancedReader.java
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation
williamhyun commented on pull request #848:
URL: https://github.com/apache/orc/pull/848#issuecomment-896478425
cc: @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
williamhyun opened a new pull request #848:
URL: https://github.com/apache/orc/pull/848
### What changes were proposed in this pull request?
This PR aims to add integration tests for Java bench.
### Why are the changes needed?
To prevent further regressions.
William Hyun created ORC-934:
Summary: Add integration tests for Java bench
Key: ORC-934
URL: https://issues.apache.org/jira/browse/ORC-934
Project: ORC
Issue Type: Improvement
krystalics commented on pull request #847:
URL: https://github.com/apache/orc/pull/847#issuecomment-896476663
> In addition, the example is an executable uber jar.
>
> ```
> $ java -jar target/orc-examples-1.8.0-SNAPSHOT-uber.jar
> ORC Java Examples
>
> usage: java -jar
krystalics commented on a change in pull request #847:
URL: https://github.com/apache/orc/pull/847#discussion_r686468179
##
File path: java/examples/pom.xml
##
@@ -50,10 +50,12 @@
org.apache.hadoop
hadoop-common
+ compile
dongjoon-hyun commented on a change in pull request #847:
URL: https://github.com/apache/orc/pull/847#discussion_r686467716
##
File path: java/examples/pom.xml
##
@@ -50,10 +50,12 @@
org.apache.hadoop
hadoop-common
+ compile
dongjoon-hyun commented on pull request #847:
URL: https://github.com/apache/orc/pull/847#issuecomment-896474540
Welcome and no problem at all, @krystalics !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
krystalics commented on a change in pull request #847:
URL: https://github.com/apache/orc/pull/847#discussion_r686466938
##
File path: java/examples/src/java/org/apache/orc/examples/AdvancedReader.java
##
@@ -0,0 +1,71 @@
+package org.apache.orc.examples;
Review comment:
krystalics commented on pull request #847:
URL: https://github.com/apache/orc/pull/847#issuecomment-896474073
> Thank you for making a PR, @krystalics .
thanks to reple me so quickly , it's my first time to involve this project
--
This is an automated message from the Apache Git
dongjoon-hyun commented on a change in pull request #847:
URL: https://github.com/apache/orc/pull/847#discussion_r686466538
##
File path: java/examples/src/java/org/apache/orc/examples/AdvancedReader.java
##
@@ -0,0 +1,71 @@
+package org.apache.orc.examples;
Review comment:
krystalics opened a new pull request #847:
URL: https://github.com/apache/orc/pull/847
### What changes were proposed in this pull request?
the main branch's example module has the AdvancedWriter,but doesn't contain
the match reader,so I complete it.
--
This is an
L-Job created ORC-933:
-
Summary: extend the example with advanced reader
Key: ORC-933
URL: https://issues.apache.org/jira/browse/ORC-933
Project: ORC
Issue Type: Improvement
Reporter: L-Job
dongjoon-hyun commented on pull request #846:
URL: https://github.com/apache/orc/pull/846#issuecomment-896413956
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] opened a new pull request #846:
URL: https://github.com/apache/orc/pull/846
Bumps [jaxb-api](https://github.com/javaee/jaxb-spec) from 2.2.11 to 2.3.1.
Commits
See full diff in https://github.com/javaee/jaxb-spec/commits/2.3.1;>compare view
dongjoon-hyun merged pull request #842:
URL: https://github.com/apache/orc/pull/842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Dongjoon Hyun created ORC-932:
-
Summary: Bump byte-buddy from 1.10.19 to 1.11.12
Key: ORC-932
URL: https://issues.apache.org/jira/browse/ORC-932
Project: ORC
Issue Type: Improvement
dongjoon-hyun commented on pull request #823:
URL: https://github.com/apache/orc/pull/823#issuecomment-896404207
I landed this to branch-1.6, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dongjoon-hyun commented on pull request #843:
URL: https://github.com/apache/orc/pull/843#issuecomment-896400879
I landed this to branch-1.6, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dongjoon-hyun commented on pull request #839:
URL: https://github.com/apache/orc/pull/839#issuecomment-896400756
I landed this to branch-1.6 too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dongjoon-hyun commented on pull request #833:
URL: https://github.com/apache/orc/pull/833#issuecomment-896400649
I backported this to branch-1.6 too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
omalley closed pull request #716:
URL: https://github.com/apache/orc/pull/716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dongjoon-hyun commented on pull request #795:
URL: https://github.com/apache/orc/pull/795#issuecomment-896363150
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dongjoon-hyun commented on pull request #752:
URL: https://github.com/apache/orc/pull/752#issuecomment-896301589
I'll backport this to branch-1.7 for Apache ORC 1.7.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dongjoon-hyun merged pull request #844:
URL: https://github.com/apache/orc/pull/844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dongjoon-hyun commented on pull request #844:
URL: https://github.com/apache/orc/pull/844#issuecomment-896299804
I'll merge this, @pgaref ~ :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dongjoon-hyun merged pull request #845:
URL: https://github.com/apache/orc/pull/845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dongjoon-hyun commented on pull request #844:
URL: https://github.com/apache/orc/pull/844#issuecomment-896214316
I added an empty commit to recover from the data loss during GitHub outage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
dongjoon-hyun commented on pull request #844:
URL: https://github.com/apache/orc/pull/844#issuecomment-896192907
I updated my branch, but it seems that GitHub outage resets the change from
this PR.
- https://github.com/dongjoon-hyun/orc/tree/ORC-930
--
This is an automated message
dongjoon-hyun commented on pull request #844:
URL: https://github.com/apache/orc/pull/844#issuecomment-896121276
Thank you for review, @pgaref !
For the `Scan`, it looks okay to ignore it because the file doesn't exist.
For the `Generator`, I'll try to add a message.
--
This is an
Yiqun Zhang created ORC-931:
---
Summary: Optimize RunLengthIntegerWriterV2 code for better
readability
Key: ORC-931
URL: https://issues.apache.org/jira/browse/ORC-931
Project: ORC
Issue Type:
guiyanakuang opened a new pull request #845:
URL: https://github.com/apache/orc/pull/845
### What changes were proposed in this pull request?
RunLengthIntegerWriterV2.java
512-546 line
```java
if (diffBitsLH > 1) {
for (int i = 0; i < numLiterals; i++) {
Thank you all for moving this forward!
Late +1 from my side -- verified GPG and checksum, built and ran tests for
Java and C++
Cheers,
Panagiotis
On Tue, Aug 10, 2021 at 6:01 AM Owen O'Malley
wrote:
> With five +1's (three binding) and no -1's the vote passes. I'll publish
> the release.
>
>
dongjoon-hyun opened a new pull request #844:
URL: https://github.com/apache/orc/pull/844
### What changes were proposed in this pull request?
This PR aims to ignore unsupported JSON x ZSTD combination in bench.
### Why are the changes needed?
```
$ java -jar
Dongjoon Hyun created ORC-930:
-
Summary: Ignore unsupported JSON x ZSTD combination in bench
Key: ORC-930
URL: https://issues.apache.org/jira/browse/ORC-930
Project: ORC
Issue Type: Improvement
48 matches
Mail list logo
