guiyanakuang commented on pull request #887:
URL: https://github.com/apache/orc/pull/887#issuecomment-907728267
Update C++ improve, please help review code. I don't use C++ much.
@dongjoon-hyun @wgtmac
--
This is an automated message from the Apache Git Service.
To respond to the
dongjoon-hyun commented on pull request #887:
URL: https://github.com/apache/orc/pull/887#issuecomment-907724332
Thank you for updating and considering C++ change together, @guiyanakuang .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
dongjoon-hyun commented on a change in pull request #885:
URL: https://github.com/apache/orc/pull/885#discussion_r697950909
##
File path: java/core/src/java/org/apache/orc/impl/StringRedBlackTree.java
##
@@ -29,49 +30,42 @@
public class StringRedBlackTree extends RedBlackTree
guiyanakuang commented on a change in pull request #886:
URL: https://github.com/apache/orc/pull/886#discussion_r697950740
##
File path: java/core/src/java/org/apache/orc/impl/SerializationUtils.java
##
@@ -270,8 +270,16 @@ public static BigInteger readBigInteger(InputStream
guiyanakuang commented on pull request #887:
URL: https://github.com/apache/orc/pull/887#issuecomment-907723209
> Thank you, @guiyanakuang . In this case, we had batter improve C++ code
together for consistency. Could you update it in this PR?
>
>
guiyanakuang commented on a change in pull request #887:
URL: https://github.com/apache/orc/pull/887#discussion_r697949572
##
File path: java/core/src/java/org/apache/orc/impl/RunLengthIntegerWriterV2.java
##
@@ -545,14 +547,10 @@ private void determineEncoding() {
dongjoon-hyun commented on pull request #887:
URL: https://github.com/apache/orc/pull/887#issuecomment-907722040
cc @pgaref and @williamhyun , too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dongjoon-hyun commented on a change in pull request #887:
URL: https://github.com/apache/orc/pull/887#discussion_r697948360
##
File path: java/core/src/java/org/apache/orc/impl/RunLengthIntegerWriterV2.java
##
@@ -545,14 +547,10 @@ private void determineEncoding() {
dongjoon-hyun commented on a change in pull request #886:
URL: https://github.com/apache/orc/pull/886#discussion_r697947341
##
File path: java/core/src/java/org/apache/orc/impl/SerializationUtils.java
##
@@ -270,8 +270,16 @@ public static BigInteger readBigInteger(InputStream
dongjoon-hyun commented on pull request #884:
URL: https://github.com/apache/orc/pull/884#issuecomment-907719841
Merged to main/1.7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dongjoon-hyun merged pull request #884:
URL: https://github.com/apache/orc/pull/884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dongjoon-hyun merged pull request #754:
URL: https://github.com/apache/orc/pull/754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dongjoon-hyun commented on pull request #754:
URL: https://github.com/apache/orc/pull/754#issuecomment-907719705
Thank you, @belugabehr .
Merged to main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
belugabehr commented on pull request #754:
URL: https://github.com/apache/orc/pull/754#issuecomment-907713847
@dongjoon-hyun I made the change regarding JavaDocs. Please review.
In regards to my comment:
> I actually think this DictionaryUtils class can probably be removed
belugabehr commented on a change in pull request #754:
URL: https://github.com/apache/orc/pull/754#discussion_r697939940
##
File path: java/core/src/java/org/apache/orc/impl/DictionaryUtils.java
##
@@ -46,6 +47,18 @@ public static void getTextInternal(Text result, int
guiyanakuang opened a new pull request #887:
URL: https://github.com/apache/orc/pull/887
### What changes were proposed in this pull request?
```java
private void computeZigZagLiterals() {
// populate zigzag encoded literals
long zzEncVal = 0;
for
Yiqun Zhang created ORC-976:
---
Summary: Optimize compute zigZagLiterals
Key: ORC-976
URL: https://issues.apache.org/jira/browse/ORC-976
Project: ORC
Issue Type: Improvement
Components:
guiyanakuang opened a new pull request #886:
URL: https://github.com/apache/orc/pull/886
### What changes were proposed in this pull request?
```
310 int idx = encodeBitWidth(findClosestNumBits(data[i]));
```
```
public int encodeBitWidth(int n) {
n =
Yiqun Zhang created ORC-975:
---
Summary: Avoid double counting closestFixedBits in percentileBits
method
Key: ORC-975
URL: https://issues.apache.org/jira/browse/ORC-975
Project: ORC
Issue Type:
19 matches
Mail list logo
