belugabehr commented on pull request #754: URL: https://github.com/apache/orc/pull/754#issuecomment-907713847
@dongjoon-hyun I made the change regarding JavaDocs. Please review. In regards to my comment: > I actually think this DictionaryUtils class can probably be removed and roll the functionality into StringHashTable directly. Looking into it a bit more, I think the best thing to do is to create a new data structure that stores the `DynamicByteArray` and its offsets (`DynamicIntArray`). It should govern access and resizing the two as needed. That would remove `DictionaryUtils`, make the methods more unit test-able and remove a bunch of logic from the `StringHashTableDictionary` class that deals with maintenance (like growing the arrays). Alas, I still believe this should be accomplished as a separate issue/task. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
