[GitHub] [orc] guiyanakuang commented on pull request #1003: ORC-1082: Fix code in `FileDump` and `JsonFileDump` commands that determines if column statistics exist

2022-01-09 Thread GitBox
guiyanakuang commented on pull request #1003: URL: https://github.com/apache/orc/pull/1003#issuecomment-1008562661 You are right. Accept criticism :grimacing: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [orc] guiyanakuang commented on pull request #1003: ORC-1082: Fix code in `FileDump` and `JsonFileDump` commands that determines if column statistics exist

2022-01-09 Thread GitBox
guiyanakuang commented on pull request #1003: URL: https://github.com/apache/orc/pull/1003#issuecomment-1008501054 > Thanks. Could you elaborate how to verify your PR in the PR description, @guiyanakuang ? @dongjoon-hyun This can be tested with the following code ```java

[jira] [Created] (ORC-1083) Failed to proune when converting Hybrid calendar to Proleptic calendar

2022-01-09 Thread chong (Jira)
chong created ORC-1083: -- Summary: Failed to proune when converting Hybrid calendar to Proleptic calendar Key: ORC-1083 URL: https://issues.apache.org/jira/browse/ORC-1083 Project: ORC Issue Type: Bug

[GitHub] [orc] guiyanakuang commented on pull request #992: ORC-1075: Fix the issue of failing to read orc file without statistics or missing min/max info in statistics in RowIndex when filter is push

2022-01-09 Thread GitBox
guiyanakuang commented on pull request #992: URL: https://github.com/apache/orc/pull/992#issuecomment-1008304814 > Had the exact same question. Ideally we should be able to write the actual file using a custom unofficial writer to repro the case. Initially I used the user-supplied

[GitHub] [orc] pgaref commented on pull request #992: ORC-1075: Fix the issue of failing to read orc file without statistics or missing min/max info in statistics in RowIndex when filter is pushed dow

2022-01-09 Thread GitBox
pgaref commented on pull request #992: URL: https://github.com/apache/orc/pull/992#issuecomment-1008303115 > BTW, why the new test file is `unofficial` ORC? Which writer is used? > > * `java/core/src/test/resources/unofficial.orc` Had the exact same question. Ideally we should

[GitHub] [orc] pgaref commented on a change in pull request #992: ORC-1075: Fix the issue of failing to read orc file without statistics or missing min/max info in statistics in RowIndex when filter i

2022-01-09 Thread GitBox
pgaref commented on a change in pull request #992: URL: https://github.com/apache/orc/pull/992#discussion_r780784845 ## File path: java/core/src/test/org/apache/orc/impl/TestRecordReaderImpl.java ## @@ -2449,4 +2449,41 @@ public void testSargApplier() throws Exception {

[GitHub] [orc] guiyanakuang commented on a change in pull request #994: ORC-1004: Java ORC writer supports the selection vector

2022-01-09 Thread GitBox
guiyanakuang commented on a change in pull request #994: URL: https://github.com/apache/orc/pull/994#discussion_r780780485 ## File path: java/core/src/test/org/apache/orc/TestSelectedVector.java ## @@ -0,0 +1,527 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [orc] guiyanakuang commented on a change in pull request #994: ORC-1004: Java ORC writer supports the selection vector

2022-01-09 Thread GitBox
guiyanakuang commented on a change in pull request #994: URL: https://github.com/apache/orc/pull/994#discussion_r780778024 ## File path: java/core/src/test/org/apache/orc/TestSelectedVector.java ## @@ -0,0 +1,513 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [orc] guiyanakuang opened a new pull request #1003: Fix code in `FileDump` and `JsonFileDump` commands that determines if column statistics exist

2022-01-09 Thread GitBox
guiyanakuang opened a new pull request #1003: URL: https://github.com/apache/orc/pull/1003 ### What changes were proposed in this pull request? This pr is aims to fixing code in the FileDump and JsonFileDump commands that determines whether a column statistic exists or not.

[jira] [Created] (ORC-1082) FileDump and JsonFileDump do not correctly handle the case where the RowIndex does not have column statistics

2022-01-09 Thread Yiqun Zhang (Jira)
Yiqun Zhang created ORC-1082: Summary: FileDump and JsonFileDump do not correctly handle the case where the RowIndex does not have column statistics Key: ORC-1082 URL: https://issues.apache.org/jira/browse/ORC-1082