+1
Bests,
William
On Sun, Jun 25, 2023 at 10:42 AM Dongjoon Hyun
wrote:
> Thank you all.
>
> If there is no functional issue, I prefer to proceed with 1.9.0 RC0
> and get more feedback.
>
> BTW, I merged ORC-1455 for Apache ORC 1.9.1 (Milestone:
> https://github.com/apache/orc/milestone/22)
>
Thank you all.
If there is no functional issue, I prefer to proceed with 1.9.0 RC0
and get more feedback.
BTW, I merged ORC-1455 for Apache ORC 1.9.1 (Milestone:
https://github.com/apache/orc/milestone/22)
- ORC-1455: [C++] Fix build failure on non-x86 with unused macro in
CpuInfoUtil.cc
+1 (non-binding)
Validated java build, works fine, all tests pass
On Sun, 25 Jun 2023 at 01:52, Yiqun Zhang wrote:
> +1
>
> - Build and test C++/Java on macOS (intel) 13.4.1 with Apple clang 14.0.3
> and openjdk 11.0.19
> - Verified checksum and signature
>
> Bests,
> Yiqun
>
> Shaoyun Chen
+1
- Build and test C++/Java on macOS (intel) 13.4.1 with Apple clang 14.0.3
and openjdk 11.0.19
- Verified checksum and signature
Bests,
Yiqun
Shaoyun Chen 于2023年6月25日周日 16:23写道：
> +1
>
> Both use Apple Clang version 14.0.3[1] and Clang 14.0.6[2] installed
> through brew can build
+1
Both use Apple Clang version 14.0.3[1] and Clang 14.0.6[2] installed
through brew can build successfully.
[1] https://github.com/apache/orc/pull/1551#issuecomment-1605893531
[2] https://github.com/apache/orc/pull/1551#issuecomment-1605920181
Gang Wu 于2023年6月25日周日 16:14写道：
>
> +1
>
> After I
+1
After I tried to enforce clang 14 via env, everything looks good now.
If we are not dropping support of clang 13 or under, we still need
the fix above.
Best,
Gang
On Sun, Jun 25, 2023 at 12:02 PM Gang Wu wrote:
> I use clang 14 on my mac m1.
>
> ➜ clang -v
> Homebrew clang version 14.0.6
>
