belugabehr commented on pull request #754:
URL: https://github.com/apache/orc/pull/754#issuecomment-907713847
@dongjoon-hyun I made the change regarding JavaDocs. Please review.
In regards to my comment:
> I actually think this DictionaryUtils class can probably be removed and
belugabehr commented on pull request #754:
URL: https://github.com/apache/orc/pull/754#issuecomment-906819411
@pgref Thanks for checking out my work. I hope we can move forward with
this PR and any subsequent work can be done in a separate issue.
--
This is an automated message from the
belugabehr commented on pull request #754:
URL: https://github.com/apache/orc/pull/754#issuecomment-902686030
@pgaref @kbendick Care to take a look over once more? Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
belugabehr commented on pull request #754:
URL: https://github.com/apache/orc/pull/754#issuecomment-892712031
@pgaref @kbendick Got the other items merged into the project, so this one
is now ready. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the m
belugabehr commented on pull request #754:
URL: https://github.com/apache/orc/pull/754#issuecomment-892712031
@pgaref @kbendick Got the other items merged into the project, so this one
is now ready. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the m
belugabehr commented on pull request #754:
URL: https://github.com/apache/orc/pull/754#issuecomment-885645517
@pgaref Will do, however, I think it would be better to get #735, #748 in
first since they remove some instances of `Text` and then I can re-work this
one to convert the remaining
belugabehr commented on pull request #754:
URL: https://github.com/apache/orc/pull/754#issuecomment-882593391
Using ByteBuffer here will allow us to remove the `Text` version of this
method in a subsequent release and move the project closer to removing Hadoop
as a dependency (ORC-508)
-
belugabehr commented on pull request #754:
URL: https://github.com/apache/orc/pull/754#issuecomment-882593391
Using ByteBuffer here will allow us to remove the `Text` version of this
method in a subsequent release and move the project closer to removing Hadoop
as a dependency (ORC-508)
-
belugabehr commented on pull request #754:
URL: https://github.com/apache/orc/pull/754#issuecomment-882593391
Using ByteBuffer here will allow us to remove the `Text` version of this
method in a subsequent release and move the project closer to removing Hadoop
as a dependency (ORC-508)
-
