[GitHub] [orc] stiga-huang commented on a change in pull request #1056: ORC-1122: [C++] Add buffer to decode the whole run in RleDecoderV2

2022-03-09 Thread GitBox
stiga-huang commented on a change in pull request #1056: URL: https://github.com/apache/orc/pull/1056#discussion_r822592473 ## File path: c++/src/RleDecoderV2.cc ## @@ -703,80 +680,61 @@ uint64_t RleDecoderV2::nextDelta(int64_t* const data, runLength =

[GitHub] [orc] stiga-huang commented on a change in pull request #1056: ORC-1122: [C++] Add buffer to decode the whole run in RleDecoderV2

2022-03-04 Thread GitBox
stiga-huang commented on a change in pull request #1056: URL: https://github.com/apache/orc/pull/1056#discussion_r820005368 ## File path: c++/src/RLEv2.hh ## @@ -25,6 +25,7 @@ #include +#define MAX_LITERAL_SIZE 512 Review comment: Yeah, so the encoder and the