Github user asfgit closed the pull request at:
https://github.com/apache/orc/pull/277
---
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/277#discussion_r193159979
--- Diff: c++/src/Compression.cc ---
@@ -199,13 +199,16 @@ namespace orc {
uint64_t blockSize,
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/277#discussion_r193106126
--- Diff: c++/test/CMakeLists.txt ---
@@ -64,7 +64,12 @@ target_link_libraries (create-test-files
protobuf
)
-add_test (NAME orc-test COMMA
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/277#discussion_r19313
--- Diff: c++/src/Compression.cc ---
@@ -199,13 +199,16 @@ namespace orc {
uint64_t blockSize,
Memo
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/277#discussion_r192919379
--- Diff: c++/src/TypeImpl.cc ---
@@ -258,31 +258,34 @@ namespace orc {
case STRUCT: {
StructVectorBatch *result = new StructVecto
Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/orc/pull/277#discussion_r192909966
--- Diff: c++/src/TypeImpl.cc ---
@@ -498,54 +506,54 @@ namespace orc {
}
ORC_UNIQUE_PTR Type::buildTypeFromString(const std::string& input)
Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/orc/pull/277#discussion_r192907281
--- Diff: c++/src/TypeImpl.cc ---
@@ -258,31 +258,34 @@ namespace orc {
case STRUCT: {
StructVectorBatch *result = new StructVectorBatch
Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/orc/pull/277#discussion_r192910566
--- Diff: c++/src/Compression.cc ---
@@ -282,6 +285,11 @@ DIAGNOSTIC_PUSH
}
}
+ void ZlibCompressionStream::end() {
+(void)defl
GitHub user majetideepak opened a pull request:
https://github.com/apache/orc/pull/277
ORC-372: Enable valgrind for C++ travis-ci tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/majetideepak/orc ORC-372
Alternatively you c
