Thank you all. The vote passed.
I'll conclude the vote.
On 2023/06/26 08:19:20 deshan xiao wrote:
> +1
>
> Thanks,
> Deshan
>
> On Mon, Jun 26, 2023 at 12:29 PM William H. wrote:
>
> > +1
> >
> > Bests,
> > William
> >
> > On Sun, Jun 25, 2023 at 10:42 AM Dongjoon Hyun
> > wrote:
> >
> > >
+1
Thanks,
Deshan
On Mon, Jun 26, 2023 at 12:29 PM William H. wrote:
> +1
>
> Bests,
> William
>
> On Sun, Jun 25, 2023 at 10:42 AM Dongjoon Hyun
> wrote:
>
> > Thank you all.
> >
> > If there is no functional issue, I prefer to proceed with 1.9.0 RC0
> > and get more feedback.
> >
> > BTW, I
+1
Bests,
William
On Sun, Jun 25, 2023 at 10:42 AM Dongjoon Hyun
wrote:
> Thank you all.
>
> If there is no functional issue, I prefer to proceed with 1.9.0 RC0
> and get more feedback.
>
> BTW, I merged ORC-1455 for Apache ORC 1.9.1 (Milestone:
> https://github.com/apache/orc/milestone/22)
>
Thank you all.
If there is no functional issue, I prefer to proceed with 1.9.0 RC0
and get more feedback.
BTW, I merged ORC-1455 for Apache ORC 1.9.1 (Milestone:
https://github.com/apache/orc/milestone/22)
- ORC-1455: [C++] Fix build failure on non-x86 with unused macro in
CpuInfoUtil.cc
+1 (non-binding)
Validated java build, works fine, all tests pass
On Sun, 25 Jun 2023 at 01:52, Yiqun Zhang wrote:
> +1
>
> - Build and test C++/Java on macOS (intel) 13.4.1 with Apple clang 14.0.3
> and openjdk 11.0.19
> - Verified checksum and signature
>
> Bests,
> Yiqun
>
> Shaoyun Chen
+1
- Build and test C++/Java on macOS (intel) 13.4.1 with Apple clang 14.0.3
and openjdk 11.0.19
- Verified checksum and signature
Bests,
Yiqun
Shaoyun Chen 于2023年6月25日周日 16:23写道：
> +1
>
> Both use Apple Clang version 14.0.3[1] and Clang 14.0.6[2] installed
> through brew can build
+1
Both use Apple Clang version 14.0.3[1] and Clang 14.0.6[2] installed
through brew can build successfully.
[1] https://github.com/apache/orc/pull/1551#issuecomment-1605893531
[2] https://github.com/apache/orc/pull/1551#issuecomment-1605920181
Gang Wu 于2023年6月25日周日 16:14写道：
>
> +1
>
> After I
+1
After I tried to enforce clang 14 via env, everything looks good now.
If we are not dropping support of clang 13 or under, we still need
the fix above.
Best,
Gang
On Sun, Jun 25, 2023 at 12:02 PM Gang Wu wrote:
> I use clang 14 on my mac m1.
>
> ➜ clang -v
> Homebrew clang version 14.0.6
>
I use clang 14 on my mac m1.
➜ clang -v
Homebrew clang version 14.0.6
Target: arm64-apple-darwin21.6.0
Thread model: posix
InstalledDir: /opt/homebrew/opt/llvm@14/bin
I think the issue can only happen on non-x86 machines.
This is the proposed fix: https://github.com/apache/orc/pull/1552
Best
Thank you for testing and sharing.
What is your environment? From 1.9, all docker environements are moved to
at least Clang 14+.
Dongjoon
On Sat, Jun 24, 2023 at 6:40 PM Gang Wu wrote:
> Thanks Dongjoon!
>
> I have verified checksum and signature. And also can confirm that the java
> build
Thanks Dongjoon!
I have verified checksum and signature. And also can confirm that the java
build works as expected.
However, when I tried to run the C++ build, it complains with following
error:
[ 46%] Building CXX object c++/src/CMakeFiles/orc.dir/Common.cc.o
[ 47%] Building CXX object
I'll start with my +1.
RC0 is tested with all test coverages including unit tests, multiple docker
os tests, Spark and Iceberg integration tests. Here is the summary.
https://github.com/apache/orc/issues/1532
Dongjoon.
On Fri, Jun 23, 2023 at 5:47 PM Dongjoon Hyun wrote:
> Please vote on
Please vote on releasing the following candidate as Apache ORC version
1.9.0. This vote is open until June 28th 1AM (PST) and passes if a majority
+1 PMC votes are cast, with a minimum of 3 +1 votes.
[ ] +1 Release this package as Apache ORC 1.9.0
[ ] -1 Do not release this package because ...
13 matches
Mail list logo
