[GitHub] oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-22 Thread GitBox
oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-391059716 @morlovich Ah..I forgot about that backtrace.. To be honest my memory of that is bit blurry right now b

[GitHub] oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-22 Thread GitBox
oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-391053142 Re: "What exactly did you mean by "body content being larger": So sometimes (without the patch ab

[GitHub] oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-22 Thread GitBox
oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-391046316 I've been searching for code that messes up consistency, but no luck so far.. You can see the eff

[GitHub] oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-22 Thread GitBox
oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-390896994 So the following diff helps with the bad content-length and mismatching c-e headers: ``` diff

[GitHub] oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-16 Thread GitBox
oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-389603258 @morlovich Yeah, I have been looking at that too.. What I think is *really* odd is that this

[GitHub] oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-15 Thread GitBox
oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-389077301 The change above doesn't help. It probably wouldn't have been the right fix, but naively I would have e

[GitHub] oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-15 Thread GitBox
oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-389066123 So I caught the http cache in gdb writing the bad entry. The C-L is 7411 with C-E gzip, but the body co

[GitHub] oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-14 Thread GitBox
oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-388759087 Well actually .. in the script that demonstrates the issue there is: ``` good_css_url=$(curl -

[GitHub] oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-14 Thread GitBox
oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-388730282 @jstangroome awesome, I have it reproduced now! So one prerequisite that I think exists for the p

[GitHub] oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-13 Thread GitBox
oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-388653519 @jstangroome are you able to set up a minimal reproduction scenario? I'd love to dig into this one, but

[GitHub] oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-09 Thread GitBox
oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-387895462 I suspect that impact on required cache space of the workaround may not be that big: images probably ma

[GitHub] oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-09 Thread GitBox
oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-387774687 In this scenario, nginx is not expected to play a role in the gzipping. As a workaround, adding

[GitHub] oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit

2018-05-09 Thread GitBox
oschaaf commented on issue #1556: Combined css returns truncated, mis-encoded body on cache hit URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1556#issuecomment-387686294 That is some really good information. Intuitively I'd think that there is an issue specific to interact