[GitHub] jadatkins commented on issue #1521: install from script fails due to new filename

2018-01-08 Thread GitBox
jadatkins commented on issue #1521: install from script fails due to new filename URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1521#issuecomment-355955902 thanks @oschaaf This is an automated message from th

[GitHub] jmarantz commented on a change in pull request #1695: OutputSanitizingAsyncFetch: runs right before PSOL responds

2018-01-08 Thread GitBox
jmarantz commented on a change in pull request #1695: OutputSanitizingAsyncFetch: runs right before PSOL responds URL: https://github.com/apache/incubator-pagespeed-mod/pull/1695#discussion_r160147018 ## File path: net/instaweb/http/public/async_fetch.h ## @@ -316,6 +316,

[GitHub] jmarantz commented on a change in pull request #1695: OutputSanitizingAsyncFetch: runs right before PSOL responds

2018-01-08 Thread GitBox
jmarantz commented on a change in pull request #1695: OutputSanitizingAsyncFetch: runs right before PSOL responds URL: https://github.com/apache/incubator-pagespeed-mod/pull/1695#discussion_r160146867 ## File path: net/instaweb/http/public/async_fetch.h ## @@ -316,6 +316,

[GitHub] jmarantz commented on a change in pull request #1695: OutputSanitizingAsyncFetch: runs right before PSOL responds

2018-01-08 Thread GitBox
jmarantz commented on a change in pull request #1695: OutputSanitizingAsyncFetch: runs right before PSOL responds URL: https://github.com/apache/incubator-pagespeed-mod/pull/1695#discussion_r160146665 ## File path: net/instaweb/http/async_fetch.cc ## @@ -276,6 +276,33 @@

[GitHub] jmarantz commented on a change in pull request #1695: OutputSanitizingAsyncFetch: runs right before PSOL responds

2018-01-08 Thread GitBox
jmarantz commented on a change in pull request #1695: OutputSanitizingAsyncFetch: runs right before PSOL responds URL: https://github.com/apache/incubator-pagespeed-mod/pull/1695#discussion_r160147479 ## File path: pagespeed/apache/header_util.cc ## @@ -115,6 +115,9 @@ vo

[GitHub] jmarantz commented on a change in pull request #1703: Removes deprecated mod_access_compat directives

2018-01-08 Thread GitBox
jmarantz commented on a change in pull request #1703: Removes deprecated mod_access_compat directives URL: https://github.com/apache/incubator-pagespeed-mod/pull/1703#discussion_r160155613 ## File path: install/common/pagespeed.conf.template ## @@ -321,15 +321,19 @@

[GitHub] oschaaf commented on a change in pull request #1703: Removes deprecated mod_access_compat directives

2018-01-08 Thread GitBox
oschaaf commented on a change in pull request #1703: Removes deprecated mod_access_compat directives URL: https://github.com/apache/incubator-pagespeed-mod/pull/1703#discussion_r160168266 ## File path: install/common/pagespeed.conf.template ## @@ -321,15 +321,19 @@ #

[GitHub] oschaaf closed pull request #1706: Only perform semanage sequence once on CentOS

2018-01-08 Thread GitBox
oschaaf closed pull request #1706: Only perform semanage sequence once on CentOS URL: https://github.com/apache/incubator-pagespeed-mod/pull/1706 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] robov commented on issue #1181: Support Alpine

2018-01-08 Thread GitBox
robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356010210 @nberlee : When I try to build your dockerfile I get : ``` adding module in /tmp/ngx_pagespeed-1.12.34.3-stable ./configure: error: no /tmp/ngx_

[GitHub] robov commented on issue #1181: Support Alpine

2018-01-08 Thread GitBox
robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356011231 @ashishk-1 : When I try to build your dockerfile I get : adding module in /tmp/ngx_pagespeed-1.12.34.3-stable ./configure: error: no /tmp/ngx_page

[GitHub] REPTILEHAUS opened a new issue #1522: Cannot install - issues with ngx_pagespeed.o

2018-01-08 Thread GitBox
REPTILEHAUS opened a new issue #1522: Cannot install - issues with ngx_pagespeed.o URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1522 I have a docker environment that i have deployed a couple of times and it has always worked except now when provisioning a new server the sa

[GitHub] oschaaf opened a new pull request #1523: Unbreak install after repo transfers

2018-01-08 Thread GitBox
oschaaf opened a new pull request #1523: Unbreak install after repo transfers URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1523 The directory name in the zip we download from github's release archive will be different now that the project was renamed. It may be renamed a

[GitHub] oschaaf commented on issue #1522: Cannot install - issues with ngx_pagespeed.o

2018-01-08 Thread GitBox
oschaaf commented on issue #1522: Cannot install - issues with ngx_pagespeed.o URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1522#issuecomment-356012833 Could the build process be running out of memory? This i

[GitHub] REPTILEHAUS commented on issue #1522: Cannot install - issues with ngx_pagespeed.o

2018-01-08 Thread GitBox
REPTILEHAUS commented on issue #1522: Cannot install - issues with ngx_pagespeed.o URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1522#issuecomment-356014257 Im not sure, Ill scale up the vm now and revert back with the result. --

[GitHub] REPTILEHAUS commented on issue #1522: Cannot install - issues with ngx_pagespeed.o

2018-01-08 Thread GitBox
REPTILEHAUS commented on issue #1522: Cannot install - issues with ngx_pagespeed.o URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1522#issuecomment-356017773 Scaled up the instance and its working as it should, really should have checked that first. thanks man. ---

[GitHub] jmarantz commented on a change in pull request #1523: Unbreak install after repo transfers

2018-01-08 Thread GitBox
jmarantz commented on a change in pull request #1523: Unbreak install after repo transfers URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1523#discussion_r160193605 ## File path: scripts/build_ngx_pagespeed.sh ## @@ -612,7 +612,8 @@ Not deleting $directory; n

[GitHub] oschaaf closed issue #1522: Cannot install - issues with ngx_pagespeed.o

2018-01-08 Thread GitBox
oschaaf closed issue #1522: Cannot install - issues with ngx_pagespeed.o URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1522 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] oschaaf commented on issue #1522: Cannot install - issues with ngx_pagespeed.o

2018-01-08 Thread GitBox
oschaaf commented on issue #1522: Cannot install - issues with ngx_pagespeed.o URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1522#issuecomment-356022083 No problem, happy to hear its working now! This is an au

[GitHub] hgl commented on issue #1181: Support Alpine

2018-01-08 Thread GitBox
hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356024910 @nberlee Thanks for sharing. But I got the same error too. ``` configuring additional modules adding module in /tmp/ngx_pagespeed-1.12.34.3-sta

[GitHub] oschaaf closed pull request #1523: Unbreak install after repo transfers

2018-01-08 Thread GitBox
oschaaf closed pull request #1523: Unbreak install after repo transfers URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1523 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] oschaaf closed issue #1521: install from script fails due to new filename

2018-01-08 Thread GitBox
oschaaf closed issue #1521: install from script fails due to new filename URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1521 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] oschaaf commented on issue #1521: install from script fails due to new filename

2018-01-08 Thread GitBox
oschaaf commented on issue #1521: install from script fails due to new filename URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1521#issuecomment-356026172 Should be fixed, please retry! This is an automated mes

[GitHub] jadatkins commented on issue #1521: install from script fails due to new filename

2018-01-08 Thread GitBox
jadatkins commented on issue #1521: install from script fails due to new filename URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1521#issuecomment-356028628 @oschaaf @jmarantz that seems to work, thank you! Th

[GitHub] robov commented on issue #1181: Support Alpine

2018-01-08 Thread GitBox
robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356047432 I am not sure yet, but it seems to be related to the nginx version. 1.12.2 seems to be working... 1.13.3 seems to be not. Can anyone confirm ? I am still

[GitHub] oschaaf commented on a change in pull request #1695: OutputSanitizingAsyncFetch: runs right before PSOL responds

2018-01-08 Thread GitBox
oschaaf commented on a change in pull request #1695: OutputSanitizingAsyncFetch: runs right before PSOL responds URL: https://github.com/apache/incubator-pagespeed-mod/pull/1695#discussion_r160230016 ## File path: pagespeed/apache/header_util.cc ## @@ -115,6 +115,9 @@ voi

[GitHub] hgl commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356237144 After some digging, I found the root cause to be that this project just got moved to `apache/incubator-pagespeed-ngx`, so after downloading the archive fi

[GitHub] hgl commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356237144 After some digging, I found the root cause is that this project just got moved to `apache/incubator-pagespeed-ngx`, so after downloading the archive file,

[GitHub] robov commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356242099 @HGL AWESOME.. yes I was very frustrated that even my backup files did not work anymore... So I guess you are right

[GitHub] robov commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356242638 I am a pretty newbie... can you share your changed code ? This is an automated message f

[GitHub] hgl commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356237144 After some digging, I found the root cause to be that this project just got moved to `apache/incubator-pagespeed-ngx`, so after downloading the archive fi

[GitHub] hgl commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356253735 @robov in @nberlee's Dockerfile add ``` mv incubator-pagespeed-ngx-1.12.34.3-stable /tmp/ngx_pagespeed-1.12.34.3-stable ``` below

[GitHub] hgl commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356254153 @nberlee a quick question, why is [this line](https://github.com/nberlee/ngx-pagespeed-alpine/blob/3.7/Dockerfile#L47) necessary? I try to compile without

[GitHub] hgl commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356254153 @nberlee a quick question, why is [this line](https://github.com/nberlee/ngx-pagespeed-alpine/blob/3.7/Dockerfile#L47) necessary? I tried to compile witho

[GitHub] hgl commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356253735 @robov in @nberlee's Dockerfile add ``` mv incubator-pagespeed-ngx-1.12.34.3-stable /tmp/ngx_pagespeed-1.12.34.3-stable && \ ``` be

[GitHub] hgl commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356253735 @robov in @nberlee's Dockerfile add ``` mv /tmp/incubator-pagespeed-ngx-1.12.34.3-stable /tmp/ngx_pagespeed-1.12.34.3-stable && \ ```

[GitHub] oschaaf commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
oschaaf commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356254572 (The repo may be renamed again at some stage later on, and this change hopefully is resilient to that) ---

[GitHub] oschaaf commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
oschaaf commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356254446 With regard to the renaming of the repo, https://github.com/apache/incubator-pagespeed-ngx/commit/e733a838c35a0f2108768c2d1ead6fb7ee806cf8 was merged

[GitHub] hgl commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356255779 @oschaaf Thanks for the head up. But it seems `Dockerfile`s from most unofficial alpine images don't use this script. So they will continue to fail to bui

[GitHub] hgl commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356255779 @oschaaf Thanks for the head up. But it seems `Dockerfile`s from most unofficial alpine images don't use this script. So they'll continue to fail to build

[GitHub] robov commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356276303 @oschaaf @hgl : with the merge to unbreak the install script... do I still have to rename the dir

[GitHub] hgl commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356277277 Yes, that script is never used in the Dockerfile This is an automated message from the Apa

[GitHub] hgl commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356277892 But since the name is tentative, that mv command could easily fail when that happens. A better approach: ``` mkdir -p /usr/local/src/mod-pagespee

[GitHub] hgl commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356277892 But since the name is tentative, that mv command could easily fail when that happens. A better approach: ``` mkdir -p /tmp/modpagespeed-${PAGESPE

[GitHub] oschaaf commented on issue #1695: OutputSanitizingAsyncFetch: runs right before PSOL responds

2018-01-09 Thread GitBox
oschaaf commented on issue #1695: OutputSanitizingAsyncFetch: runs right before PSOL responds URL: https://github.com/apache/incubator-pagespeed-mod/pull/1695#issuecomment-356278838 @jmarantz processed your comments in https://github.com/apache/incubator-pagespeed-mod/pull/1695/commits/ee

[GitHub] hgl commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
hgl commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356277892 But since the name is tentative, that mv command could easily fail when that happens. A better approach: ``` mkdir -p /tmp/ngx_pagespeed-${PAGESP

[GitHub] nberlee commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
nberlee commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356353214 @hgl The sed line was a workaround for a Alpine 3.7 busybox wait bug. (which never stopped waiting) This seems to be fixed since, making the line now

[GitHub] robov commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356395182 @nberlee Is there intentionally the hardcoded version in ``` https://github.com/We-Amp/ngx-pagespeed-alpine/blob/master/mod-pagespeed-beta-1.

[GitHub] nberlee commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
nberlee commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356418528 @robov Currently yes, once a new mod-pagespeed stable (1.12.34.3) is released, with @ashishk-1 commit: https://github.com/apache/incubator-pagespeed-m

[GitHub] nberlee commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
nberlee commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356418528 @robov Currently yes, once a new mod-pagespeed stable (1.12.34.3) is released, with @ashishk-1 commit: https://github.com/apache/incubator-pagespeed-m

[GitHub] nberlee commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
nberlee commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356418528 @robov Currently yes, once a new mod-pagespeed stable (1.12.34.3) is released, with @ashishk-1 commit: https://github.com/apache/incubator-pagespeed-m

[GitHub] oschaaf commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
oschaaf commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356420687 @nberlee @robov maybe we should inventorise if it is viable to pull maintenance of the alpine image into the project to centralize efforts. Would you

[GitHub] oppianmatt opened a new issue #1524: build instructions no longer working for 1.13.35.1-beta

2018-01-09 Thread GitBox
oppianmatt opened a new issue #1524: build instructions no longer working for 1.13.35.1-beta URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1524 Linked from the README https://www.modpagespeed.com/doc/build_ngx_pagespeed_from_source ``` #[check the release notes fo

[GitHub] oppianmatt commented on issue #1524: build instructions no longer working for all versions

2018-01-09 Thread GitBox
oppianmatt commented on issue #1524: build instructions no longer working for all versions URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1524#issuecomment-356427457 tried using the existing version in the readme but it still breaks on both places ``` inflating:

[GitHub] oppianmatt commented on issue #1524: build instructions no longer working for all versions

2018-01-09 Thread GitBox
oppianmatt commented on issue #1524: build instructions no longer working for all versions URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1524#issuecomment-356427654 after a bit of googling and testing found that psol moved to a new place and so that needs to be fixed.

[GitHub] oschaaf commented on issue #1524: build instructions no longer working for all versions

2018-01-09 Thread GitBox
oschaaf commented on issue #1524: build instructions no longer working for all versions URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1524#issuecomment-356429014 Thanks for the report! Would you be willing to make a pull request for it? (The change should go into http

[GitHub] oppianmatt commented on issue #1524: build instructions no longer working for all versions

2018-01-09 Thread GitBox
oppianmatt commented on issue #1524: build instructions no longer working for all versions URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1524#issuecomment-356429334 ok, just testing it a bit more, it works for that part and then later fails in configure when I got i

[GitHub] oschaaf commented on issue #1524: build instructions no longer working for all versions

2018-01-09 Thread GitBox
oschaaf commented on issue #1524: build instructions no longer working for all versions URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1524#issuecomment-356429446 @oppianmatt great, thanks! This is an automate

[GitHub] oppianmatt commented on issue #1524: build instructions no longer working for all versions

2018-01-09 Thread GitBox
oppianmatt commented on issue #1524: build instructions no longer working for all versions URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1524#issuecomment-356435232 do you know where the binaries are being hosted now they aren't on google? the links at https://github.com/a

[GitHub] robov commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356498629 I would definately be interested, but I am not bringing much to this table. My experience in linux is very low and I consider myself a newbie in this spa

[GitHub] robov commented on issue #1181: Support Alpine

2018-01-09 Thread GitBox
robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356517069 @nberlee : I am trying to understand your code, especially this part confuses me : LD_LIBRARY_PATH=/tmp/modpagespeed-${PAGESPEED_VERSION}/usr/lib ./

[GitHub] oschaaf commented on issue #1524: build instructions no longer working for all versions

2018-01-09 Thread GitBox
oschaaf commented on issue #1524: build instructions no longer working for all versions URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1524#issuecomment-356522611 Above I see the script attempts to download https://dl.google.com/dl/page-speed/psol/1.13.35.1-beta.tar.gz T

[GitHub] oschaaf commented on issue #1524: build instructions no longer working for all versions

2018-01-09 Thread GitBox
oschaaf commented on issue #1524: build instructions no longer working for all versions URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1524#issuecomment-356526816 I suspect the line with `unzip -d` isn't working as expected. The automated install had a similar problem, and

[GitHub] oschaaf opened a new pull request #1707: Update build_ngx_pagespeed_from_source.html

2018-01-09 Thread GitBox
oschaaf opened a new pull request #1707: Update build_ngx_pagespeed_from_source.html URL: https://github.com/apache/incubator-pagespeed-mod/pull/1707 Update to make it work after the repo transfer This is an automated message

[GitHub] oschaaf commented on issue #1524: build instructions no longer working for all versions

2018-01-09 Thread GitBox
oschaaf commented on issue #1524: build instructions no longer working for all versions URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1524#issuecomment-356527294 Created https://github.com/apache/incubator-pagespeed-mod/pull/1707 @oppianmatt could you review that?

[GitHub] oschaaf opened a new pull request #1708: Update README.md

2018-01-10 Thread GitBox
oschaaf opened a new pull request #1708: Update README.md URL: https://github.com/apache/incubator-pagespeed-mod/pull/1708 Fix travis links This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] oschaaf opened a new pull request #1525: Update README.md

2018-01-10 Thread GitBox
oschaaf opened a new pull request #1525: Update README.md URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1525 Fix travis links This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] robov commented on issue #1181: Support Alpine

2018-01-10 Thread GitBox
robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356535658 Holy Smoly... my bad... I was looking at the wrong branch... I was looking at 3.4 instead of 3.7 for this last post

[GitHub] oppianmatt commented on issue #1707: Update build_ngx_pagespeed_from_source.html

2018-01-10 Thread GitBox
oppianmatt commented on issue #1707: Update build_ngx_pagespeed_from_source.html URL: https://github.com/apache/incubator-pagespeed-mod/pull/1707#issuecomment-356543054 need to change later on also the nginx add-module line: locally I went with: ``` cd incubator-pagespeed-n

[GitHub] robov commented on issue #1181: Support Alpine

2018-01-10 Thread GitBox
robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356561161 Is there someone who can help me out ? I want to build (tedious long) pagespeed in a separate container and include only the necessary files in the ma

[GitHub] robov commented on issue #1181: Support Alpine

2018-01-10 Thread GitBox
robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356562398 I guessed the libpng was missing (only present in the temp build container, so I added that to the main one. But hten the compiling broke on "missing pa

[GitHub] nberlee commented on issue #1181: Support Alpine

2018-01-10 Thread GitBox
nberlee commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356570673 @robov I made a multi-stage Dockerfile see https://github.com/nberlee/ngx-pagespeed-alpine/tree/3.7-dev but haven't tested it yet! It should build fin

[GitHub] robov commented on issue #1181: Support Alpine

2018-01-10 Thread GitBox
robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356575446 @nberlee : I am testing now.. This is an automated message from the Apache Git Service.

[GitHub] robov commented on issue #1181: Support Alpine

2018-01-10 Thread GitBox
robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356576872 Step 8/26 : COPY mod-pagespeed-beta-1.12.34.3.tar.bz2 patches/*.patch /tmp/ COPY failed: stat /var/lib/docker/tmp/docker-builder857321033/mod-pagespee

[GitHub] robov commented on issue #1181: Support Alpine

2018-01-10 Thread GitBox
robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356577063 oops... my bad... forgot to pull your entire sources This is an automated message from t

[GitHub] oschaaf commented on issue #1707: Update build_ngx_pagespeed_from_source.html

2018-01-10 Thread GitBox
oschaaf commented on issue #1707: Update build_ngx_pagespeed_from_source.html URL: https://github.com/apache/incubator-pagespeed-mod/pull/1707#issuecomment-356598953 @oppianmatt updated to fix the ./configure line, could you take a another look? ---

[GitHub] robov commented on issue #1181: Support Alpine

2018-01-10 Thread GitBox
robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356605030 @nberlee it compiles nice (I have not tested the actual functionality, just compiling) I have a personal preference to have separate files instead of

[GitHub] robov commented on issue #1181: Support Alpine

2018-01-10 Thread GitBox
robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356605923 When I do something like this on a container : docker cp extractfromcontainer:/usr/lib/libpng* compiled/usr/lib then it cannot find anything... when I

[GitHub] nberlee commented on issue #1181: Support Alpine

2018-01-10 Thread GitBox
nberlee commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356654833 @robov https://github.com/moby/moby/issues/7710 This is an automated message from the

[GitHub] robov commented on issue #1181: Support Alpine

2018-01-10 Thread GitBox
robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356665588 aha, and when copying the entire folder it complains ( i think it was about the symlinks) --

[GitHub] oppianmatt commented on issue #1707: Update build_ngx_pagespeed_from_source.html

2018-01-10 Thread GitBox
oppianmatt commented on issue #1707: Update build_ngx_pagespeed_from_source.html URL: https://github.com/apache/incubator-pagespeed-mod/pull/1707#issuecomment-356676091 builds and configures This is an automated message from

[GitHub] oschaaf closed pull request #1707: Update build_ngx_pagespeed_from_source.html

2018-01-10 Thread GitBox
oschaaf closed pull request #1707: Update build_ngx_pagespeed_from_source.html URL: https://github.com/apache/incubator-pagespeed-mod/pull/1707 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] oschaaf closed issue #1524: build instructions no longer working for all versions

2018-01-10 Thread GitBox
oschaaf closed issue #1524: build instructions no longer working for all versions URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1524 This is an automated message from the Apache Git Service. To respond to the

[GitHub] robov commented on issue #1181: Support Alpine

2018-01-10 Thread GitBox
robov commented on issue #1181: Support Alpine URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1181#issuecomment-356742597 After 5 days of a very steep learning curve I am finally getting somewhere... @nberlee , FROM on you multistage image I create my own derivative whi

[GitHub] oschaaf opened a new pull request #1709: Update release notes for 1.13.35.2-beta

2018-01-10 Thread GitBox
oschaaf opened a new pull request #1709: Update release notes for 1.13.35.2-beta URL: https://github.com/apache/incubator-pagespeed-mod/pull/1709 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] oschaaf closed pull request #1709: Update release notes for 1.13.35.2-beta

2018-01-10 Thread GitBox
oschaaf closed pull request #1709: Update release notes for 1.13.35.2-beta URL: https://github.com/apache/incubator-pagespeed-mod/pull/1709 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] googlebot commented on issue #1710: Update config_filters.html

2018-01-10 Thread GitBox
googlebot commented on issue #1710: Update config_filters.html URL: https://github.com/apache/incubator-pagespeed-mod/pull/1710#issuecomment-356849655 Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at you

[GitHub] vitaliytv opened a new pull request #1710: Update config_filters.html

2018-01-10 Thread GitBox
vitaliytv opened a new pull request #1710: Update config_filters.html URL: https://github.com/apache/incubator-pagespeed-mod/pull/1710 fix broken link to insert_image_dimensions This is an automated message from the Apache Gi

[GitHub] vitaliytv commented on issue #1710: Update config_filters.html

2018-01-10 Thread GitBox
vitaliytv commented on issue #1710: Update config_filters.html URL: https://github.com/apache/incubator-pagespeed-mod/pull/1710#issuecomment-356851049 I signed it! This is an automated message from the Apache Git Service. To

[GitHub] googlebot commented on issue #1710: Update config_filters.html

2018-01-10 Thread GitBox
googlebot commented on issue #1710: Update config_filters.html URL: https://github.com/apache/incubator-pagespeed-mod/pull/1710#issuecomment-356851059 CLAs look good, thanks! This is an automated message from the Apac

[GitHub] oschaaf commented on issue #968: Distribute PSOL and mod_pagespeed as a source tarball.

2018-01-11 Thread GitBox
oschaaf commented on issue #968: Distribute PSOL and mod_pagespeed as a source tarball. URL: https://github.com/apache/incubator-pagespeed-mod/issues/968#issuecomment-356868405 https://dl.google.com/dl/linux/mod-pagespeed/tar/beta/mod-pagespeed-beta-1.13.35.2-r0.tar.bz2 https://dl.goo

[GitHub] oschaaf closed pull request #1710: Update config_filters.html

2018-01-11 Thread GitBox
oschaaf closed pull request #1710: Update config_filters.html URL: https://github.com/apache/incubator-pagespeed-mod/pull/1710 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign p

[GitHub] oschaaf opened a new pull request #1711: New index for modpagespeed.com

2018-01-11 Thread GitBox
oschaaf opened a new pull request #1711: New index for modpagespeed.com URL: https://github.com/apache/incubator-pagespeed-mod/pull/1711 Based on Jeff's earlier work on this, with a couple of changes: - Link the examples that currently serve as the index as http://staging.modpagesp

[GitHub] oschaaf commented on issue #1711: New index for modpagespeed.com

2018-01-11 Thread GitBox
oschaaf commented on issue #1711: New index for modpagespeed.com URL: https://github.com/apache/incubator-pagespeed-mod/pull/1711#issuecomment-357050102 @jmarantz @morlovich WDYT? This is an automated message from the Apache

[GitHub] oschaaf commented on issue #1711: New index for modpagespeed.com

2018-01-11 Thread GitBox
oschaaf commented on issue #1711: New index for modpagespeed.com URL: https://github.com/apache/incubator-pagespeed-mod/pull/1711#issuecomment-357050625 @jeffkaufman ping (just a FYI, this PR is based on your earlier work on a new index for modpagespeed.com) --

[GitHub] oschaaf closed pull request #1708: Update README.md

2018-01-11 Thread GitBox
oschaaf closed pull request #1708: Update README.md URL: https://github.com/apache/incubator-pagespeed-mod/pull/1708 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub an

[GitHub] oschaaf closed pull request #1525: Update README.md

2018-01-11 Thread GitBox
oschaaf closed pull request #1525: Update README.md URL: https://github.com/apache/incubator-pagespeed-ngx/pull/1525 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub an

[GitHub] jeffkaufman commented on issue #1711: New index for modpagespeed.com

2018-01-11 Thread GitBox
jeffkaufman commented on issue #1711: New index for modpagespeed.com URL: https://github.com/apache/incubator-pagespeed-mod/pull/1711#issuecomment-357059322 Thanks for picking this up! I'm sorry I didn't finish it! This is a

[GitHub] jmarantz commented on issue #1711: New index for modpagespeed.com

2018-01-11 Thread GitBox
jmarantz commented on issue #1711: New index for modpagespeed.com URL: https://github.com/apache/incubator-pagespeed-mod/pull/1711#issuecomment-357060042 +1 I think it's really great that you are picking this up, and organizationally it's a huge win. I would like to see someone (no

[GitHub] oschaaf commented on issue #1711: New index for modpagespeed.com

2018-01-11 Thread GitBox
oschaaf commented on issue #1711: New index for modpagespeed.com URL: https://github.com/apache/incubator-pagespeed-mod/pull/1711#issuecomment-357065891 @jmarantz I'll ask around tomorrow to figure out what effort it would take to reuse some design elements. I do suspect it would invo

[GitHub] oschaaf closed pull request #1711: New index for modpagespeed.com

2018-01-11 Thread GitBox
oschaaf closed pull request #1711: New index for modpagespeed.com URL: https://github.com/apache/incubator-pagespeed-mod/pull/1711 This is an automated message from the Apache Git Service. To respond to the message, please l

<    7   8   9   10   11   12   13   14   15   16   >