[jira] [Commented] (PARQUET-2387) Simplify `hasFieldsIgnored` expression

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791649#comment-17791649 ] ASF GitHub Bot commented on PARQUET-2387: - Fokko commented on code in PR #1210: URL:

Re: [PR] PARQUET-2387: Simplify `hasFieldsIgnored` expression [parquet-mr]

2023-11-30 Thread via GitHub
Fokko commented on code in PR #1210: URL: https://github.com/apache/parquet-mr/pull/1210#discussion_r1410732198 ## parquet-thrift/src/main/java/org/apache/parquet/thrift/BufferedProtocolReadToWrite.java: ## @@ -369,7 +369,7 @@ public String toDebugString() { ThriftField

Re: [PR] Bump com.fasterxml.jackson.core:jackson-databind from 2.15.2 to 2.16.0 [parquet-mr]

2023-11-30 Thread via GitHub
Fokko merged PR #1205: URL: https://github.com/apache/parquet-mr/pull/1205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (PARQUET-2392) Remove StringBuilder in `LogicalTypeAnnotation`

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791643#comment-17791643 ] ASF GitHub Bot commented on PARQUET-2392: - Fokko commented on PR #1215: URL:

Re: [PR] PARQUET-2392: Remove StringBuilder in `LogicalTypeAnnotation` [parquet-mr]

2023-11-30 Thread via GitHub
Fokko commented on PR #1215: URL: https://github.com/apache/parquet-mr/pull/1215#issuecomment-1833844311 @zhangjiashen Thanks for the review, appreciate it! I don't think there are any negative performance implications since the compile will just optimize it to a single concatenation.

Re: [PR] PARQUET-2171: Support Hadoop vectored IO [parquet-mr]

2023-11-30 Thread via GitHub
steveloughran commented on code in PR #1139: URL: https://github.com/apache/parquet-mr/pull/1139#discussion_r1410699415 ## parquet-hadoop/README.md: ## @@ -501,3 +501,11 @@ If `false`, key material is stored in separate new files, created in the same fo **Description:**

[jira] [Commented] (PARQUET-2171) Implement vectored IO in parquet file format

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791631#comment-17791631 ] ASF GitHub Bot commented on PARQUET-2171: - steveloughran commented on code in PR #1139: URL:

[jira] [Commented] (PARQUET-2171) Implement vectored IO in parquet file format

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791630#comment-17791630 ] ASF GitHub Bot commented on PARQUET-2171: - steveloughran commented on PR #1139: URL:

Re: [PR] PARQUET-2171: Support Hadoop vectored IO [parquet-mr]

2023-11-30 Thread via GitHub
steveloughran commented on PR #1139: URL: https://github.com/apache/parquet-mr/pull/1139#issuecomment-1833813575 @Fokko that's japicmp getting its logic wrong because it's a new file; thought I'd edited the build rules so it would ignore that. anyway, need to fix the merge as

[jira] [Resolved] (PARQUET-2319) Upgrade Avro to version 1.11.2

2023-11-30 Thread Atour Mousavi Gourabi (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atour Mousavi Gourabi resolved PARQUET-2319. Resolution: Fixed > Upgrade Avro to version 1.11.2 >

[jira] [Resolved] (PARQUET-2360) Upgrade Avro to version 1.11.3

2023-11-30 Thread Atour Mousavi Gourabi (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atour Mousavi Gourabi resolved PARQUET-2360. Resolution: Fixed > Upgrade Avro to version 1.11.3 >

[jira] [Commented] (PARQUET-2385) Don't initialize CodecFactory in ParquetWriter

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791571#comment-17791571 ] ASF GitHub Bot commented on PARQUET-2385: - amousavigourabi commented on PR #1203: URL:

Re: [PR] PARQUET-2385: Allow user to specify CodecFactory for ParquetWriter [parquet-mr]

2023-11-30 Thread via GitHub
amousavigourabi commented on PR #1203: URL: https://github.com/apache/parquet-mr/pull/1203#issuecomment-183334 > @amousavigourabi It seems a rebase is required. @wgtmac Done, thanks for the heads up -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (PARQUET-2400) Update Spotless command in PR prompt to include vector plugins

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791563#comment-17791563 ] ASF GitHub Bot commented on PARQUET-2400: - amousavigourabi opened a new pull request, #1223:

[PR] PARQUET-2400: Update Spotless command in PR prompt to include plugins [parquet-mr]

2023-11-30 Thread via GitHub
amousavigourabi opened a new pull request, #1223: URL: https://github.com/apache/parquet-mr/pull/1223 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references

[jira] [Created] (PARQUET-2400) Update Spotless command in PR prompt to include vector plugins

2023-11-30 Thread Atour Mousavi Gourabi (Jira)
Atour Mousavi Gourabi created PARQUET-2400: -- Summary: Update Spotless command in PR prompt to include vector plugins Key: PARQUET-2400 URL: https://issues.apache.org/jira/browse/PARQUET-2400

[jira] [Commented] (PARQUET-2399) Use deprecated tag in Javadoc

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791560#comment-17791560 ] ASF GitHub Bot commented on PARQUET-2399: - amousavigourabi opened a new pull request, #1222:

[PR] PARQUET-2399: Use deprecated tag in Javadoc [parquet-mr]

2023-11-30 Thread via GitHub
amousavigourabi opened a new pull request, #1222: URL: https://github.com/apache/parquet-mr/pull/1222 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references

[jira] [Created] (PARQUET-2399) Use deprecated tag in Javadoc

2023-11-30 Thread Atour Mousavi Gourabi (Jira)
Atour Mousavi Gourabi created PARQUET-2399: -- Summary: Use deprecated tag in Javadoc Key: PARQUET-2399 URL: https://issues.apache.org/jira/browse/PARQUET-2399 Project: Parquet Issue

[jira] [Commented] (PARQUET-1647) [Java] support for Arrow's float16

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791520#comment-17791520 ] ASF GitHub Bot commented on PARQUET-1647: - wgtmac commented on PR #1142: URL:

Re: [PR] PARQUET-1647: [Java][Parquet] Implement FLOAT16 logical type [parquet-mr]

2023-11-30 Thread via GitHub
wgtmac commented on PR #1142: URL: https://github.com/apache/parquet-mr/pull/1142#issuecomment-1833370284 Could you please rebase it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (PARQUET-2385) Don't initialize CodecFactory in ParquetWriter

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791519#comment-17791519 ] ASF GitHub Bot commented on PARQUET-2385: - wgtmac commented on PR #1203: URL:

Re: [PR] PARQUET-2385: Allow user to specify CodecFactory for ParquetWriter [parquet-mr]

2023-11-30 Thread via GitHub
wgtmac commented on PR #1203: URL: https://github.com/apache/parquet-mr/pull/1203#issuecomment-1833368029 @amousavigourabi It seems a rebase is required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Resolved] (PARQUET-2386) More consistent code style in parquet-mr

2023-11-30 Thread Gang Wu (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gang Wu resolved PARQUET-2386. -- Fix Version/s: 1.14.0 Resolution: Fixed > More consistent code style in parquet-mr >

[jira] [Commented] (PARQUET-2386) More consistent code style in parquet-mr

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791517#comment-17791517 ] ASF GitHub Bot commented on PARQUET-2386: - wgtmac commented on PR #1209: URL:

Re: [PR] PARQUET-2386: More consistent code style in parquet-mr [parquet-mr]

2023-11-30 Thread via GitHub
wgtmac commented on PR #1209: URL: https://github.com/apache/parquet-mr/pull/1209#issuecomment-1833367177 > I rebased on the latest master. I'd rather get this merged somewhat quickly (maybe by the end of the week?) as to avoid blocking other merges and/or endless rebasing. I just

Re: [PR] PARQUET-2386: More consistent code style in parquet-mr [parquet-mr]

2023-11-30 Thread via GitHub
wgtmac merged PR #1209: URL: https://github.com/apache/parquet-mr/pull/1209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (PARQUET-2386) More consistent code style in parquet-mr

2023-11-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791516#comment-17791516 ] ASF GitHub Bot commented on PARQUET-2386: - wgtmac merged PR #1209: URL:

Re: How the key rotation works when using Parquet Modular Encryption

2023-11-30 Thread Gidon Gershinsky
On Wed, Nov 29, 2023 at 5:40 PM Priyanshu Sharma wrote: > With Parquet Modular Encryption > 1. With each key rotation , Is it possible to avoid encryption and > decryption of existing data? > Yes > > 2. If master key rotation does not require modification of the data file > then how would the