[DISCUSS] Merge script for parquet-java and parquet-format

2024-07-16 Thread Micah Kornfield
I started trying to modernize the merge script in parquet-java [1] and the question came up on whether we want to require using a merge script at all. At least for parquet-format I think people have been merging for a while using squash and merge. I'm not sure what people are doing for parquet-ja

Re: [DISCUSS] Merge script for parquet-java and parquet-format

2024-07-17 Thread Fokko Driesprong
Hey Micah, Thanks for bringing this up. I'm a big fan of just doing things through Github. Of course, it is not as customizable as a script, but I think it can do the job. 1. Being able to link each PR to a milestone. This becomes more important > since the move away from JIRA to Github issues

Re: [DISCUSS] Merge script for parquet-java and parquet-format

2024-07-17 Thread Andrew Lamb
> The awesome new template of Gang suggests adding Closes #1234 < https://github.com/apache/parquet-java/pull/2940/files#diff-18813c86948efc57e661623d7ba48ff94325c9b5421ec9177f724922dd553a35R30 > in the PR description. Once the PR goes in, GitHub will automatically close the issue as well. We use

Re: [DISCUSS] Merge script for parquet-java and parquet-format

2024-07-17 Thread Alkis Evlogimenos
+1 in using stock github On Wed, Jul 17, 2024 at 10:00 AM Fokko Driesprong wrote: > Hey Micah, > > Thanks for bringing this up. I'm a big fan of just doing things through > Github. Of course, it is not as customizable as a script, but I think it > can do the job. > > 1. Being able to link each

Re: [DISCUSS] Merge script for parquet-java and parquet-format

2024-07-19 Thread Micah Kornfield
My only concern here is it seems to rely on convention rather than mechanisms. If there are no other comments on the matter I'll delete the merge scripts for now and we can see how a github only process works out and revise accordingly. Thanks for the discussion. Cheers, Micah On Wed, Jul 17, 2

Re: [DISCUSS] Merge script for parquet-java and parquet-format

2024-07-19 Thread Ryan Blue
+1 for using Github options. I think the scripts were mainly intended to do things that Github does for you. On Fri, Jul 19, 2024 at 2:47 PM Micah Kornfield wrote: > My only concern here is it seems to rely on convention rather than > mechanisms. If there are no other comments on the matter I'l

Re: [DISCUSS] Merge script for parquet-java and parquet-format

2024-07-19 Thread Fokko Driesprong
Hey Micah, That's a good point. I'm happy to formalize the conventions by raising a PR against the parquet website with guidelines where we can hammer out the details. Kind regards, Fokko Op vr 19 jul 2024 om 23:49 schreef Ryan Blue : > +1 for using Github options. I think the scripts were main

Re: [DISCUSS] Merge script for parquet-java and parquet-format

2024-07-22 Thread Fokko Driesprong
Hey everyone, I've raised two PRs to update the way of working for contributing and releasing . Let me know what you think. Kind regards, Fokko Op za 20 jul 2024 om 00:03 schreef Fokko Driesprong :

Re: [DISCUSS] Merge script for parquet-java and parquet-format

2024-07-23 Thread Julien Le Dem
The merge script existed originally because The ASF only allowed merging in the apache git repo and the github repo was just a read-only mirror. Now that this is not the case anymore, I am also in favor of just using github. On Mon, Jul 22, 2024 at 3:40 AM Fokko Driesprong wrote: > Hey everyone,

Re: [DISCUSS] Merge script for parquet-java and parquet-format

2024-07-31 Thread Micah Kornfield
Just to close on this, I'll go ahead and delete the merge script and we'll try to use github workflows, we can always reassess the process at some later point. On Tue, Jul 23, 2024 at 1:09 PM Julien Le Dem wrote: > The merge script existed originally because The ASF only allowed merging in > the