Re: [PR] PARQUET-2385: Allow user to specify CodecFactory for ParquetWriter [parquet-mr]

2023-12-03 Thread via GitHub
wgtmac merged PR #1203: URL: https://github.com/apache/parquet-mr/pull/1203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apac

Re: [PR] PARQUET-2385: Allow user to specify CodecFactory for ParquetWriter [parquet-mr]

2023-11-30 Thread via GitHub
amousavigourabi commented on PR #1203: URL: https://github.com/apache/parquet-mr/pull/1203#issuecomment-183334 > @amousavigourabi It seems a rebase is required. @wgtmac Done, thanks for the heads up😄 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] PARQUET-2385: Allow user to specify CodecFactory for ParquetWriter [parquet-mr]

2023-11-30 Thread via GitHub
wgtmac commented on PR #1203: URL: https://github.com/apache/parquet-mr/pull/1203#issuecomment-1833368029 @amousavigourabi It seems a rebase is required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] PARQUET-2385: Allow user to specify CodecFactory for ParquetWriter [parquet-mr]

2023-11-27 Thread via GitHub
amousavigourabi commented on PR #1203: URL: https://github.com/apache/parquet-mr/pull/1203#issuecomment-1828048073 > > @wgtmac , after the comments on the code style I had a quick look through the repository and found that indentations and the such differ quite drastically between (and even

Re: [PR] PARQUET-2385: Allow user to specify CodecFactory for ParquetWriter [parquet-mr]

2023-11-27 Thread via GitHub
wgtmac commented on PR #1203: URL: https://github.com/apache/parquet-mr/pull/1203#issuecomment-1828031389 cc @Fokko -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] PARQUET-2385: Allow user to specify CodecFactory for ParquetWriter [parquet-mr]

2023-11-27 Thread via GitHub
wgtmac commented on PR #1203: URL: https://github.com/apache/parquet-mr/pull/1203#issuecomment-1828030327 > @wgtmac , after the comments on the code style I had a quick look through the repository and found that indentations and the such differ quite drastically between (and even within) fi

Re: [PR] PARQUET-2385: Allow user to specify CodecFactory for ParquetWriter [parquet-mr]

2023-11-27 Thread via GitHub
amousavigourabi commented on PR #1203: URL: https://github.com/apache/parquet-mr/pull/1203#issuecomment-1827942202 @wgtmac , after the comments on the code style I had a quick look through the repository and found that indentations and the such differ quite drastically between (and even wit

Re: [PR] PARQUET-2385: Allow user to specify CodecFactory for ParquetWriter [parquet-mr]

2023-11-26 Thread via GitHub
wgtmac commented on code in PR #1203: URL: https://github.com/apache/parquet-mr/pull/1203#discussion_r1405536183 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetWriter.java: ## @@ -303,6 +303,32 @@ public ParquetWriter(Path file, Configuration conf, WriteSuppor

[PR] PARQUET-2385: Allow user to specify CodecFactory for ParquetWriter [parquet-mr]

2023-11-24 Thread via GitHub
amousavigourabi opened a new pull request, #1203: URL: https://github.com/apache/parquet-mr/pull/1203 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references