I think that a call that results in printing the usage should result in
a non-null exit code.
Tilman
Am 15.01.2015 um 18:13 schrieb Maruan Sahyoun:
Yes,
current behavior within the tools
usage(): some tools have a System.exit, some don't and for the ones they have
the exit code is not
[
https://issues.apache.org/jira/browse/PDFBOX-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279014#comment-14279014
]
ASF subversion and git services commented on PDFBOX-2600:
-
Commit
[
https://issues.apache.org/jira/browse/PDFBOX-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278949#comment-14278949
]
ASF subversion and git services commented on PDFBOX-2600:
-
Commit
[
https://issues.apache.org/jira/browse/PDFBOX-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279010#comment-14279010
]
ASF subversion and git services commented on PDFBOX-2600:
-
Commit
Am 15.01.2015 um 18:55 schrieb Tilman Hausherr thaush...@t-online.de:
Am 15.01.2015 um 18:50 schrieb Maruan Sahyoun:
Am 15.01.2015 um 18:47 schrieb Tilman Hausherr thaush...@t-online.de:
I think that a call that results in printing the usage should result in a
non-null exit code.
Yes,
current behavior within the tools
usage(): some tools have a System.exit, some don't and for the ones they have
the exit code is not always the same.
-main() there is no System.exit for the ones I looked at in case of an error.
Only an error message is written to System.err
You'd rather
If the usage was printed due to invalid command line parameters, then the
convention on Unix is to return exit code 1. We should be doing that too.
Note than if Java throws an exception which causes main() to exit and there is
no catch clause, then java will return a non-zero code of its own
so if I understand an summarize correctly we'd change
- the usage() for all to return 1
- print messages on exceptions to System.err
- rethrow the exception so java can handle it if it will terminate afterwards
anyway
- use something above 2 and below 126 as an error code for System.exit() if
Hi,
Am 15.01.2015 um 17:20 schrieb John Hewson:
Only if there's a non-zero number used as the argument.
Yes, but IMO such a value is only useful if there is any processing issue.
Maruans question targets those calls within the usage message which is shown
only if there is any issue with the
Am 15.01.2015 um 18:50 schrieb Maruan Sahyoun:
Am 15.01.2015 um 18:47 schrieb Tilman Hausherr thaush...@t-online.de:
I think that a call that results in printing the usage should result in a
non-null exit code.
fine - but shouldn't an error in processing not also lead to a non-null exit
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279029#comment-14279029
]
ASF subversion and git services commented on PDFBOX-2576:
-
Commit
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279044#comment-14279044
]
ASF subversion and git services commented on PDFBOX-2576:
-
Commit
Am 15.01.2015 um 18:47 schrieb Tilman Hausherr thaush...@t-online.de:
I think that a call that results in printing the usage should result in a
non-null exit code.
fine - but shouldn't an error in processing not also lead to a non-null exit
code?
Tilman
Am 15.01.2015 um 18:13 schrieb
[
https://issues.apache.org/jira/browse/PDFBOX-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279009#comment-14279009
]
ASF subversion and git services commented on PDFBOX-2600:
-
Commit
[
https://issues.apache.org/jira/browse/PDFBOX-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279007#comment-14279007
]
ASF subversion and git services commented on PDFBOX-2600:
-
Commit
Only if there's a non-zero number used as the argument.
-- John
On 15 Jan 2015, at 06:06, Maruan Sahyoun sahy...@fileaffairs.de wrote:
Hi,
do we need System.exit() in our command line tools usage messages? Opinions?
Don't see a benefit of having them.
BR
Maruan
See
https://builds.apache.org/job/PDFBox-trunk/org.apache.pdfbox$pdfbox/1683/changes
See https://builds.apache.org/job/PDFBox-trunk/1683/changes
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279197#comment-14279197
]
ASF subversion and git services commented on PDFBOX-2576:
-
Commit
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279234#comment-14279234
]
ASF subversion and git services commented on PDFBOX-2576:
-
Commit
[
https://issues.apache.org/jira/browse/PDFBOX-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279265#comment-14279265
]
ASF subversion and git services commented on PDFBOX-2516:
-
Commit
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279132#comment-14279132
]
ASF subversion and git services commented on PDFBOX-2576:
-
Commit
[
https://issues.apache.org/jira/browse/PDFBOX-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279155#comment-14279155
]
ASF subversion and git services commented on PDFBOX-2601:
-
Commit
[
https://issues.apache.org/jira/browse/PDFBOX-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tilman Hausherr resolved PDFBOX-2601.
-
Resolution: Fixed
fix getHashObjectIdentifier in TSAClient
[
https://issues.apache.org/jira/browse/PDFBOX-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279311#comment-14279311
]
ASF subversion and git services commented on PDFBOX-2516:
-
Commit
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279137#comment-14279137
]
ASF subversion and git services commented on PDFBOX-2576:
-
Commit
See
https://builds.apache.org/job/PDFBox-trunk/org.apache.pdfbox$pdfbox/1684/changes
[
https://issues.apache.org/jira/browse/PDFBOX-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279349#comment-14279349
]
ASF subversion and git services commented on PDFBOX-2516:
-
Commit
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279128#comment-14279128
]
ASF subversion and git services commented on PDFBOX-2576:
-
Commit
Tilman Hausherr created PDFBOX-2601:
---
Summary: fix getHashObjectIdentifier in TSAClient
Key: PDFBOX-2601
URL: https://issues.apache.org/jira/browse/PDFBOX-2601
Project: PDFBox
Issue Type:
Maruan Sahyoun created PDFBOX-2602:
--
Summary: Enhance command line tools
Key: PDFBOX-2602
URL: https://issues.apache.org/jira/browse/PDFBOX-2602
Project: PDFBox
Issue Type: Bug
Affects
On 15 Jan 2015, at 10:56, Maruan Sahyoun sahy...@fileaffairs.de wrote:
so if I understand an summarize correctly we'd change
- the usage() for all to return 1
Except when the user has asked for the usage via -h, because that’s a success,
not a failure.
- print messages on exceptions to
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279139#comment-14279139
]
ASF subversion and git services commented on PDFBOX-2576:
-
Commit
On 15 Jan 2015, at 10:56, Maruan Sahyoun sahy...@fileaffairs.de wrote:
so if I understand an summarize correctly we'd change
- the usage() for all to return 1
Except when the user has asked for the usage via -h, because that’s a
success, not a failure.
as there is no -h at the
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279438#comment-14279438
]
ASF subversion and git services commented on PDFBOX-2576:
-
Commit
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279441#comment-14279441
]
ASF subversion and git services commented on PDFBOX-2576:
-
Commit
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279470#comment-14279470
]
ASF subversion and git services commented on PDFBOX-2576:
-
Commit
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279482#comment-14279482
]
ASF subversion and git services commented on PDFBOX-2576:
-
Commit
[
https://issues.apache.org/jira/browse/PDFBOX-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279523#comment-14279523
]
John Hewson commented on PDFBOX-2601:
-
{quote}SHA-394 is the model number of a
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279536#comment-14279536
]
John Hewson commented on PDFBOX-2576:
-
This does not improve the code quality,
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279538#comment-14279538
]
John Hewson commented on PDFBOX-2576:
-
See above.
Improve code quality
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279539#comment-14279539
]
John Hewson commented on PDFBOX-2576:
-
See above.
Improve code quality
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279374#comment-14279374
]
ASF subversion and git services commented on PDFBOX-2576:
-
Commit
On 15 Jan 2015, at 11:21, Maruan Sahyoun sahy...@fileaffairs.de wrote:
On 15 Jan 2015, at 10:56, Maruan Sahyoun sahy...@fileaffairs.de wrote:
so if I understand an summarize correctly we'd change
- the usage() for all to return 1
Except when the user has asked for the usage via -h,
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279538#comment-14279538
]
John Hewson edited comment on PDFBOX-2576 at 1/15/15 11:49 PM:
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279537#comment-14279537
]
John Hewson edited comment on PDFBOX-2576 at 1/15/15 11:48 PM:
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279379#comment-14279379
]
ASF subversion and git services commented on PDFBOX-2576:
-
Commit
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279380#comment-14279380
]
ASF subversion and git services commented on PDFBOX-2576:
-
Commit
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279393#comment-14279393
]
ASF subversion and git services commented on PDFBOX-2576:
-
Commit
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279477#comment-14279477
]
ASF subversion and git services commented on PDFBOX-2576:
-
Commit
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279480#comment-14279480
]
ASF subversion and git services commented on PDFBOX-2576:
-
Commit
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279539#comment-14279539
]
John Hewson edited comment on PDFBOX-2576 at 1/15/15 11:50 PM:
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279432#comment-14279432
]
ASF subversion and git services commented on PDFBOX-2576:
-
Commit
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279463#comment-14279463
]
ASF subversion and git services commented on PDFBOX-2576:
-
Commit
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279536#comment-14279536
]
John Hewson edited comment on PDFBOX-2576 at 1/15/15 11:48 PM:
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279537#comment-14279537
]
John Hewson commented on PDFBOX-2576:
-
See above.
Improve code quality
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279451#comment-14279451
]
ASF subversion and git services commented on PDFBOX-2576:
-
Commit
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279456#comment-14279456
]
ASF subversion and git services commented on PDFBOX-2576:
-
Commit
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279475#comment-14279475
]
ASF subversion and git services commented on PDFBOX-2576:
-
Commit
[
https://issues.apache.org/jira/browse/PDFBOX-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279847#comment-14279847
]
Tilman Hausherr commented on PDFBOX-2596:
-
{quote}
{code}
PDPage templatePage =
[
https://issues.apache.org/jira/browse/PDFBOX-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279847#comment-14279847
]
Tilman Hausherr edited comment on PDFBOX-2596 at 1/16/15 6:11 AM:
[
https://issues.apache.org/jira/browse/PDFBOX-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279847#comment-14279847
]
Tilman Hausherr edited comment on PDFBOX-2596 at 1/16/15 6:12 AM:
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279879#comment-14279879
]
ASF subversion and git services commented on PDFBOX-2576:
-
Commit
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279882#comment-14279882
]
ASF subversion and git services commented on PDFBOX-2576:
-
Commit
[
https://issues.apache.org/jira/browse/PDFBOX-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279904#comment-14279904
]
John Hewson commented on PDFBOX-2596:
-
By not holding a reference to the PDDocument
[
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279909#comment-14279909
]
ASF subversion and git services commented on PDFBOX-2576:
-
Commit
[
https://issues.apache.org/jira/browse/PDFBOX-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279915#comment-14279915
]
John Hewson commented on PDFBOX-2596:
-
As an aside, the code which calls close() in
[
https://issues.apache.org/jira/browse/PDFBOX-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279915#comment-14279915
]
John Hewson edited comment on PDFBOX-2596 at 1/16/15 7:23 AM:
[
https://issues.apache.org/jira/browse/PDFBOX-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279915#comment-14279915
]
John Hewson edited comment on PDFBOX-2596 at 1/16/15 7:22 AM:
[
https://issues.apache.org/jira/browse/PDFBOX-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279915#comment-14279915
]
John Hewson edited comment on PDFBOX-2596 at 1/16/15 7:24 AM:
[
https://issues.apache.org/jira/browse/PDFBOX-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279915#comment-14279915
]
John Hewson edited comment on PDFBOX-2596 at 1/16/15 7:23 AM:
[
https://issues.apache.org/jira/browse/PDFBOX-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279904#comment-14279904
]
John Hewson edited comment on PDFBOX-2596 at 1/16/15 7:26 AM:
[
https://issues.apache.org/jira/browse/PDFBOX-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279915#comment-14279915
]
John Hewson edited comment on PDFBOX-2596 at 1/16/15 7:27 AM:
[
https://issues.apache.org/jira/browse/PDFBOX-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279915#comment-14279915
]
John Hewson edited comment on PDFBOX-2596 at 1/16/15 7:27 AM:
[
https://issues.apache.org/jira/browse/PDFBOX-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279915#comment-14279915
]
John Hewson edited comment on PDFBOX-2596 at 1/16/15 7:29 AM:
Stefano Maestri created PDFBOX-2603:
---
Summary: deployment under jboss 7
Key: PDFBOX-2603
URL: https://issues.apache.org/jira/browse/PDFBOX-2603
Project: PDFBox
Issue Type: Task
[
https://issues.apache.org/jira/browse/PDFBOX-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279724#comment-14279724
]
John Roche commented on PDFBOX-2596:
I've done some more digging and although I
Hi,
do we need System.exit() in our command line tools usage messages? Opinions?
Don't see a benefit of having them.
BR
Maruan
See https://builds.apache.org/job/PDFBox-trunk/1684/changes
79 matches
Mail list logo
