Re: dynamic request hook ordering (take 2)

2004-02-29 Thread Geoffrey Young
>> or you could just comment out each >>different startup in TEST.PL (or just TEST if you don't feel like running >>Makefile.PL each time) and run each one at a time. > > > I just did that - only two of the tests sequences run > individually - one where -defines is '' and the other when > it's 'R

Re: dynamic request hook ordering (take 2)

2004-02-29 Thread Randy Kobes
On Sun, 29 Feb 2004, Geoffrey Young wrote: > > > Hi Geoff, > > hey randy. hope you had a nice vacation :) Thanks :) Actually, it was a bunch of meetings for deciding on some grants, which was interesting, but stressful ... > >However, when running the tests, what happens is that the > > tes

Re: dynamic request hook ordering (take 2)

2004-02-29 Thread Geoffrey Young
> Hi Geoff, hey randy. hope you had a nice vacation :) > I've tried this out on Win32 - nice work! Just a small > thing - in src/modules/perl/modperl_apache.c, there's a > declaration of 'int j' in modperl_apache_resort_hooks() that > VC++ didn't like occurring so late - moving it up near t

Re: dynamic request hook ordering (take 2)

2004-02-29 Thread Randy Kobes
On Sun, 29 Feb 2004, Geoffrey Young wrote: > here's another pass that incorporates the suggestions thus > far. comments on the global foo appreciated. the tests I > posted before are still valid at this point. > > --Geoff Hi Geoff, I've tried this out on Win32 - nice work! Just a small thin

Re: cvs commit: modperl-docs/src/docs/2.0/api/Apache PerlSections.pod

2004-02-29 Thread Stas Bekman
Philippe M. Chiasson wrote: I did run podchecker, but, yes, next time I'll run bin/build and all. It's a problem in Pod::POM which is not podspec complient :( __ Stas BekmanJAm_pH --> Just Another mod_perl Hacker http

Re: cvs commit: modperl-docs/src/docs/2.0/api/Apache PerlSections.pod

2004-02-29 Thread Philippe M. Chiasson
On Sun, 2004-02-29 at 18:30, Stas Bekman wrote: > Philippe M. Chiasson wrote: > > On Sun, 2004-02-29 at 00:54, [EMAIL PROTECTED] wrote: > > > >>stas2004/02/29 00:54:59 > >> > >> Modified:src/docs/2.0/api/Apache PerlSections.pod > >> Log: > >> escape -> in pod > > > > > > Oy! Thank

Re: cvs commit: modperl-docs/src/docs/2.0/api/Apache PerlSections.pod

2004-02-29 Thread Stas Bekman
Philippe M. Chiasson wrote: On Sun, 2004-02-29 at 00:54, [EMAIL PROTECTED] wrote: stas2004/02/29 00:54:59 Modified:src/docs/2.0/api/Apache PerlSections.pod Log: escape -> in pod Oy! Thanks stas! my bad ;-S No probs ;) I rushed to fix it as the cronjob would have complained again

Re: dynamic request hook ordering (take 2)

2004-02-29 Thread Stas Bekman
Geoffrey Young wrote: Stas Bekman wrote: Geoffrey Young wrote: Much better, but still why having any data at all in mod_perl.c? Have the static variable in modperl_apache.c and provide an accessor to do: hook_order = apr_table_make(p, 0); from modperl_apache.c. Now you are all set. well, I ca

Re: dynamic request hook ordering (take 2)

2004-02-29 Thread Geoffrey Young
Stas Bekman wrote: > Geoffrey Young wrote: > >>> Much better, but still why having any data at all in mod_perl.c? Have >>> the static variable in modperl_apache.c and provide an accessor to do: >>> >>> hook_order = apr_table_make(p, 0); >>> >>> from modperl_apache.c. Now you are all set. >> >> >

Re: dynamic request hook ordering (take 2)

2004-02-29 Thread Stas Bekman
Geoffrey Young wrote: Much better, but still why having any data at all in mod_perl.c? Have the static variable in modperl_apache.c and provide an accessor to do: hook_order = apr_table_make(p, 0); from modperl_apache.c. Now you are all set. well, I can't see where to draw the pool from or how e

Re: dynamic request hook ordering (take 2)

2004-02-29 Thread Geoffrey Young
> Much better, but still why having any data at all in mod_perl.c? Have > the static variable in modperl_apache.c and provide an accessor to do: > > hook_order = apr_table_make(p, 0); > > from modperl_apache.c. Now you are all set. well, I can't see where to draw the pool from or how else to in

Re: dynamic request hook ordering (take 2)

2004-02-29 Thread Stas Bekman
Geoffrey Young wrote: here's another pass that incorporates the suggestions thus far. comments on the global foo appreciated. the tests I posted before are still valid at this point. Much better, but still why having any data at all in mod_perl.c? Have the static variable in modperl_apache.c and