Re: [mp2] failure to compile mod_perl-1.99_15-dev on NetBSD 1.6.2

2004-08-19 Thread Randy Kobes
On Thu, 19 Aug 2004, Stas Bekman wrote: > Stas Bekman wrote: > > > >>> make: stopped in /data/src/mod_perl-1.99_15-dev > >>> steel1: {30} cd xs/APR/aprext/ > >>> steel1: {31} make dynamic > >>> make: don't know how to make dynamic. Stop > > > > > > OK, Carl, please file a bug report at: > > http:/

Re: smoky has found a segfault

2004-08-19 Thread Joe Schaefer
Stas Bekman <[EMAIL PROTECTED]> writes: [...] > You were saying delete (which is remove+destroy): > http://marc.theaimsgroup.com/?l=apache-modperl-dev&m=109285355117298&w=2 > >$b->delete; # APR::Bucket needs to wrap apr_bucket_delete(), ># since APR_BUCKET_REMOVE() do

Re: smoky has found a segfault

2004-08-19 Thread Stas Bekman
Joe Schaefer wrote: Stas Bekman <[EMAIL PROTECTED]> writes: So how do we clean them up? Last time you said that you do want to remove them With either *apr_bucket_destroy* or *apr_brigade_cleanup*, which is what I've been saying all along. You were saying delete (which is remove+destroy): http://

Re: smoky has found a segfault

2004-08-19 Thread Joe Schaefer
Stas Bekman <[EMAIL PROTECTED]> writes: > So how do we clean them up? Last time you said that you do want to > remove them With either *apr_bucket_destroy* or *apr_brigade_cleanup*, which is what I've been saying all along. -- Joe Schaefer -

Re: smoky has found a segfault

2004-08-19 Thread Stas Bekman
Joe Schaefer wrote: Stas Bekman <[EMAIL PROTECTED]> writes: Joe Schaefer wrote: [...] == MODULE = APR::BrigadePACKAGE = APR::Brigade PREFIX = apr_brigade_ apr_status_t apr_brigade_cleanup(data) void * data =

Re: smoky has found a segfault

2004-08-19 Thread Joe Schaefer
Stas Bekman <[EMAIL PROTECTED]> writes: > Joe Schaefer wrote: [...] > > == > > MODULE = APR::BrigadePACKAGE = APR::Brigade PREFIX = apr_brigade_ > > apr_status_t > > apr_brigade_cleanup(data) > > void * data > > ==

Re: [mp2] failure to compile mod_perl-1.99_15-dev on NetBSD 1.6.2

2004-08-19 Thread Stas Bekman
Stas Bekman wrote: make: stopped in /data/src/mod_perl-1.99_15-dev steel1: {30} cd xs/APR/aprext/ steel1: {31} make dynamic make: don't know how to make dynamic. Stop OK, Carl, please file a bug report at: http://rt.cpan.org/NoAuth/ReportBug.html?Queue=ExtUtils-MakeMaker OK, Carl has submitted it

Re: [mp2] failure to compile mod_perl-1.99_15-dev on NetBSD 1.6.2

2004-08-19 Thread Stas Bekman
make: stopped in /data/src/mod_perl-1.99_15-dev steel1: {30} cd xs/APR/aprext/ steel1: {31} make dynamic make: don't know how to make dynamic. Stop OK, Carl, please file a bug report at: http://rt.cpan.org/NoAuth/ReportBug.html?Queue=ExtUtils-MakeMaker The message should be Subject: SKIP doesn't w

Re: [mp2] t\apache\discard_rbody.t smoked

2004-08-19 Thread Stas Bekman
Markus Wichitill wrote: Stas Bekman wrote: OK, reverting my last patch (back to normal cvs) and trying this one? No change. That should probably be right, since the error happens after the response is sent (observer 200 codes in access_log). So what do you think could be the cause of the dropped

Re: [mp2] t\apache\discard_rbody.t smoked

2004-08-19 Thread Markus Wichitill
Stas Bekman wrote: OK, reverting my last patch (back to normal cvs) and trying this one? No change. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: smoky has found a segfault

2004-08-19 Thread Stas Bekman
Joe Schaefer wrote: Stas Bekman <[EMAIL PROTECTED]> writes: Joe Schaefer wrote: Stas Bekman <[EMAIL PROTECTED]> writes: [...] Heh, I tried that (removing $b->remove), and t/compat/request_body.t then segfaults right there, all by itself. :-( Did you remember to replace it with $bb->cleanup? I can

Re: [mp2] t\apache\discard_rbody.t smoked

2004-08-19 Thread Stas Bekman
Markus Wichitill wrote: Stas Bekman wrote: The access log says that the failing test wasn't really failing, as you can see the stamp 200, so it must be some glitch on the data transport level. Could it be a fault of LWP? Try the same test after you have set: APACHE_TEST_PRETEND_NO_LWP=1, in whic

Re: [mp2] failure to compile mod_perl-1.99_15-dev on NetBSD 1.6.2

2004-08-19 Thread Stas Bekman
Carl Brewer wrote: Stas Bekman wrote: Carl Brewer wrote: S Looks fine as it's in .PHONY. You should be able to do % cd xs/APR/aprext/Makefile % make dynamic make: Nothing to be done for `dynamic'. steel1: {7} cd xs/APR/aprext/ steel1: {8} make dynmaic make: don't know how to make dynmaic. Stop ma

Re: [mp2] failure to compile mod_perl-1.99_15-dev on NetBSD 1.6.2

2004-08-19 Thread Carl Brewer
Stas Bekman wrote: Carl Brewer wrote: S Looks fine as it's in .PHONY. You should be able to do % cd xs/APR/aprext/Makefile % make dynamic make: Nothing to be done for `dynamic'. steel1: {7} cd xs/APR/aprext/ steel1: {8} make dynmaic make: don't know how to make dynmaic. Stop make: stopped in /dat

Re: [mp2] t\apache\discard_rbody.t smoked

2004-08-19 Thread Markus Wichitill
Stas Bekman wrote: The access log says that the failing test wasn't really failing, as you can see the stamp 200, so it must be some glitch on the data transport level. Could it be a fault of LWP? Try the same test after you have set: APACHE_TEST_PRETEND_NO_LWP=1, in which case it won't use LWP

Re: [mp2] failure to compile mod_perl-1.99_15-dev on NetBSD 1.6.2

2004-08-19 Thread Stas Bekman
Carl Brewer wrote: S Looks fine as it's in .PHONY. You should be able to do % cd xs/APR/aprext/Makefile % make dynamic make: Nothing to be done for `dynamic'. steel1: {7} cd xs/APR/aprext/ steel1: {8} make dynmaic make: don't know how to make dynmaic. Stop make: stopped in /data/src/mod_perl-1.99

Re: [mp2] lingering deleted cvs directories

2004-08-19 Thread Stas Bekman
Markus Wichitill wrote: Stas Bekman wrote: a fresh modperl-2.0 chekout: cvs -d [EMAIL PROTECTED]:/home/cvs co modperl-2.0 with ~/.cvsrc: cvs -z9 update -dP diff -u checks out directories which were long deleted: examples/ pod/ xs/APR/Lib that breaks 'make dist' as they disappear as soon as I run 'c

Re: [mp2] failure to compile mod_perl-1.99_15-dev on NetBSD 1.6.2

2004-08-19 Thread Carl Brewer
S Looks fine as it's in .PHONY. You should be able to do % cd xs/APR/aprext/Makefile % make dynamic make: Nothing to be done for `dynamic'. steel1: {7} cd xs/APR/aprext/ steel1: {8} make dynmaic make: don't know how to make dynmaic. Stop make: stopped in /data/src/mod_perl-1.99_15-dev/xs/APR/apre

Re: [mp2] failure to compile mod_perl-1.99_15-dev on NetBSD 1.6.2

2004-08-19 Thread Stas Bekman
Carl Brewer wrote: Stas Bekman wrote: Please post the output of: grep dynamic xs/APR/aprext/Makefile steel1: {4} grep dynamic xs/APR/aprext/Makefile # SKIP => [q[dynamic], q[test], q[static]] [...] .PHONY: all config static dynamic test linkext manifest Looks fine as it's in .PHONY. You shoul

Re: [mp2] failure to compile mod_perl-1.99_15-dev on NetBSD 1.6.2

2004-08-19 Thread Carl Brewer
Stas Bekman wrote: Please post the output of: grep dynamic xs/APR/aprext/Makefile steel1: {4} grep dynamic xs/APR/aprext/Makefile # SKIP => [q[dynamic], q[test], q[static]] # dynamic_lib => { OTHERLDFLAGS=>q[ -Wl,-rpath,/usr/pkg/lib -Wl,-rpath,/usr/local/lib -L/usr/pkg/lib -L/usr/local/l

Re: [mp2] lingering deleted cvs directories

2004-08-19 Thread Markus Wichitill
Stas Bekman wrote: a fresh modperl-2.0 chekout: cvs -d [EMAIL PROTECTED]:/home/cvs co modperl-2.0 with ~/.cvsrc: cvs -z9 update -dP diff -u checks out directories which were long deleted: examples/ pod/ xs/APR/Lib that breaks 'make dist' as they disappear as soon as I run 'cvs up'. Do you think it

Re: [mp2] failure to compile mod_perl-1.99_15-dev on NetBSD 1.6.2

2004-08-19 Thread Stas Bekman
Hey Carl, This is the output from running make after a routine perl Makefile.PL MP_APXS=/usr/local/apache2/bin/apxs make make: don't know how to make dynamic. Stop make: stopped in /data/src/mod_perl-1.99_15-dev/xs/APR/aprext *** Error code 2 Please post the output of: grep dynamic xs/APR/aprext/M

Re: [mp2] t\apache\discard_rbody.t smoked

2004-08-19 Thread Stas Bekman
Markus Wichitill wrote: Stas Bekman wrote: The access log says that the failing test wasn't really failing, as you can see the stamp 200, so it must be some glitch on the data transport level. Could it be a fault of LWP? Try the same test after you have set: APACHE_TEST_PRETEND_NO_LWP=1, in whic

[mp2] failure to compile mod_perl-1.99_15-dev on NetBSD 1.6.2

2004-08-19 Thread Carl Brewer
8<-- Start Bug Report 8<-- 1. Problem Description: Failure at compile time 2. Used Components and their Configuration: *** mod_perl version 1.9915 *** using /data/src/mod_perl-1.99_15-dev/bin/../lib/Apache/BuildConfig.pm *** Makefile.PL options: MP_APR_LI

Re: [mp2] t\apache\discard_rbody.t smoked

2004-08-19 Thread Markus Wichitill
Stas Bekman wrote: The access log says that the failing test wasn't really failing, as you can see the stamp 200, so it must be some glitch on the data transport level. Could it be a fault of LWP? Try the same test after you have set: APACHE_TEST_PRETEND_NO_LWP=1, in which case it won't use LWP a

[mp2] lingering deleted cvs directories

2004-08-19 Thread Stas Bekman
a fresh modperl-2.0 chekout: cvs -d [EMAIL PROTECTED]:/home/cvs co modperl-2.0 with ~/.cvsrc: cvs -z9 update -dP diff -u checks out directories which were long deleted: examples/ pod/ xs/APR/Lib that breaks 'make dist' as they disappear as soon as I run 'cvs up'. Do you think it's a cvs client pro

eliminating modperl-2.0/patches dir?

2004-08-19 Thread Stas Bekman
You discover interesting things when doing release packaging. Apparently we had an apache patch to do static modperl for years at: modperl-2.0/patches/link-hack.pat I suppose it's no longer needed, right Philippe? There is also modperl-2.0/patches/c-scan.pat which is the patch against the origin

Re: [mp2] t\apache\discard_rbody.t smoked

2004-08-19 Thread Stas Bekman
Markus Wichitill wrote: Stas Bekman wrote: I've seen those too sometimes. What's OS 10053 on win32? ECONNABORTED? WSAECONNABORTED Software caused connection abort. An established connection was aborted by the software in your host computer, possibly due to a data transmission time-out or protocol

Re: smoky has found a segfault

2004-08-19 Thread Joe Schaefer
Stas Bekman <[EMAIL PROTECTED]> writes: > Joe Schaefer wrote: > > Stas Bekman <[EMAIL PROTECTED]> writes: > > [...] > > > >>Heh, I tried that (removing $b->remove), and t/compat/request_body.t > >>then segfaults right there, all by itself. > > :-( Did you remember to replace it with $bb->cleanup?

Re: [mp2] t\apache\discard_rbody.t smoked

2004-08-19 Thread Markus Wichitill
Stas Bekman wrote: I've seen those too sometimes. What's OS 10053 on win32? ECONNABORTED? WSAECONNABORTED Software caused connection abort. An established connection was aborted by the software in your host computer, possibly due to a data transmission time-out or protocol error. perl t\TEST -v t

[mp2] code freeze

2004-08-19 Thread Stas Bekman
in case you haven't noticed i've posted an RC, so we enter the code freeze phase. So please avoid committing code changes, unless they are fixes of something that's broken (e.g. tests). I think we may want to change that practice in order not to create obstacles for new development. We should T

Re: [PATCH] 2.1 build foo

2004-08-19 Thread Stas Bekman
Joe Orton wrote: On Wed, Aug 18, 2004 at 12:34:01PM -0700, Stas Bekman wrote: Joe Orton wrote: On Wed, Aug 18, 2004 at 07:55:25PM +0100, Joe Orton wrote: On Wed, Aug 18, 2004 at 10:54:13AM -0700, Stas Bekman wrote: Joe Orton wrote: Thanks Joe. Any chance this can be rewritten to find out what syn

Re: [mp2] cleaning up Apache::Log

2004-08-19 Thread Geoffrey Young
> ($r|$s)->log->(warn|crit|...) are all there. They are fine (well, not > exactly all of them, but I'm working on that). cool. then I'm fine with your suggestion. --Geoff - To unsubscribe, e-mail: [EMAIL PROTECTED] For additi

Re: smoky has found a segfault

2004-08-19 Thread Stas Bekman
Joe Schaefer wrote: Stas Bekman <[EMAIL PROTECTED]> writes: [...] Heh, I tried that (removing $b->remove), and t/compat/request_body.t then segfaults right there, all by itself. :-( Did you remember to replace it with $bb->cleanup? I can't. Remember it crashes on win32: http://marc.theaimsgroup.c

Re: [mp2] cleaning up Apache::Log

2004-08-19 Thread Stas Bekman
Vivek Khera wrote: On Aug 19, 2004, at 3:03 AM, Stas Bekman wrote: And I'm still trying to figure out whether it's possible to make 'a plain warn()' log into the vhost log (die already logs into the vhost log). I haven't yet checked how it worked in mp1, I think it never did. A plain warn() in m

Re: [mp2] cleaning up Apache::Log

2004-08-19 Thread Stas Bekman
Geoffrey Young wrote: I think this should be reduced to: * $r->log_error * $r->warn * $s->log_error * $s->warn don't forget about $r->log->warn(), which is slightly different than $r->warn() in mp1, as well as $r->log->info(), etc which are frequently used in mp1. I haven't checke

Re: [mp2] cleaning up Apache::Log

2004-08-19 Thread Geoffrey Young
> I think this should be reduced to: > > * $r->log_error > * $r->warn > * $s->log_error > * $s->warn don't forget about $r->log->warn(), which is slightly different than $r->warn() in mp1, as well as $r->log->info(), etc which are frequently used in mp1. I haven't checked if

Re: [mp2] t\apache\discard_rbody.t smoked

2004-08-19 Thread Stas Bekman
Markus Wichitill wrote: SMOKE found another failing test combination on Win32: [Thu Aug 19 17:15:07 2004] [info] (OS 10053)An established connection was aborted by the software in your host machine. : core_output_filter: writing data to the network I've seen those too sometimes. What's OS 10053

[mp2] t\apache\discard_rbody.t smoked

2004-08-19 Thread Markus Wichitill
SMOKE found another failing test combination on Win32: perl t\TEST -v t\preconnection\note.t t\filter\in_str_bin_data.t t\filter\out_str_declined.t t\apache\discard_rbody.t t\apache\discard_rbody...1..3 # Running under perl version 5.008005 for MSWin32 # Current time local: Thu Aug 19 17:44:2

Re: time for 1.99_15?

2004-08-19 Thread Stas Bekman
Markus Wichitill wrote: Markus Wichitill wrote: t\perl\ithreads.Scalars leaked: 1 Scalars leaked: 1 t\perl\ithreads.ok Just now I got this instead: t\perl\ithreads.Attempt to free temp prematurely: SV 0x6cc4a14, Perl interpre

Re: time for 1.99_15?

2004-08-19 Thread Markus Wichitill
Markus Wichitill wrote: t\perl\ithreads.Scalars leaked: 1 Scalars leaked: 1 t\perl\ithreads.ok Just now I got this instead: t\perl\ithreads.Attempt to free temp prematurely: SV 0x6cc4a14, Perl interpreter: 0x6c90cfc at C:\Dev

Re: time for 1.99_15?

2004-08-19 Thread Stas Bekman
Randy Kobes wrote: On Thu, 19 Aug 2004, Steve Hay wrote: Randy Kobes wrote: [ ... ] Did you (or Markus?) see any problem with the modperl/pnotes test? Before I left I was getting a failure on one of the tests that tested if an entry exists - mine didn't. This was with an ActivePerl 810 compatible

Re: time for 1.99_15?

2004-08-19 Thread Randy Kobes
On Thu, 19 Aug 2004, Steve Hay wrote: > Randy Kobes wrote: [ ... ] > >Did you (or Markus?) see any problem with the modperl/pnotes > >test? Before I left I was getting a failure on one of the > >tests that tested if an entry exists - mine didn't. This > >was with an ActivePerl 810 compatible Win32

Re: time for 1.99_15?

2004-08-19 Thread Steve Hay
Randy Kobes wrote: >On Thu, 19 Aug 2004, Steve Hay wrote: > > > >>Looks like they're all fixed now: current CVS passes all tests (incl >>ModPerl-Registry)! >> >> > >Did you (or Markus?) see any problem with the modperl/pnotes >test? Before I left I was getting a failure on one of the >tests

Re: time for 1.99_15?

2004-08-19 Thread Randy Kobes
On Thu, 19 Aug 2004, Steve Hay wrote: > Looks like they're all fixed now: current CVS passes all tests (incl > ModPerl-Registry)! Did you (or Markus?) see any problem with the modperl/pnotes test? Before I left I was getting a failure on one of the tests that tested if an entry exists - mine didn

Re: pnotes.t failures with 5.8.0

2004-08-19 Thread Randy Kobes
On Thu, 19 Aug 2004, Geoffrey Young wrote: > hi > > I'm getting a single test difference in pnotes.t between 5.8.0 and 5.8.5: > > # testing : unset entry contents > # expected: undef > # received: undef > ok 6 > not ok 7 > > since 5.8.5 seems to remove the entry entirely but 5.8.0 doesn't I'm not

Re: smoky has found a segfault

2004-08-19 Thread Joe Schaefer
Stas Bekman <[EMAIL PROTECTED]> writes: [...] > Heh, I tried that (removing $b->remove), and t/compat/request_body.t > then segfaults right there, all by itself. :-( Did you remember to replace it with $bb->cleanup? What's the backtrace look like? -- Joe Schaefer ---

pnotes.t failures with 5.8.0

2004-08-19 Thread Geoffrey Young
hi I'm getting a single test difference in pnotes.t between 5.8.0 and 5.8.5: # testing : unset entry contents # expected: undef # received: undef ok 6 not ok 7 since 5.8.5 seems to remove the entry entirely but 5.8.0 doesn't I'm not exactly sure where the problem is. perl -V for both below. an

Re: [PATCH] 2.1 build foo

2004-08-19 Thread Joe Orton
On Wed, Aug 18, 2004 at 12:34:01PM -0700, Stas Bekman wrote: > Joe Orton wrote: > >On Wed, Aug 18, 2004 at 07:55:25PM +0100, Joe Orton wrote: > > > >>On Wed, Aug 18, 2004 at 10:54:13AM -0700, Stas Bekman wrote: > >> > >>>Joe Orton wrote: > >>>Thanks Joe. > >>> > >>>Any chance this can be rewritten

Re: [mp2] cleaning up Apache::Log

2004-08-19 Thread Vivek Khera
On Aug 19, 2004, at 3:03 AM, Stas Bekman wrote: And I'm still trying to figure out whether it's possible to make 'a plain warn()' log into the vhost log (die already logs into the vhost log). I haven't yet checked how it worked in mp1, I think it never did. A plain warn() in mp1 does end up in t

Re: time for 1.99_15?

2004-08-19 Thread Steve Hay
Randy Kobes wrote: >On Tue, 17 Aug 2004, Stas Bekman wrote: > > > >>So, do we have any showstoppers for 1.99_15 release? Should some tests be >>excluded from the distro? >> >> > >Apart from the problem you found today with the segfault, >I'd say (but perhaps Steve has a better feeling) that,

Re: [mp2] t\filter\in_bbs_inject_header.t crashes when run alone

2004-08-19 Thread Steve Hay
Markus Wichitill wrote: >Stas Bekman wrote: > > >>>May be we just drop safemalloc, and use the plain old malloc, or now >>>that we are more educated with apache internals the right solution >>>seems to be to create a sub-pool and use it to allocate memory. Let me >>>try to work on that first.

Re: smoky has found a segfault

2004-08-19 Thread Stas Bekman
Joe Schaefer wrote: [...] Instead of iterating using for(;;), use while(): while ($b = $bb->first) { ++$seen_eos, last if $b->is_eos; if ($b->read(my $buf)) { $data .= $buf; } $b->delete; # APR::Bucket needs to wrap apr_bucket_delete(), # since APR_BUCKET_REMOVE() does

Re: Win32 fails filter\out_bbs_filebucket

2004-08-19 Thread Steve Hay
Stas Bekman wrote: >>>out_bbs_filebucket.pm @ 1.3, rest @ Sunday: works >>>out_bbs_filebucket.pm @ 1.3, rest @ Monday: not anymore >>> >>> > >I reverted all related changes in cvs, please confirm that the current cvs >all works fine and I'll post a release candidate tomorrow. > Yes -- all w

[mp2] cleaning up Apache::Log

2004-08-19 Thread Stas Bekman
I'm working on finishing Apache::Log, besides several issues I've a test for (like $s->log_error logging into the main server error log instead of vhost), I want to cut the amount of the ways one can log. Among others we have: * Apache::warn * Apache->warn * Apache::Server->log_e