Re: [MP2] possible pnotes bug?

2006-03-15 Thread Philippe M. Chiasson
Geoffrey Young wrote: in order for $o to maintain it's internal state. is that right? if so, I don't like that very much. >> >>It's not right. You are confusing scalars with references in that example. > > ook, my bad - I thought the proposed "solution" was to always dereference > pnote

Re: [MP2] possible pnotes bug?

2006-03-15 Thread Geoffrey Young
>>>in order for $o to maintain it's internal state. is that right? if so, I >>>don't like that very much. > > > It's not right. You are confusing scalars with references in that example. ook, my bad - I thought the proposed "solution" was to always dereference pnotes behind the scenes, making

Re: [MP2] possible pnotes bug?

2006-03-15 Thread Philippe M. Chiasson
Perrin Harkins wrote: > On Wed, 2006-03-15 at 12:23 -0500, Geoffrey Young wrote: > >>I actually thing that would be somewhat common. and as I understand things, >>the fix would require the middle step to be >> >> -- next handler >> my $o = $r->pnotes('foo'); >> $o->set(bar => 1); # se

Re: [MP2] possible pnotes bug?

2006-03-15 Thread Torsten Foertsch
On Wednesday 15 March 2006 18:55, Perrin Harkins wrote: > On Wed, 2006-03-15 at 12:23 -0500, Geoffrey Young wrote: > > I actually thing that would be somewhat common. and as I understand > > things, the fix would require the middle step to be > > > > -- next handler > > my $o = $r->pnotes('foo

Re: [MP2] possible pnotes bug?

2006-03-15 Thread Torsten Foertsch
On Wednesday 15 March 2006 18:23, Geoffrey Young wrote: > > + my $foo = 123; > > + $r->pnotes('foo' => $foo); > > + $foo = 456; > > + $r->pnotes('foo') # <== now 456 (in 2.0.2) > > + $r->pnotes('foo') # <== left at 123 (in 2.0.3) > > actually, I'm re-thinking my stance on this. a common use of pno

Re: [MP2] possible pnotes bug?

2006-03-15 Thread Perrin Harkins
On Wed, 2006-03-15 at 12:23 -0500, Geoffrey Young wrote: > I actually thing that would be somewhat common. and as I understand things, > the fix would require the middle step to be > > -- next handler > my $o = $r->pnotes('foo'); > $o->set(bar => 1); # sets $o->{_bar} = 1 > $r->p

Re: [MP2] possible pnotes bug?

2006-03-15 Thread Frank Wiles
On Wed, 15 Mar 2006 12:23:38 -0500 Geoffrey Young <[EMAIL PROTECTED]> wrote: > I actually thing that would be somewhat common. and as I understand > things, the fix would require the middle step to be > > -- next handler > my $o = $r->pnotes('foo'); > $o->set(bar => 1); # sets $o-

Re: [MP2] possible pnotes bug?

2006-03-15 Thread Geoffrey Young
> + my $foo = 123; > + $r->pnotes('foo' => $foo); > + $foo = 456; > + $r->pnotes('foo') # <== now 456 (in 2.0.2) > + $r->pnotes('foo') # <== left at 123 (in 2.0.3) actually, I'm re-thinking my stance on this. a common use of pnotes is to pass objects around. if I understand things correctly, th

Re: [MP2] possible pnotes bug?

2006-03-15 Thread Tom Schindl
Hi Geoff, As already said I'd also like to see this fix in the next release but I'd like to have a rc released to users which is announced at the user-mailing list pointing to this "API"-Change and in the same time I'd propose the following documentation patch. Tom Geoffrey Young wrote: >>>So do

Re: [MP2] possible pnotes bug?

2006-03-15 Thread Geoffrey Young
>>So does anybody think this behaviour shouldn't be 'fixed' in 2.0 ? >> > > > Yes, I do not because I use this feature or think it should be changed > but it simply changes how mp2 behaves within a stable release-cycle but > that's only my opinion. I agree with you in principle. however, histo

Re: Connection pnotes

2006-03-15 Thread Geoffrey Young
> This seems to make the problem go away, but I am not sure if that's where it > belongs: > > sub handler { > > my $r = shift; > > # make it ok to call ok() here while plan()ing elsewhere > Apache::Test::init_test_pm($r); > > + Test::_reset_globals() if Test->can('_reset_globals'