On Mon 24 Aug 2009, Philippe M. Chiasson wrote:
Modified: perl/modperl/trunk/lib/Apache2/Build.pm
URL:
http://svn.apache.org/viewvc/perl/modperl/trunk/lib/Apache2/Build.p
m?rev=807116r1=807115r2=807116view=diff
===
Hi,
in lib/ModPerl/BuildMM.pm:WriteMakefile() I found these lines (80-83):
my $inc;
$inc = $args{INC} if $args{INC};
$inc = . $build-inc;
Shouldn't the last one read instead:
$inc .= . $build-inc;
Torsten
Hi,
recently I stumbled upon a curious thing. A freshly unpacked modperl
aborted compilation after compiling in src/modules/perl. These are the
symptoms:
- during perl Makefile.PL:
...
WARNING: #define AP_SERVER_MAJORVERSION_NUMBER 2
is not a known parameter.
Checking if your kit is
On Fri 21 Aug 2009, Torsten Foertsch wrote:
I think the whole reconfig thing should be skipped
with -run-tests.
How about the enclosed patch? I don't know enough about AT to judge. So,
please comment.
Torsten
--
Need professional mod_perl support?
Just hire me: torsten.foert...@gmx.net
On Mon 23 Mar 2009, Philippe M. Chiasson wrote:
almost a month ago there was this posting on the users list
http://www.gossamer-threads.com/lists/modperl/modperl/99170#99170
stating there was a security related bug in modperl.
Since then there were no svn updated touching the code.
On Wed 01 Apr 2009, Geoffrey Young wrote:
Torsten Foertsch wrote:
On Mon 23 Mar 2009, Philippe M. Chiasson wrote:
almost a month ago there was this posting on the users list
http://www.gossamer-threads.com/lists/modperl/modperl/99170#99170
stating there was a security related bug
On Wed 01 Apr 2009, Perrin Harkins wrote:
On Wed, Apr 1, 2009 at 1:51 PM, Torsten Foertsch
torsten.foert...@gmx.net wrote:
I hope you understand, there is a security bug and it seems nobody
cares for a month!
Try not to take it personally, Torsten. Sometimes people claim to
have
Hi,
almost a month ago there was this posting on the users list
http://www.gossamer-threads.com/lists/modperl/modperl/99170#99170
stating there was a security related bug in modperl.
Since then there were no svn updated touching the code. I'd like to know
if my servers are secure. So, where
On Wed 04 Mar 2009, csross wrote:
I am converting some cgi scripts to enable them to run under
mod_perl. I have one script that I defined as a package and
reference it via the package name in the calling program. That
eliminated my undefined subroutine errors but I just got one I do
not
On Mon 02 Mar 2009, Torsten Foertsch wrote:
The reason can be found in modperl_handler.c. Each time /handler is
called a new closure is stored in $PL_modglobal{ANONSUB}{$id}.
Unfortunately the closure is never deleted from the hash I believe.
So since $self is in the pad each time /handler
Hi,
I have just stumbled on the following behavior.
httpd.conf:
Perl
{
package My::Object;
sub handler : method {
my ($self, $r)=...@_;
$r-push_handlers(PerlLogHandler =
sub {
$self-doit;
});
}
sub DESTROY
Hi,
why do we not call perl's cleanup at child exit?
Here my setup:
Perl
package My::Test;
use strict;
use warnings;
sub new {
my (undef, $data)=...@_;
my $inst=bless \$data;
warn $$: a new instance is born: $inst ($$inst)\n;
$inst;
}
sub DESTROY {warn $$: DESTROY $_[0] (${$_[0]})\n}
On Thu 19 Feb 2009, Geoffrey Young wrote:
I've love if this particular aspect had a better solution, though
threads really complicates things...
child_terminate is forbidden with a threaded MPM. And I think it is
rightly so.
void mpxs_Apache2__RequestRec_child_terminate(pTHX_ request_rec *r)
Hi,
the doc for $r-headers_in states:
This table is available starting from the PerlHeaderParserHandler
phase.
This is definitely wrong for apache 2.2. 2.2 reads in the complete
request including all headers even before the PostReadRequest phase.
Does anyone remember where this phrase comes
Hi,
MP_FUNC is NULL unless MP_TRACE is set (modperl_common_log.h).
MP_CHECK_WBUCKET_INIT is defined as (modperl_util.h):
#define MP_CHECK_WBUCKET_INIT(func) \
if (!rcfg-wbucket) { \
Perl_croak(aTHX_ %s: func can't be called \
before the response phase,
On Fri 18 Jul 2008, Philip M. Gollucci wrote:
Torsten Foertsch wrote:
Please review.
+ /* use the same error message as perl core's read() */
+ Perl_croak(aTHX_ Negative length);
It possible someone is regexing $@ against the previous string. Do
you really need to change
On Sat 28 Jun 2008, Torsten Foertsch wrote:
mybranch/ $ svnmerge init
When am I supposed to do this before I begin to integrate trunk changes or
after all changes are committed to my branch?
property 'svnmerge-integrated' set on '.'
mybranch/ $ svn ci -F svnmerge-commit-message.txt
Hi,
I have mod_proxy_html in my httpd.conf. This requires an additional LoadFile
directive to load libxml prior to LoadModule. Unfortunately the httpd.conf
generated by the test framework includes the LoadModule mod_proxy_html but
omits the LoadFile libxml.so.
I can solve this problem by
On Mon 30 Jun 2008, Philip M. Gollucci wrote:
this patch silence a few warnings about unused variables and unused
return codes. It is against the threading branch but is applyable with
offsets to trunk. Is it OK to apply it?
Looks good to me on both branch and trunk.
Committed revision
On Fri 27 Jun 2008, Philippe M. Chiasson wrote:
As a result XSLoader tries to load the shared lib from the wrong
location.
A simple change makes it work as expected:
goto XSLoader::load;
This way instead of pushing a new frame on the call stack the current
Hi,
this is an excerpt of our BRANCHING document:
###
### make a new branch ###
###
we will create a branch mybranch
branch:
svn copy https://svn.apache.org/repos/asf/perl/modperl/trunk \
On Fri 20 Jun 2008, Fred Moyer wrote:
You forgot to ask about the 2 perl connection handlers.
Can you suggest additional answer items for that question?
I mean you ask about PerlResponseHandler, PerlTranslationHandler etc. You ask
about all handlers of the HTTP response cycle. But with mp2
On Fri 20 Jun 2008, Fred Moyer wrote:
I'm interested on what thoughts other devs have on sending this out to
the list.
I have answered all your questions.
Point 10 is really 3 questions.
You forgot to ask about the 2 perl connection handlers.
Torsten
--
Need professional mod_perl support?
Hi,
does anybody know why this test is failing?
I have enhanced t/response/TestApache/util.pm with a few t_debug()s before and
after the Encode::decode_utf8 call. The utf8 bit is obviously set but the ä
in Mär doesn't match \w.
# locale_is_utf8=1
# is_utf8(Fr, 14 Mär 2008 10:56:54 GMT):
#
On Fri 22 Feb 2008, Philippe M. Chiasson wrote:
- parms.path = path;
+ parms.path = apr_pstrdup(p, path);
Yes, Philippe, you are right.
In current modperl there are 3 ways to get to modperl_config_insert():
- $r-add_config via modperl_config_insert_request
- $s-add_config via
On Thu 21 Feb 2008, Fred Moyer wrote:
patching file src/modules/perl/modperl_config.c
Hunk #1 succeeded at 607 with fuzz 1 (offset -17 lines).
I am working with the threading branch. So there may be an offset. Also, some
time ago I had to split up a jumbo patch. Since the bits built up on top
On Mon 18 Feb 2008, Torsten Foertsch wrote:
Here is a patch and a test case.
Forget the patch. It fixes the wrong place. The only other directive (that I
know of) that uses the location path ProxyPassReverse also assumes that the
pointer is valid for the whole request.
So the correct place
Hi,
modperl_config_dir_create begins with these lines:
void *modperl_config_dir_create(apr_pool_t *p, char *dir)
{
modperl_config_dir_t *dcfg = modperl_config_dir_new(p);
dcfg-location = dir;
While dcfg is created anew the dir pointer is simply stored. This means the
lifetime of dcfg
On Thu 24 Jan 2008, Philippe M. Chiasson wrote:
So this might be a good patch ;-)
I am curious to find out what this breaks.
nice work. I have applied it to my threading branch and the test suite passes
with a threaded apache 2.2.6, perl 5.8.8 on linux.
Torsten
On Wed 14 Nov 2007, Philippe M. Chiasson wrote:
/*
* Local Variables:
* c-basic-offset: 4
* indent-tabs-mode: nil
* End:
*/
and this to Perl-files:
# Local Variables: #
# mode: cperl #
# cperl-indent-level: 4 #
# indent-tabs-mode: nil #
# End: #
Can I take it
On Mon 03 Dec 2007, Torsten Foertsch wrote:
28.diff
adds emacs local vars to C files
Index: src/modules/perl/modperl_handler.c
===
--- src/modules/perl/modperl_handler.c (revision 27)
+++ src/modules/perl/modperl_handler.c (revision
On Mon 03 Dec 2007, Torsten Foertsch wrote:
29.diff
expands tabs in C files
Index: src/modules/perl/modperl_module.c
===
--- src/modules/perl/modperl_module.c (revision 28)
+++ src/modules/perl/modperl_module.c (revision 29
On Mon 03 Dec 2007, Torsten Foertsch wrote:
30.diff
expands tabs in *.p[lm]
This patch is too big for the 10 byte limit of the mailing list and
will be sent in 2 parts.
Part 1
Index: Apache-Test/Apache-TestItSelf/lib/MyTest/Util.pm
On Mon 03 Dec 2007, Torsten Foertsch wrote:
33.diff
expands tabs in ModPerl-Registry/t/*.t
Index: t/apr-ext/perlio.t
===
--- t/apr-ext/perlio.t (revision 32)
+++ t/apr-ext/perlio.t (revision 33)
@@ -26,7 +26,7 @@
# prerequisite
On Mon 03 Dec 2007, Torsten Foertsch wrote:
34.diff
adds emacs local vars to ModPerl-Registry/t/*.t
Index: ModPerl-Registry/t/special_blocks.t
===
--- ModPerl-Registry/t/special_blocks.t (revision 33)
+++ ModPerl-Registry/t
Hi Philippe,
On Thu 25 Oct 2007, Torsten Foertsch wrote:
On Thursday 18 October 2007, Philippe M. Chiasson wrote:
Any chance you can break the patch into multiple patches
This is the last one of this series of patches. It simply adds the test
perl/ithreads3.
Please apply all these patches
newlines. For me they are rather
disturbing but I thought they were there on purpose. So, what is the right
way to call MP_TRACE_x, with or without a trailing newline?
How about these 2 questions?
On Thu 25 Oct 2007, Torsten Foertsch wrote:
On Thursday 25 October 2007, Philippe M. Chiasson wrote
Hi Philippe,
in the threading branch this line and the corresponding get in
modperl_interp_pool_select() are the last occurrences of hash lookups in the
interp management.
(void)apr_pool_userdata_set((void *)r, MODPERL_R, NULL, r-pool);
I am thinking of removing it. But it requires a
Hi,
while trying modperl with perl 5.10.0 I got 2 nice coredumps in the init code.
1) this is with perfork mpm:
#0 0x08601de4 in ?? ()
#1 0x407dda91 in Perl_mg_free (my_perl=0x85fb4f0, sv=0x85ffbdc) at mg.c:490
#2 0x4085a5ba in Perl_sv_clear (my_perl=0x85fb4f0, sv=0x85ffbdc) at sv.c:5154
#3
On Thursday 18 October 2007, Philippe M. Chiasson wrote:
Any chance you can break the patch into multiple patches
This is the last one of this series of patches. It simply adds the test
perl/ithreads3.
Please apply all these patches in the given order to the threading branch.
The result
On Thursday 25 October 2007, Philippe M. Chiasson wrote:
It was named after apr_pool_cleanup_kill(). If you don't like it then
what do you prefer _destroy or _reset? To me it's all the same.
In that case, yes, pnotes_kill() probably is a bit more consistent.
Of course, after thinking about
On Thursday 18 October 2007, Philippe M. Chiasson wrote:
Any chance you can break the patch into multiple patches
This one needs the refcount based interpreter management to work. It moves the
registration of the PerlCleanupHandler callback to
modperl_hook_create_request.
It also fixes a
On Wednesday 24 October 2007, Torsten Foertsch wrote:
This one ...
Ups, forgot to add t/directive/perlcleanuphandler.t
Torsten
Index: src/modules/perl/mod_perl.c
===
--- src/modules/perl/mod_perl.c (revision 4)
+++ src/modules/perl
On Thursday 18 October 2007, Philippe M. Chiasson wrote:
Any chance you can break the patch into multiple patches
This one registers the cleanup phase with a subpool to ensure it is run before
pnotes are destroyed. Subpools are destroyed first thing in
apr_pool_{clear,destroy}. Hence, a pool
On Thursday 18 October 2007, Philippe M. Chiasson wrote:
Any chance you can break the patch into multiple patches
This one makes PerlInterpScope more advisory. Using pnotes increment the
refcnt of the interp thus binding it to the lifetime of the pnotes. So, using
$c-pnotes binds the interp to
On Wednesday 24 October 2007, Torsten Foertsch wrote:
On Thursday 18 October 2007, Philippe M. Chiasson wrote:
Any chance you can break the patch into multiple patches
This one ...
I forgot the changes in xs/maps and xs/tables.
Torsten
Index: src/modules/perl/modperl_types.h
On Thursday 18 October 2007, Philippe M. Chiasson wrote:
Any chance you can break the patch into multiple patches
This one adds ModPerl::InterpPool, ModPerl::TiPool and ModPerl::TiPoolConfig,
changes ModPerl::Interpreter a bit and provides some basic testing.
Torsten
Index:
On Thursday 18 October 2007, Philippe M. Chiasson wrote:
Any chance you can break the patch into multiple patches
This one is supposed to be applied after the pid-tid patch to the threading
branch. It adds the last pnotes refcount fix.
Torsten
Index: src/modules/perl/modperl_util.c
On Thursday 18 October 2007, Philippe M. Chiasson wrote:
Any chance you can break the patch into multiple patches
This one implements the refcount based interpreter management. Is supposed to
be applied on top of the pnotes-refcount patch.
It implements basically the same functionality as the
On Thursday 18 October 2007, Philippe M. Chiasson wrote:
Any chance you can break the patch into multiple patches
This one removes the unused tipool_cfg from modperl_interp_pool_t.
Torsten
Index: src/modules/perl/modperl_types.h
On Monday 22 October 2007, Philippe M. Chiasson wrote:
And make modperl_trace always prefix log messages with modperl_tid_pid()?
That makes sense. I didn't know about modperl_pid_tid(). But the
implementation is not good.
1) It requires a pool that is not always available
2) It introduces a
On Thursday 18 October 2007, Philippe M. Chiasson wrote:
The patch contains all my findings so far including the pnotes refcount
problem. Pnotes now lock the interpreter like pools do.
Any chance you can break the patch into multiple patches, one for each
feature/fix? Ideally with an
On Thursday 18 October 2007, Philippe M. Chiasson wrote:
Any chance you can break the patch into multiple patches
This one adds the current pid to the output of modperl_trace.
Torsten
Index: src/modules/perl/modperl_common_log.c
On Wednesday 17 October 2007 18:10, Philippe M. Chiasson wrote:
Yeah, I know. If you ask me, this pnotes behaviour is wrong, but we chose
to keep it around for historical reasons. It's not a bug if it's documented
It is a bug. If it is documented it is a documented bug. I was hit by it once
On Thursday 11 October 2007 15:18, Torsten Foertsch wrote:
I am wondering whether the REFCNT is always right. *pnotes is a HV. If the
function is called without a key argument the else branch newRV_inc
increments the REFCNT of the HV, right? Then the return statement in the
last line
Hi,
this is a snippet from modperl_util.c:modperl_pnotes()
if (key) {
STRLEN len;
char *k = SvPV(key, len);
if (val) {
retval = *hv_store(*pnotes, k, len, SvREFCNT_inc(val), 0);
}
else if (hv_exists(*pnotes, k, len)) {
retval =
On Thursday 11 October 2007 15:18, Torsten Foertsch wrote:
if (key) {
STRLEN len;
char *k = SvPV(key, len);
if (val) {
retval = *hv_store(*pnotes, k, len, SvREFCNT_inc(val), 0);
}
else if (hv_exists(*pnotes, k, len
On Tuesday 02 October 2007 08:54, Dmitry Karasik wrote:
Can you try the updated test patch that Torsten replied to the list with:
http://marc.info/?l=apache-modperlm=119074979901161w=2
The test succeeds in boths cases, on both patched and unpatched mod_perl.
I don't know why is that, but
Hi Gozer,
On Tuesday 25 September 2007 15:52, Torsten Foertsch wrote:
I think pnotes need to be dropped whenever an interpreter is freed.
Currently $c-pnotes are dropped in a connection pool cleanup while $r-pnotes
are dropped just after PerlCleanupHandler. A comment
Hi Gozer,
this patch is a complete rework of the interpreter allocation. I have tested
it with apache 2.2.6 with prefork and worker MPM but only with a perl 5.8.8
that has defined USE_ITHREADS. The rest of this text concerns only the worker
MPM.
The main idea behind the patch is to eliminate
On Monday 14 May 2007 08:35, Philippe M. Chiasson wrote:
http://www.gossamer-threads.com/lists/modperl/dev/93415
This one looks pretty good, and I think it's a cleaner approach
to the currently uncorrect one.
I've just spent the evening looking at this more in details, and the
more I
On Wednesday 09 May 2007 10:42, Fred Moyer wrote:
to have these 2 patches applied to trunk or to get a statement why they
cannot be applied?
http://www.gossamer-threads.com/lists/modperl/dev/93415
http://www.gossamer-threads.com/lists/modperl/dev/93466
I have been following this
Hi Fred,
On Wednesday 09 May 2007 10:42, Fred Moyer wrote:
I have been following this somewhat, but not grokking all of it.
Can you write a test that shows the change and its effect?
I was poking around that area of the code for the stacked handlers bug
so I understand some of it but a test
On Sunday 06 May 2007 19:11, Torsten Foertsch wrote:
I am in the middle of the analysis of a segfault. The segfault happens in a
$r-push_handlers(PerlFixupHandler=sub{}). Unfortunately it happens not
for every request but after 13. Finally, I think I have tracked it down to
something to talk
Hi,
I am in the middle of the analysis of a segfault. The segfault happens in a
$r-push_handlers(PerlFixupHandler=sub{}). Unfortunately it happens not for
every request but after 13. Finally, I think I have tracked it down to
something to talk about.
The modperl_handler_lookup_handlers
On Monday 30 April 2007 12:08, Torsten Foertsch wrote:
This means in both cases modperl_interp_select is called twice but for the
perl-script case rcfg-interp = interp is set.
modperl_interp_select first looks if rcfg-interp is set and returns it.
Only if it's not it looks at other places
Hi,
what should the exact semantic of a PerlCleanupHandler be when
PerlInterpScope==handler?
I am not asking what it is but what it should be.
A PerlCleanupHandler can be installed in httpd.conf or via $r-add_config or
by $r-{push|set}_handlers.
a) all cleanup handlers are called when the
On Wednesday 02 May 2007 14:41, you wrote:
what should the exact semantic of a PerlCleanupHandler be when
PerlInterpScope==handler?
I am not asking what it is but what it should be.
And are cleanups to be run once per request or once per interpreter?
Torsten
pgp62xWc42LH0.pgp
Description:
On Monday 30 April 2007 22:22, Philippe M. Chiasson wrote:
And that doesn't seem logical at all. In all cases, since the initial int=
erpreter
is tied up in modperl_response_handler() a new one shouldn't be needed to=
dispatch
that handler part.
I have found similar bug. Try
On Monday 23 April 2007 07:08, Philippe M. Chiasson wrote:
Is there something like $r-release_interp_after_this_phase()?
Nope, but writing one would be very simple, all that's needed is
to call
MpInterpPUTBACK_On(interp)
apr_pool_cleanup_kill(r-pool, r, modperl_config_req_cleanup);
Hi,
in case of a threaded server modperl_response_handler runs this code:
#ifdef USE_ITHREADS
interp = modperl_interp_select(r, r-connection, r-server);
aTHX = interp-perl;
#endif
while modperl_response_handler_cgi runs this:
#ifdef USE_ITHREADS
interp = modperl_interp_select(r,
On Thursday 26 April 2007 21:10, Tyler Bird wrote:
But I was wondering isn't there anything I can do to mod_perl that will
allow a plain warn to send it to my virtualhosts log and not my servers
log.
without using the $r-warn() syntax
The problem is you need a $r object for that. In MP1
Hi,
is there a reason not to use APR mutex and condition variables in the tipool
implementation but instead Perl's COND_... and MUTEX_... macros?
The reason I am asking is that after some heavy load generated with ab over a
GBit link I have seen request timeouts and what is worse apache
Hi,
while configuring an mp2 with worker mpm I found it hard to guess how many
interpreters are needed for my needs. The best way to measure the utilization
of the interpreters I thought would be the time a request is blocked waiting
for an interpreter to become available. The patch below
On Thursday 15 March 2007 11:18, Darryl Miles wrote:
Torsten Foertsch wrote:
On Tuesday 13 March 2007 10:05, Torsten Foertsch wrote:
So, the simple patch below solves my problem. No segfaults so far. But is
it right?
I have tested it with ab and several million requests and no memory
Hi,
I have found a reproducible way to segfault a mod_perled httpd.
My environment:
httpd 2.2.3
mpm worker
mod_perl 2.0.3
perl 5.8.8 (Suse linux 10.2)
and my httpd.conf
LoadModule log_config_module
On Tuesday 13 March 2007 10:05, Torsten Foertsch wrote:
PerlInterpScope handler
I have had it run with PerlTrace all set. The xx attachment shows what
happens at the first run without segfault. yy shows the output with a
segfault. Obviously it dies after or in
modperl_module_config_obj_cleanup
On Tuesday 13 March 2007 10:05, Torsten Foertsch wrote:
I have found a reproducible way to segfault a mod_perled httpd.
Sorry for the private posting but I need advice from the person who has
implemented the worker mpm stuff in modperl particularly the InterpScope
handler stuff. I think
Hi,
the default interpreter scope is request. That means a certain interpreter is
locked during the whole request cycle. I use modperl mostly in the
pre-response phases plus sometimes as an output filter. But I use pnotes to
pass data between the phases. If I understand it correctly this
On Thursday 03 August 2006 13:41, Philip M. Gollucci wrote:
Now,
is there a way to programatically check the t/logs/error_log for the
existance / non existance of the A::SL child killed message ? In the mean
time, this at least exercises the code that caused David Wheeler's error.
In one
On Friday 16 June 2006 17:23, Perrin Harkins wrote:
Dave Rolsky wrote:
Apache::SizeLimit has a long-standing bug on Linux where it never
actually kills a child, because of Perl's caching of ppid info
internally, and the way this interacts with Apache's forking.
See this thread for
On Friday 16 June 2006 19:19, Dave Rolsky wrote:
Requiring syscall.ph seems like a nasty hack to me. That _is_ what we've
done with our local version here at Socialtext, but I was planning to use
Linux::Pid for a CPAN version, since it seems cleaners.
No, I meant the Perl::AfterFork
On Thursday 08 June 2006 19:13, Philippe M. Chiasson wrote:
I wouldn't mind introducing $r-pnotes_noref or
sth to fix it
The more I think of it the more I am convinced that this is not good. If you
think $r-pnotes behaves the way it is designed to then let it be so. There
is indeed an
On Friday 09 June 2006 09:13, Torsten Foertsch wrote:
The behavior must be well documented and the difference thoroughly
explained. That's all. I'll see if I can come up with a better patch.
How about that?
Torsten
Index: docs/api/Apache2/ConnectionUtil.pod
On Friday 09 June 2006 15:04, Geoffrey Young wrote:
The more I think of it the more I am convinced that this is not good. If
you think $r-pnotes behaves the way it is designed to then let it be so.
There is indeed an interface that already does what the new one is
intended to do, that is
On Friday 09 June 2006 17:48, Geoffrey Young wrote:
Geoffrey Young wrote:
I didn't realize there was a difference between this (preferred for eons)
syntax and the tied (essentially deprecated, never suggested on list)
syntax. that there is a difference constitutes a bug in and of itself.
On Friday 09 June 2006 19:21, Geoffrey Young wrote:
This is said in the description of pnotes:
$hash_ref = $r-pnotes();
...
if no arguments are passed, a hash reference is returned, which can
then be directly accessed without going through the pnotes() interface.
Since a
On Wednesday 07 June 2006 22:07, Perrin Harkins wrote:
Me too. I don't think this is a bug, since it behaves normally for a
Perl hash. It's been documented now, and I think that should be the end
of it.
No, it does not. $r-pnotes-{key}=value behaves like a Perl hash.
$r-pnotes(key, value)
Hi,
I got a warning on line 488 in mod_perl.c about an unused variable
'base_scfg':
485 #ifdef USE_ITHREADS
486 static void modperl_init_clones(server_rec *s, apr_pool_t *p)
487 {
488 modperl_config_srv_t *base_scfg = modperl_config_srv_get(s);
489 #ifdef MP_TRACE
490
Hi,
some time ago there was an argument about the right behavior of pnotes, see
http://www.gossamer-threads.com/lists/modperl/dev/87819.
The question was whether $r-pnotes(key=value) should do exactly the same as
$r-pnotes-{key}=value or for some historical reason not.
The problem is that
On Tuesday 06 June 2006 11:46, Philip M. Gollucci wrote:
Torsten Foertsch wrote:
Further on, in line 564 it complains about an illegal typecast. This
Linux behaves in this regard obviously like Windows.
561 #ifdef WIN32
562 PERL_SYS_INIT3(argc, argv, env);
563 #else
On Tuesday 06 June 2006 12:38, Philip M. Gollucci wrote:
Torsten Foertsch wrote:
What is the common understanding on this point by now?
- retval = *hv_store(*pnotes, k, len, SvREFCNT_inc(val), 0);
+ retval = *hv_store(*pnotes, k, len, newSVsv(val), 0);
Pushes
On Thursday 16 March 2006 00:39, Geoffrey Young wrote:
in order for $o to maintain it's internal state. is that right? if so,
I don't like that very much.
It's not right. You are confusing scalars with references in that
example.
ook, my bad - I thought the proposed solution was to
On Wednesday 15 March 2006 18:23, Geoffrey Young wrote:
+ my $foo = 123;
+ $r-pnotes('foo' = $foo);
+ $foo = 456;
+ $r-pnotes('foo') # == now 456 (in 2.0.2)
+ $r-pnotes('foo') # == left at 123 (in 2.0.3)
actually, I'm re-thinking my stance on this. a common use of pnotes is to
pass
On Wednesday 15 March 2006 18:55, Perrin Harkins wrote:
On Wed, 2006-03-15 at 12:23 -0500, Geoffrey Young wrote:
I actually thing that would be somewhat common. and as I understand
things, the fix would require the middle step to be
-- next handler
my $o = $r-pnotes('foo');
On Tuesday 14 March 2006 03:01, Philippe M. Chiasson wrote:
I'm fine with fixing things in 2.0 if that's the majority consensus.
I'd certainly put my vote in that direction.
So do I. Don't forget connection pnotes.
Torsten
pgpnqoXjeGg3n.pgp
Description: PGP signature
Hi,
the patch below solves the following situation.
The ProxyPassReverse directive is outside any Location block given as
ProxyPassReverse /path http://...
but inside a Location block without the /path specification:
Location /path
ProxyPassReverse http://...
/Location
In the latter
On Thursday 03 November 2005 17:08, Geoffrey Young wrote:
so, please try the attached patch to Apache::Test. hopefully this fixes
things once and for all (without breaking more stuff :)
Torsten, any luck with this?
yep, it works:
0 [EMAIL PROTECTED]:~/work/libapreq-1.33$ perl Makefile.PL
On Thursday 03 November 2005 17:08, Geoffrey Young wrote:
so, please try the attached patch to Apache::Test. hopefully this fixes
things once and for all (without breaking more stuff :)
Torsten, any luck with this?
yep, it works:
0 [EMAIL PROTECTED]:~/work/libapreq-1.33$ perl Makefile.PL
Hi,
now that we have Apache2::SizeLimit using Linux::Smaps the old functionality
of accounting COW pages as shared is restored on linux 2.6. It should show
for linux 2.4 and 2.6 the same behavior (can someone using 2.4 and 2.6 check
this please? I have no 2.4 box available) since the algorithm
1 - 100 of 104 matches
Mail list logo
